Re: [Spice-devel] [client 2/2] streaming: Use the frame dimensions reported by the video decoder

On Wed, 25 May 2016, Pavel Grunt wrote: [...] > > +do { > it is preferred to declare variables at the beginning of the block. That does not seem to be mentionned in the Spice coding style and conventions: http://www.spice-space.org/static/docs/spice_style.pdf There's also quite a few cases

Re: [Spice-devel] [PATCH spice-gtk 1/2] main: remove SpiceFileTransferTaskPrivate

Hi, On Wed, May 25, 2016 at 11:01:47PM +0200, Victor Toso wrote: > Hi, > > On Wed, May 25, 2016 at 05:42:48PM +0200, Pavel Grunt wrote: > > Of course it is correct, but I would wait with it after applying: > >  https://lists.freedesktop.org/archives/spice-devel/2016-May/029359.html > > or if

Re: [Spice-devel] [PATCH spice-gtk 1/2] main: remove SpiceFileTransferTaskPrivate

Hi, On Wed, May 25, 2016 at 05:42:48PM +0200, Pavel Grunt wrote: > Of course it is correct, but I would wait with it after applying: >  https://lists.freedesktop.org/archives/spice-devel/2016-May/029359.html > or if Victor is ok with it? No problem Besides the typo in the commit log /o\ :D

Re: [Spice-devel] [spice-gtk v2 00/16] separate SpiceFileTransferTask logic from channel-main

Hi, On Mon, May 23, 2016 at 01:50:37PM +0200, Victor Toso wrote: > The idea is mainly to have a design improvement over the current file-transfer > logic by trying to detach it from channel-main and the agent logic plus a few > simple tests. > > One interesting change is about creating a

Re: [Spice-devel] [PATCH 1/2 v2] replay: better record encapsulation

On Wed, 2016-05-25 at 16:35 +0100, Frediano Ziglio wrote: > Remove global/static from red_record_qxl.c. > Defined a structure and use it to hold record state. > > Signed-off-by: Frediano Ziglio > --- > server/red-record-qxl.c | 53

Re: [Spice-devel] [PATCH 4/4] add some comments to cursor-channel.h header

On Fri, 2016-05-13 at 10:16 +0100, Frediano Ziglio wrote: > Explain usage of the class. > > Signed-off-by: Frediano Ziglio > --- > server/cursor-channel.h | 30 +- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git

Re: [Spice-devel] [PATCH 3/4] hide CursorChannelClient implementation details

On Fri, 2016-05-13 at 10:16 +0100, Frediano Ziglio wrote: > The existence of this class can be hidden to user of CursorChannel class > > Signed-off-by: Frediano Ziglio > --- > server/cursor-channel.c | 15 +++ > server/cursor-channel.h | 7 ++- >

Re: [Spice-devel] [PATCH 2/4] make cursor_channel_client_new static

Acked-by: Jonathon Jongsma On Fri, 2016-05-13 at 10:16 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/cursor-channel.c | 10 ++ > server/cursor-channel.h | 5 - > 2 files changed, 6 insertions(+), 9

Re: [Spice-devel] [PATCH 1/4] move cursor_connect to CursorChannel

Looks like an improvment Acked-by: Jonathon Jongsma On Fri, 2016-05-13 at 10:16 +0100, Frediano Ziglio wrote: > This function was handling mainly CursorChannel state > > Signed-off-by: Frediano Ziglio > --- > server/cursor-channel.c | 23

Re: [Spice-devel] [spice-gtk] main: Don't delay update_display_timer(0) for up to 1 second

On Wed, May 25, 2016 at 12:31:09PM -0400, Marc-André Lureau wrote: > > > > When this happens, we inform the server that only one monitor is active, > > then the server sends a MonitorsConfig message with 2 monitors (first > > request we sent), and then with just 1 monitor (second request we

Re: [Spice-devel] [spice-gtk] main: Don't delay update_display_timer(0) for up to 1 second

Hi - Original Message - > When using remote-viewer --full-screen with a VM/client with multiple > monitors, a race can be observed during auto-configuration. First, the > client monitors config is sent to the guest: > (remote-viewer:19480): GSpice-DEBUG: channel-main.c:1166 main-1:0:

[Spice-devel] [spice-gtk] main: Don't delay update_display_timer(0) for up to 1 second

When using remote-viewer --full-screen with a VM/client with multiple monitors, a race can be observed during auto-configuration. First, the client monitors config is sent to the guest: (remote-viewer:19480): GSpice-DEBUG: channel-main.c:1166 main-1:0: sending new monitors config to guest

Re: [Spice-devel] [PATCH spice-gtk 1/2] main: remove SpiceFileTransferTaskPrivate

Of course it is correct, but I would wait with it after applying:  https://lists.freedesktop.org/archives/spice-devel/2016-May/029359.html or if Victor is ok with it? Pavel On Wed, 2016-05-25 at 17:33 +0200, Marc-André Lureau wrote: > The struct is already private > > Signed-off-by: Marc-André

Re: [Spice-devel] [PATCH spice-gtk 2/2] file-transfer-task: Hide internals of SpiceFileTransferTask

Hi On Wed, May 25, 2016 at 7:30 AM, Pavel Grunt wrote: > --- > doc/reference/spice-gtk-sections.txt | 4 ++-- > src/channel-main.c | 24 > src/spice-file-transfer-task.h | 23 --- > 3 files changed, 26

[Spice-devel] [PATCH 1/2 v2] replay: better record encapsulation

Remove global/static from red_record_qxl.c. Defined a structure and use it to hold record state. Signed-off-by: Frediano Ziglio --- server/red-record-qxl.c | 53 ++--- server/red-record-qxl.h | 15 ++

[Spice-devel] [PATCH 2/2 v2] replay: allows to specify a filter for record output

This allows compressions using external programs or any type of filters. To use it set SPICE_WORKER_RECORD_FILTER environment to the filter command you want to use. The command is executed with g_spawn_async_with_pipes (which uses execve) so is not a shell command although the command is parsed

[Spice-devel] [PATCH spice-gtk 2/2] main: remove unneeded gtk-doc comments

They are no longer in the doc, and not really useful anyway Signed-off-by: Marc-André Lureau --- src/channel-main.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/channel-main.c b/src/channel-main.c index c9bc668..92e01ce 100644 ---

[Spice-devel] [PATCH spice-gtk 1/2] main: remove SpiceFileTransferTaskPrivate

The struct is already private Signed-off-by: Marc-André Lureau --- src/channel-main.c | 227 +++-- src/spice-file-transfer-task.h | 1 - 2 files changed, 107 insertions(+), 121 deletions(-) diff --git

Re: [Spice-devel] [PATCH 1/2] replay: better record encapsulation

> > I vaguely remembered reviewing something like this earlier and found an > earlier > thread where we were discussing some changes to this patch: > https://lists.freedesktop.org/archives/spice-devel/2016-January/026206.html > > It doesn't look like those changes were incorporated. Did you

Re: [Spice-devel] [client 2/2] streaming: Use the frame dimensions reported by the video decoder

Hi Francois, On Tue, 2016-05-24 at 11:46 +0200, Francois Gouget wrote: > The dimensions sent by the remote end are redundant and should not be > trusted. > > Signed-off-by: Francois Gouget > --- >  src/channel-display-gst.c   | 40

Re: [Spice-devel] [PATCH 1/2] replay: better record encapsulation

I vaguely remembered reviewing something like this earlier and found an earlier thread where we were discussing some changes to this patch: https://lists.freedesktop.org/archives/spice-devel/2016-January/026206.html It doesn't look like those changes were incorporated. Did you decide against

Re: [Spice-devel] Gtk-doc VS Doxygen

> > On Wed, 2016-05-25 at 10:21 +0200, Pavel Grunt wrote: > > Hi, > > > > On Fri, 2016-05-20 at 06:44 -0400, Frediano Ziglio wrote: > > > Hi, > > > I'd like to have some standard on the internal documentation of spice- > > > server. > > > > > Yes, that would be nice. > > > > > The current

Re: [Spice-devel] Different styles

On Wed, 2016-05-25 at 16:12 +0200, Victor Toso wrote: > Hi! > > On Wed, May 25, 2016 at 08:31:45AM -0400, Frediano Ziglio wrote: > > I personally find that vertical indentation tend to cause long lines and > > it's hard to maintain when new declarations are added (like requiring > > new

Re: [Spice-devel] Different styles

On Wed, 2016-05-25 at 08:31 -0400, Frediano Ziglio wrote: > Hi, > I was reading the style document and I found some different styles in the > code > > The structures for GObject differs from the rest of the code, they are > > struct DispatcherClass > { > GObjectClass parent_class; > }; >

Re: [Spice-devel] Gtk-doc VS Doxygen

On Wed, 2016-05-25 at 10:21 +0200, Pavel Grunt wrote: > Hi, > > On Fri, 2016-05-20 at 06:44 -0400, Frediano Ziglio wrote: > > Hi, > > I'd like to have some standard on the internal documentation of spice- > > server. > > > Yes, that would be nice. > > > The current situation is quite messy

Re: [Spice-devel] [PATCH] Make some function static

Acked-by: Jonathon Jongsma On Wed, 2016-05-25 at 11:35 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/dcc-encoders.c| 7 +-- > server/dcc-encoders.h| 2 -- > server/display-channel.c | 2 +- >

[Spice-devel] [PATCH RFC] make code more aware of Valgrind

Hi, more than a patch review I'd like to start (another?) discussion about some changes in the code. This patch add some code to make valgrind work better. The main issue is that we don't want code like this in production. It simply does make no sense. These kind of stuff are usually called

Re: [Spice-devel] [PATCH] Avoid to access data before a NULL check

On Wed, 2016-05-25 at 13:02 +0200, Christophe Fergeau wrote: > On Wed, May 25, 2016 at 11:31:13AM +0100, Frediano Ziglio wrote: > > If you are testing for NULL data this means that variable could be > > NULL so avoid to access before the check to make sure the check is hit. > > > > Signed-off-by:

[Spice-devel] [phodav PATCH 3/3 v7 spice-webdavd-windows: Dismount shared folder on service stop

From: Lukas Venhoda When stopping the service, automatically disconnect shared folder on windows. Not dismounting could lead to multiple shared folders. --- Changes since v6: - Changed gchar* to ServiceData* - Added mutex for ServiceData multithread handeling - Moved

[Spice-devel] [phodav PATCH 1/3 v7] spice-webdavd-windows: Automount shared folder

From: Lukas Venhoda Try to connect to shared folder automatically on Windows. On each loop of run_service(), run a GTask, that waits for half a second. If read_thread() returns, it means, that sharing is not yet connected, and the map_drive task is cancelled. If the

Re: [Spice-devel] spice-html5 audio problem

Hi Lorenzo, On 05/25/2016 07:35 AM, Lorenzo Garcia wrote: > Hello, > > First of all, thanks for your help. The biggest change was that we > changed the physical server, but i have used the same debs for the > installation and used the same ubuntu. The spice-html5 client was > upgraded, but with

Re: [Spice-devel] [PATCH 1/2] style: Sort abbreviations alphabetically

> > Acked-by: Christophe Fergeau > > (and as a side-note, we should actively fight against using these > abbreviations) > > Christophe > Currently they are mostly used for variable like the standard "int i" in C. There are some exceptions like dcc but really, it became

Re: [Spice-devel] [PATCH 2/2] style: Add some abbreviations

Reluctant Acked-by: Christophe Fergeau as imo the solution is not to document them, but to get rid of them. This will do for now :) Christophe On Wed, May 25, 2016 at 12:51:37PM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >

Re: [Spice-devel] [PATCH 1/2] style: Sort abbreviations alphabetically

Acked-by: Christophe Fergeau (and as a side-note, we should actively fight against using these abbreviations) Christophe On Wed, May 25, 2016 at 12:51:36PM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > docs/spice_style.txt |

Re: [Spice-devel] [PATCH] avoid getting channel from client

Hey, On Wed, May 25, 2016 at 12:58:48PM +0100, Frediano Ziglio wrote: > --- > server/inputs-channel-client.c | 2 -- > server/inputs-channel.c| 7 +-- > server/inputs-channel.h| 1 - > 3 files changed, 1 insertion(+), 9 deletions(-) > > diff --git

[Spice-devel] [PATCH 0/2] replay: encapsulation and filter

Hi, was a while I didn't post this set of patches. Changes: - rebased; - adapt to name prefix decisions. One of the pending issue was about using Red or Spice prefix for structures. It was (recently?) decided to use Red for internal and Spice for external so as these structure are internal now

[Spice-devel] [PATCH 2/2] replay: allows to specify a filter for record output

This allows compressions using external programs or any type of filters. To use it set SPICE_WORKER_RECORD_FILTER environment to the filter command you want to use. The command is executed with g_spawn_async_with_pipes (which uses execve) so is not a shell command although the command is parsed

Re: [Spice-devel] spice-html5 audio problem

Hello, First of all, thanks for your help. The biggest change was that we changed the physical server, but i have used the same debs for the installation and used the same ubuntu. The spice-html5 client was upgraded, but with the old version it behaves the same. For now I can't use the old

[Spice-devel] Different styles

Hi, I was reading the style document and I found some different styles in the code The structures for GObject differs from the rest of the code, they are struct DispatcherClass { GObjectClass parent_class; }; instead of struct DispatcherClass { GObjectClass parent_class; }; (all

[Spice-devel] [PATCH] removed unused GET_CODE definition

--- server/glz-encode.tmpl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/server/glz-encode.tmpl.c b/server/glz-encode.tmpl.c index 033a810..d699499 100644 --- a/server/glz-encode.tmpl.c +++ b/server/glz-encode.tmpl.c @@ -538,7 +538,6 @@ static void FNAME(compress)(Encoder *encoder) #undef

[Spice-devel] [PATCH] avoid getting channel from client

--- server/inputs-channel-client.c | 2 -- server/inputs-channel.c| 7 +-- server/inputs-channel.h| 1 - 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/server/inputs-channel-client.c b/server/inputs-channel-client.c index f9dd6b2..2f8acec 100644 ---

[Spice-devel] [PATCH 1/2] style: Sort abbreviations alphabetically

Signed-off-by: Frediano Ziglio --- docs/spice_style.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/spice_style.txt b/docs/spice_style.txt index b024b6b..d7a879d 100644 --- a/docs/spice_style.txt +++ b/docs/spice_style.txt @@ -138,15

[Spice-devel] [PATCH v2] RedChannel: Add FOREACH_CHANNEL and use it to iterate

Signed-off-by: Frediano Ziglio --- server/red-channel.c | 40 ++-- 1 file changed, 18 insertions(+), 22 deletions(-) Changes since v1: - fix a typo in subject; - use a single macro that is safe instead of two. diff --git

Re: [Spice-devel] [PATCH] Avoid to access data before a NULL check

On Wed, May 25, 2016 at 11:31:13AM +0100, Frediano Ziglio wrote: > If you are testing for NULL data this means that variable could be > NULL so avoid to access before the check to make sure the check is hit. > > Signed-off-by: Frediano Ziglio > --- > server/cursor-channel.c

Re: [Spice-devel] [PATCH] RFC: Allow multiple typedefs

> > On Wed, May 25, 2016 at 06:42:56AM -0400, Frediano Ziglio wrote: > > > > > > On Wed, May 25, 2016 at 11:44:14AM +0200, Christophe Fergeau wrote: > > > > and verify() causing compile failures > > > > > > Actually this one is just a warning + -Werror: > > > > > > image-cache.c:82: warning:

Re: [Spice-devel] [PATCH] RFC: Allow multiple typedefs

> > On Wed, May 25, 2016 at 11:44:14AM +0200, Christophe Fergeau wrote: > > and verify() causing compile failures > > Actually this one is just a warning + -Werror: > > image-cache.c:82: warning: nested extern declaration of > '_gl_verify_function6' [-Wnested-externs] > > Christophe > Can

[Spice-devel] [PATCH] Make some function static

Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c| 7 +-- server/dcc-encoders.h| 2 -- server/display-channel.c | 2 +- server/display-channel.h | 2 -- server/image-cache.c | 2 +- server/image-cache.h | 1 - server/inputs-channel.c | 10

Re: [Spice-devel] [PATCHv2 3/4] gtk: remove unneeded check

On Wed, 2016-05-25 at 12:20 +0200, Marc-André Lureau wrote: > spice_cairo_draw_event() can deal with d->canvas.surface == NULL. > > Signed-off-by: Marc-André Lureau Acked-by: Pavel Grunt > --- >  src/spice-widget.c | 1 - >  1 file changed, 1

Re: [Spice-devel] [PATCHv2 4/4] egl: fix delayed widget realize

On Wed, 2016-05-25 at 12:20 +0200, Marc-André Lureau wrote: > When the display is not yet realized, spice_display_widget_gl_scanout() > will fail because the egl context is not ready. The display is never > marked ready because the egl.image (and egl.scanout) is not set, and > some clients, such

Re: [Spice-devel] [PATCHv2 1/4] gtk: move canvas related data in its own structure

On Wed, 2016-05-25 at 12:20 +0200, Marc-André Lureau wrote: > Group canvas related data to a sub-structure. > > Signed-off-by: Marc-André Lureau Acked-by: Pavel Grunt > --- >  src/spice-widget-cairo.c | 38 +++-- >  

[Spice-devel] [PATCH] Avoid to access data before a NULL check

If you are testing for NULL data this means that variable could be NULL so avoid to access before the check to make sure the check is hit. Signed-off-by: Frediano Ziglio --- server/cursor-channel.c | 5 +++-- server/dcc-send.c| 6 -- server/dcc.c |

Re: [Spice-devel] [PATCH] RFC: Allow multiple typedefs

On Wed, May 25, 2016 at 11:44:14AM +0200, Christophe Fergeau wrote: > and verify() causing compile failures Actually this one is just a warning + -Werror: image-cache.c:82: warning: nested extern declaration of '_gl_verify_function6' [-Wnested-externs] Christophe signature.asc Description:

[Spice-devel] [PATCHv2 3/4] gtk: remove unneeded check

spice_cairo_draw_event() can deal with d->canvas.surface == NULL. Signed-off-by: Marc-André Lureau --- src/spice-widget.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/spice-widget.c b/src/spice-widget.c index a37faad..f13a066 100644 --- a/src/spice-widget.c

[Spice-devel] [PATCHv2 1/4] gtk: move canvas related data in its own structure

Group canvas related data to a sub-structure. Signed-off-by: Marc-André Lureau --- src/spice-widget-cairo.c | 38 +++-- src/spice-widget-priv.h | 17 +++-- src/spice-widget.c | 62

[Spice-devel] [PATCHv2 2/4] gtk: rename spicex_* functions

spice-gtk used to have x11/shm backend, now it's only cairo Signed-off-by: Marc-André Lureau Acked-by: Pavel Grunt --- src/spice-widget-cairo.c | 8 src/spice-widget-priv.h | 8 src/spice-widget.c | 27

[Spice-devel] [PATCHv2 4/4] egl: fix delayed widget realize

When the display is not yet realized, spice_display_widget_gl_scanout() will fail because the egl context is not ready. The display is never marked ready because the egl.image (and egl.scanout) is not set, and some clients, such as virt-viewer will not realize the widget until the display is

Re: [Spice-devel] [PATCH spice-gtk 5/5] egl: fix delayed widget realize

Hi On Wed, May 25, 2016 at 8:42 AM, Pavel Grunt wrote: > On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote: >> When the display is not yet realized, spice_display_widget_gl_scanout() >> will fail because the egl context is not ready. The display is never >> marked

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: move canvas related data in its own structure

Hi - Original Message - > Hi, > > On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote: > > Group canvas related data to a sub-structure. > I am ok with groupping part of the patch, but there are some changes which > should be documented & go in a separate patch. > > > >

Re: [Spice-devel] [spice v13 03/29] server: Add a GStreamer 1.0 MJPEG video encoder and use it by default

On Wed, 25 May 2016, Francois Gouget wrote: > On Tue, 24 May 2016, Francois Gouget wrote: > [...] > > Now if the content of SpiceCopy cannot be trusted, the GStreamer encoder > > is the wrong place to check for issues : there are at least three places > > where the SpiceCopy bitmap can be used:

Re: [Spice-devel] [PATCH spice-gtk 2/5] widget: move canvas related data in its own structure

Hi, On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote: > Group canvas related data to a sub-structure. I am ok with groupping part of the patch, but there are some changes which should be documented & go in a separate patch. > > Signed-off-by: Marc-André Lureau

Re: [Spice-devel] [PATCH] RFC: Allow multiple typedefs

On Wed, May 25, 2016 at 04:42:00AM -0400, Frediano Ziglio wrote: > Could we use a backported gcc on rhel6 ? > I remember for rhel5 there was an official gcc44 package you > could install to get a newer compiler, maybe we can use it > to support multiple typedefs on rhel6. There is

[Spice-devel] [spice-server] Remove duplicate typedef

This fixes compilation on el6. This is achieved by moving the most problematic typedef to a red-types.h header. Ideally, it will go away once we have put some order in the header content/API/... For example, StreamAgent would be better as an opaque type. --- Here is my take on this. Christophe

Re: [Spice-devel] [PATCH spice-gtk 3/5] egl: bind the scanout texture

On Wed, 2016-05-25 at 11:13 +0200, Marc-André Lureau wrote: > Hi > > On Wed, May 25, 2016 at 9:00 AM, Pavel Grunt wrote: > > > > What about binding the texture in gl_make_current ? > > There are 2 textures, one for the display and one for the cursor. ah, right, I did not

Re: [Spice-devel] [PATCH spice-gtk 3/5] egl: bind the scanout texture

Hi On Wed, May 25, 2016 at 9:00 AM, Pavel Grunt wrote: > > What about binding the texture in gl_make_current ? There are 2 textures, one for the display and one for the cursor. > More info about the regression in the commit log would be nice. What about:

Re: [Spice-devel] typedefs and header dependencies

> > On 05/24/2016 12:19 AM, Jonathon Jongsma wrote: > > On Mon, 2016-05-23 at 15:17 -0500, Jonathon Jongsma wrote: > >> On Sun, 2016-05-22 at 04:19 -0400, Frediano Ziglio wrote: > >> > /* FIXME: move back to display-channel.h (once structs are private) */ > typedef struct Drawable

[Spice-devel] [PATCH v4] Simplify current_add_equal loop

With some simple steps I simplified the internal loop of this function * convert to infinite loop while (link) { dcc = link->data; dpi = SPICE_UPCAST(RedDrawablePipeItem, dpi_ring_item); -while (link && (!dpi || dcc != dpi->dcc)) { +for (;;) { +

Re: [Spice-devel] Gtk-doc VS Doxygen

Hi, On Fri, 2016-05-20 at 06:44 -0400, Frediano Ziglio wrote: > Hi, >   I'd like to have some standard on the internal documentation of spice- > server. > Yes, that would be nice. > The current situation is quite messy having different styles. > I think the worst think is not having any

Re: [Spice-devel] [spice v13 03/29] server: Add a GStreamer 1.0 MJPEG video encoder and use it by default

On Tue, 24 May 2016, Francois Gouget wrote: [...] > Now if the content of SpiceCopy cannot be trusted, the GStreamer encoder > is the wrong place to check for issues : there are at least three places > where the SpiceCopy bitmap can be used: the MJPEG encoder, the GStreamer > encoder and the

Re: [Spice-devel] [spice] server: Don't define a static function if it's not going to be used

Hi, On Wed, May 25, 2016 at 09:54:07AM +0200, Francois Gouget wrote: > Signed-off-by: Francois Gouget This should be fixed by https://cgit.freedesktop.org/spice/spice/commit/?id=7a51188891885d2950bd20dc129d58f9360a2408 > --- > > Otherwise you get compiler warnings...

[Spice-devel] [spice] server: Don't define a static function if it's not going to be used

Signed-off-by: Francois Gouget --- Otherwise you get compiler warnings... server/display-channel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index b970c9b..b0875e8 100644 ---

Re: [Spice-devel] [PATCH] Fix build warning when RED_WORKER_STAT is undefined

Hi, On Tue, May 24, 2016 at 01:58:57PM -0500, Jonathon Jongsma wrote: > since display_channel_print_stats is now static, the compiler complains > when RED_WORKER_STAT is undefined since this function is not used: > > ../../server/display-channel.c:853:13: error: >

Re: [Spice-devel] [PATCH spice-gtk 3/5] egl: bind the scanout texture

Hi, What about binding the texture in gl_make_current ? More info about the regression in the commit log would be nice. Pavel On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote: > Fix regression from commit 3539ac6212d506128bd38aad032e0363e78cb4f6. > > Signed-off-by: Marc-André Lureau

Re: [Spice-devel] [PATCH spice-gtk 4/5] gtk: rename spicex_* functions

On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote: > spice-gtk used to have x11/shm backend, now it's only cairo > > Signed-off-by: Marc-André Lureau Acked-by: Pavel Grunt > --- >  src/spice-widget-cairo.c |  8 >  

Re: [Spice-devel] [PATCH spice-gtk 5/5] egl: fix delayed widget realize

On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote: > When the display is not yet realized, spice_display_widget_gl_scanout() > will fail because the egl context is not ready. The display is never > marked ready because the egl.image (and egl.scanout) is not set, and > some clients, such

Re: [Spice-devel] [PATCH spice-gtk 1/5] display: lower to debug gstreamer codec support

On Tue, 2016-05-24 at 21:31 +0200, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau Acked-by: Pavel Grunt > --- >  src/channel-display.c | 6 +++--- >  1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/channel-display.c