Re: ZPH patches for Squid

2008-04-21 Thread Henrik Nordstrom
tis 2008-04-22 klockan 09:47 +0800 skrev Adrian Chadd: > Store the hit information in the MemObject; include it in swap metadata. It's about misses so no need to swap it out.. Storing it in the mem object is acceptable. It really should go into the reply, but you then have to worry abour ICAP an

Re: mem_node memory usage in 2.x

2008-04-21 Thread Henrik Nordstrom
tis 2008-04-22 klockan 17:56 +1200 skrev Amos Jeffries: > I gave it a try on Linux. > > Once all the compile errors were fixed the testing code produced "RSS: > 0" for both run cases. That's not Adrians fault.. Linux doesn't report rss in getrusage().. To test on Linux you need to make the pro

Re: Long response header problem

2008-04-21 Thread Henrik Nordstrom
mån 2008-04-21 klockan 23:21 +0200 skrev Axel Westerhold: > Uhmmm, > > See my mybeReadVirginBody() from Stable4 > > Any chance that you re using CVS ? Hmm.. yes. I am using current Squid-3.0 sources and thought this was in STABLE4.. looking again it's not.. The patch is here: http://www.squid-

Re: mem_node memory usage in 2.x

2008-04-21 Thread Amos Jeffries
Adrian Chadd wrote: (This also may be an issue in Squid-3, as the mem_node class stores the data inline.) I did a little poking with the FreeBSD allocator - it allocates non-tiny objects on page boundaries with a size rounded up to the next page. [EMAIL PROTECTED] ~]$ ./test1 test1 131072 alloc

Re: Long response header problem

2008-04-21 Thread Axel Westerhold
> Axel Westerhold wrote: >>> mån 2008-04-21 klockan 21:35 +0200 skrev Axel Westerhold: >>> --- src/http.cc 2008-04-01 13:54:38.0 +0200 +++ src/http.cc 2008-04-21 19:11:47.0 +0200 @@ -1200,7 +1200,7 @@ void HttpStateData::maybeReadVirginBody() {

Re: ZPH patches for Squid

2008-04-21 Thread Adrian Chadd
On Tue, Apr 22, 2008, Amos Jeffries wrote: > If anyone has any info that might help Marin could you mail it to me or > him please. Store the hit information in the MemObject; include it in swap metadata. > >Hello, > > > >I've practically finished the patch porting for the Squid source code > >w

Re: ZPH patches for Squid

2008-04-21 Thread Amos Jeffries
If anyone has any info that might help Marin could you mail it to me or him please. Marin Stavrev wrote: Hello, I've practically finished the patch porting for the Squid source code with one minor glitch that I'll need more time to figure out myself, or use your help about it: I'm also mai

3.1 Feature Submission Closure

2008-04-21 Thread Amos Jeffries
We are now three weeks past the official published feature submission deadline. With only a handful of new prospects. I'd like to freeze new features for 3.1 at the current TODO list plus those non-timelined items actively under development which can be timelined by April 30th. http://wiki.sq

Re: Feature Comparison Map

2008-04-21 Thread Amos Jeffries
Mark Nottingham wrote: HTCP? Thanks. There are a lot of others missing too. IIRC the original list was incomplete at two pages length. Amos On 19/04/2008, at 9:12 PM, Amos Jeffries wrote: You may recall I built a Feature comparison map a while back after some users requests for one. As

Re: Long response header problem

2008-04-21 Thread Amos Jeffries
Axel Westerhold wrote: mån 2008-04-21 klockan 21:35 +0200 skrev Axel Westerhold: --- src/http.cc 2008-04-01 13:54:38.0 +0200 +++ src/http.cc 2008-04-21 19:11:47.0 +0200 @@ -1200,7 +1200,7 @@ void HttpStateData::maybeReadVirginBody() { -int read_sz = replyBodySpace(readBuf

Re: cvs commit: squid/src dns_internal.c

2008-04-21 Thread Amos Jeffries
Guido Serassio wrote: Hi Henrik, At 16:45 21/04/2008, Henrik Nordstrom wrote: > On Windows the search list always overrides the machine domain. Isn't these parameters in the registry on Windows which means no ordering issues? On Window 2000 and later the machine DNS domain is always automati

Re: Long response header problem

2008-04-21 Thread Axel Westerhold
As said before, not my day. I did my checkes with Stable4 without the applied logresp patch. That's why I missed if (read_sz < 2) { if (flags.headers_parsed) return; else read_sz = 1024; } S, as a guess my initial patch (with the longresp ) went wrong

Re: Long response header problem

2008-04-21 Thread Axel Westerhold
> mån 2008-04-21 klockan 21:35 +0200 skrev Axel Westerhold: > >> --- src/http.cc 2008-04-01 13:54:38.0 +0200 >> +++ src/http.cc 2008-04-21 19:11:47.0 +0200 >> @@ -1200,7 +1200,7 @@ >> void >> HttpStateData::maybeReadVirginBody() >> { >> -int read_sz = replyBodySpace(readBuf-

Re: Long response header problem

2008-04-21 Thread Axel Westerhold
> mån 2008-04-21 klockan 21:35 +0200 skrev Axel Westerhold: > >> --- src/http.cc 2008-04-01 13:54:38.0 +0200 >> +++ src/http.cc 2008-04-21 19:11:47.0 +0200 >> @@ -1200,7 +1200,7 @@ >> void >> HttpStateData::maybeReadVirginBody() >> { >> -int read_sz = replyBodySpace(readBuf-

Re: Feature Comparison Map

2008-04-21 Thread Mark Nottingham
HTCP? On 19/04/2008, at 9:12 PM, Amos Jeffries wrote: You may recall I built a Feature comparison map a while back after some users requests for one. As a follow up from those discussions, I have finally created the wiki page for it: http://wiki.squid-cache.org/FeatureComparison Though i

Re: Long response header problem

2008-04-21 Thread Henrik Nordstrom
mån 2008-04-21 klockan 21:35 +0200 skrev Axel Westerhold: > --- src/http.cc 2008-04-01 13:54:38.0 +0200 > +++ src/http.cc 2008-04-21 19:11:47.0 +0200 > @@ -1200,7 +1200,7 @@ > void > HttpStateData::maybeReadVirginBody() > { > -int read_sz = replyBodySpace(readBuf->spaceSize(

Re: Long response header problem

2008-04-21 Thread Axel Westerhold
> Hmm.. can't seem to reproduce this. > > The proposed change do not fix the problem, just hides it a bit. See my last mail of three (:-) sorry Not my best day) > > The 3.0.STABLE4 code already bumps the read size to 1KB minimum when > headers haven't been successfully parsed yet. See > Http

Re: Long response header problem

2008-04-21 Thread Henrik Nordstrom
Hmm.. can't seem to reproduce this. The proposed change do not fix the problem, just hides it a bit. The 3.0.STABLE4 code already bumps the read size to 1KB minimum when headers haven't been successfully parsed yet. See HttpStateData::maybeReadVirginBody() Do you have an example URL triggering t

squid DTD project question

2008-04-21 Thread Darius BUFNEA
Dear Sirs, I want to know what's the status of the Squid Duplicate Transfer Detection project. A recent analysis I have performed on our department proxy server's cache shows that around 12% of the cache objects are duplicates, and these duplicate objects occupy around 10% of the total cache

Re: Long response header problem

2008-04-21 Thread Axel Westerhold
And one more. It might be this patch which solved the issue --- src/http.cc 2008-04-01 13:54:38.0 +0200 +++ src/http.cc 2008-04-21 19:11:47.0 +0200 @@ -1200,7 +1200,7 @@ void HttpStateData::maybeReadVirginBody() { -int read_sz = replyBodySpace(readBuf->spaceSize()); +int

Long response header problem

2008-04-21 Thread Axel Westerhold
Hi there, I ran, or better a customer ran into a problem today which sounded like this bug. http://www.squid-cache.org/bugs/show_bug.cgi?id=2001 So I applied the attached patch to squid-3.0.STABLE4 and did a quick test. Still the same problem. By cache.log looks like this ... comm_read_try: F

Re: Long response header problem

2008-04-21 Thread Axel Westerhold
Ok, Did some additional checks, It should be --- src/http.cc 2008-04-01 13:54:38.0 +0200 +++ src/http.cc 2008-04-21 16:42:19.0 +0200 @@ -75,7 +75,7 @@ surrogateNoStore = false; fd = fwd->server_fd; readBuf = new MemBuf; -readBuf->init(4096, SQUID_TCP_S

Re: Squid feature: http uploads archive

2008-04-21 Thread Henrik Nordstrom
mån 2008-04-21 klockan 15:47 +0530 skrev C.S.R.C.Murthy: > We intend to develop a squid plugin for the purpose of archiving > http uploads happening through squid proxy server. We think that we > have to tweak "ClientStreamsAPI" . Am I right?. Not sure the ClientStreamsAPI fits yet.. it mos

Re: cvs commit: squid/src dns_internal.c

2008-04-21 Thread Guido Serassio
Hi Henrik, At 16:45 21/04/2008, Henrik Nordstrom wrote: > On Windows the search list always overrides the machine domain. Isn't these parameters in the registry on Windows which means no ordering issues? On Window 2000 and later the machine DNS domain is always automatically defined in the r

Squid feature: http uploads archive

2008-04-21 Thread C.S.R.C.Murthy
Hi all, We intend to develop a squid plugin for the purpose of archiving http uploads happening through squid proxy server. We think that we have to tweak "ClientStreamsAPI" . Am I right?. May I request the development community to point me to more help. -regards

Re: cvs commit: squid/src dns_internal.c

2008-04-21 Thread Henrik Nordstrom
mån 2008-04-21 klockan 16:27 +0200 skrev Guido Serassio: > But there is some standard defined about ? Doubtful. resolv.conf is not specified in SUS, so the closest to standard for resolv.conf is the bind implementation I think. > This could be a GLIBC bug Could be. Not sure domain is meant

Re: cvs commit: squid/src dns_internal.c

2008-04-21 Thread Guido Serassio
Hi Henrik, At 16:16 21/04/2008, Henrik Nordstrom wrote: mån 2008-04-21 klockan 23:28 +1200 skrev Amos Jeffries: > 'tis supposed to prefix the existing search list Not in my tests, using Linux GLIBC as test platform to compare with. search replaces domain, and opposite. domain takes a si

Re: cvs commit: squid/src dns_internal.c

2008-04-21 Thread Henrik Nordstrom
mån 2008-04-21 klockan 23:28 +1200 skrev Amos Jeffries: > 'tis supposed to prefix the existing search list Not in my tests, using Linux GLIBC as test platform to compare with. search replaces domain, and opposite. domain takes a single domain, search a list. multiple search statements over

Re: cvs commit: squid/src dns_internal.c

2008-04-21 Thread Henrik Nordstrom
mån 2008-04-21 klockan 12:57 +0200 skrev Guido Serassio: > What happens when both search and domain keywords are specified into > resolv.conf ? The last one is used. > It seems to me that the last parsed overwrites the domain search list. Yes. As it does in the glibc resolver.. Regards Henrik

Re: client_side and comm_close

2008-04-21 Thread Alex Rousskov
On Mon, 2008-04-21 at 23:45 +1200, Amos Jeffries wrote: > >> IMO, The proposed API _very_ first two lines of code in comm_close are to > >> register a special Comm callback to perform the fclose() call, and then to > >> immediately set fd_table flag closed for the rest of the comm_close > >> proces

Re: client_side and comm_close

2008-04-21 Thread Amos Jeffries
Alex Rousskov wrote: On Mon, 2008-04-21 at 16:02 +1200, Amos Jeffries wrote: On Sun, 2008-04-20 at 22:01 +0300, Tsantilas Christos wrote: Maybe it can be easier: The ease of implementation is a separate question. We still have to agree what we are implementing, and the items below attempt to d

Re: cvs commit: squid/src dns_internal.c

2008-04-21 Thread Amos Jeffries
Guido Serassio wrote: Hi Henrik, At 02:41 16/04/2008, Henrik Nordstrom wrote: hno 2008/04/15 18:41:41 MDT Modified files: src dns_internal.c Log: Add support for the resolv.conf domain directive, and also automatically derived default domain this patch a

Re: cvs commit: squid/src dns_internal.c

2008-04-21 Thread Guido Serassio
Hi Henrik, At 02:41 16/04/2008, Henrik Nordstrom wrote: hno 2008/04/15 18:41:41 MDT Modified files: src dns_internal.c Log: Add support for the resolv.conf domain directive, and also automatically derived default domain this patch adds the domain resolv.c

Re: client_side and comm_close

2008-04-21 Thread Amos Jeffries
Alex Rousskov wrote: On Mon, 2008-04-21 at 15:48 +1200, Amos Jeffries wrote: comm_close(fd) API: 1) No I/O callbacks will be dialed after comm_close is called (including the time when comm_close is running). Sounds good. 2) All close callbacks registered before comm_close was called will be

Re: Blocker bzr problem on Windows

2008-04-21 Thread Henrik Nordstrom
mån 2008-04-21 klockan 10:04 +0200 skrev Guido Serassio: > But before, I like to focus on Squid 2 before the 2.7 release, hoping > that in the meantime the bzr people will fix the problem As good plan as any. Porting 2.7 should be very straight forward from 2.6. > I like to run some Windows in-d

Re: Blocker bzr problem on Windows

2008-04-21 Thread Guido Serassio
Hi Henrik, Sorry for the delayed response :-( At 22:34 15/04/2008, Henrik Nordstrom wrote: tis 2008-04-15 klockan 20:30 +0200 skrev Guido Serassio: > I cannot waste my very limited time trying to fix the development > tools that I should use . :-( My proposal if you find that you hav