Re: A few patches

2007-03-14 Thread Henrik Nordstrom
ons 2007-03-14 klockan 11:27 +0900 skrev Steven: The attached patch should fix the concerns raised. If there are no other concerns do you want me to wait until 2.6.STABLE11 has been released before committing? With the new maintenance model with Squid-2.6 branched from HEAD Squid-2 is

RE: A few patches

2007-03-14 Thread Henrik Nordstrom
ons 2007-03-14 klockan 11:45 +0900 skrev Steven: Did you have any concerns with the patch that would allow NTLM auth to work on transparent requests if pipeline prefetching was enabled? Hmm.. don't like it. a) If allowing pipelining then it should be done on the same server connection. Also

Re: A few patches

2007-03-14 Thread Henrik Nordstrom
tis 2007-03-13 klockan 14:50 +0900 skrev Steven: The second patch (transparent-dns-hint.patch) is designed to use the destination IP that the client was attempting to connect to as the server IP if DNS lookup fail (for a transparent request). Cool. But can be significantly simplified. No

Re: A few patches

2007-03-13 Thread Adrian Chadd
On Tue, Mar 13, 2007, Steven Wilton wrote: Good point. The only problem is that (under Linux at least) we can't find out the original destination port (ie if traffic destined for port 80 is redirected to port 3128). Would you suggest this as a configuration option on a per-port basis? (ie

RE: A few patches

2007-03-13 Thread Steven Wilton
-Original Message- From: Adrian Chadd [mailto:[EMAIL PROTECTED] Sent: Tuesday, 13 March 2007 4:59 PM To: Steven Wilton Cc: 'Adrian Chadd'; squid-dev@squid-cache.org Subject: Re: A few patches On Tue, Mar 13, 2007, Steven Wilton wrote: Good point. The only problem

RE: A few patches

2007-03-13 Thread Henrik Nordstrom
tis 2007-03-13 klockan 15:46 +0900 skrev Steven Wilton: Good point. The only problem is that (under Linux at least) we can't find out the original destination port (ie if traffic destined for port 80 is redirected to port 3128). conn-me has the original IP and port in transparently

Re: A few patches

2007-03-13 Thread Henrik Nordstrom
tis 2007-03-13 klockan 14:50 +0900 skrev Steven: The third patch (transparent-pipeline.patch) is designed to allow squid to handle non-http traffic. If a request can not be decoded by squid, and it was a transparently intercepted requets, it will be transformed to a CONNECT request to the

RE: A few patches

2007-03-13 Thread Steven Wilton
-Original Message- From: Henrik Nordstrom [mailto:[EMAIL PROTECTED] Sent: Wednesday, 14 March 2007 9:30 AM To: Steven Wilton Cc: 'Adrian Chadd'; squid-dev@squid-cache.org Subject: RE: A few patches tis 2007-03-13 klockan 15:46 +0900 skrev Steven Wilton: Good point. The only

Re: A few patches

2007-03-13 Thread Steven
On Wed, 14 Mar 2007, Henrik Nordstrom wrote: tis 2007-03-13 klockan 14:50 +0900 skrev Steven: The third patch (transparent-pipeline.patch) is designed to allow squid to handle non-http traffic. If a request can not be decoded by squid, and it was a transparently intercepted requets, it

Re: A few patches

2007-03-12 Thread Adrian Chadd
On Tue, Mar 13, 2007, Steven wrote: /* Parse the request line */ ret = httpMsgParseRequestLine(hmsg); -if (ret == -1) - return parseHttpRequestAbort(conn, error:invalid-request); +if (ret == -1) { + /* If this is a transparent request that has been natted, try

RE: A few patches

2007-03-12 Thread Steven Wilton
-Original Message- From: Adrian Chadd [mailto:[EMAIL PROTECTED] Sent: Tuesday, 13 March 2007 3:14 PM To: Steven Cc: squid-dev@squid-cache.org Subject: Re: A few patches On Tue, Mar 13, 2007, Steven wrote: This bit is clever! Don't use a CONNECT to port 80 though; try