Re: Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

2006-10-30 Thread Henrik Nordstrom
mån 2006-10-30 klockan 20:41 +0800 skrev Adrian Chadd: > Kqueue makes it easier (in the traditional UNIX IO method). > It tells you how much data is available before you read/write. :) Yes, but the copy to/from userspace is still unavoidable which is the biggest difference. Actually knowing how m

Re: Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

2006-10-30 Thread Adrian Chadd
On Mon, Oct 30, 2006, Henrik Nordstrom wrote: > m??n 2006-10-30 klockan 14:16 +0800 skrev Adrian Chadd: > > > (When this is done you'll be rather scared at how much of a boost > > overlapped IO will give you. Its acually frightening to watch > > a Win2k or win2k3 server decimate a Linux/FreeBSD ma

Re: Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

2006-10-30 Thread Henrik Nordstrom
mån 2006-10-30 klockan 14:16 +0800 skrev Adrian Chadd: > (When this is done you'll be rather scared at how much of a boost > overlapped IO will give you. Its acually frightening to watch > a Win2k or win2k3 server decimate a Linux/FreeBSD machine due to > overlapped IO. Ouch.) Yes, the overlapped

Re: Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

2006-10-30 Thread Henrik Nordstrom
mån 2006-10-30 klockan 16:07 +1100 skrev Robert Collins: > On Sat, 2006-10-28 at 02:51 +0200, Henrik Nordstrom wrote: > > WSAAsyncSelect() > ... > > probably better to go straight to overlapped io, which is pretty nice. It is, but not a good fit for 2.6 buffer management.. WSAAsyncSelect slots d

Re: Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

2006-10-29 Thread Adrian Chadd
On Mon, Oct 30, 2006, Robert Collins wrote: > On Sat, 2006-10-28 at 02:51 +0200, Henrik Nordstrom wrote: > > WSAAsyncSelect() > ... > > probably better to go straight to overlapped io, which is pretty nice. Get squid-3 out the door and concentrate on tidying up the codebase! Overlapped IO won't

Re: Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

2006-10-29 Thread Robert Collins
On Sat, 2006-10-28 at 02:51 +0200, Henrik Nordstrom wrote: > WSAAsyncSelect() ... probably better to go straight to overlapped io, which is pretty nice. -Rib -- GPG key available at: . signature.asc Description: This is a digitally signed message part

Re: Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

2006-10-28 Thread Adrian Chadd
On Sat, Oct 28, 2006, Henrik Nordstrom wrote: > l??r 2006-10-28 klockan 18:53 +0200 skrev Guido Serassio: > > > With this change, things seems to go better: > > > -for (fd = 0; fd < Biggest_FD; fd++) { > > +for (fd = 0; fd <= Biggest_FD; fd++) { You've no idea how many times that bit me

Re: Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

2006-10-28 Thread Henrik Nordstrom
lör 2006-10-28 klockan 18:53 +0200 skrev Guido Serassio: > With this change, things seems to go better: > -for (fd = 0; fd < Biggest_FD; fd++) { > +for (fd = 0; fd <= Biggest_FD; fd++) { Looks good. Regards Henrik signature.asc Description: Detta är en digitalt signerad meddelandedel

Re: Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

2006-10-28 Thread Guido Serassio
Hi Henrik, At 18.44 28/10/2006, Henrik Nordstrom wrote: lör 2006-10-28 klockan 12:41 +0200 skrev Guido Serassio: > Great !!! :-) > > Basically it seems to work. > But it give to me a strange feeling when loading some complex page > with many embedded objects, like images, style sheets or .js o

Re: Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

2006-10-28 Thread Henrik Nordstrom
lör 2006-10-28 klockan 12:41 +0200 skrev Guido Serassio: > Great !!! :-) > > Basically it seems to work. > But it give to me a strange feeling when loading some complex page > with many embedded objects, like images, style sheets or .js objects: > The browser doesn't complete the page load for m

Re: Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

2006-10-28 Thread Guido Serassio
Hi Henrik, At 02.51 28/10/2006, Henrik Nordstrom wrote: tis 2006-10-24 klockan 08:24 +0200 skrev Guido Serassio: > Sure, but some oddity comes directly from Microsoft "features" :-) > Windows select() is only similar to the Unix one Sorted out the differences and whipped up a new com

Re: Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

2006-10-27 Thread Henrik Nordstrom
tis 2006-10-24 klockan 08:24 +0200 skrev Guido Serassio: > Sure, but some oddity comes directly from Microsoft "features" :-) > Windows select() is only similar to the Unix one Sorted out the differences and whipped up a new comm_select_win32.c file (untested). Please check if it works.

Re: Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

2006-10-23 Thread Guido Serassio
Hi Henrik, At 00.41 24/10/2006, Henrik Nordstrom wrote: Hi Guido, I think it's about time comm_select_win32.c is rewritten to use the new commloop framework like the other I/O loops. Probably best to start from scratch using current comm_select.c as basis (only about 100 lines of code in total,

Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

2006-10-23 Thread Henrik Nordstrom
Hi Guido, I think it's about time comm_select_win32.c is rewritten to use the new commloop framework like the other I/O loops. Probably best to start from scratch using current comm_select.c as basis (only about 100 lines of code in total, about 70 unique for select, quite a bit down from the prev