[sr-dev] [kamailio/kamailio] db_mysql: enable TLS when building with mariadb-connector-c (PR #3734)

2024-01-30 Thread space88man via sr-dev
Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for

[sr-dev] Re: [kamailio/kamailio] db_mysql: enable TLS when building with mariadb-connector-c (PR #3734)

2024-01-30 Thread Victor Seva via sr-dev
But then, is the connection still possible without TLS or are we forcing that the server would support TLS? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3734#issuecomment-1916429032 You are receiving this because you are subscribed to this threa

[sr-dev] git:master:e470f67c: github: [skip ci] enable dependabot for devcontainers

2024-01-30 Thread Victor Seva via sr-dev
Module: kamailio Branch: master Commit: e470f67c9aaaeb2dc39f49a1b5abb3352b45ad13 URL: https://github.com/kamailio/kamailio/commit/e470f67c9aaaeb2dc39f49a1b5abb3352b45ad13 Author: Victor Seva Committer: Victor Seva Date: 2024-01-30T10:44:19+01:00 github: [skip ci] enable dependabot for devconta

[sr-dev] Re: [kamailio/kamailio] db_mysql: enable TLS when building with mariadb-connector-c (PR #3734)

2024-01-30 Thread space88man via sr-dev
> But then, is the connection still possible without TLS or are we forcing that > the server would support TLS? Yes connection is possible if the server doesn't enforce TLS — the connection will use plain TCP. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/

[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)

2024-01-30 Thread Ivanuschak Nikolay via sr-dev
@ivanuschak commented on this pull request. > @@ -204,6 +204,10 @@ static inline int msg_send_buffer( goto error; } + if(!dst->id) { + dst->id = con->id; + } + This change is needed for siptrace. Below i

[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)

2024-01-30 Thread Ivanuschak Nikolay via sr-dev
@ivanuschak commented on this pull request. > @@ -2845,6 +2876,47 @@ int branch_builder(unsigned int hash_index, return size; } +static int is_haproxy(struct dest_info *send_info, struct receive_info *haproxy_rcv) { The function goal is as follows: 1. it retrieves the tcp_connetion_

[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)

2024-01-30 Thread Ivanuschak Nikolay via sr-dev
@ivanuschak commented on this pull request. > @@ -396,6 +396,7 @@ typedef struct sip_msg char *unparsed; /*!< here we stopped parsing*/ struct receive_info rcv; /*!< source & dest ip, ports, proto a.s.o*/ + struct receive_info haproxy_rcv; /*!< source & dest ip, ports, pr

[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)

2024-01-30 Thread Ivanuschak Nikolay via sr-dev
@ivanuschak commented on this pull request. > @@ -1843,13 +1843,17 @@ inline static int handle_io(struct fd_map *fm, short > events, int idx) * handle_io might decide to del. the new connection => * must be in the list */

[sr-dev] Re: [kamailio/kamailio] extented haproxy protocol support (PR #3731)

2024-01-30 Thread Victor Seva via sr-dev
I was thinking. Could we have something generic that abstracts the rcv parameter of the message? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3731#issuecomment-1916629196 You are receiving this because you are subscribed to this thread. Messag

[sr-dev] Re: [kamailio/kamailio] db_mysql: enable TLS when building with mariadb-connector-c (PR #3734)

2024-01-30 Thread space88man via sr-dev
@space88man pushed 1 commit. c37d25c7f4c929c34a8ed0d41fcbeeeb55972b61 db_mysql: enable TLS when building with mariadb-connector-c -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3734/files/c532d64bbbca64786b5330d91aa5d9eab324449f..c37d25c7f4c929c34a8ed0d41fcbeeeb55972b61 You ar

[sr-dev] [kamailio/kamailio] db_mysql: built with mariadb-connector-c does not use TLS (Issue #3735)

2024-01-30 Thread space88man via sr-dev
### Description Applies to `db_mysql` built with mariadb-connector-c; TLS is not working Option 1: configure mariadb server to use TLS (optional) Option 2: configure mariadb server to use TLS (mandatory) ### Troubleshooting 1. wireshark inspect the pcap dump of traffic to :3306 and look for Clien

[sr-dev] Re: Format of settings sets in config.

2024-01-30 Thread Henning Westerholt via sr-dev
Hello, of course, everything is possible to program somehow given enough effort. But your format would be difficult to support in Kamailio and in my opinion also quite sensitive to user failures. Usually, Kamailio modules use the simple way of one assigning cfg parameter, or using a parsing he

[sr-dev] Re: [kamailio/kamailio] db_mysql: built with mariadb-connector-c does not use TLS (Issue #3735)

2024-01-30 Thread space88man via sr-dev
Current WIP to enable TLS on https://github.com/kamailio/kamailio/pull/3734. Use existing `opt_ssl_mode` and map as follows.: 1. 0(off), 1(SSL_MODE_DISABLED): mariadb-connector-c defaults 2. 2(SSL_MODE_PREFERRED) 3(SSL_MODE_REQUIRED) 4(SSL_MODE_VERIFY_CA): `MYSQL_OPT_SSL_ENFORCE` 3. 5(SSL_MODE_

[sr-dev] Re: Format of settings sets in config.

2024-01-30 Thread vadim.saranov--- via sr-dev
Thank you, I will do it as in htable. ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] db_mysql: enable TLS when building with mariadb-connector-c (PR #3734)

2024-01-30 Thread space88man via sr-dev
@space88man pushed 1 commit. 90a04fd06818e68f0db7a288b7e0f2957be09fad db_mysql: update docs for MariaDB Connector/C builds -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3734/files/c37d25c7f4c929c34a8ed0d41fcbeeeb55972b61..90a04fd06818e68f0db7a288b7e0f2957be09fad You are recei

[sr-dev] Re: Format of settings sets in config.

2024-01-30 Thread Daniel-Constantin Mierla via sr-dev
Hello, On 29.01.24 17:35, Вадим С via sr-dev wrote: > Hello dear developers! > I'm developing a module that can have several sets of similar > connections. I see that some modules allow specifying a sequence of > settings in one parameter through the symbol ";", as sample: > > modparam("htable", "

[sr-dev] Re: Format of settings sets in config.

2024-01-30 Thread vadim.saranov--- via sr-dev
I did so, but there was a doubt that you might not approve such a format when checking PR. ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] db_mysql: enable TLS when building with mariadb-connector-c (PR #3734)

2024-01-30 Thread Victor Seva via sr-dev
Much better now @space88man . Thanks for taking care. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3734#issuecomment-1916847351 You are receiving this because you are subscribed to this thread. Message ID: ___

[sr-dev] Re: [kamailio/kamailio] db_mysql: enable TLS when building with mariadb-connector-c (PR #3734)

2024-01-30 Thread Victor Seva via sr-dev
Merged #3734 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3734#event-11641771032 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Developm

[sr-dev] git:master:d772b4c2: db_mysql: enable TLS when building with mariadb-connector-c

2024-01-30 Thread Victor Seva via sr-dev
Module: kamailio Branch: master Commit: d772b4c24a3a4995b93287ccf8eac9b80d1a5bac URL: https://github.com/kamailio/kamailio/commit/d772b4c24a3a4995b93287ccf8eac9b80d1a5bac Author: S-P Chan Committer: Victor Seva Date: 2024-01-30T14:28:26+01:00 db_mysql: enable TLS when building with mariadb-con

[sr-dev] git:master:2bcc32a1: db_mysql: update docs for MariaDB Connector/C builds

2024-01-30 Thread Victor Seva via sr-dev
Module: kamailio Branch: master Commit: 2bcc32a14e63d895077071715b0321fbdcdb8a33 URL: https://github.com/kamailio/kamailio/commit/2bcc32a14e63d895077071715b0321fbdcdb8a33 Author: S-P Chan Committer: Victor Seva Date: 2024-01-30T14:28:26+01:00 db_mysql: update docs for MariaDB Connector/C build

[sr-dev] git:master:dad7c857: modules: readme files regenerated - db_mysql ... [skip ci]

2024-01-30 Thread Kamailio Dev via sr-dev
Module: kamailio Branch: master Commit: dad7c857eaab613deed27ab687ddd0b1fdf8001b URL: https://github.com/kamailio/kamailio/commit/dad7c857eaab613deed27ab687ddd0b1fdf8001b Author: Kamailio Dev Committer: Kamailio Dev Date: 2024-01-30T14:32:10+01:00 modules: readme files regenerated - db_mysql .

[sr-dev] git:master:1e87f96a: tls_wolfssl: un-break jammy using libwolfssl32

2024-01-30 Thread S-P Chan via sr-dev
Module: kamailio Branch: master Commit: 1e87f96ad3a85b35935f14db36626036469cb6b0 URL: https://github.com/kamailio/kamailio/commit/1e87f96ad3a85b35935f14db36626036469cb6b0 Author: S-P Chan Committer: S-P Chan Date: 2024-01-30T22:25:01+08:00 tls_wolfssl: un-break jammy using libwolfssl32 --- M

[sr-dev] Re: [kamailio/kamailio] db_mysql: built with mariadb-connector-c does not use TLS (Issue #3735)

2024-01-30 Thread space88man via sr-dev
Closed #3735 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3735#event-11642778824 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Devel

[sr-dev] git:5.7:41f9a92a: tls_wolfssl: un-break jammy using libwolfssl32

2024-01-30 Thread S-P Chan via sr-dev
Module: kamailio Branch: 5.7 Commit: 41f9a92a9725a5ae6af473863bbd3a1cd0dccd38 URL: https://github.com/kamailio/kamailio/commit/41f9a92a9725a5ae6af473863bbd3a1cd0dccd38 Author: S-P Chan Committer: S-P Chan Date: 2024-01-31T05:43:08+08:00 tls_wolfssl: un-break jammy using libwolfssl32 (cherry-p

[sr-dev] git:5.7:d72637b8: tls_wolfssl: fix possible uninitialised variable

2024-01-30 Thread S-P Chan via sr-dev
Module: kamailio Branch: 5.7 Commit: d72637b8a76217dcd9b15504783279fd8800543a URL: https://github.com/kamailio/kamailio/commit/d72637b8a76217dcd9b15504783279fd8800543a Author: S-P Chan Committer: S-P Chan Date: 2024-01-31T05:41:49+08:00 tls_wolfssl: fix possible uninitialised variable (cherry

[sr-dev] git:5.7:07afe1b5: tls_wolfssl: clang-format

2024-01-30 Thread S-P Chan via sr-dev
Module: kamailio Branch: 5.7 Commit: 07afe1b520961de0e5271f0921742d1465fa55e9 URL: https://github.com/kamailio/kamailio/commit/07afe1b520961de0e5271f0921742d1465fa55e9 Author: S-P Chan Committer: S-P Chan Date: 2024-01-31T05:41:18+08:00 tls_wolfssl: clang-format (cherry-pick from 0f963a7a1e2a

[sr-dev] [kamailio/kamailio] core: infra to run functions in threads (PR #3736)

2024-01-30 Thread space88man via sr-dev
- [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to

[sr-dev] Re: [kamailio/kamailio] core: infra to run functions in threads (PR #3736)

2024-01-30 Thread space88man via sr-dev
@space88man pushed 5 commits. 83e72f5f093a27266157c8de79a088b6e1d371a9 core: add infrastructure to run functions in threads db4ffc31640694a7ab1da6f426a4451d9f603b14 db_unixodbc: use core/rthreads.h d608beabe6345a935c1bec43aa9421bcbb35bf01 db_mysql: use core/rthreads.h 0d2a03bf6ad7d5b3914e60cda

[sr-dev] Re: [kamailio/kamailio] tls_wolfssl: clean-up; continue to remove OpenSSL-isms (5d3c11c)

2024-01-30 Thread space88man via sr-dev
Both builds fixed master/5.7 > Sorry but bookworm has 5.5.4-2 > [libwolfssl35](https://packages.debian.org/bookworm/libwolfssl35) and jammy > has 5.2.0-2 [libwolfssl32](https://packages.ubuntu.com/jammy/libwolfssl32) > > I will remove the support for bookworm and jammy for tls_wolfssl then --

[sr-dev] Jenkins build is back to normal : kamailiodev-nightly-binaries » amd64,jammy #2587

2024-01-30 Thread kamailio--- via sr-dev
See ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] core: infra to run functions in threads (PR #3736)

2024-01-30 Thread Henning Westerholt via sr-dev
Thanks for the PR. I just had a quick look, please add a licence header to the new core file (BSD, similar to other core parts). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3736#issuecomment-1918508699 You are receiving this because you are sub