Closed #2045.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2045#event-2605074521___
Kamailio (SER) - Development Mailing List
sr-dev@lis
I merged your pull request, with some adaptions. I removed the white-space
changes from the docs.
The nat_uac_test function return 1 when a NAT check matches for all existing
checks and -1 otherwise. So i also adapted the check to work like this. A
second reason for the change was that the way
Hello,
I couldnt test multiple connection address but i am sure it works . I think
parse_sdp cannot parse it so it always give me 1 address.
function on error returns -2.
if all address are matched , returns -1 instead of 0 (zero). Because if returns
0 , script exits.(I dont know why)
added more
@ycaner06 pushed 2 commits.
70200b9a135e1feebde20fcdb285c6ce754eeac8 nathelper : added 256 to nat_uac_test
function to test cline and src_ip
55f4c697a464cad71f1f56e222c0999d94f6de7d nathelper : added information for new
nat_uac_test(256)
--
You are receiving this because you are subscribed
Hi Yasin, any update about the patch?
if you don't change the code regarding the multiple c lines - some extensions
in the docs would be necessary. A second point would be to add a return -2 if
the SDP can't be parsed.
Let me know, then I can do a manual merge e.g. on Tuesday evening in time for
> As I looked at the entire diff -- do not change the formatting of existing
> code/docs files when adding a new features. Now the diff has a lot of changes
> in the xml doc files making hard to spot what was changed. Patches to fix
> existing indentation and whitespaces are more than welcome, b
As I looked at the entire diff -- do not change the formatting of existing
code/docs files when adding a new features. Now the diff has a lot of changes
in the xml doc files making hard to spot what was changed. Patches to fix
existing indentation and whitespaces are more than welcome, but must
@ycaner06 pushed 2 commits.
1137b2c44eacbf795e340317b49b1f0e7effd9c5 nathelper : removed unnecessary
variable and fixed indentation
6ad9790a79984e8d5bfe9d747c386a2dc9840689 nathelper: added more information
about 256 flag to documentation
--
You are receiving this because you are subscribed
OK, so the title of PR is misleading, the test is true if there is mismatch,
not when IPs are matched.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2045#issuecomment-525209585
> First a note for who is going to merge: the last commit doesn't have proper
> formatted commit message. So this PR should be squashed and merged or merged
> manually.
>
> Then, I need a clarification: when this test is true: when all IPs in SDP
> match the source IP? If my logic is not missin
First a note for who is going to merge: the last commit doesn't have proper
formatted commit message. So this PR should be squashed and merged or merged
manually.
Then, I need a clarification: when this test is true: when all IPs in SDP match
the source IP? If my logic is not missing something,
Hello,
I used str2ipxbuf() instead of stripx().
Tested
- IPv6 short and long versions
- IPv4 versions.
```
ip_addr_t* str2ip6(str* st)
{
static ip_addr_t ip;
if(str2ip6buf(st, &ip)<0) {
return NULL;
}
return &ip;
}
```
--
You are receiving
@ycaner06 pushed 1 commit.
388fda36f81e486134f4b3c4acaa51ace97f6645 test sdp c line and sip source ip
address is matched
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/2045/files/6060b1399eee16fcd593d6bc66c1afb
It has to be `%.*s`, you used `*` before the `.` -- also you do not need that
expression with address of the first char, just give `session->ip_addr.s`
instead of `&session->ip_addr.s[0]`, it should avoid array access and get
address of it -- probably there is not much difference in performance,
@miconda
I dont understand reason but it gives empty line.
loggin:
```
LM_ERR("SDP CLINE2 [%*.s][LEN: %d]
\n",session->ip_addr.len,&session->ip_addr.s[0],session->ip_addr.len);
LM_ERR("SDP CLINE2 [%s] \n",&session->ip_addr.s[0]);
```
here is result
```
9(4455) ERROR: {1 1 INVITE 1-4478@192.168.
Have you tested that session->ip_addr.len>0? Can you print the str value for
session->ip_addr and see if it is a valid IP?
Then it would be better to use str2ipx(), because it tries internally both
ipv4/6.
--
You are receiving this because you are subscribed to this thread.
Reply to this email
@miconda
I tried to convert string to ip_addr struct as you mentioned but , functions
cannot convert it. In addition , when i try to log "sdp ip address " it gives
empty. I didnt understand reason.
converting with str2ip gives NULL.
```
struct ip_addr* cline_addr;
if(session->pf==AF_INET6){
I see that the comparison of the IPs is done with string operations. That's ok
for ipv4, but can be a mismatch with ipv6 because there can be different forms
of the same address.
I suggest to convert the the ip in sdp to binary struct and compare with the
src ip which is in binary struct -- see
Thanks Yasin, looks good to me.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2045#issuecomment-524756254___
Kamailio (SER) - Development
Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils,
...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files
20 matches
Mail list logo
