Re: [SSSD] having trouble linking with libsamba-security (but only sometimes)

2014-04-04 Thread Lukas Slebodnik
On (03/04/14 14:47), Yassir Elley wrote: >Hi all, > >I have been using a samba function (string_to_sid) in my gpo code and have >had no trouble so far compiling and linking my libsss_ad.so gpo code. > >I simply needed to apply the following patches, which includes having >to declare the string_to_s

Re: [SSSD] Planning the 1.11.5 release

2014-04-04 Thread Lukas Slebodnik
On (03/04/14 19:53), Jakub Hrozek wrote: >I think the 1.11 branch has accumulated a critical mass of fixes, so I'd >like to release 1.11.5 on Monday (to let the dust settle a bit). > >Is anyone opposed to that idea? > >The only remaining fix I'd like to see in is #2293 which Lukas has a >patch for.

Re: [SSSD] having trouble linking with libsamba-security (but only sometimes)

2014-04-04 Thread Jakub Hrozek
On Fri, Apr 04, 2014 at 09:25:50AM +0200, Lukas Slebodnik wrote: > On (03/04/14 14:47), Yassir Elley wrote: > >Hi all, > > > >I have been using a samba function (string_to_sid) in my gpo code and have > >had no trouble so far compiling and linking my libsss_ad.so gpo code. > > > >I simply needed to

Re: [SSSD] Planning the 1.11.5 release

2014-04-04 Thread Jakub Hrozek
On Fri, Apr 04, 2014 at 09:42:23AM +0200, Lukas Slebodnik wrote: > On (03/04/14 19:53), Jakub Hrozek wrote: > >I think the 1.11 branch has accumulated a critical mass of fixes, so I'd > >like to release 1.11.5 on Monday (to let the dust settle a bit). > > > >Is anyone opposed to that idea? > > > >T

Re: [SSSD] having trouble linking with libsamba-security (but only sometimes)

2014-04-04 Thread Alexander Bokovoy
On Fri, 04 Apr 2014, Jakub Hrozek wrote: >* Presumably, the libsss_ad.so gpo code links successfully because it is >pulling in a library (which is internally pulling in libsamba-security), > but I'm not sure which library that is. Any ideas? >* Is there a better solution for getting the gpo tests

Re: [SSSD] having trouble linking with libsamba-security (but only sometimes)

2014-04-04 Thread Sumit Bose
On Thu, Apr 03, 2014 at 02:47:43PM -0400, Yassir Elley wrote: > Hi all, > > I have been using a samba function (string_to_sid) in my gpo code and have > had no trouble so far compiling and linking my libsss_ad.so gpo code. Please have a look at sss_idmap_sid_to_smb_sid() from libsss_idmap and se

Re: [SSSD] having trouble linking with libsamba-security (but only sometimes)

2014-04-04 Thread Sumit Bose
On Fri, Apr 04, 2014 at 11:16:01AM +0300, Alexander Bokovoy wrote: > On Fri, 04 Apr 2014, Jakub Hrozek wrote: > >>>* Presumably, the libsss_ad.so gpo code links successfully because it is > >>>pulling in a library (which is internally pulling in libsamba-security), > >>> but I'm not sure which libr

[SSSD] [PATCH] Makefile: Use alternative method to replace *bindir

2014-04-04 Thread Lukas Slebodnik
ehlo, attached patch resolves #2293 LS >From cecba27b046e7a0dc86ec7485d472f50595c777c Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Fri, 4 Apr 2014 10:13:44 +0200 Subject: [PATCH] Makefile: Use alternative method to replace *bindir MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8

Re: [SSSD] [PATCH] Re-add the InfoPipe server plumbing

2014-04-04 Thread Pavel Březina
On 04/03/2014 06:54 PM, Jakub Hrozek wrote: On Fri, Mar 28, 2014 at 12:45:01PM +0100, Pavel Březina wrote: On 03/23/2014 10:08 PM, Jakub Hrozek wrote: Hi, I've been working on re-adding a public DBus API to SSSD lately, based on Stephen's InfoPipe code. While I'm not finished yet, the interfac

Re: [SSSD] [PATCH] AUTOFS: terminate array after the last entry

2014-04-04 Thread Pavel Březina
On 04/03/2014 05:31 PM, Lukas Slebodnik wrote: ehlo, If LDAP entries have more then one attribute "automountKey" automount map will be skipped and error message will be printed to log files and sssd_be will crash. DEBUG(SSSDBG_MINOR_FAILURE, "Malformed entry, skipping\n"); The output array

Re: [SSSD] having trouble linking with libsamba-security (but only sometimes)

2014-04-04 Thread Günther Deschner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Yassir, linking a private library is not a good idea in general. You could use well documented and public calls ConvertSidToStringSid() and ConvertStringSidToSid() from netapi for example. See: http://msdn.microsoft.com/en-us/library/windows/des

Re: [SSSD] [INI] Ding-lIbs - Merging Configuration Snippets Installed in Different Locations (Design page)

2014-04-04 Thread Sumit Bose
On Tue, Apr 01, 2014 at 11:51:23PM -0400, Dmitri Pal wrote: > On 04/01/2014 05:26 AM, Sumit Bose wrote: > >On Fri, Mar 28, 2014 at 09:08:33PM -0400, Dmitri Pal wrote: > >>Hello, > >> > >>Please review: > >>https://fedorahosted.org/sssd/wiki/DesignDocs/ding-libs/INIConfigMerge > >I would like to sta

Re: [SSSD] [PATCH] Re-add the InfoPipe server plumbing

2014-04-04 Thread Jakub Hrozek
On Fri, Apr 04, 2014 at 11:50:35AM +0200, Pavel Březina wrote: > On 04/03/2014 06:54 PM, Jakub Hrozek wrote: > >On Fri, Mar 28, 2014 at 12:45:01PM +0100, Pavel Březina wrote: > >>On 03/23/2014 10:08 PM, Jakub Hrozek wrote: > >>>Hi, > >>> > >>>I've been working on re-adding a public DBus API to SSSD

Re: [SSSD] [PATCH] AUTOFS: terminate array after the last entry

2014-04-04 Thread Jakub Hrozek
On Fri, Apr 04, 2014 at 11:56:58AM +0200, Pavel Březina wrote: > On 04/03/2014 05:31 PM, Lukas Slebodnik wrote: > >ehlo, > > > >If LDAP entries have more then one attribute "automountKey" > >automount map will be skipped and error message will be printed to log files > >and sssd_be will crash. > >

Re: [SSSD] [PATCH] IFP: do not create client socket

2014-04-04 Thread Jakub Hrozek
On Thu, Apr 03, 2014 at 06:59:32PM +0200, Jakub Hrozek wrote: > On Fri, Mar 28, 2014 at 12:54:54PM +0100, Pavel Březina wrote: > > https://fedorahosted.org/sssd/ticket/2290 > > > > Depends on Jakub's IFP patches... the code actually does not create > > new socket if NULL name is provided, so there

[SSSD] [PATCH] Possible null dereference in SELinux code

2014-04-04 Thread Michal Židek
Reported by Clang. This is probably false positive, because if state->nmaps is 0 in ipa_get_selinux_recv() then state->selinuxmaps will probaly always be NULL, so this patch just ensures it will always be the case. Patch is attached. Michal >From 16287c64308e94a24c6ace9358fb501b393ad77a Mon Sep

Re: [SSSD] [PATCH] Makefile: Use alternative method to replace *bindir

2014-04-04 Thread Jakub Hrozek
On Fri, Apr 04, 2014 at 10:35:59AM +0200, Lukas Slebodnik wrote: > ehlo, > > attached patch resolves #2293 > > LS I tested the usual builds, both in-tree and parallel and also distcheck and just ./configure without parameters. All tests showed expected results in the systemd service file. ACK f

Re: [SSSD] having trouble linking with libsamba-security (but only sometimes)

2014-04-04 Thread Simo Sorce
On Fri, 2014-04-04 at 10:03 +0200, Jakub Hrozek wrote: > On Fri, Apr 04, 2014 at 09:25:50AM +0200, Lukas Slebodnik wrote: > > On (03/04/14 14:47), Yassir Elley wrote: > > >Hi all, > > > > > >I have been using a samba function (string_to_sid) in my gpo code and have > > >had no trouble so far compil

Re: [SSSD] [PATCH] Makefile: Use alternative method to replace *bindir

2014-04-04 Thread Jakub Hrozek
On Fri, Apr 04, 2014 at 02:47:44PM +0200, Jakub Hrozek wrote: > On Fri, Apr 04, 2014 at 10:35:59AM +0200, Lukas Slebodnik wrote: > > ehlo, > > > > attached patch resolves #2293 > > > > LS > > I tested the usual builds, both in-tree and parallel and also distcheck > and just ./configure without p

Re: [SSSD] [PATCH] krb5_child: Fix use after free

2014-04-04 Thread Jakub Hrozek
On Thu, Apr 03, 2014 at 07:11:37PM +0200, Jakub Hrozek wrote: > On Thu, Mar 20, 2014 at 05:53:31PM +0100, Lukas Slebodnik wrote: > > On (20/03/14 17:21), Jakub Hrozek wrote: > > >On Thu, Mar 20, 2014 at 05:00:00PM +0100, Sumit Bose wrote: > > >> On Thu, Mar 20, 2014 at 04:20:59PM +0100, Lukas Slebo

Re: [SSSD] [PATCH] Possible null dereference in SELinux code

2014-04-04 Thread Lukas Slebodnik
On (04/04/14 14:28), Michal Židek wrote: >Reported by Clang. > >This is probably false positive, because if state->nmaps is 0 >in ipa_get_selinux_recv() then state->selinuxmaps will >probaly always be NULL, so this patch just ensures it will >always be the case. > >Patch is attached. > >Michal >Fr

Re: [SSSD] [PATCH] Makefile: Use alternative method to replace *bindir

2014-04-04 Thread Lukas Slebodnik
On (04/04/14 14:47), Jakub Hrozek wrote: >On Fri, Apr 04, 2014 at 10:35:59AM +0200, Lukas Slebodnik wrote: >> ehlo, >> >> attached patch resolves #2293 >> >> LS > >I tested the usual builds, both in-tree and parallel and also distcheck >and just ./configure without parameters. All tests showed ex

Re: [SSSD] [PATCH] krb5_child: Fix use after free

2014-04-04 Thread Lukas Slebodnik
On (04/04/14 15:18), Jakub Hrozek wrote: >On Thu, Apr 03, 2014 at 07:11:37PM +0200, Jakub Hrozek wrote: >> On Thu, Mar 20, 2014 at 05:53:31PM +0100, Lukas Slebodnik wrote: >> > On (20/03/14 17:21), Jakub Hrozek wrote: >> > >On Thu, Mar 20, 2014 at 05:00:00PM +0100, Sumit Bose wrote: >> > >> On Thu,

[SSSD] [PATCH] Passing NULL as map_order in create_order_array is invalid.

2014-04-04 Thread Michal Židek
Reported by Clang. See patch description for more info. Patch is in attachment. Thanks, Michal >From a0c94bc4c5df2955e82a7dc0852a86019286577e Mon Sep 17 00:00:00 2001 From: Michal Zidek Date: Fri, 4 Apr 2014 16:53:48 +0200 Subject: [PATCH] Passing NULL as map_order in create_order_array is inva

Re: [SSSD] [PATCH] Possible null dereference in SELinux code

2014-04-04 Thread Jakub Hrozek
On Fri, Apr 04, 2014 at 02:50:15PM +0200, Lukas Slebodnik wrote: > patch fixed warning > > ACK > > LS Pushed to master and sssd-1-11 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-deve

Re: [SSSD] [PATCH] Makefile: Use alternative method to replace *bindir

2014-04-04 Thread Jakub Hrozek
On Fri, Apr 04, 2014 at 03:28:46PM +0200, Lukas Slebodnik wrote: > On (04/04/14 14:47), Jakub Hrozek wrote: > >On Fri, Apr 04, 2014 at 10:35:59AM +0200, Lukas Slebodnik wrote: > >> ehlo, > >> > >> attached patch resolves #2293 > >> > >> LS > > > >I tested the usual builds, both in-tree and parall

Re: [SSSD] [PATCH] Passing NULL as map_order in create_order_array is invalid.

2014-04-04 Thread Lukas Slebodnik
On (04/04/14 17:08), Michal Židek wrote: >Reported by Clang. See patch description for more info. > >Patch is in attachment. > >Thanks, >Michal >From a0c94bc4c5df2955e82a7dc0852a86019286577e Mon Sep 17 00:00:00 2001 >From: Michal Zidek >Date: Fri, 4 Apr 2014 16:53:48 +0200 >Subject: [PATCH] Passi

[SSSD] [PATCHES] Always store home directory expansions to sysdb

2014-04-04 Thread Pavel Reichl
Hello, attached patches implement ticket: https://fedorahosted.org/sssd/ticket/2205 Maybe I split the changes into too many patches, please feel free to suggest squashing them. Regards, Pavel Reichl >From 259d5bd7ece1a16ff21bf1603eac8effbaa81526 Mon Sep 17 00:00:00 2001 From: Pavel Reichl Dat

Re: [SSSD] [PATCH] Passing NULL as map_order in create_order_array is invalid.

2014-04-04 Thread Michal Židek
On 04/04/2014 07:26 PM, Lukas Slebodnik wrote: On (04/04/14 17:08), Michal Židek wrote: Reported by Clang. See patch description for more info. Patch is in attachment. Thanks, Michal From a0c94bc4c5df2955e82a7dc0852a86019286577e Mon Sep 17 00:00:00 2001 From: Michal Zidek Date: Fri, 4 Apr

Re: [SSSD] [ding-libs] Patches for #2267, build issue and tight loop

2014-04-04 Thread Dmitri Pal
Just a couple minor edits to the language of the doxygen: diff --git a/ini/ini_configobj.h b/ini/ini_configobj.h index 9a4eb58..4ef98dc 100644 - --- a/ini/ini_configobj.h +++ b/ini/ini_configobj.h @@ -483,6 +483,31 @@ int ini_config_file_open(const char *filename, s

Re: [SSSD] Move a couple of tickets from 1.11.x

2014-04-04 Thread Dmitri Pal
On 04/03/2014 02:04 PM, Jakub Hrozek wrote: Hi, for some reason several low-priority tickets ended up in 1.11.x. In retrospective, I don't think they need to be in the stable branch and I'd like to move them out. See below: 1) https://fedorahosted.org/sssd/ticket/2236 - The cleanup task has no

Re: [SSSD] SSSD ticket #2214

2014-04-04 Thread Dmitri Pal
On 04/03/2014 02:59 PM, Michal Židek wrote: Hello, I was looking at https://fedorahosted.org/sssd/ticket/2214 I did not know about C being that paranoid with nested pointers to const data when passed as function arguments (I probably don't use const as often as I should, so I never bumped into

Re: [SSSD] [INI] Ding-lIbs - Merging Configuration Snippets Installed in Different Locations (Design page)

2014-04-04 Thread Dmitri Pal
On 04/04/2014 07:39 AM, Sumit Bose wrote: On Tue, Apr 01, 2014 at 11:51:23PM -0400, Dmitri Pal wrote: On 04/01/2014 05:26 AM, Sumit Bose wrote: On Fri, Mar 28, 2014 at 09:08:33PM -0400, Dmitri Pal wrote: Hello, Please review: https://fedorahosted.org/sssd/wiki/DesignDocs/ding-libs/INIConfigMe

Re: [SSSD] SSSD ticket #2214

2014-04-04 Thread Pavel Reichl
Or you could write a wrapper function 'diff_string_lists_const' calling original 'diff_string_lists' but at least hiding the nasty discard_const_p. - Original Message - From: "Dmitri Pal" To: sssd-devel@lists.fedorahosted.org Sent: Friday, April 4, 2014 11:57:47 PM Subject: Re: [SSSD] SS