[SSSD] [sssd PR#156][comment] FILES: Remove unnecessary check

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/156 Title: #156: FILES: Remove unnecessary check jhrozek commented: """ Well, this check was actually intentional. Please grep for gr_mem in proxy_id.c code. I remember from the distant past that we had issues where libc would pass in a zero-length member

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface jhrozek commented: """ On Fri, Feb 17, 2017 at 03:59:51AM -0800, Pavel Březina wrote: > Hi, I prepared few trivial commits for you to squash if you agree: > https://github.com/pb

[SSSD] [sssd PR#156][comment] FILES: Remove unnecessary check

2017-02-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/156 Title: #156: FILES: Remove unnecessary check lslebodn commented: """ On (20/02/17 00:52), Jakub Hrozek wrote: >Well, this check was actually intentional. Please grep for gr_mem in >proxy_id.c code. I remember from the distant past that we had issues wh

[SSSD] [sssd PR#153][synchronized] sss_cache: User/groups invalidation in domain cache

2017-02-20 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Author: celestian Title: #153: sss_cache: User/groups invalidation in domain cache Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/153/head:pr153 git checkout pr153 From 1c548

[SSSD] [sssd PR#137][comment] Initial pkinit support

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/137 Title: #137: Initial pkinit support jhrozek commented: """ There is a small issue where `sss_authtok_set_sc` is used before it's defined, which would break bisect. btw I'm battling a bit with the downstream tests, it looks like saying these patches b

[SSSD] [sssd PR#154][comment] Confront caches first

2017-02-20 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/154 Title: #154: Confront caches first pbrezina commented: """ Hi, thank you for the patch. ```c @@ -469,6 +476,8 @@ static void cache_req_input_parsed(struct tevent_req *subreq) return; } +cache_req_setup_search_approach(state); +

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-20 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache celestian commented: """ New version pushed, but CI said "NO": http://sssd-ci.duckdns.org/logs/job/62/98/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/153#i

[SSSD] [sssd PR#154][+Changes requested] Confront caches first

2017-02-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/154 Title: #154: Confront caches first Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#155][+Accepted] MONITOR: Don't return an error in case we fail to register a service

2017-02-20 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/155 Title: #155: MONITOR: Don't return an error in case we fail to register a service Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-l

[SSSD] [sssd PR#155][comment] MONITOR: Don't return an error in case we fail to register a service

2017-02-20 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/155 Title: #155: MONITOR: Don't return an error in case we fail to register a service pbrezina commented: """ In case of an error you want to free `mini` context. Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/155#issuecomment-2810720

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-02-20 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups pbrezina commented: """ Try to describe how PAM responder works with cache and where it differes with other responders in few words. If you have time, do it now before next review. You want

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-02-20 Thread spbnick
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups spbnick commented: """ @fidencio Sorry, I was able to understand very little from the comment, so I can't really suggest a better commit message. """ See the full comment at https://github

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-02-20 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups sumit-bose commented: """ I've checked and tested the patches and all worked well. So ACK and if spbnick's comments are addressed the patches can be pushed. While testing UPN/email/Kerberos

[SSSD] [sssd PR#152][synchronized] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Author: jhrozek Title: #152: Add a tevent wrapper around libcurl's asynchronous interface Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/152/head:pr152 git checkout pr152 Fro

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface jhrozek commented: """ Per Pavel's request I moved the headers parameter to the send function so every request can run with different headers. """ See the full comment at https

[SSSD] [sssd PR#66][comment] Minor Dynamic DNS fixes

2017-02-20 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes justin-stephenson commented: """ @fidencio No problem, thanks for looking into this. 1. Once the DNS role is installed, create a Reverse Zone in the AD DNS MMC(right click Reverse-Lookup zones and click New Zone) 2.

[SSSD] [sssd PR#152][synchronized] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Author: jhrozek Title: #152: Add a tevent wrapper around libcurl's asynchronous interface Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/152/head:pr152 git checkout pr152 Fro

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface jhrozek commented: """ I also added more comments per Pavel's request. If there are more areas that need to be commented better, please point them out and I will decorate the cod

[SSSD] [sssd PR#141][-Changes requested] PAM: Use cache_req to perform initgroups lookups

2017-02-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.f

[SSSD] [sssd PR#141][synchronized] PAM: Use cache_req to perform initgroups lookups

2017-02-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Author: fidencio Title: #141: PAM: Use cache_req to perform initgroups lookups Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/141/head:pr141 git checkout pr141 From 430c59b49

[SSSD] [sssd PR#137][comment] Initial pkinit support

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/137 Title: #137: Initial pkinit support jhrozek commented: """ OK, apart from the issue with the patch compilation, I found one more with manual testing -- it looks like changing the expired password of a newly created IPA user is not working correctly. I

[SSSD] [sssd PR#137][+Changes requested] Initial pkinit support

2017-02-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/137 Title: #137: Initial pkinit support Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#66][synchronized] Minor Dynamic DNS fixes

2017-02-20 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/66 Author: justin-stephenson Title: #66: Minor Dynamic DNS fixes Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/66/head:pr66 git checkout pr66 From 562bedea14aca46013a3612d709e01

[SSSD] [sssd PR#66][synchronized] Minor Dynamic DNS fixes

2017-02-20 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/66 Author: justin-stephenson Title: #66: Minor Dynamic DNS fixes Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/66/head:pr66 git checkout pr66 From 562bedea14aca46013a3612d709e01

[SSSD] [sssd PR#66][comment] Minor Dynamic DNS fixes

2017-02-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes fidencio commented: """ @justin-stephenson: Thanks for the patches and explanation. I was able to reproduce the behavior you mentioned and, IMO, the patches look fine. I've just submitted them to our internal CI and

[SSSD] [sssd PR#66][comment] Minor Dynamic DNS fixes

2017-02-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes fidencio commented: """ CI: http://sssd-ci.duckdns.org/logs/job/63/03/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/66#issuecomment-281198976 _

[SSSD] [sssd PR#66][+Accepted] Minor Dynamic DNS fixes

2017-02-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#70][comment] check_duplicate: check name member before using it

2017-02-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/70 Title: #70: check_duplicate: check name member before using it fidencio commented: """ Can we have this one pushed by @sumit-bose and @jhrozek review? """ See the full comment at https://github.com/SSSD/sssd/pull/70#issuecomment-281199204 _

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-20 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache celestian commented: """ New version pushed. CI passed: http://sssd-ci.duckdns.org/logs/job/63/02/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/153#issuecomm

[SSSD] [sssd PR#153][synchronized] sss_cache: User/groups invalidation in domain cache

2017-02-20 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Author: celestian Title: #153: sss_cache: User/groups invalidation in domain cache Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/153/head:pr153 git checkout pr153 From c5a91