URL: https://github.com/SSSD/sssd/pull/515
Title: #515: sssctl: Showing help even when sssd not configured
amitkumar50 commented:
"""
@jhrozek Done changes. Thanks
"""
See the full comment at
https://github.com/SSSD/sssd/pull/515#issuecomment-372545291
_
URL: https://github.com/SSSD/sssd/pull/515
Author: amitkumar50
Title: #515: sssctl: Showing help even when sssd not configured
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/515/head:pr515
git checkout pr515
From c5cb
URL: https://github.com/SSSD/sssd/pull/511
Title: #511: Do not shutdown KCM/Secrets responders when activities are
happening ...
fidencio commented:
"""
> why do the first two patches fix code that the subsequent patches refactor?
> Is it to make it clear where the issue is? Or did you conside
URL: https://github.com/SSSD/sssd/pull/531
Title: #531: Add the needed machinery to have automated builds for our COPR
repos
fidencio commented:
"""
> I'm fine with this plan for master, but do you think it's wise with our level
> of testing to build packages after every commit?
Maybe I shoul
URL: https://github.com/SSSD/sssd/pull/511
Title: #511: Do not shutdown KCM/Secrets responders when activities are
happening ...
jhrozek commented:
"""
Actually, I have some more questions about the code:
- why do the first two patches fix code that the subsequent patches refactor?
Is it to m
URL: https://github.com/SSSD/sssd/pull/519
Title: #519: DEBUG: Print simple access provider allow and deny lists
jhrozek commented:
"""
ACK, CI http://vm-031.${ABC}/logs/job/86/34/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/519#issuecomment-372449692
URL: https://github.com/SSSD/sssd/pull/525
Title: #525: TESTS: simple CA to generate certificates for test
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahost
URL: https://github.com/SSSD/sssd/pull/519
Title: #519: DEBUG: Print simple access provider allow and deny lists
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fe
URL: https://github.com/SSSD/sssd/pull/525
Title: #525: TESTS: simple CA to generate certificates for test
jhrozek commented:
"""
Unsuprisingly the PR doesn't apply to older branches. I agree it would be nice
to backport it to sssd-1-13, because it's the long-term branch and the
workaround was
URL: https://github.com/SSSD/sssd/pull/528
Title: #528: NSS: Adjust netgroup setnetgrent cache lifetime if midpoint
refresh is used
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-
URL: https://github.com/SSSD/sssd/pull/528
Title: #528: NSS: Adjust netgroup setnetgrent cache lifetime if midpoint
refresh is used
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email
URL: https://github.com/SSSD/sssd/pull/528
Title: #528: NSS: Adjust netgroup setnetgrent cache lifetime if midpoint
refresh is used
jhrozek commented:
"""
I'm sorry for the delay.
I think in this case the minimal timeout makes sense. Considering the NSS API,
which has a separate `setnetgrent`
URL: https://github.com/SSSD/sssd/pull/529
Title: #529: SPEC: Move secrets responder to the package sssd-kcm
jhrozek commented:
"""
I understand the point about minimal dependencies of sssd-common, but I wonder
if it was better to create a separate subpackage for the secrets binary. This
is fo
URL: https://github.com/SSSD/sssd/pull/531
Title: #531: Add the needed machinery to have automated builds for our COPR
repos
jhrozek commented:
"""
I'm fine with this plan for master, but do you think it's wise with our level
of testing to build packages after every commit? We also try to chec
On Sun, 2018-03-11 at 21:38 +0100, Jakub Hrozek wrote:
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you recognize the sender and know the
> content is safe.
>
>
> > On 9 Mar 2018, at 14:45, Joakim Tjernlund
> > wrote:
> >
URL: https://github.com/SSSD/sssd/pull/530
Author: CendioOssman
Title: #530: GPO: Add "thinlinc" to ad_gpo_map_remote_interactive
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/530/head:pr530
git checkout pr530
URL: https://github.com/SSSD/sssd/pull/530
Title: #530: GPO: Add "thinlinc" to ad_gpo_map_remote_interactive
mzidek-rh commented:
"""
Actually, I do not have permissions to close this PR :D
So, someone who does have it, please close this PR :)
"""
See the full comment at
https://github.com/S
URL: https://github.com/SSSD/sssd/pull/530
Title: #530: GPO: Add "thinlinc" to ad_gpo_map_remote_interactive
Label: +Rejected
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedora
URL: https://github.com/SSSD/sssd/pull/530
Title: #530: GPO: Add "thinlinc" to ad_gpo_map_remote_interactive
mzidek-rh commented:
"""
@simo5 `domain/_defaults_` sounds good to me as well :) , I will updated the
issue and I am closing this PR.
Thanks everyone for your input.
"""
See the full c
URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
mzidek-rh commented:
"""
Ok, I just pushed to last iteration to CI. If it is green I will ACK :)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/532#issuecomment-372315576
URL: https://github.com/SSSD/sssd/pull/530
Title: #530: GPO: Add "thinlinc" to ad_gpo_map_remote_interactive
simo5 commented:
"""
No strong opinion beside bikeshedding on the name: ```domain/_defaults_``` :-)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/530#issuecomment-372307
URL: https://github.com/SSSD/sssd/pull/530
Title: #530: GPO: Add "thinlinc" to ad_gpo_map_remote_interactive
simo5 commented:
"""
No strong opinion beside bikeshedding on the name: domain/_defaults_ :-)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/530#issuecomment-372307376
__
URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
fidencio commented:
"""
Okay, let me go for Sumit's suggestion. ;-) I've updated the patch.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/532#issuecomment-372306534
_
URL: https://github.com/SSSD/sssd/pull/532
Author: fidencio
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/532/head:pr532
git checkout pr532
From 501cfcf585
URL: https://github.com/SSSD/sssd/pull/530
Title: #530: GPO: Add "thinlinc" to ad_gpo_map_remote_interactive
mzidek-rh commented:
"""
@simo5 : I understand why you want to set defaults in the [sssd] section and it
makes sense to me. But I also think we may end up finding similar situations in
URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
mzidek-rh commented:
"""
The last version does not work for me:
```
# PEP8_IGNORE="--ignore=E121,E123,E126,E226,E24,E704,W503"
# find ./src -path ./src/config -prune -o -name \*.py -exec pep8
URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
sumit-bose commented:
"""
With
diff --git a/src/tests/intg/test_netgroup.py b/src/tests/intg/test_netgroup.py
index 3cf5dac..5c36dc2 100644
--- a/src/tests/intg/test_netgroup.py
+++ b/src/te
URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
fidencio commented:
"""
@jhrozek, I like your suggestion more than mine.
I've updated the patch and pushed it to our internal CI. I'll get back here as
soon as I have the results.
"""
See t
URL: https://github.com/SSSD/sssd/pull/532
Author: fidencio
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/532/head:pr532
git checkout pr532
From 574ea22bad
URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
jhrozek commented:
"""
Feel free to push the patch as emergency to unblock the CI, but I admit I don't
find the syntax very readable. What about:
```
--- a/src/tests/intg/test_netgroup.py
+++
URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
mzidek-rh commented:
"""
I pushed the patch to CI.
This issue blocks CI, so I will ACK it when the results are green. I am not
python expert either, but the fix LGTM. If someone proposes bet
On Thu, Mar 8, 2018 at 12:46 PM, Jakub Hrozek wrote:
>
>
>> On 8 Mar 2018, at 12:34, Pavel Březina wrote:
>>
>> On 03/08/2018 12:22 PM, Jakub Hrozek wrote:
On 8 Mar 2018, at 12:13, Fabiano Fidêncio wrote:
On Thu, Mar 8, 2018 at 12:00 PM, Jakub Hrozek wrote:
>
>
>> On
On Thu, Mar 8, 2018 at 12:44 PM, Jakub Hrozek wrote:
>
>
>> On 8 Mar 2018, at 12:30, Fabiano Fidêncio wrote:
>>
>> On Thu, Mar 8, 2018 at 12:22 PM, Jakub Hrozek wrote:
>>>
>>>
On 8 Mar 2018, at 12:13, Fabiano Fidêncio wrote:
On Thu, Mar 8, 2018 at 12:00 PM, Jakub Hrozek wrote:
>
URL: https://github.com/SSSD/sssd/pull/530
Title: #530: GPO: Add "thinlinc" to ad_gpo_map_remote_interactive
fidencio commented:
"""
I'm adding the discussion here:
```
simo: not going to extend the discussion in the pagure with a
question that sounds quite stupid to me ... but why the option
URL: https://github.com/SSSD/sssd/pull/532
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
fidencio commented:
"""
Just a note here ... knowing my python knowledge I'd say there are a few other
ways to better solve this issue. So, please, give me your suggestion and I'll
change th
URL: https://github.com/SSSD/sssd/pull/532
Author: fidencio
Title: #532: TESTS: Fix E501 pep8 issues on test_netgroup.py
Action: opened
PR body:
"""
E501: line too long (longer than 79 characters)
The issue was inserted in commit 0f8add07b8, which has been pushed just
before the pep8 patches
36 matches
Mail list logo