[SSSD] [sssd PR#810][comment] TESTS: ability to run unit tests under valgrind (sssd-1-16 backport)

2019-05-03 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/810 Title: #810: TESTS: ability to run unit tests under valgrind (sssd-1-16 backport) alexey-tikhonov commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/810#issuecomment-488998014 _

[SSSD] [sssd PR#804][comment] PAM: Also cache SSS_PAM_PREAUTH

2019-05-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/804 Title: #804: PAM: Also cache SSS_PAM_PREAUTH sumit-bose commented: """ Hi Jakub, the patch is working as expected, I only added a minor comment to the code. While testing I came across two issues where I wonder if you would like to fix them with this

[SSSD] [sssd PR#804][comment] PAM: Also cache SSS_PAM_PREAUTH

2019-05-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/804 Title: #804: PAM: Also cache SSS_PAM_PREAUTH jhrozek commented: """ Thank you, I'll look at the System Error. I saw it in my testing, but I stopped after I realised this was not caused by my patches. I should have at least filed a ticket :-) About th

[SSSD] [sssd PR#804][+Changes requested] PAM: Also cache SSS_PAM_PREAUTH

2019-05-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/804 Title: #804: PAM: Also cache SSS_PAM_PREAUTH Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org F

[SSSD] [sssd PR#806][comment] sudo: always use server highest usn for smart refresh

2019-05-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/806 Title: #806: sudo: always use server highest usn for smart refresh sumit-bose commented: """ > Because the search result contains only sudo object (or nothing), it is quite > possible that `srv_opts->max_sudo_value <= newusn < srv_opts->last_usn` > th