[SSSD] Re: [PATCH] Handle unparseable names in the simple access list correctly

2016-07-29 Thread Jakub Hrozek
On Fri, Jul 29, 2016 at 02:59:46PM +0200, Lukas Slebodnik wrote: > On (29/07/16 13:01), Jakub Hrozek wrote: > >On Fri, Jul 29, 2016 at 11:44:53AM +0200, Lukas Slebodnik wrote: > >> On (26/07/16 15:00), Jakub Hrozek wrote: > >> >Hi, > >> > > >>

[SSSD] Re: [PATCHES] views: properly override group member names

2016-07-29 Thread Jakub Hrozek
On Thu, Jul 28, 2016 at 09:41:18AM +0200, Jakub Hrozek wrote: > On Wed, Jul 27, 2016 at 06:56:15PM +0200, Jakub Hrozek wrote: > > On Wed, Jul 27, 2016 at 11:36:09AM +0200, Jakub Hrozek wrote: > > > On Wed, Jul 27, 2016 at 11:11:48AM +0200, Jakub Hrozek wrote: > > > >

[SSSD] Re: [PATCHES] User lookup and login by Kerberos alias and email

2016-07-29 Thread Jakub Hrozek
On Thu, Jul 28, 2016 at 09:41:51AM +0200, Jakub Hrozek wrote: > On Wed, Jul 27, 2016 at 07:06:53PM +0200, Jakub Hrozek wrote: > > On Tue, Jul 26, 2016 at 04:57:19PM +0200, Sumit Bose wrote: > > > now with patches ... > > > > > > On Tue, Jul 26, 2016 a

[SSSD] Re: [PATCH] sssctl: Consistent commands naming

2016-07-29 Thread Jakub Hrozek
On Fri, Jul 29, 2016 at 02:09:02PM +0200, Lukas Slebodnik wrote: > On (29/07/16 13:59), Jakub Hrozek wrote: > >On Fri, Jul 29, 2016 at 01:49:41PM +0200, Lukas Slebodnik wrote: > >> On (29/07/16 13:44), Jakub Hrozek wrote: > >> >On Fri, Jul 29, 2016 at 01:07:56P

[SSSD] Re: [PATCH] sssctl: Consistent commands naming

2016-07-29 Thread Jakub Hrozek
On Fri, Jul 29, 2016 at 01:49:41PM +0200, Lukas Slebodnik wrote: > On (29/07/16 13:44), Jakub Hrozek wrote: > >On Fri, Jul 29, 2016 at 01:07:56PM +0200, Lukas Slebodnik wrote: > >> >Others who? :-) > >> non developers (The person who requested this cha

[SSSD] Re: [PATCH] sssctl: Consistent commands naming

2016-07-29 Thread Jakub Hrozek
On Fri, Jul 29, 2016 at 01:07:56PM +0200, Lukas Slebodnik wrote: > >Others who? :-) > non developers (The person who requested this change; I assume this > change was not requested by developers) It was (and btw I agree with the change, consistent naming is important as I wish I raised this

[SSSD] Re: [PATCH] Handle unparseable names in the simple access list correctly

2016-07-29 Thread Jakub Hrozek
On Fri, Jul 29, 2016 at 11:44:53AM +0200, Lukas Slebodnik wrote: > On (26/07/16 15:00), Jakub Hrozek wrote: > >Hi, > > > >please see the attached patches. I'm not sure how this bug got in, > >because in the patch that broke the functionality > >(eef359b508b898a

[SSSD] Re: [PATCH] sssctl: Consistent commands naming

2016-07-29 Thread Jakub Hrozek
On Fri, Jul 29, 2016 at 09:31:32AM +0200, Lukas Slebodnik wrote: > On (28/07/16 19:37), Michal Židek wrote: > >On 07/28/2016 02:11 PM, Michal Židek wrote: > >> On 07/28/2016 01:57 PM, Jakub Hrozek wrote: > >> > On Thu, Jul 28, 2016 at 01:51:40PM +0200, Pavel Březina

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-07-29 Thread Jakub Hrozek
On Fri, Jul 29, 2016 at 12:27:24PM +0200, thierry bordaz wrote: > > > On 07/29/2016 12:21 PM, Jakub Hrozek wrote: > > On Fri, Jul 29, 2016 at 11:57:54AM +0200, thierry bordaz wrote: > > > > > > On 07/28/2016 04:49 PM, Lukas Slebodnik wrote: > > > &

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-07-29 Thread Jakub Hrozek
On Fri, Jul 29, 2016 at 11:57:54AM +0200, thierry bordaz wrote: > > > On 07/28/2016 04:49 PM, Lukas Slebodnik wrote: > > On (28/07/16 16:37), thierry bordaz wrote: > > > ... > > > That is correct and this is the expected behavior. > > > Using ns-inactivate.pl with a role, it inactivates all the

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-07-28 Thread Jakub Hrozek
On Thu, Jul 28, 2016 at 01:33:32PM +0200, Lukas Slebodnik wrote: > On (28/07/16 12:06), thierry bordaz wrote: > >On 07/28/2016 09:39 AM, Jakub Hrozek wrote: > >> On Wed, Jul 27, 2016 at 04:09:07PM +0200, thierry bordaz wrote: > >> > > >> >

[SSSD] Re: [PATCH] sssctl: Consistent commands naming

2016-07-28 Thread Jakub Hrozek
On Thu, Jul 28, 2016 at 01:51:40PM +0200, Pavel Březina wrote: > On 07/28/2016 01:38 PM, Jakub Hrozek wrote: > > On Thu, Jul 28, 2016 at 12:23:24PM +0200, Michal Židek wrote: > > > On 07/28/2016 10:00 AM, Pavel Březina wrote: > > > > On 07/27/2016 03:28 PM, Michal Ž

[SSSD] Re: [PATCH] sssctl: Consistent commands naming

2016-07-28 Thread Jakub Hrozek
On Thu, Jul 28, 2016 at 12:23:24PM +0200, Michal Židek wrote: > On 07/28/2016 10:00 AM, Pavel Březina wrote: > > On 07/27/2016 03:28 PM, Michal Židek wrote: > > > On 07/27/2016 11:09 AM, Jakub Hrozek wrote: > > > > On Wed, Jul 27, 2016 at 11:03:34AM +0200, Pavel Bře

[SSSD] Re: [PATCHES] User lookup and login by Kerberos alias and email

2016-07-28 Thread Jakub Hrozek
On Wed, Jul 27, 2016 at 07:06:53PM +0200, Jakub Hrozek wrote: > On Tue, Jul 26, 2016 at 04:57:19PM +0200, Sumit Bose wrote: > > now with patches ... > > > > On Tue, Jul 26, 2016 at 04:55:37PM +0200, Sumit Bose wrote: > > > On Tue, Jul 26, 2016 at 11:12:

[SSSD] Re: [PATCHES] views: properly override group member names

2016-07-28 Thread Jakub Hrozek
On Wed, Jul 27, 2016 at 06:56:15PM +0200, Jakub Hrozek wrote: > On Wed, Jul 27, 2016 at 11:36:09AM +0200, Jakub Hrozek wrote: > > On Wed, Jul 27, 2016 at 11:11:48AM +0200, Jakub Hrozek wrote: > > > On Tue, Jul 26, 2016 at 10:05:21PM +0200, Sumit Bose wrote: > > > >

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-07-28 Thread Jakub Hrozek
On Wed, Jul 27, 2016 at 04:09:07PM +0200, thierry bordaz wrote: > > > On 07/27/2016 03:36 PM, Jakub Hrozek wrote: > > On Wed, Jul 27, 2016 at 02:55:37PM +0200, thierry bordaz wrote: > > > > > > On 07/27/2016 01:56 PM, Jakub Hrozek wrote: > > > > On

[SSSD] Re: [PATCHES] AD: netlogon_get_domain_info() allow missing arguments

2016-07-28 Thread Jakub Hrozek
On Wed, Jul 27, 2016 at 05:56:48PM +0200, Lukas Slebodnik wrote: > On (27/07/16 15:57), Jakub Hrozek wrote: > >On Mon, Jul 25, 2016 at 04:11:16PM +0200, Lukas Slebodnik wrote: > >> On (25/07/16 13:10), Jakub Hrozek wrote: > >> >On Wed, Jul 20, 2016 at 03:14:17PM +0200

[SSSD] Re: [PATCHES] User lookup and login by Kerberos alias and email

2016-07-27 Thread Jakub Hrozek
On Tue, Jul 26, 2016 at 04:57:19PM +0200, Sumit Bose wrote: > now with patches ... > > On Tue, Jul 26, 2016 at 04:55:37PM +0200, Sumit Bose wrote: > > On Tue, Jul 26, 2016 at 11:12:34AM +0200, Jakub Hrozek wrote: > > > On Fri, Jul 22, 2016 at 09:44:33PM +0200, Sumi

[SSSD] Re: [PATCHES] views: properly override group member names

2016-07-27 Thread Jakub Hrozek
On Wed, Jul 27, 2016 at 11:36:09AM +0200, Jakub Hrozek wrote: > On Wed, Jul 27, 2016 at 11:11:48AM +0200, Jakub Hrozek wrote: > > On Tue, Jul 26, 2016 at 10:05:21PM +0200, Sumit Bose wrote: > > > On Tue, Jul 26, 2016 at 06:06:48PM +0200, Jakub Hrozek wrote: > > > >

[SSSD] Re: [PATCHES] AD: netlogon_get_domain_info() allow missing arguments

2016-07-27 Thread Jakub Hrozek
On Mon, Jul 25, 2016 at 04:11:16PM +0200, Lukas Slebodnik wrote: > On (25/07/16 13:10), Jakub Hrozek wrote: > >On Wed, Jul 20, 2016 at 03:14:17PM +0200, Sumit Bose wrote: > >> Hi, > >> > >> it is possible that the CLAP/netlogon reply does not contain any si

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-07-27 Thread Jakub Hrozek
On Wed, Jul 27, 2016 at 02:55:37PM +0200, thierry bordaz wrote: > > > On 07/27/2016 01:56 PM, Jakub Hrozek wrote: > > On Wed, Jul 27, 2016 at 01:03:59PM +0200, Jakub Hrozek wrote: > > > On Wed, Jul 27, 2016 at 12:22:46PM +0200, Lukas Slebodnik wrote: > > > &g

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-07-27 Thread Jakub Hrozek
On Wed, Jul 27, 2016 at 01:03:59PM +0200, Jakub Hrozek wrote: > On Wed, Jul 27, 2016 at 12:22:46PM +0200, Lukas Slebodnik wrote: > > On (27/07/16 12:08), Jakub Hrozek wrote: > > >On Wed, Jul 27, 2016 at 12:02:24PM +0200, Jakub Hrozek wrote: > > >> On Wed, Jul 27, 2

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-07-27 Thread Jakub Hrozek
On Wed, Jul 27, 2016 at 12:22:46PM +0200, Lukas Slebodnik wrote: > On (27/07/16 12:08), Jakub Hrozek wrote: > >On Wed, Jul 27, 2016 at 12:02:24PM +0200, Jakub Hrozek wrote: > >> On Wed, Jul 27, 2016 at 11:54:16AM +0200, Lukas Slebodnik wrote: > >> > ehlo, > >&g

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-07-27 Thread Jakub Hrozek
On Wed, Jul 27, 2016 at 12:02:24PM +0200, Jakub Hrozek wrote: > On Wed, Jul 27, 2016 at 11:54:16AM +0200, Lukas Slebodnik wrote: > > ehlo, > > > > attached patch fixes acces denied after activating user in 389ds. > > Jakub had some comments/ideas in ticket but I t

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-07-27 Thread Jakub Hrozek
On Wed, Jul 27, 2016 at 11:54:16AM +0200, Lukas Slebodnik wrote: > ehlo, > > attached patch fixes acces denied after activating user in 389ds. > Jakub had some comments/ideas in ticket but I think it's better to discuss > about virtual attributes and timestamp cache on mailing list. Yes, so the

[SSSD] Re: [PATCHES] views: properly override group member names

2016-07-27 Thread Jakub Hrozek
On Wed, Jul 27, 2016 at 11:11:48AM +0200, Jakub Hrozek wrote: > On Tue, Jul 26, 2016 at 10:05:21PM +0200, Sumit Bose wrote: > > On Tue, Jul 26, 2016 at 06:06:48PM +0200, Jakub Hrozek wrote: > > > On Tue, Jul 26, 2016 at 05:25:11PM +0200, Jakub Hrozek wrote: > > > >

[SSSD] Re: [PATCHES] views: properly override group member names

2016-07-27 Thread Jakub Hrozek
On Tue, Jul 26, 2016 at 10:05:21PM +0200, Sumit Bose wrote: > On Tue, Jul 26, 2016 at 06:06:48PM +0200, Jakub Hrozek wrote: > > On Tue, Jul 26, 2016 at 05:25:11PM +0200, Jakub Hrozek wrote: > > > On Tue, Jul 26, 2016 at 01:51:56PM +0200, Sumit Bose wrote: > > > > &g

[SSSD] Re: [PATCH] sssctl: Consistent commands naming

2016-07-27 Thread Jakub Hrozek
On Wed, Jul 27, 2016 at 11:03:34AM +0200, Pavel Březina wrote: > On 07/26/2016 04:19 PM, Michal Židek wrote: > > On 07/26/2016 01:19 PM, Pavel Březina wrote: > > > On 07/25/2016 02:12 PM, Michal Židek wrote: > > > > Hi, > > > > > > > > this patches makes the sssctl commands more similar to > > >

[SSSD] Re: [PATCH] PROVIDER: Conversion empty string from D-Bus to NULL

2016-07-27 Thread Jakub Hrozek
On Wed, Jul 27, 2016 at 10:26:30AM +0200, Petr Cech wrote: > Hi list, > > there is patch for [1] attached. > > [1] https://fedorahosted.org/sssd/ticket/3084 > > If you prefer two commits--one for reverting and second with the > patch--don't hesitate to tell me it. :-) Pavel is best suited to

[SSSD] Re: [PATCHES] views: properly override group member names

2016-07-26 Thread Jakub Hrozek
On Tue, Jul 26, 2016 at 05:25:11PM +0200, Jakub Hrozek wrote: > On Tue, Jul 26, 2016 at 01:51:56PM +0200, Sumit Bose wrote: > > > > The third patch adds a sysdb call to recursively resolve all > > > > user-members of a group. Since the groups in SSSD's cache are >

[SSSD] Re: [PATCHES] views: properly override group member names

2016-07-26 Thread Jakub Hrozek
On Tue, Jul 26, 2016 at 01:51:56PM +0200, Sumit Bose wrote: > > > The third patch adds a sysdb call to recursively resolve all > > > user-members of a group. Since the groups in SSSD's cache are > > > hierarchically organized the member attribute only contains direct > > > user and group members.

[SSSD] [PATCH] Handle unparseable names in the simple access list correctly

2016-07-26 Thread Jakub Hrozek
is that the rebasing after the DP patches were merged went wrong. To make sure we don't regress, I added more tests and switched the tests to calling the DP handler. >From 9a60d3ed8bd2b0eeb51dff2c6f78771e0d29245e Mon Sep 17 00:00:00 2001 From: Jakub Hrozek <jhro...@redhat.com> Date: Thu, 21 Jul 2016 12:18

[SSSD] Re: [PATCHES] views: properly override group member names

2016-07-26 Thread Jakub Hrozek
On Tue, Jul 26, 2016 at 01:51:56PM +0200, Sumit Bose wrote: > On Mon, Jul 25, 2016 at 01:45:13PM +0200, Jakub Hrozek wrote: > > On Thu, Jul 21, 2016 at 02:13:40PM +0200, Sumit Bose wrote: > > > Hi, > > > > > > this is my suggestion to solve https://fedorahoste

[SSSD] Re: [PATCHES] IPA: fix [capaths] output

2016-07-26 Thread Jakub Hrozek
On Mon, Jul 25, 2016 at 02:15:31PM +0200, Lukas Slebodnik wrote: > On (25/07/16 12:15), Jakub Hrozek wrote: > >On Wed, Jul 20, 2016 at 12:48:16PM +0200, Sumit Bose wrote: > >> Hi, > >> > >> please find attached a fix for https://fedorahosted.org/ss

[SSSD] Re: [PATCHES] User lookup and login by Kerberos alias and email

2016-07-26 Thread Jakub Hrozek
On Tue, Jul 26, 2016 at 11:12:34AM +0200, Jakub Hrozek wrote: > On Fri, Jul 22, 2016 at 09:44:33PM +0200, Sumit Bose wrote: > > Hi, > > > > this patch set should fix https://fedorahosted.org/sssd/ticket/2958 > > "Support multiple principals for IPA

[SSSD] Re: [PATCHES] User lookup and login by Kerberos alias and email

2016-07-26 Thread Jakub Hrozek
On Fri, Jul 22, 2016 at 09:44:33PM +0200, Sumit Bose wrote: > Hi, > > this patch set should fix https://fedorahosted.org/sssd/ticket/2958 > "Support multiple principals for IPA users" so the IPA users can log in > with their Kerberos alias as well. First, thank you very much for splitting the

[SSSD] Re: [PATCHES] views: properly override group member names

2016-07-25 Thread Jakub Hrozek
On Mon, Jul 25, 2016 at 01:45:13PM +0200, Jakub Hrozek wrote: > On Thu, Jul 21, 2016 at 02:13:40PM +0200, Sumit Bose wrote: > > Hi, > > > > this is my suggestion to solve https://fedorahosted.org/sssd/ticket/2948 > > "Handle overriden name of members in the mem

[SSSD] Re: [PATCHES] views: properly override group member names

2016-07-25 Thread Jakub Hrozek
On Thu, Jul 21, 2016 at 02:13:40PM +0200, Sumit Bose wrote: > Hi, > > this is my suggestion to solve https://fedorahosted.org/sssd/ticket/2948 > "Handle overriden name of members in the memberUid attribute". So far I read them to get a grasp of what they do, but didn't do a full review. See some

[SSSD] Re: [PATCHES] AD: netlogon_get_domain_info() allow missing arguments

2016-07-25 Thread Jakub Hrozek
On Wed, Jul 20, 2016 at 03:14:17PM +0200, Sumit Bose wrote: > Hi, > > it is possible that the CLAP/netlogon reply does not contain any site > data. In this case we should not fail but just use what we can get. > Especially when looking up the Global Catalog the forest name is needed. > If the

[SSSD] Re: [PATCHES] IPA: fix [capaths] output

2016-07-25 Thread Jakub Hrozek
On Wed, Jul 20, 2016 at 12:48:16PM +0200, Sumit Bose wrote: > Hi, > > please find attached a fix for https://fedorahosted.org/sssd/ticket/3103 > which turned out to be an issue with the way SSSD generates the capaths > section in the krb5.conf snippet. > > bye, > Sumit > Before the patch:

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-07-21 Thread Jakub Hrozek
On Wed, Jul 20, 2016 at 12:24:11PM +0200, Jakub Hrozek wrote: > On Fri, Jul 15, 2016 at 03:24:15PM +0200, Petr Cech wrote: > > > > On 07/12/2016 10:31 AM, Pavel Březina wrote: > > > On 07/11/2016 05:12 PM, Petr Cech wrote: > > > > > > >

[SSSD] Re: The sorry state of code documentation

2016-07-20 Thread Jakub Hrozek
On Wed, Jul 20, 2016 at 03:53:54PM +0300, Nikolai Kondrashov wrote: > I suggest several measures which could be taken. > > 1. Require *every* new module/function/argument/structure/field to be >documented. It must be at least a sentence for each. A module or a bigger >data structure could

[SSSD] Re: [PATCHES] sssctl: print active server and server list

2016-07-20 Thread Jakub Hrozek
On Wed, Jul 20, 2016 at 03:00:14PM +0200, Jakub Hrozek wrote: > On Tue, Jul 19, 2016 at 12:20:16PM +0200, Pavel Březina wrote: > > On 07/18/2016 03:23 PM, Jakub Hrozek wrote: > > > On Thu, Jul 14, 2016 at 11:39:40AM +0200, Pavel Březina wrote: > > > > From 6af0640128

[SSSD] Re: [PATCHES] sssctl: print active server and server list

2016-07-20 Thread Jakub Hrozek
On Tue, Jul 19, 2016 at 12:20:16PM +0200, Pavel Březina wrote: > On 07/18/2016 03:23 PM, Jakub Hrozek wrote: > > On Thu, Jul 14, 2016 at 11:39:40AM +0200, Pavel Březina wrote: > > > From 6af064012844f3e61b9fa5b502bebe44e4620ffd Mon Sep 17 00:00:00 2001 > > > From: =?U

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-07-20 Thread Jakub Hrozek
On Fri, Jul 15, 2016 at 03:24:15PM +0200, Petr Cech wrote: > > On 07/12/2016 10:31 AM, Pavel Březina wrote: > > On 07/11/2016 05:12 PM, Petr Cech wrote: > > > > > > On 07/05/2016 08:44 AM, Jakub Hrozek wrote: > > > > On Mon, Jun 27,

[SSSD] Re: IPA: enable enterprise principals if server supports them

2016-07-18 Thread Jakub Hrozek
On Fri, Jul 15, 2016 at 09:13:01PM +0200, Lukas Slebodnik wrote: > On (15/07/16 21:05), Sumit Bose wrote: > >On Fri, Jul 15, 2016 at 08:42:50PM +0200, Jakub Hrozek wrote: > >> On Wed, Jul 06, 2016 at 06:48:25PM +0200, Jakub Hrozek wrote: > >> > On Tue, Jul 05, 2016 a

[SSSD] Re: [PATCHES] sssctl: print active server and server list

2016-07-18 Thread Jakub Hrozek
On Thu, Jul 14, 2016 at 11:39:40AM +0200, Pavel Březina wrote: > On 07/13/2016 12:11 PM, Jakub Hrozek wrote: > > On Thu, Jun 30, 2016 at 02:10:47PM +0200, Pavel Březina wrote: > > > Failover patches for the sssctl tool. The output looks like: > > > > > > [m

[SSSD] Re: IPA: enable enterprise principals if server supports them

2016-07-15 Thread Jakub Hrozek
On Wed, Jul 06, 2016 at 06:48:25PM +0200, Jakub Hrozek wrote: > On Tue, Jul 05, 2016 at 10:06:15PM +0200, Sumit Bose wrote: > > On Tue, Jul 05, 2016 at 07:15:03PM +0200, Jakub Hrozek wrote: > > > On Tue, Jul 05, 2016 at 12:37:22PM +0200, Sumit Bose wrote: > > > > H

[SSSD] Re: [PATCHES] sssctl: print active server and server list

2016-07-13 Thread Jakub Hrozek
On Thu, Jun 30, 2016 at 02:10:47PM +0200, Pavel Březina wrote: > Failover patches for the sssctl tool. The output looks like: > > [master.ipa.pb: ~]$ sudo sssctl domain-status ad.pb > Online status: Online > > Active servers: > AD Global Catalog: root-dc.ad.pb > AD Domain Controller:

[SSSD] Re: [PATCH] sssctl: move filter creation to separate function

2016-07-13 Thread Jakub Hrozek
On Wed, Jul 13, 2016 at 10:44:18AM +0200, Fabiano Fidêncio wrote: > Thanks a lot! > Acked-by: Fabiano Fidêncio > * master: * 3c6e15e8aa38d9dfa02a7255fad56149bdfb35a6 * aa691837a2fa2fe2e38a55d576644074e0f45bd8 ___ sssd-devel

[SSSD] Re: [PATCH] dyndns: Add checks for NULL

2016-07-13 Thread Jakub Hrozek
On Wed, Jul 13, 2016 at 10:16:22AM +0200, Pavel Březina wrote: > On 07/12/2016 03:50 PM, Michal Židek wrote: > > On 07/12/2016 01:36 PM, Michal Židek wrote: > > > On 07/12/2016 01:15 PM, Pavel Březina wrote: > > > > On 07/12/2016 12:34 PM, Michal Židek wrote: > > > > >

[SSSD] Re: [PATCH] views: allow override added for non-default views at runtime

2016-07-13 Thread Jakub Hrozek
On Wed, Jul 13, 2016 at 10:13:05AM +0200, Pavel Březina wrote: > On 07/12/2016 02:46 PM, Jakub Hrozek wrote: > > On Tue, Jul 12, 2016 at 11:45:07AM +0200, Pavel Březina wrote: > > > On 07/11/2016 03:16 PM, Sumit Bose wrote: > > > > Hi, > > > > >

[SSSD] Re: [PATCH] TOOLS: Prevent dereference of null pointer

2016-07-12 Thread Jakub Hrozek
On Tue, Jul 12, 2016 at 12:12:05PM +0200, Pavel Březina wrote: > Ack. * master: f9d3aec54d19a771a6eafe09ba6d445cc094bfae ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] views: allow override added for non-default views at runtime

2016-07-12 Thread Jakub Hrozek
On Tue, Jul 12, 2016 at 11:45:07AM +0200, Pavel Březina wrote: > On 07/11/2016 03:16 PM, Sumit Bose wrote: > > Hi, > > > > this patch should solve > > https://fedorahosted.org/sssd/ticket/3092, please see commit message for > > details. > > > > bye, > > Sumit > > Ack. CI:

[SSSD] Re: [PATCH] nss-srv-tests: Fix prototype of wrapped ncache functions

2016-07-12 Thread Jakub Hrozek
On Tue, Jul 12, 2016 at 12:07:34PM +0200, Pavel Březina wrote: > On 07/04/2016 02:15 PM, Lukas Slebodnik wrote: > > On (20/06/16 11:45), Lukas Slebodnik wrote: > > > ehlo, > > > > > > simple patch is attached. > > > I wonder how it could work because argument ttl was previously > > > in the midle

[SSSD] Re: [PATCH] sssctl: manual page

2016-07-12 Thread Jakub Hrozek
On Tue, Jul 12, 2016 at 11:53:20AM +0200, Pavel Březina wrote: > On 07/11/2016 12:29 PM, Lukas Slebodnik wrote: > > On (09/07/16 11:35), Jakub Hrozek wrote: > > > On Fri, Jul 08, 2016 at 03:11:12PM -0400, Dan Lavu wrote: > > > > So I didn't need to review this

[SSSD] Re: [PATCH] dyndns: Add checks for NULL

2016-07-12 Thread Jakub Hrozek
On Tue, Jul 12, 2016 at 01:15:30PM +0200, Pavel Březina wrote: > On 07/12/2016 12:34 PM, Michal Židek wrote: > > state->ipa_ctx->dyndns_ctx->last_refresh = time(NULL); > > LGTM but maybe we should place the check before this line? Also in the commit message we should probably say the

[SSSD] Re: [PATCH] sssctl: Fix warning maybe-uninitialized

2016-07-12 Thread Jakub Hrozek
On Tue, Jul 12, 2016 at 11:54:03AM +0200, Jakub Hrozek wrote: > On Fri, Jul 08, 2016 at 03:55:56PM +0200, Lukas Slebodnik wrote: > > ehlo, > > > > I can see warning maybe-uninitialized in mock build. > > I had a plan to initialize it to NULL. > >

[SSSD] Re: [PATCH] ipa_hbac: Fix documentation for hbac_enable_debug

2016-07-12 Thread Jakub Hrozek
On Tue, Jul 12, 2016 at 11:48:03AM +0200, Jakub Hrozek wrote: > On Fri, Jul 08, 2016 at 02:45:35PM +0200, Lukas Slebodnik wrote: > > ehlo, > > > > You will need to apply patch "[PATCH] doxygen: Fix path to header file > > ipa_hbac.h" if you want to see this

[SSSD] Re: [PATCH] doxygen: Fix path to header file ipa_hbac.h

2016-07-12 Thread Jakub Hrozek
On Tue, Jul 12, 2016 at 11:46:47AM +0200, Jakub Hrozek wrote: > On Fri, Jul 08, 2016 at 01:51:23PM +0200, Lukas Slebodnik wrote: > > ehlo, > > > > Small issue after moving libiba_hbac to new location. > > > > Warning: tag INPUT: input source `src/providers/ip

[SSSD] Re: [PATCH] FO: Set port to NOT_WORKING when trying a next server

2016-07-12 Thread Jakub Hrozek
On Fri, Jul 08, 2016 at 10:53:12AM +0200, Pavel Březina wrote: > On 05/10/2016 04:33 PM, Jakub Hrozek wrote: > > Hi, > > > > attached is a patch that I think is correct and it did solve a bug I was > > seeing, but I'm not sure if it's the right thing to do since the cod

[SSSD] Re: [PATCH] sssctl: Fix format string for size_t

2016-07-12 Thread Jakub Hrozek
On Tue, Jul 12, 2016 at 11:45:01AM +0200, Jakub Hrozek wrote: > On Fri, Jul 08, 2016 at 01:30:24PM +0200, Lukas Slebodnik wrote: > > ehlo, > > > > We review some patches in hurry yesterday > > and therefore I misse some issues. > > I noticed after packagi

[SSSD] Re: [PATCH] IPA: Removing of confusing debug message

2016-07-12 Thread Jakub Hrozek
On Tue, Jul 12, 2016 at 11:52:05AM +0200, Pavel Březina wrote: > On 07/12/2016 10:20 AM, Petr Cech wrote: > > Hello list, > > > > there is simple patch for [1]. > > > > I prepared two version: > > a) the first is for changing the message, > > b) the second is for removing. > > > > I looked at

[SSSD] Re: [PATCH] sssctl: Fix warning maybe-uninitialized

2016-07-12 Thread Jakub Hrozek
On Fri, Jul 08, 2016 at 03:55:56PM +0200, Lukas Slebodnik wrote: > ehlo, > > I can see warning maybe-uninitialized in mock build. > I had a plan to initialize it to NULL. > But this version fixed if as well. > > It looks like some special gcc optimalisation and special case > may cause to have

[SSSD] Re: [PATCH] ipa_hbac: Fix documentation for hbac_enable_debug

2016-07-12 Thread Jakub Hrozek
On Fri, Jul 08, 2016 at 02:45:35PM +0200, Lukas Slebodnik wrote: > ehlo, > > You will need to apply patch "[PATCH] doxygen: Fix path to header file > ipa_hbac.h" if you want to see this warning. > > LS ACK CI: http://sssd-ci.duckdns.org/logs/job/49/42/summary.html

[SSSD] Re: [PATCH] doxygen: Fix path to header file ipa_hbac.h

2016-07-12 Thread Jakub Hrozek
On Fri, Jul 08, 2016 at 01:51:23PM +0200, Lukas Slebodnik wrote: > ehlo, > > Small issue after moving libiba_hbac to new location. > > Warning: tag INPUT: input source `src/providers/ipa/ipa_hbac.h' does not exist > warning: source src/providers/ipa/ipa_hbac.h is not > a readable file

[SSSD] Re: [PATCH] sssctl: Fix format string for size_t

2016-07-12 Thread Jakub Hrozek
On Fri, Jul 08, 2016 at 01:30:24PM +0200, Lukas Slebodnik wrote: > ehlo, > > We review some patches in hurry yesterday > and therefore I misse some issues. > I noticed after packaging 1.14.0 in rawhide > and copr > > LS ACK CI: http://sssd-ci.duckdns.org/logs/job/49/40/summary.html

[SSSD] Re: [PATCH] LDAP: Removing of useless debug message

2016-07-11 Thread Jakub Hrozek
On Mon, Jul 11, 2016 at 09:49:15AM -0400, Stephen Gallagher wrote: > On 07/11/2016 09:33 AM, Petr Cech wrote: > > Hi list, > > > > how Jakub mentioned on internal list this debug message should be removed. > > So I > > attached simple patch for it. > > > > I'd recommend changing it to "Trace:

[SSSD] Re: [PATCH] sssctl: manual page

2016-07-09 Thread Jakub Hrozek
On Fri, Jul 08, 2016 at 03:11:12PM -0400, Dan Lavu wrote: > So I didn't need to review this? Yes, but we had to release the rebase, sorry. I think we should apply your edits as a follow-up to the original patch. ___ sssd-devel mailing list

[SSSD] Re: [PATCH] LDAP: Fix storing initgroups for users with no supplementary

2016-07-08 Thread Jakub Hrozek
On Fri, Jul 08, 2016 at 02:03:16PM +0200, Lukas Slebodnik wrote: > On (08/07/16 13:55), Jakub Hrozek wrote: > >Hi, > > > >I was looking into the remaining downstream test failures and found this > >bug caused by the FQDN patchset.. > > Would it be complicated

[SSSD] [PATCH] LDAP: Fix storing initgroups for users with no supplementary

2016-07-08 Thread Jakub Hrozek
Hi, I was looking into the remaining downstream test failures and found this bug caused by the FQDN patchset.. >From df82480e68ac31f97e504c56917e1dbe083950cb Mon Sep 17 00:00:00 2001 From: Jakub Hrozek <jhro...@redhat.com> Date: Fri, 8 Jul 2016 13:19:31 +0200 Subject: [PATCH] LDAP: Fi

[SSSD] Announce - SSSD 1.13 is the new LTM branch

2016-07-08 Thread Jakub Hrozek
Hi, the SSSD upstream supports some selected branches for a longer time, to make life easier for long-term supported distributions such as Red Hat Enterprise Linux, Ubuntu LTM or Suse Enterprise Linux. Since the sssd-1.13 branch is quite stable and already used in several long-term supported

[SSSD] Announcing SSSD 1.14.0

2016-07-07 Thread Jakub Hrozek
ysdb: move add_ulong() convenience to sysdb.c * sysdb: add sysdb_{add,replace,delete}_ulong() Graham Leggett (1): * Add underlying diagnostic message for SSL errors. Jakub Hrozek (189): * Updating the version to track 1.14 development * MAN: Clarify pam_trusted_users option d

[SSSD] Re: [PATCH] sssctl: manual page

2016-07-07 Thread Jakub Hrozek
On Thu, Jul 07, 2016 at 07:18:55PM +0200, Michal Židek wrote: > On 07/07/2016 07:12 PM, Michal Židek wrote: > > On 07/07/2016 06:45 PM, Michal Židek wrote: > > > The man page looks good to me with exception > > > for one detail (see inline) > > > > > > On 07/04/2016 12:45 PM, Pavel Březina wrote:

[SSSD] Re: [PATCH] SSH-CERT: always initialize cert_verify_opts

2016-07-07 Thread Jakub Hrozek
On Thu, Jul 07, 2016 at 06:13:04PM +0200, Jakub Hrozek wrote: > On Fri, Jun 17, 2016 at 02:50:36PM +0200, Sumit Bose wrote: > > Hi, > > > > please find attached two small patches related to the conversion of the > > public key in a certificate to a public ssh-ke

[SSSD] Re: [PATCH] SSH-CERT: always initialize cert_verify_opts

2016-07-07 Thread Jakub Hrozek
On Fri, Jun 17, 2016 at 02:50:36PM +0200, Sumit Bose wrote: > Hi, > > please find attached two small patches related to the conversion of the > public key in a certificate to a public ssh-key. > > The first fixes an issue which should only happen in master. The second > might be useful for

[SSSD] Re: [PATCH] CONFIGURE: Inform about optional build dependencies

2016-07-07 Thread Jakub Hrozek
On Thu, Jul 07, 2016 at 06:06:26PM +0200, Jakub Hrozek wrote: > On Thu, Jul 07, 2016 at 01:05:39PM +0200, Lukas Slebodnik wrote: > > On (05/07/16 07:59), Jakub Hrozek wrote: > > >On Fri, Jul 01, 2016 at 08:45:53AM +0200, Lukas Slebodnik wrote: > > >> ehlo, > &g

[SSSD] Re: [PATCH] CONFIGURE: Inform about optional build dependencies

2016-07-07 Thread Jakub Hrozek
On Thu, Jul 07, 2016 at 01:05:39PM +0200, Lukas Slebodnik wrote: > On (05/07/16 07:59), Jakub Hrozek wrote: > >On Fri, Jul 01, 2016 at 08:45:53AM +0200, Lukas Slebodnik wrote: > >> ehlo, > >> > >> We usually inform about optional build dependencies at conf

[SSSD] Fwd: Re: [PATCH] LDAP: Lookup services by all protocols unless a protocol is specified

2016-07-07 Thread Jakub Hrozek
sssd-devel seems to be eating our mails lately, resending - Forwarded Message - From: "Jakub Hrozek" <jhro...@redhat.com> To: sssd-devel@lists.fedorahosted.org Sent: Thursday, July 7, 2016 4:44:30 PM Subject: Re: [SSSD] Re: [PATCH] LDAP: Lookup services by all protocols un

[SSSD] Re: [PATCH] sudo: solve problems with fully qualified names

2016-07-07 Thread Jakub Hrozek
On Wed, Jul 06, 2016 at 06:20:00PM +0200, Jakub Hrozek wrote: > On Wed, Jul 06, 2016 at 03:23:26PM +0200, Jakub Hrozek wrote: > > On Wed, Jun 01, 2016 at 11:52:44AM +0200, Pavel Březina wrote: > > > On 05/31/2016 01:44 PM, Jakub Hrozek wrote: > > > > On Fri, May 27, 2

[SSSD] Re: [PATCH] LDAP: Lookup services by all protocols unless a protocol is specified

2016-07-07 Thread Jakub Hrozek
On Thu, Jul 07, 2016 at 12:39:28PM +0200, Pavel Březina wrote: > On 07/07/2016 12:34 PM, Jakub Hrozek wrote: > > On Thu, Jul 07, 2016 at 10:16:03AM +0200, Sumit Bose wrote: > > > resend > > > - Forwarded message from Sumit Bose <sb...@redhat.com> - > &g

[SSSD] Re: [PATCH][PUSHED] MAN: Include idmap_sss.8.xml in the manpage sources

2016-07-07 Thread Jakub Hrozek
On Thu, Jul 07, 2016 at 01:06:31PM +0200, Lukas Slebodnik wrote: > On (07/07/16 13:05), Pavel Březina wrote: > >On 06/30/2016 03:37 PM, Lukas Slebodnik wrote: > >> On (30/06/16 09:28), Sumit Bose wrote: > >> > On Wed, Jun 29, 2016 at 11:23:55PM +0200, Jakub Hrozek

[SSSD] Re: [PATCH] PAM/KRB5: optional otp and password prompting

2016-07-07 Thread Jakub Hrozek
On Thu, Jul 07, 2016 at 12:39:01PM +0200, Jakub Hrozek wrote: > The prompts were changes as Nathaniel suggested and the basic sanity > checks worked with this patch. I'm going to push with Nathaniel's RB. * master: 78027feeb56d6fe216f699be86a4716aae

[SSSD] Re: [PATCH] LDAP: Lookup services by all protocols unless a protocol is specified

2016-07-07 Thread Jakub Hrozek
n; charset=us-ascii > Content-Disposition: inline > In-Reply-To: <20160705103025.GB24232@hendrix> > User-Agent: Mutt/1.6.1 (2016-04-27) > > On Tue, Jul 05, 2016 at 12:30:25PM +0200, Jakub Hrozek wrote: > > Hi, > > > > the attached patch makes service lookups gr

[SSSD] Re: fully qualified sysdb names for users and groups

2016-07-07 Thread Jakub Hrozek
On Thu, Jul 07, 2016 at 11:45:42AM +0200, Lukas Slebodnik wrote: > On (07/07/16 11:39), Pavel Březina wrote: > >On 07/06/2016 11:21 PM, Sumit Bose wrote: > >> > >> ok, CI passed http://sssd-ci.duckdns.org/logs/job/47/41/summary.html > >> > >> ACK > > > >I went through the code changes and it

[SSSD] Re: fully qualified sysdb names for users and groups

2016-07-06 Thread Jakub Hrozek
On Wed, Jul 06, 2016 at 06:34:32PM +0200, Jakub Hrozek wrote: > On Wed, Jul 06, 2016 at 11:13:02AM +0200, Lukas Slebodnik wrote: > > On (03/07/16 12:50), Jakub Hrozek wrote: > > >On Fri, Jul 01, 2016 at 11:01:53PM +0200, Jakub Hrozek wrote: > > >> On Fri, Jul 01, 2

[SSSD] RFC: Release notes for the 1.14.0 release

2016-07-06 Thread Jakub Hrozek
Hi, I prepared the release notes for the 1.14.0 release here: https://fedorahosted.org/sssd/wiki/Releases/Notes-1.14.0 please comment or edit them. The notes are written with the assumption that several pending patches (including prompting patches, enterprise principals or the sysdb

[SSSD] Re: [PATCHES] krb5 config snippets

2016-07-06 Thread Jakub Hrozek
On Wed, Jul 06, 2016 at 06:24:08PM +0200, Jakub Hrozek wrote: > On Tue, Jul 05, 2016 at 12:54:34PM +0200, Sumit Bose wrote: > > Hi, > > > > the following 4 patches include fixes for > > ttps://fedorahosted.org/sssd/ticket/2788 and > > https://

[SSSD] Re: IPA: enable enterprise principals if server supports them

2016-07-06 Thread Jakub Hrozek
On Tue, Jul 05, 2016 at 10:06:15PM +0200, Sumit Bose wrote: > On Tue, Jul 05, 2016 at 07:15:03PM +0200, Jakub Hrozek wrote: > > On Tue, Jul 05, 2016 at 12:37:22PM +0200, Sumit Bose wrote: > > > Hi, > > > > > > this patch set should solve https://fedorahosted.o

[SSSD] Re: fully qualified sysdb names for users and groups

2016-07-06 Thread Jakub Hrozek
On Wed, Jul 06, 2016 at 11:13:02AM +0200, Lukas Slebodnik wrote: > On (03/07/16 12:50), Jakub Hrozek wrote: > >On Fri, Jul 01, 2016 at 11:01:53PM +0200, Jakub Hrozek wrote: > >> On Fri, Jul 01, 2016 at 03:24:39PM +0200, Jakub Hrozek wrote: > >> > On Wed, Jun 29, 2

[SSSD] Re: [PATCHES] krb5 config snippets

2016-07-06 Thread Jakub Hrozek
On Tue, Jul 05, 2016 at 12:54:34PM +0200, Sumit Bose wrote: > Hi, > > the following 4 patches include fixes for > ttps://fedorahosted.org/sssd/ticket/2788 and > https://fedorahosted.org/sssd/ticket/3041. They are not related but > depend on each other patch-wise, so I put them in a single mail.

[SSSD] Re: [PATCH] test_sysdb_ts_cache: Do not use wrong pointer for output argument

2016-07-06 Thread Jakub Hrozek
On Wed, Jul 06, 2016 at 01:04:49PM +0200, Sumit Bose wrote: > On Wed, Jul 06, 2016 at 12:23:08PM +0200, Sumit Bose wrote: > > On Mon, Jul 04, 2016 at 03:33:08PM +0200, Lukas Slebodnik wrote: > > > ehlo, > > > > > > Attached patches fix failures in test on big endian > > >

[SSSD] Re: [PATCH] sudo: solve problems with fully qualified names

2016-07-06 Thread Jakub Hrozek
On Wed, Jul 06, 2016 at 03:23:26PM +0200, Jakub Hrozek wrote: > On Wed, Jun 01, 2016 at 11:52:44AM +0200, Pavel Březina wrote: > > On 05/31/2016 01:44 PM, Jakub Hrozek wrote: > > > On Fri, May 27, 2016 at 11:54:20AM +0200, Pavel Březina wrote: > > > >

[SSSD] Re: [PATCH] LDAP: Change the default rfc2307 autofs attribute mappings

2016-07-06 Thread Jakub Hrozek
On Wed, Jul 06, 2016 at 11:07:30AM +0200, Lukas Slebodnik wrote: > On (06/07/16 00:03), Jakub Hrozek wrote: > >On Tue, Jul 05, 2016 at 11:40:48PM +0200, Jakub Hrozek wrote: > >> On Tue, Jul 05, 2016 at 09:02:24PM +0200, Lukas Slebodnik wrote: > >> > On (05/07

[SSSD] Re: [PATCH] sudo: solve problems with fully qualified names

2016-07-06 Thread Jakub Hrozek
On Wed, Jun 01, 2016 at 11:52:44AM +0200, Pavel Březina wrote: > On 05/31/2016 01:44 PM, Jakub Hrozek wrote: > > On Fri, May 27, 2016 at 11:54:20AM +0200, Pavel Březina wrote: > > > See commit message for details. > > > > > > Two configura

[SSSD] Re: [PATCH] PAM: Allow to configure pam services for smartcards

2016-07-06 Thread Jakub Hrozek
On Wed, Jul 06, 2016 at 11:04:56AM +0200, Lukas Slebodnik wrote: > Updated patch is attached. it is not :-) ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] LDAP: Change the default rfc2307 autofs attribute mappings

2016-07-05 Thread Jakub Hrozek
On Tue, Jul 05, 2016 at 11:40:48PM +0200, Jakub Hrozek wrote: > On Tue, Jul 05, 2016 at 09:02:24PM +0200, Lukas Slebodnik wrote: > > On (05/07/16 12:27), Jakub Hrozek wrote: > > >On Wed, Jun 29, 2016 at 05:38:55PM +0200, Lukas Slebodnik wrote: > > >> On (29/06

[SSSD] Re: [PATCH] LDAP: Change the default rfc2307 autofs attribute mappings

2016-07-05 Thread Jakub Hrozek
On Tue, Jul 05, 2016 at 09:02:24PM +0200, Lukas Slebodnik wrote: > On (05/07/16 12:27), Jakub Hrozek wrote: > >On Wed, Jun 29, 2016 at 05:38:55PM +0200, Lukas Slebodnik wrote: > >> On (29/06/16 13:12), Jakub Hrozek wrote: > >> >On Wed, Jun 29, 2016 at 12:48:36P

[SSSD] Re: IPA: enable enterprise principals if server supports them

2016-07-05 Thread Jakub Hrozek
On Tue, Jul 05, 2016 at 12:37:22PM +0200, Sumit Bose wrote: > Hi, > > this patch set should solve https://fedorahosted.org/sssd/ticket/3018 > by looking up the additional UPN suffixes on the IPA server. If some > were found, enterprise principals are enabled if they are not explicitly > disabled

[SSSD] [PATCH] LDAP: Lookup services by all protocols unless a protocol is specified

2016-07-05 Thread Jakub Hrozek
00:00:00 2001 From: Jakub Hrozek <jhro...@redhat.com> Date: Tue, 5 Jul 2016 12:23:23 +0200 Subject: [PATCH] LDAP: Lookup services by all protocols unless a protocol is specified The DP refactoring changed the way we handle strings from sbus. We no longer receive NULL strings, but em

<    1   2   3   4   5   6   7   8   9   10   >