Re: [SSSD] [PATCH] Make ldap bind asynchronous

2010-07-29 Thread Martin Nagy
On Tue, 2010-07-27 at 14:26 -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 07/27/2010 11:04 AM, Martin Nagy wrote: > > On Mon, 2010-07-26 at 22:26 +0200, Martin Nagy wrote: > >> On Mon, 2010-07-26 at 16:14 +0200, Jak

Re: [SSSD] [PATCH] Make ldap simple bind asynchronous

2010-05-03 Thread Martin Nagy
On Fri, 2010-04-23 at 14:49 +0200, Martin Nagy wrote: > Hi, > here it is. I included some description in the commit log, it is > necessary to read it in order to understand why I did some things this > way. Any suggestions to make the patch better are most welcome. > > Martin

Re: [SSSD] [PATCH] Support SRV servers in failover

2010-04-27 Thread Martin Nagy
On Mon, 2010-04-26 at 23:14 +0200, Jakub Hrozek wrote: > New patches are attached, comments are inline. > > On 04/26/2010 05:54 PM, Martin Nagy wrote: > > On Fri, 2010-04-23 at 11:57 +0200, Jakub Hrozek wrote: > >> > [PATCH 1/2] Remove freed server_common entities fro

Re: [SSSD] [PATCH] Support SRV servers in failover

2010-04-26 Thread Martin Nagy
On Fri, 2010-04-23 at 11:57 +0200, Jakub Hrozek wrote: > > [PATCH 1/2] Remove freed server_common entities from list > > We didn't hit this before as we never removed common entities. When > > using service requests, we remove the resolved fo_servers when we hit a > > timeout, so the server_common

Re: [SSSD] [PATCH] Make the handling of fd events opaque

2010-04-26 Thread Martin Nagy
On Fri, Apr 23, 2010 at 02:37:01PM +0200, Martin Nagy wrote: > On Fri, 2010-04-23 at 11:28 +0200, Sumit Bose wrote: > > On Thu, Apr 22, 2010 at 11:58:10PM +0200, Martin Nagy wrote: > > > On 04/16/2010 12:22 PM, Sumit Bose wrote: [snip] > > Thanks for the revi

[SSSD] [PATCH] Make ldap simple bind asynchronous

2010-04-23 Thread Martin Nagy
Hi, here it is. I included some description in the commit log, it is necessary to read it in order to understand why I did some things this way. Any suggestions to make the patch better are most welcome. Martin >From 228bfdcc000e93be5908ef9ba28aee13385c258d Mon Sep 17 00:00:00 2001 From: Mar

Re: [SSSD] [PATCH] Make the handling of fd events opaque

2010-04-23 Thread Martin Nagy
On Fri, 2010-04-23 at 11:28 +0200, Sumit Bose wrote: > On Thu, Apr 22, 2010 at 11:58:10PM +0200, Martin Nagy wrote: > > On 04/16/2010 12:22 PM, Sumit Bose wrote: > > > Hi, > > > > > > to support the current effort to make the LDAP provider more robust thi

Re: [SSSD] [PATCH] Make the handling of fd events opaque

2010-04-23 Thread Martin Nagy
On Fri, 2010-04-23 at 11:28 +0200, Sumit Bose wrote: > On Thu, Apr 22, 2010 at 11:58:10PM +0200, Martin Nagy wrote: > > On 04/16/2010 12:22 PM, Sumit Bose wrote: > > > Hi, > > > > > > to support the current effort to make the LDAP provider more robust thi

Re: [SSSD] [PATCH] Make the handling of fd events opaque

2010-04-23 Thread Martin Nagy
On 04/23/2010 12:21 AM, Stephen Gallagher wrote: > 11 times out of 10, it's a bad idea to use inline explicitly. Modern > compilers will automatically optimize small functions into inline > where it is safe to do so. Yes, but gcc can't inline it if it is defined in another translation unit, altho

Re: [SSSD] [PATCH] Make the handling of fd events opaque

2010-04-22 Thread Martin Nagy
On 04/16/2010 12:22 PM, Sumit Bose wrote: > Hi, > > to support the current effort to make the LDAP provider more robust this > patch removes all the #ifdef HAVE_LDAP_CONNCB calls from the main code > into a separate file which provides generic helper functions. > > bye, > Sumit Nitpick: -static vo

Re: [SSSD] [Patch] Improvements for the Kerberos locator plugin

2010-03-08 Thread Martin Nagy
On 03/08/2010 02:45 PM, Sumit Bose wrote: > On Mon, Mar 08, 2010 at 04:29:12AM +0100, Martin Nagy wrote: >> On 03/05/2010 08:19 PM, Sumit Bose wrote: >>> On Fri, Mar 05, 2010 at 12:00:41PM -0500, Dmitri Pal wrote: >>>> Sumit Bose wrote: >>>>> Hi, >

Re: [SSSD] [Patch] Improvements for the Kerberos locator plugin

2010-03-07 Thread Martin Nagy
On 03/05/2010 08:19 PM, Sumit Bose wrote: > On Fri, Mar 05, 2010 at 12:00:41PM -0500, Dmitri Pal wrote: >> Sumit Bose wrote: >>> Hi, >>> >>> the following two patches are related to the Kerberos locator plugin. >>> >>> The first patch removes the name resolution from the locator plugin and >>> let

Re: [SSSD] [PATCH] Do not run negative resolv test with no network

2010-03-04 Thread Martin Nagy
On Wed, 2010-03-03 at 14:49 +0100, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > One of our resolv tests tries to resolve a nonexistent hostname. Do not > run this test unless we are explicitly told that a network connection > is available (-n). > > Our tests now pass

[SSSD] [PATCH] Add forgotten \n in DEBUG statements

2010-03-03 Thread Martin Nagy
Logs from confdb with missing '\n' in the DEBUG statements annoyed me so I decided to fix them. I also made a quick grep through the code and found other places so I fixed them too. Martin >From d297fd987da1d512ef98666aae051e9b0133c4e5 Mon Sep 17 00:00:00 2001 From: Martin Nagy Dat

[SSSD] [PATCH] Make confdb_init's confdb_location parameter const

2010-03-03 Thread Martin Nagy
SSIA Martin >From d6a78ddef613e39a6912a31d9ed70903533fa014 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Wed, 3 Mar 2010 08:31:59 +0100 Subject: [PATCH] Make confdb_init's confdb_location parameter const --- src/confdb/confdb.c |2 +- src/confdb/confdb.h |2 +- 2 files ch

[SSSD] [PATCH] Don't pass a variable as format to talloc_asprintf()

2010-02-12 Thread Martin Nagy
Hi, SSIA. Martin >From 3f417c3f8c193f830edd973a46e7c3919cc7f954 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Wed, 20 Jan 2010 17:35:10 +0100 Subject: [PATCH] Don't pass a variable as format to talloc_asprintf() This practice is not recommended and can also be dangerous. ---

Re: [SSSD] [PATCH] Fix handling of the global context in the leak detector

2010-02-08 Thread Martin Nagy
On Mon, 2010-02-08 at 11:58 +0100, Sumit Bose wrote: > Hi, > > this patch fixes the handling of the global context in the leak test > routine of some unit tests. Now it is initialize only once. > > bye, > Sumit ACK Nice work, thanks :) Martin ___ sss

Re: [SSSD] [PATCH] Make resolve and failover test work with CK_FORK=no

2010-02-04 Thread Martin Nagy
Sumit Bose wrote: > Hi, > > the resolver and failover unit test are using a leak checker which calls > 'talloc_free(talloc_autofree_context());'. This is not recommended and > makes the test fail it CK_FORK is set to 'no'. The attached patch > introduces a global talloc context which should be use

Re: [SSSD] [PATCH] Handle IPv6 addresses with the async resolver

2010-01-21 Thread Martin Nagy
Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > If a DNS lookup fails to return an IPv4 address for a hostname, we > will attempt to look up an IPv6 address before returning a failure. > > Note: this only ensures that the async resolver identifies the correct > addr

Re: [SSSD] [PATCH] Add missing KRB5_LIBS

2010-01-20 Thread Martin Nagy
On Wed, 2010-01-20 at 16:12 -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > This was a bizarre bug. It was found by the Ubuntu packagers. On Fedora, > we were providing an implicit dependency on -lkrb5 to the sssd_be binary > through -lldb. On Ubuntu, there ar

Re: [SSSD] [PATCH] Fix memory issues in async resolver

2010-01-19 Thread Martin Nagy
On Mon, 2010-01-18 at 14:11 -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > This fixes two issues: > 1) Eliminates a double-free when a timeout occurs (we were freeing the > running event context) > 2) Ensures that we don't continue to schedule unnecessary tim

Re: [SSSD] [PATCH] Make periodic checks for DNS timeouts

2010-01-14 Thread Martin Nagy
Simo Sorce wrote: > On Thu, 14 Jan 2010 07:13:01 -0500 > Stephen Gallagher wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > On 01/13/2010 05:38 PM, Simo Sorce wrote: > > > On Wed, 13 Jan 2010 16:54:54 -0500 > > > Stephen Gallagher wrote: > > > > > >> It's bad practice to

Re: [SSSD] [PATCH] Make periodic checks for DNS timeouts

2010-01-14 Thread Martin Nagy
On Wed, 2010-01-13 at 16:54 -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 01/13/2010 04:11 PM, Martin Nagy wrote: > > This fixes #381. This patch is based on Steven's DNS timeout patch. > > > > Martin > >

[SSSD] [PATCH] Make sure callbacks never retry when ares channel is destroyed

2010-01-13 Thread Martin Nagy
Comments are in the commit message. Martin >From 0238f9f556d4278f1b8d61655c21c7b9f5a2be19 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Wed, 13 Jan 2010 19:42:21 +0100 Subject: [PATCH 3/3] Make sure callbacks never retry when ares channel is destroyed When the resolv context destructor

[SSSD] [PATCH] Don't recursively call ares_process_fd() from fd_event()

2010-01-13 Thread Martin Nagy
This fixes #384. Martin >From 495c58af7024a5b31b7c60455dccbe3873d3d391 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Wed, 13 Jan 2010 17:03:53 +0100 Subject: [PATCH 2/3] Don't recursively call ares_process_fd() from fd_event() Since ares_process_fd() might also cause fd_event() to b

[SSSD] [PATCH] Make periodic checks for DNS timeouts

2010-01-13 Thread Martin Nagy
This fixes #381. This patch is based on Steven's DNS timeout patch. Martin >From b47325c4303530d832bf5dad67bebdecdc762dd7 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Mon, 11 Jan 2010 18:24:16 +0100 Subject: [PATCH 1/3] Make periodic checks for DNS timeouts Since we only call c

Re: [SSSD] [PATCH] Set asynchronous DNS timeout in sssd.conf

2010-01-13 Thread Martin Nagy
On Wed, 2010-01-13 at 14:16 -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 01/13/2010 11:00 AM, Stephen Gallagher wrote: > > Allow us to explicitly set the timeout. I set the number of > > tries to once, with a default of ten seconds. > > > > > Simo rec

Re: [SSSD] [PATCH] Set asynchronous DNS timeout in sssd.conf

2010-01-13 Thread Martin Nagy
On Wed, 2010-01-13 at 11:00 -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Allow us to explicitly set the timeout. I set the number of > tries to once, with a default of ten seconds. Nack. This is a duplicate already sent. Martin __

Re: [SSSD] [PATCH] Set asynchronous DNS timeout in sssd.conf

2010-01-13 Thread Martin Nagy
On Wed, 2010-01-13 at 11:00 -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Allow us to explicitly set the timeout. I set the number of > tries to once, with a default of ten seconds. Nack. Please also mention this in the documentation. Martin _

[SSSD] [PATCH] Make periodic checks for DNS timeouts

2010-01-11 Thread Martin Nagy
Fix for #381. Martin >From fcba9849de1e6499a2dcf7ccda277698ef8e4552 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Mon, 11 Jan 2010 18:24:16 +0100 Subject: [PATCH] Make periodic checks for DNS timeouts Since we only call c-ares to process input on FD when there is an activity on them, c-a

[SSSD] [PATCH] Re-create c-ares channels if /etc/resolv.conf is modified

2010-01-08 Thread Martin Nagy
SSIA. Thanks to Steven for testing out this patch. Martin >From 6e6f8bb2f09ddb22cbe767e61ebbd9ecb254f05a Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Fri, 8 Jan 2010 22:32:25 +0100 Subject: [PATCH] Re-create c-ares channels if /etc/resolv.conf is modified Fixes: #378 --- server/provid

[SSSD] [PATCHES] Fail over fixes for #321

2009-12-10 Thread Martin Nagy
Hi, basically, there were two problems with the fail over, both are addressed and described in the attached patches. Martin >From 3b359c31de586956f9dd7326c859efb641afbe43 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Thu, 10 Dec 2009 22:23:04 +0100 Subject: [PATCH 1/2] Don't cons

Re: [SSSD] [PATCH] Document the failover feature in manpages

2009-12-10 Thread Martin Nagy
On Thu, 2009-12-10 at 16:05 +0100, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Fixes: #309 Ack for the content, English also looks good as far as I can tell. Martin ___ sssd-devel mailing list sssd-devel@lists.fedorahoste

[SSSD] [PATCH] Correctly restart server status after the timeout

2009-12-09 Thread Martin Nagy
001 From: Martin Nagy Date: Wed, 9 Dec 2009 14:11:09 +0100 Subject: [PATCH] Correctly restart server status after the timeout The macro STATUS_DIFF() was wrong causing the result to always be lower than 0, therefore the timeout was never reached. Fixes: #302 --- server/providers/fail_over.c |

[SSSD] [PATCH] Add some debugging statements to fail_over and resolver

2009-12-09 Thread Martin Nagy
These were very useful for debugging and hopefully still will be in the future. Martin >From c67a854ffeb36db5d28e1182a14018ec99cf37e0 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Tue, 8 Dec 2009 19:26:50 +0100 Subject: [PATCH] Add some debugging statements to fail_over and resolver Th

[SSSD] [PATCH] fix rpms target: Fix egg-info file generation in the spec file

2009-12-09 Thread Martin Nagy
erate the rpms. Martin >From e323e34470c6b32ca8d1cf6b2d7f6f2856c3336d Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Wed, 9 Dec 2009 12:04:51 +0100 Subject: [PATCH] Fix egg-info file generation in the spec file We were actually listing files that are on the system, not those that we create

Re: [SSSD] [PATCH] Fix RPM spec for RHEL6

2009-12-09 Thread Martin Nagy
On Tue, 2009-12-08 at 13:35 -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Red Hat Enterprise Linux 6 will eventuall be based on Fedora. Currently > our spec file treats all versions of RHEL the same. This will cause it > to fail on RHEL6. Ack. Martin _

Re: [SSSD] [PATCH] c-ares 1.7.0 related changes

2009-12-09 Thread Martin Nagy
On Tue, 2009-12-08 at 20:43 +0100, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 12/08/2009 07:53 PM, Jakub Hrozek wrote: > > Thank you for the review, the issues should be fixed now. > > Two more small fixes - clean up when talloc fails and fix one bad typo > (comp

Re: [SSSD] [PATCH] c-ares 1.7.0 related changes

2009-12-08 Thread Martin Nagy
On Tue, 2009-12-08 at 19:53 +0100, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 12/08/2009 02:20 PM, Martin Nagy wrote: > > Unfortunately, that still doesn't solve the issue. These functions are > > surprisingly difficult to get right.

Re: [SSSD] [PATCH] c-ares 1.7.0 related changes

2009-12-08 Thread Martin Nagy
On Mon, 2009-12-07 at 20:03 +0100, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 12/02/2009 03:07 PM, Martin Nagy wrote: > > > > I think we should just push these patches (after the review is done) and > > then disable them in the

Re: [SSSD] [PATCH] c-ares 1.7.0 related changes

2009-12-03 Thread Martin Nagy
On Wed, 2009-12-02 at 15:07 +0100, Martin Nagy wrote: > On Tue, 2009-12-01 at 19:33 +0100, Jakub Hrozek wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > c-ares 1.7.0 was released today and is already in rawhide. It is the > > first released

Re: [SSSD] [PATCH] c-ares 1.7.0 related changes

2009-12-02 Thread Martin Nagy
On Tue, 2009-12-01 at 19:33 +0100, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > c-ares 1.7.0 was released today and is already in rawhide. It is the > first released version that contains the code we contributed. > > What we have in HEAD right now for SRV and TXT pars

Re: [SSSD] [PATCH] failover fixes

2009-11-18 Thread Martin Nagy
On Wed, 2009-11-18 at 11:31 +0100, Martin Nagy wrote: > On Mon, 2009-11-16 at 17:51 -0500, Simo Sorce wrote: > > On Mon, 2009-11-16 at 17:08 +0100, Martin Nagy wrote: > > > Simo Sorce wrote: > > > > On Mon, 2009-11-16 at 08:46 +0100, Martin Nagy wrote: > > >

Re: [SSSD] [PATCH] failover fixes

2009-11-18 Thread Martin Nagy
On Mon, 2009-11-16 at 17:51 -0500, Simo Sorce wrote: > On Mon, 2009-11-16 at 17:08 +0100, Martin Nagy wrote: > > Simo Sorce wrote: > > > On Mon, 2009-11-16 at 08:46 +0100, Martin Nagy wrote: > > > > Simo Sorce wrote: > > > > > While working on a patch

Re: [SSSD] [PATCH] failover fixes

2009-11-16 Thread Martin Nagy
Simo Sorce wrote: > On Mon, 2009-11-16 at 08:46 +0100, Martin Nagy wrote: > > Simo Sorce wrote: > > > While working on a patch to use failover in the ldap driver I found a > > > few bugs and a few things I felt missing. > > > > > > Attached a patch

Re: [SSSD] [PATCH] failover fixes

2009-11-15 Thread Martin Nagy
Simo Sorce wrote: > While working on a patch to use failover in the ldap driver I found a > few bugs and a few things I felt missing. > > Attached a patch to fix bugs and add a function to get back a server > name from a fo_server structure. > > Simo. > > P.S: if you are interested in the failov

[SSSD] [PATCH] Add missing include file to files-tests.c

2009-11-09 Thread Martin Nagy
The files tests are broken and don't compile, attached patch fixes that. Martin >From a37cbc89a167eaf0f8cd5d5e6845f5fe9e3109e3 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Fri, 6 Nov 2009 17:48:37 +0100 Subject: [PATCH] Add missing include file to files-tests.c --- server/tes

Re: [SSSD] [PATCHES] Fail over helper functions and reference counting wrappers

2009-11-09 Thread Martin Nagy
On Thu, 2009-11-05 at 15:53 -0500, Simo Sorce wrote: > On Wed, 2009-11-04 at 18:32 +0100, Martin Nagy wrote: > > On Mon, 2009-11-02 at 16:02 -0500, Simo Sorce wrote: > > > On Fri, 2009-10-30 at 14:07 +0100, Martin Nagy wrote: > > > > Hi, > > > > att

Re: [SSSD] [PATCH] Fix a bad free in async_resolv.c

2009-11-09 Thread Martin Nagy
On Fri, 2009-11-06 at 08:12 -0500, Simo Sorce wrote: > On Fri, 2009-11-06 at 13:37 +0100, Martin Nagy wrote: > > Simple one-liner. > > Nack, just remove the else free completely. > It will be freed anyway as soon as you return from the function in 99% > of the cases as the

[SSSD] [PATCH] Fix a bad free in async_resolv.c

2009-11-09 Thread Martin Nagy
Simple one-liner. Martin >From ad04b74a8e9c60392cda5859e97b151eaeabbad6 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Wed, 4 Nov 2009 18:19:31 +0100 Subject: [PATCH] Fix a bad free in async_resolv.c --- server/resolv/async_resolv.c |2 +- 1 files changed, 1 insertions(+), 1 deleti

Re: [SSSD] [PATCH] Cleanups

2009-11-09 Thread Martin Nagy
On Sat, 2009-11-07 at 13:22 -0500, Simo Sorce wrote: > On Sat, 2009-11-07 at 09:47 +0100, Martin Nagy wrote: > > Simo Sorce wrote: > > > if (tevent_req_is_error(req, &tstate, &err)) { > > > -return -1; > > > +if

Re: [SSSD] [PATCH] Cleanups

2009-11-07 Thread Martin Nagy
Simo Sorce wrote: > if (tevent_req_is_error(req, &tstate, &err)) { > -return -1; > +if (err) return err; > +return EIO; > } Nack, err is not initialized here. I would recommend initializing it to EIO and replace return -1 with return err. Martin _

Re: [SSSD] [PATCHES] Fail over helper functions and reference counting wrappers

2009-11-04 Thread Martin Nagy
On Mon, 2009-11-02 at 16:02 -0500, Simo Sorce wrote: > On Fri, 2009-10-30 at 14:07 +0100, Martin Nagy wrote: > > Hi, > > attached are patches needed for the fail over functionality. The > > service discovery is not there yet, I want to hold of with that until > > I &g

Re: [SSSD] [PATCHES] Fail over helper functions and reference counting wrappers

2009-11-02 Thread Martin Nagy
Simo Sorce wrote: > On Fri, 2009-10-30 at 14:07 +0100, Martin Nagy wrote: > > Hi, > > attached are patches needed for the fail over functionality. The > > service discovery is not there yet, I want to hold of with that until I > > have at least a basic SRV-based one so I

[SSSD] [PATCHES] Fail over helper functions and reference counting wrappers

2009-10-30 Thread Martin Nagy
better. Martin>From 94a3fe2f29ac354180d37a9767ad4d722a00a3ea Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Tue, 6 Oct 2009 00:28:26 +0200 Subject: [PATCH 1/3] Add DLIST_FOR_EACH() macro --- server/util/dlinklist.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/server/util/dlinklist.h b/server

Re: [SSSD] [PATCH] User home directories management

2009-10-22 Thread Martin Nagy
On Thu, 2009-10-22 at 19:48 +0200, Jakub Hrozek wrote: > > A more serious bug I see in files.c: > > +while ((cnt = read(ifd, buf, sizeof(buf))) > 0) { > > +while (cnt > 0) { > > +written = write(ofd, buf, (size_t)cnt); > > +if (written == -1) { > > +

Re: [SSSD] [PATCH] User home directories management

2009-10-22 Thread Martin Nagy
On Wed, 2009-10-21 at 20:30 +0200, Jakub Hrozek wrote: > >> In main(): > >> +switch (ret) { > >> +case 'G': > >> +groups = poptGetOptArg(pc); > >> +if (!groups) { > >> +ret = -1; > >> +break; > >> +

Re: [SSSD] [PATCH] Fix up header file names in util.h and add sssd-i18n.h

2009-10-21 Thread Martin Nagy
Martin Nagy wrote: > On Tue, 2009-10-20 at 23:36 -0400, Simo Sorce wrote: > > On Wed, 2009-10-21 at 20:21 +0200, Martin Nagy wrote: > > > On Tue, 2009-10-20 at 22:16 -0400, Simo Sorce wrote: > > > > Why did you move config.h below talloc.h etc.. ? > > > >

Re: [SSSD] [PATCH] Fix up header file names in util.h and add sssd-i18n.h

2009-10-21 Thread Martin Nagy
On Tue, 2009-10-20 at 23:36 -0400, Simo Sorce wrote: > On Wed, 2009-10-21 at 20:21 +0200, Martin Nagy wrote: > > On Tue, 2009-10-20 at 22:16 -0400, Simo Sorce wrote: > > > Why did you move config.h below talloc.h etc.. ? > > > > > > Simo. > > > &

Re: [SSSD] [PATCH] Fix up header file names in util.h and add sssd-i18n.h

2009-10-21 Thread Martin Nagy
On Tue, 2009-10-20 at 22:16 -0400, Simo Sorce wrote: > Why did you move config.h below talloc.h etc.. ? > > Simo. No functional reason, I think it's better if <> headers are first and "" headers are last so since I was changing those lines anyway I decided to move them up as well. This shouldn't

[SSSD] [PATCHES] Fix resolv bugs and improve test coverage

2009-10-21 Thread Martin Nagy
rom 67f61eb0764eed07f33b8218e92a2dd61ac35863 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Tue, 6 Oct 2009 15:59:16 +0200 Subject: [PATCH 5/7] Use talloc to copy data from c-ares C-ares either returned a malloc-ed memory or it automatically freed the memory after out callback has returned. This patch will make s

[SSSD] [PATCH] Resolver: Use talloc_get_type() for type safety

2009-10-21 Thread Martin Nagy
Martin >From 5bf49d0fe5d1ea92a837039bbffe4a238d8bc4f0 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Thu, 6 Aug 2009 08:55:27 +0200 Subject: [PATCH 4/7] Resolver: Use talloc_get_type() for type safety --- server/resolv/async_resolv.c | 10 +- 1 files changed, 5 insertions(+)

[SSSD] [PATCH] Fix up header file names in util.h and add sssd-i18n.h

2009-10-21 Thread Martin Nagy
Martin >From f4e238fa95306a7ca5aee4160dfc64a29c38d331 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Thu, 8 Oct 2009 21:18:30 +0200 Subject: [PATCH 3/7] Fix up header file names in util.h and add sssd-i18n.h --- server/util/util.h |9 ++--- 1 files changed, 6 insertions(+)

[SSSD] [PATCH] Fix potential memory leaks in the data provider

2009-10-21 Thread Martin Nagy
Martin >From 24ce0899d4c0d71f5e1045d726d7461fdc6e4776 Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Thu, 17 Sep 2009 18:10:10 +0200 Subject: [PATCH 2/7] Fix potential memory leaks in the data provider --- server/providers/data_provider_be.c |6 -- 1 files changed, 4 insertions(+)

[SSSD] [PATCH] Use correct talloc context in sss_names_init()

2009-10-21 Thread Martin Nagy
Martin >From f48c6acde37d24dc1cd5cb3d09df76457e8aecfa Mon Sep 17 00:00:00 2001 From: Martin Nagy Date: Tue, 13 Oct 2009 13:36:28 +0200 Subject: [PATCH 1/7] Use correct talloc context in sss_names_init() --- server/util/usertools.c |4 ++-- 1 files changed, 2 insertions(+), 2 deleti

Re: [SSSD] [PATCH] User home directories management

2009-10-21 Thread Martin Nagy
Hi, sorry, I accidentally sent the email too early. I'll continue where I left, see below. On Wed, 2009-10-21 at 06:39 +0200, Martin Nagy wrote: > On Tue, 2009-10-20 at 13:33 +0200, Jakub Hrozek wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > &g

Re: [SSSD] [PATCH] User home directories management

2009-10-20 Thread Martin Nagy
On Tue, 2009-10-20 at 13:33 +0200, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/19/2009 11:32 AM, Jakub Hrozek wrote: > > On 10/15/2009 04:18 PM, Jakub Hrozek wrote: > >> > User home directories management > >> > > >> > Create and populate user directories on use

Re: [SSSD] [PATCHES] Collection related patches

2009-09-18 Thread Martin Nagy
On Thu, 2009-09-17 at 19:21 +0200, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 09/17/2009 06:08 AM, Dmitri Pal wrote: > > Dmitri Pal wrote: > >> > See patch comments for details. > >> > All three are not massive. > >> > 1) Comparison and sorting collections > The s

Re: [SSSD] [PATCH] ELAPI: Fix dispatcher structure initialization

2009-09-16 Thread Martin Nagy
Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 09/16/2009 11:08 AM, Jakub Hrozek wrote: > > The memset size_t parameter was wrong and the async_ctx param was not > > manually zeroed resulting in random segfaults when the structure was freed. > > > > Jakub >

Re: [SSSD] [PATCH] fix return value of confdb_get_domains

2009-08-18 Thread Martin Nagy
On Tue, 2009-08-18 at 09:27 +0200, Sumit Bose wrote: > Hi, > > while testing Stephen's 'only one local domain' patch I found that if > the last configured domain is broken sssd terminates even if there valid > domains available. The following patch will fix this. > > bye, > Sumit Ack. Martin __

Re: [SSSD] [PATCH] Trace updates (Ticket 99)

2009-08-17 Thread Martin Nagy
Dmitri Pal wrote: > Addressing ticket: https://fedorahosted.org/sssd/ticket/99 > See comments in patch. > Ack. Martin ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Make "files" a reserved word for legacy local domain

2009-08-13 Thread Martin Nagy
On Thu, 2009-08-13 at 13:12 +0200, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 08/13/2009 10:02 AM, Martin Nagy wrote: > > Shouldn't you also check here if ctx->name is not "proxy" and the confdb > > parameter "libNam

Re: [SSSD] [PATCH] Make "files" a reserved word for legacy local domain

2009-08-13 Thread Martin Nagy
On Wed, 2009-08-12 at 19:27 +0200, Jakub Hrozek wrote: > +if (strcasecmp(ctx->name, "files") == 0) { > +DEBUG(5, ("Rewriting provider %s\n", ctx->name)); > + > +val[0] = "proxy"; > +ret = confdb_add_param(ctx->cdb, true, > + ctx->conf_path,

Re: [SSSD] [PATCH] Tools ID range fixes

2009-08-13 Thread Martin Nagy
On Wed, 2009-08-12 at 18:58 +0200, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Patch attached. Ack. Martin ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Fix startup race condition causing backend restarts

2009-08-10 Thread Martin Nagy
Dmitri Pal wrote: > Stephen Gallagher wrote: > > On 08/10/2009 08:36 AM, Dmitri Pal wrote: > > > Martin Nagy wrote: > > >> On Mon, 10 Aug 2009 06:52:11 -0400, Stephen Gallagher > > >> wrote: > > >> > > >> > > >>&g

Re: [SSSD] [PATCH] Fix startup race condition causing backend restarts

2009-08-10 Thread Martin Nagy
On Mon, 10 Aug 2009 06:52:11 -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 08/10/2009 03:38 AM, Martin Nagy wrote: > > On Fri, 07 Aug 2009 13:59:49 -0400, Stephen Gallagher > > wrote: > >> When the backends star

Re: [SSSD] [PATCH] Fix startup race condition causing backend restarts

2009-08-10 Thread Martin Nagy
On Fri, 07 Aug 2009 13:59:49 -0400, Stephen Gallagher wrote: > When the backends start up, the monitor was immediately sending a > getIdentity request. However, as we've added more processing to > the initialization routines over time, we started introducing > latency between when we open the conn