[SSSD] [sssd PR#644][comment] When multiple UIDs exist, use the username provided by the user as the first lookup

2018-10-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/644 Title: #644: When multiple UIDs exist, use the username provided by the user as the first lookup jhrozek commented: """ tbh my opinion is that the only workable option is to have a predictable order. Something like alphabetical sort,

[SSSD] [sssd PR#678][closed] files: add session recording flag

2018-10-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/678 Author: sumit-bose Title: #678: files: add session recording flag Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/678/head:pr678 git checkout pr678

[SSSD] [sssd PR#679][+Pushed] UTIL: Suppress Coverity warning

2018-10-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/679 Title: #679: UTIL: Suppress Coverity warning Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code

[SSSD] [sssd PR#679][comment] UTIL: Suppress Coverity warning

2018-10-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/679 Title: #679: UTIL: Suppress Coverity warning jhrozek commented: """ * master: fc29c3eb9750c5e7def4e1ab6eb18f4f5024f567 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#678][+Pushed] files: add session recording flag

2018-10-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/678 Title: #678: files: add session recording flag Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora

[SSSD] [sssd PR#678][comment] files: add session recording flag

2018-10-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/678 Title: #678: files: add session recording flag jhrozek commented: """ * master: 46c483c09b85cecf8d1cc72618da993d8948c894 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#679][closed] UTIL: Suppress Coverity warning

2018-10-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/679 Author: jhrozek Title: #679: UTIL: Suppress Coverity warning Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/679/head:pr679 git checkout pr679

[SSSD] [sssd PR#678][+Accepted] files: add session recording flag

2018-10-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/678 Title: #678: files: add session recording flag Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora

[SSSD] [sssd PR#678][comment] files: add session recording flag

2018-10-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/678 Title: #678: files: add session recording flag jhrozek commented: """ ACK. After the change, both a user specified in the session_recording section and a different user who is a member of a group specified in that section report thei

[SSSD] [sssd PR#679][opened] UTIL: Suppress Coverity warning

2018-10-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/679 Author: jhrozek Title: #679: UTIL: Suppress Coverity warning Action: opened PR body: """ We recently added this code: if (domain_name != NULL && is_files_provider(

[SSSD] [sssd PR#676][closed] sudo: sbus2 related crash

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/676 Author: pbrezina Title: #676: sudo: sbus2 related crash Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/676/head:pr676 git checkout pr676

[SSSD] [sssd PR#676][comment] sudo: sbus2 related crash

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/676 Title: #676: sudo: sbus2 related crash jhrozek commented: """ * master: * c74b430ba95d99b245b634732

[SSSD] [sssd PR#676][+Pushed] sudo: sbus2 related crash

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/676 Title: #676: sudo: sbus2 related crash Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of

[SSSD] [sssd PR#675][+Pushed] p11: Fix -Wmaybe-uninitialized in p11_child_openssl.c

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/675 Title: #675: p11: Fix -Wmaybe-uninitialized in p11_child_openssl.c Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#675][comment] p11: Fix -Wmaybe-uninitialized in p11_child_openssl.c

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/675 Title: #675: p11: Fix -Wmaybe-uninitialized in p11_child_openssl.c jhrozek commented: """ * master: 7794caec36e7142423491d90aaade7e49b9df1c1 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#675][closed] p11: Fix -Wmaybe-uninitialized in p11_child_openssl.c

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/675 Author: jhrozek Title: #675: p11: Fix -Wmaybe-uninitialized in p11_child_openssl.c Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/675/head:pr675 git checkout pr675

[SSSD] [sssd PR#674][closed] p11_child: add OCSP and CRL check ot the OpenSSL version

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/674 Author: sumit-bose Title: #674: p11_child: add OCSP and CRL check ot the OpenSSL version Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/674/head:pr674 git checkout pr674

[SSSD] [sssd PR#674][comment] p11_child: add OCSP and CRL check ot the OpenSSL version

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/674 Title: #674: p11_child: add OCSP and CRL check ot the OpenSSL version jhrozek commented: """ * master: 3c096c9ad6dad911d035cfdd8

[SSSD] [sssd PR#674][+Pushed] p11_child: add OCSP and CRL check ot the OpenSSL version

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/674 Title: #674: p11_child: add OCSP and CRL check ot the OpenSSL version Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#670][+Pushed] FILES: The files provider should not enumerate

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/670 Title: #670: FILES: The files provider should not enumerate Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#670][comment] FILES: The files provider should not enumerate

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/670 Title: #670: FILES: The files provider should not enumerate jhrozek commented: """ * master: 7b3794fbe5e4f0888d4faeba1

[SSSD] [sssd PR#670][closed] FILES: The files provider should not enumerate

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/670 Author: jhrozek Title: #670: FILES: The files provider should not enumerate Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/670/head:pr670 git checkout pr670

[SSSD] [sssd PR#661][+Pushed] TESTS: Add a test for whitespace trimming in netgroup entries

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/661 Title: #661: TESTS: Add a test for whitespace trimming in netgroup entries Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#661][closed] TESTS: Add a test for whitespace trimming in netgroup entries

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/661 Author: jhrozek Title: #661: TESTS: Add a test for whitespace trimming in netgroup entries Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/661/head:pr661 git checkout pr661

[SSSD] [sssd PR#661][comment] TESTS: Add a test for whitespace trimming in netgroup entries

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/661 Title: #661: TESTS: Add a test for whitespace trimming in netgroup entries jhrozek commented: """ * master: 941e67b0bbb780aadb6461b60b4e3554dfb893db') """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#667][comment] UTIL: rename & cleanup sysdb_error_to_errno

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/667 Title: #667: UTIL: rename & cleanup sysdb_error_to_errno jhrozek commented: """ Hey @mzidek-rh if you don't have any more comments, I'll just push this patch as it is. """ See the full comment at https://github.c

[SSSD] [sssd PR#674][comment] p11_child: add OCSP and CRL check ot the OpenSSL version

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/674 Title: #674: p11_child: add OCSP and CRL check ot the OpenSSL version jhrozek commented: """ OK, this builds even with a newer OpenSSL, looks like even in our internal CI. """ See the full comment at https://github.com/S

[SSSD] [sssd PR#674][+Accepted] p11_child: add OCSP and CRL check ot the OpenSSL version

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/674 Title: #674: p11_child: add OCSP and CRL check ot the OpenSSL version Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#677][+Changes requested] pcre: port to pcre2

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/677 Title: #677: pcre: port to pcre2 Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code

[SSSD] [sssd PR#677][comment] pcre: port to pcre2

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/677 Title: #677: pcre: port to pcre2 jhrozek commented: """ CI detected some memory leaks on RHEL-7: ``` =11224== 228 bytes in 1 blocks are possibly lost in loss record 256 of 384 ==11224==at 0x4C29BC3: malloc (vg_replace_malloc

[SSSD] [sssd PR#676][+Accepted] sudo: sbus2 related crash

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/676 Title: #676: sudo: sbus2 related crash Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of

[SSSD] [sssd PR#677][comment] pcre: port to pcre2

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/677 Title: #677: pcre: port to pcre2 jhrozek commented: """ (Hopefully CI will run automatically for you the next time..) """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#677][comment] pcre: port to pcre2

2018-10-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/677 Title: #677: pcre: port to pcre2 jhrozek commented: """ add to whitelist """ See the full comment at https://github.com/SSSD/sssd/pull/677#issuecomment-429936705 ___ sssd-de

[SSSD] [sssd PR#675][synchronized] p11: Fix -Wmaybe-uninitialized in p11_child_openssl.c

2018-10-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/675 Author: jhrozek Title: #675: p11: Fix -Wmaybe-uninitialized in p11_child_openssl.c Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/675/head:pr675 git checkout pr675 From

[SSSD] [sssd PR#675][comment] p11: Fix -Wmaybe-uninitialized in p11_child_openssl.c

2018-10-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/675 Title: #675: p11: Fix -Wmaybe-uninitialized in p11_child_openssl.c jhrozek commented: """ I didn't catch this, our internal Coverity instance attached to the RH update tool did. I don't know why the other instance we use for dif

[SSSD] [sssd PR#675][comment] p11: Fix -Wmaybe-uninitialized in p11_child_openssl.c

2018-10-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/675 Title: #675: p11: Fix -Wmaybe-uninitialized in p11_child_openssl.c jhrozek commented: """ btw there is another instance of this warning about the 's' variable. Looking at the code, I don't think it can happen that the variable will be

[SSSD] [sssd PR#675][opened] p11: Fix -Wmaybe-uninitialized in p11_child_openssl.c

2018-10-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/675 Author: jhrozek Title: #675: p11: Fix -Wmaybe-uninitialized in p11_child_openssl.c Action: opened PR body: """ If uri_str was passed to the p11_child and parsing the URI failed, then modules would be uninitialized, but freed in t

[SSSD] [sssd PR#673][+Pushed] PAM: return short name for files provider users

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/673 Title: #673: PAM: return short name for files provider users Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#673][closed] PAM: return short name for files provider users

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/673 Author: sumit-bose Title: #673: PAM: return short name for files provider users Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/673/head:pr673 git checkout pr673

[SSSD] [sssd PR#669][closed] test_config: Test for invalid character in domain

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/669 Author: thalman Title: #669: test_config: Test for invalid character in domain Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/669/head:pr669 git checkout pr669

[SSSD] [sssd PR#669][+Pushed] test_config: Test for invalid character in domain

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/669 Title: #669: test_config: Test for invalid character in domain Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#669][comment] test_config: Test for invalid character in domain

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/669 Title: #669: test_config: Test for invalid character in domain jhrozek commented: """ * master: 7a2e56d061085c155a51253bd612255a4d24cb57 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#668][+Pushed] pam_sss: add try_cert_auth and require_cert_auth options

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/668 Title: #668: pam_sss: add try_cert_auth and require_cert_auth options Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#668][comment] pam_sss: add try_cert_auth and require_cert_auth options

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/668 Title: #668: pam_sss: add try_cert_auth and require_cert_auth options jhrozek commented: """ * master: 4a22fb6bba6662ad628f6e172

[SSSD] [sssd PR#668][closed] pam_sss: add try_cert_auth and require_cert_auth options

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/668 Author: sumit-bose Title: #668: pam_sss: add try_cert_auth and require_cert_auth options Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/668/head:pr668 git checkout pr668

[SSSD] [sssd PR#668][+Accepted] pam_sss: add try_cert_auth and require_cert_auth options

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/668 Title: #668: pam_sss: add try_cert_auth and require_cert_auth options Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#673][+Accepted] PAM: return short name for files provider users

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/673 Title: #673: PAM: return short name for files provider users Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#673][comment] PAM: return short name for files provider users

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/673 Title: #673: PAM: return short name for files provider users jhrozek commented: """ Thank, you, tested using: ``` sssctl user-checks --action=auth --service=pam_cert_service "" ``` Before the patch I got: ``` pam_authenticate

[SSSD] [sssd PR#667][comment] UTIL: rename & cleanup sysdb_error_to_errno

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/667 Title: #667: UTIL: rename & cleanup sysdb_error_to_errno jhrozek commented: """ This works for me. @mzidek-rh what do you think? """ See the full comment at https://github.com/SSSD/ss

[SSSD] [sssd PR#670][comment] FILES: The files provider should not enumerate

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/670 Title: #670: FILES: The files provider should not enumerate jhrozek commented: """ I pushed a new version that should hopefully pass the CI """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#670][synchronized] FILES: The files provider should not enumerate

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/670 Author: jhrozek Title: #670: FILES: The files provider should not enumerate Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/670/head:pr670 git checkout pr670 From

[SSSD] [sssd PR#671][comment] PAM: use PKCS#11 URIs to restrict certificate selection

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/671 Title: #671: PAM: use PKCS#11 URIs to restrict certificate selection jhrozek commented: """ All these patches were added to PR #668 so we can close this one as superseded, right? (I would prefer to close this one because #668 has al

[SSSD] [sssd PR#668][comment] pam_sss: add try_cert_auth and require_cert_auth options

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/668 Title: #668: pam_sss: add try_cert_auth and require_cert_auth options jhrozek commented: """ The testing was relatively minimal, but I confirmed that with an incorrect URI, I can't log in and with the correct URI I can. So

[SSSD] [sssd PR#668][comment] pam_sss: add try_cert_auth and require_cert_auth options

2018-10-10 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/668 Title: #668: pam_sss: add try_cert_auth and require_cert_auth options jhrozek commented: """ btw CI passed """ See the full comment at https://github.com/SSSD/sssd/pull/668#issuecomment-428463734 __

[SSSD] [sssd PR#671][comment] PAM: use PKCS#11 URIs to restrict certificate selection

2018-10-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/671 Title: #671: PAM: use PKCS#11 URIs to restrict certificate selection jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#672][+Changes requested] testlib/utils: use SSSDException and decode str to bytes.

2018-10-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/672 Title: #672: testlib/utils: use SSSDException and decode str to bytes. Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#672][comment] testlib/utils: use SSSDException and decode str to bytes.

2018-10-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/672 Title: #672: testlib/utils: use SSSDException and decode str to bytes. jhrozek commented: """ I have two comments: 1. as usual, the patch needs to be split :) There should be one patch that changes the exception and another patch that

[SSSD] [sssd PR#668][comment] pam_sss: add try_cert_auth and require_cert_auth options

2018-10-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/668 Title: #668: pam_sss: add try_cert_auth and require_cert_auth options jhrozek commented: """ I'm sorry for the delay. The code looks good, the smart card login works well, try_cert_auth kicks me out without a smart card, require_

[SSSD] [sssd PR#650][+Changes requested] Implement a hybrid mode of generating private groups

2018-10-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#650][comment] Implement a hybrid mode of generating private groups

2018-10-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups jhrozek commented: """ Welp, it's a good thing we haven't pushed the patches yet. They don't do what the customer wants. """ See the full comment at htt

[SSSD] [sssd PR#650][-Blocked] Implement a hybrid mode of generating private groups

2018-10-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups Label: -Blocked ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#650][-Accepted] Implement a hybrid mode of generating private groups

2018-10-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#667][comment] UTIL: rename & cleanup sysdb_error_to_errno

2018-10-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/667 Title: #667: UTIL: rename & cleanup sysdb_error_to_errno jhrozek commented: """ Aah, now I know what you mean. Yes, I agree that the numerical code is preferable over the dependency. """ See the full comment at htt

[SSSD] [sssd PR#670][comment] FILES: The files provider should not enumerate

2018-10-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/670 Title: #670: FILES: The files provider should not enumerate jhrozek commented: """ btw the reasons I chose to add multi host tests are: - I think we should get familiar with this framework as it's the only way we'll be able to add mor

[SSSD] [sssd PR#670][synchronized] FILES: The files provider should not enumerate

2018-10-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/670 Author: jhrozek Title: #670: FILES: The files provider should not enumerate Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/670/head:pr670 git checkout pr670 From

[SSSD] [sssd PR#670][opened] FILES: The files provider should not enumerate

2018-10-09 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/670 Author: jhrozek Title: #670: FILES: The files provider should not enumerate Action: opened PR body: """ Resolves: https://pagure.io/SSSD/sssd/issue/3849 For reason I cannot explain now, the files provider always enumerates. There is

[SSSD] [sssd PR#667][comment] UTIL: rename & cleanup sysdb_error_to_errno

2018-10-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/667 Title: #667: UTIL: rename & cleanup sysdb_error_to_errno jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/667#issuecomment-427954911

[SSSD] [sssd PR#667][comment] UTIL: rename & cleanup sysdb_error_to_errno

2018-10-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/667 Title: #667: UTIL: rename & cleanup sysdb_error_to_errno jhrozek commented: """ On Mon, Oct 08, 2018 at 01:56:37AM -0700, Tomáš Halman wrote: > @mzidek-rh, @jhrozek PR updated, I moved #define to sysdb.h. I also did the >

[SSSD] [sssd PR#650][comment] Implement a hybrid mode of generating private groups

2018-10-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups jhrozek commented: """ I'm adding blocked just to remind me that this shouldn't be pushed until we get a confirmation from the customer. """ See the full

[SSSD] [sssd PR#650][+Blocked] Implement a hybrid mode of generating private groups

2018-10-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups Label: +Blocked ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#665][closed] p11: handle multiple certs during auth with OpenSSL

2018-10-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/665 Author: sumit-bose Title: #665: p11: handle multiple certs during auth with OpenSSL Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/665/head:pr665 git checkout pr665

[SSSD] [sssd PR#665][+Pushed] p11: handle multiple certs during auth with OpenSSL

2018-10-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/665 Title: #665: p11: handle multiple certs during auth with OpenSSL Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#662][comment] doc: Add nsswitch.conf note to manpage

2018-10-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/662 Title: #662: doc: Add nsswitch.conf note to manpage jhrozek commented: """ * master: 0be037bbedd0aed6a7eccead6aabe0d07258242a """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#662][closed] doc: Add nsswitch.conf note to manpage

2018-10-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/662 Author: thalman Title: #662: doc: Add nsswitch.conf note to manpage Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/662/head:pr662 git checkout pr662

[SSSD] [sssd PR#665][comment] p11: handle multiple certs during auth with OpenSSL

2018-10-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/665 Title: #665: p11: handle multiple certs during auth with OpenSSL jhrozek commented: """ * master: e29b82077a78157a1e4d90e2308c1272d7612f3d """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#662][+Accepted] doc: Add nsswitch.conf note to manpage

2018-10-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/662 Title: #662: doc: Add nsswitch.conf note to manpage Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#662][comment] doc: Add nsswitch.conf note to manpage

2018-10-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/662 Title: #662: doc: Add nsswitch.conf note to manpage jhrozek commented: """ Before adding the Accepted label, I'd like like to ask @justin-stephenson for a spot-check of the grammar as neither of us is a native English speaker. &q

[SSSD] [sssd PR#650][comment] Implement a hybrid mode of generating private groups

2018-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups jhrozek commented: """ Thank you for the review. I would like to wait a bit before pushing the patches to make sure the patches get tested by the customer who act

[SSSD] [sssd PR#665][+Accepted] p11: handle multiple certs during auth with OpenSSL

2018-10-04 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/665 Title: #665: p11: handle multiple certs during auth with OpenSSL Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#667][comment] WIP, do not merge, UTIL: rename & cleanup sysdb_error_to_errno

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/667 Title: #667: WIP, do not merge, UTIL: rename & cleanup sysdb_error_to_errno jhrozek commented: """ > On 3 Oct 2018, at 13:23, mzidek-rh wrote: > > Hi, the patches look good and in general I have no problem accepti

[SSSD] [sssd PR#667][comment] UTIL: rename & cleanup sysdb_error_to_errno

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/667 Title: #667: UTIL: rename & cleanup sysdb_error_to_errno jhrozek commented: """ btw this PR should also include another patch (I know it's not specified in the ticket, but it was actually the reason we created the ticket). There

[SSSD] [sssd PR#657][comment] be: use be_is_offline for the main domain when asking for domain status

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/657 Title: #657: be: use be_is_offline for the main domain when asking for domain status jhrozek commented: """ * master: dfa7bf1133f002a9fbbd3495a70909913db25b16 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#657][+Pushed] be: use be_is_offline for the main domain when asking for domain status

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/657 Title: #657: be: use be_is_offline for the main domain when asking for domain status Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#657][closed] be: use be_is_offline for the main domain when asking for domain status

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/657 Author: pbrezina Title: #657: be: use be_is_offline for the main domain when asking for domain status Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/657/head:pr657 git checkout

[SSSD] [sssd PR#663][comment] confdb: log an error when domain is misconfigured

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/663 Title: #663: confdb: log an error when domain is misconfigured jhrozek commented: """ * master: 081b18e75c746f9a2ad1fb412c825293090311f8 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#663][closed] confdb: log an error when domain is misconfigured

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/663 Author: thalman Title: #663: confdb: log an error when domain is misconfigured Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/663/head:pr663 git checkout pr663

[SSSD] [sssd PR#663][+Pushed] confdb: log an error when domain is misconfigured

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/663 Title: #663: confdb: log an error when domain is misconfigured Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#664][+Pushed] pep8: Ignore W504 and W605 to silence warnings on Debian

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/664 Title: #664: pep8: Ignore W504 and W605 to silence warnings on Debian Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#664][closed] pep8: Ignore W504 and W605 to silence warnings on Debian

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/664 Author: jhrozek Title: #664: pep8: Ignore W504 and W605 to silence warnings on Debian Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/664/head:pr664 git checkout pr664

[SSSD] [sssd PR#664][comment] pep8: Ignore W504 and W605 to silence warnings on Debian

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/664 Title: #664: pep8: Ignore W504 and W605 to silence warnings on Debian jhrozek commented: """ * master:ec7665973936897ab6be58308e655f08d91bec5c * sssd-1-16: bca1935761a8ac21a45abcda9f82feec259dc65c """ See the full comme

[SSSD] [sssd PR#666][+Pushed] ci: add http-parser-devel for Fedora

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/666 Title: #666: ci: add http-parser-devel for Fedora Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora

[SSSD] [sssd PR#666][closed] ci: add http-parser-devel for Fedora

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/666 Author: sumit-bose Title: #666: ci: add http-parser-devel for Fedora Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/666/head:pr666 git checkout pr666

[SSSD] [sssd PR#666][comment] ci: add http-parser-devel for Fedora

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/666 Title: #666: ci: add http-parser-devel for Fedora jhrozek commented: """ * master: e18c67c38a3f645549ebd5117b49a4d3e1c94018 """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#650][comment] Implement a hybrid mode of generating private groups

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups jhrozek commented: """ Thank you, the fixups were squashed """ See the full comment at https://github.com/SSSD/sssd/p

[SSSD] [sssd PR#650][synchronized] Implement a hybrid mode of generating private groups

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Author: jhrozek Title: #650: Implement a hybrid mode of generating private groups Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/650/head:pr650 git checkout pr650 From

[SSSD] [sssd PR#650][-Changes requested] Implement a hybrid mode of generating private groups

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#650][synchronized] Implement a hybrid mode of generating private groups

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Author: jhrozek Title: #650: Implement a hybrid mode of generating private groups Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/650/head:pr650 git checkout pr650 From

[SSSD] [sssd PR#662][+Changes requested] doc: Add nsswitch.conf note to manpage

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/662 Title: #662: doc: Add nsswitch.conf note to manpage Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#663][+Accepted] confdb: log an error when domain is misconfigured

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/663 Title: #663: confdb: log an error when domain is misconfigured Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#665][comment] p11: handle multiple certs during auth with OpenSSL

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/665 Title: #665: p11: handle multiple certs during auth with OpenSSL jhrozek commented: """ Just for my education, how does this work together with https://github.com/SSSD/sssd/blob/4ff183ecbe4d8e70715eee186f1fedecc335163

<    6   7   8   9   10   11   12   13   14   15   >