[SSSD] [sssd PR#5653][synchronized] kcm: use %zu as format for size_t

2021-05-25 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5653 Author: sumit-bose Title: #5653: kcm: use %zu as format for size_t Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5653/head:pr5653 git checkout pr5653 From

[SSSD] [sssd PR#5661][opened] pam: change default for pam_response_filter

2021-05-28 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5661 Author: sumit-bose Title: #5661: pam: change default for pam_response_filter Action: opened PR body: """ So far pam_response_filter didn't had any default. It turned out that it would be useful to filter the environment va

[SSSD] [sssd PR#5647][comment] krb5_child: Honor Kerberos keytab location

2021-05-31 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5647 Title: #5647: krb5_child: Honor Kerberos keytab location sumit-bose commented: """ Hi, thank you for the new version, this is a valid solution. However I would like to ask you for another change. I wonder if you can just add

[SSSD] [sssd PR#5664][opened] pac: allow larger PACs

2021-05-31 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5664 Author: sumit-bose Title: #5664: pac: allow larger PACs Action: opened PR body: """ Currently the PAC responder only accepts request which are about 1k in size. Since a PAC can be larger there are cases where the PAC is not acce

[SSSD] [sssd PR#5652][comment] pac: allow larger PACs

2021-05-31 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5652 Title: #5652: pac: allow larger PACs sumit-bose commented: """ > There was conflict on 1.16, please open a separate PR for that. Hi, please see https://github.com/SSSD/sssd/pull/5664 which backports a couple of dependent pat

[SSSD] [sssd PR#5664][edited] pac: allow larger PACs - 1-16

2021-05-31 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5664 Author: sumit-bose Title: #5664: pac: allow larger PACs - 1-16 Action: edited Changed field: title Original value: """ pac: allow larger PACs """ ___ sssd-de

[SSSD] [sssd PR#5664][comment] pac: allow larger PACs - 1-16

2021-06-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5664 Title: #5664: pac: allow larger PACs - 1-16 sumit-bose commented: """ Hi, yes, my initial test implementation looked similar to 1a24261. However I was wondering if it wouldn't be better to have more similar code in sssd-1-16

[SSSD] [sssd PR#5552][synchronized] files: split update into batches

2021-06-02 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Author: sumit-bose Title: #5552: files: split update into batches Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5552/head:pr5552 git checkout pr5552 From

[SSSD] [sssd PR#5552][comment] files: split update into batches

2021-06-02 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Title: #5552: files: split update into batches sumit-bose commented: """ Hi, in the latest version I added a patch which implements a fallback to the next nss module in case the files provider backend is busy with updating the da

[SSSD] [sssd PR#5552][-Changes requested] files: split update into batches

2021-06-02 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Title: #5552: files: split update into batches Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.or

[SSSD] [sssd PR#5552][+Waiting for review] files: split update into batches

2021-06-02 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Title: #5552: files: split update into batches Label: +Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o

[SSSD] [sssd PR#5633][+Accepted] Gentoo/openrc: Add sssd-kcm service script

2021-06-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5633 Title: #5633: Gentoo/openrc: Add sssd-kcm service script Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o

[SSSD] [sssd PR#5633][comment] Gentoo/openrc: Add sssd-kcm service script

2021-06-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5633 Title: #5633: Gentoo/openrc: Add sssd-kcm service script sumit-bose commented: """ Hi, thanks, since there are no further comments, ACK. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5654][comment] test: replace deprecated libcheck macros

2021-06-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5654 Title: #5654: test: replace deprecated libcheck macros sumit-bose commented: """ > Thank you for the patches. I agree in general. > > I only have a questions about `sss_ck_fail_if_msg`: > > * `_ck_assert_failed` th

[SSSD] [sssd PR#5647][comment] krb5_child: Honor Kerberos keytab location

2021-06-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5647 Title: #5647: krb5_child: Honor Kerberos keytab location sumit-bose commented: """ Hi, thanks for the update and the comments. I'm fine with the code and the patch works for me, so ACK. Let me just wait for the CI before set

[SSSD] [sssd PR#5661][synchronized] pam: change default for pam_response_filter

2021-06-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5661 Author: sumit-bose Title: #5661: pam: change default for pam_response_filter Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5661/head:pr5661 git checkout pr5661 From

[SSSD] [sssd PR#5661][comment] pam: change default for pam_response_filter

2021-06-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5661 Title: #5661: pam: change default for pam_response_filter sumit-bose commented: """ Hi, thanks for the review, I added the missing space in the latest version. bye, Sumit """ See the full comment at https://

[SSSD] [sssd PR#5647][comment] krb5_child: Honor Kerberos keytab location

2021-06-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5647 Title: #5647: krb5_child: Honor Kerberos keytab location sumit-bose commented: """ Hi @elkoniu, can you check if you can reproduce the integration check failure on F34 locally? bye, Sumit """ See the full comment at

[SSSD] [sssd PR#5620][comment] Link frontend to backend requests

2021-06-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5620 Title: #5620: Link frontend to backend requests sumit-bose commented: """ Hi, thanks for you patience, I'm fine with the patch, even on its own it might already help to follow individual requests better through the logs of differ

[SSSD] [sssd PR#5620][-Waiting for review] Link frontend to backend requests

2021-06-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5620 Title: #5620: Link frontend to backend requests Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.

[SSSD] [sssd PR#5620][+Accepted] Link frontend to backend requests

2021-06-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5620 Title: #5620: Link frontend to backend requests Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora

[SSSD] [sssd PR#5647][comment] krb5_child: Honor Kerberos keytab location

2021-06-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5647 Title: #5647: krb5_child: Honor Kerberos keytab location sumit-bose commented: """ Hi, thanks for the fix, ACK. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5647][-Waiting for review] krb5_child: Honor Kerberos keytab location

2021-06-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5647 Title: #5647: krb5_child: Honor Kerberos keytab location Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedo

[SSSD] [sssd PR#5647][+Accepted] krb5_child: Honor Kerberos keytab location

2021-06-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5647 Title: #5647: krb5_child: Honor Kerberos keytab location Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o

[SSSD] Re: sssd-ldap build failing on ubuntu 20.04

2021-06-08 Thread Sumit Bose
Am Tue, Jun 08, 2021 at 05:38:14PM + schrieb burnmydread: > Hello, > I am working on building sssd-ldap on ubuntu and I am hitting a failure that > I don't see documented anywhere. Here is my setup: > Distro: ubuntu-20.04 > sssd: sssd-2.2.3 > automake: autoconf (GNU Autoconf) 2.69 > (I got the

[SSSD] [sssd PR#5675][comment] KCM: Unset _SSS_LOOPS

2021-06-10 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5675 Title: #5675: KCM: Unset _SSS_LOOPS sumit-bose commented: """ Hi, I think `sssd_kcm` does not have to set `_SSS_LOOPS`. The variable was added to prevent an SSSD component to call into SSSD with the same request again, e.g. a

[SSSD] [sssd PR#5683][comment] Fix log levels

2021-06-14 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5683 Title: #5683: Fix log levels sumit-bose commented: """ Hi, thanks for the patches, I just had a minor comment, but if you prefer the current version I'm fine as well. As a general question, not related to the patch. Do you thi

[SSSD] [sssd PR#5552][synchronized] files: split update into batches

2021-06-15 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Author: sumit-bose Title: #5552: files: split update into batches Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5552/head:pr5552 git checkout pr5552 From

[SSSD] [sssd PR#5683][-Waiting for review] Fix log levels

2021-06-15 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5683 Title: #5683: Fix log levels Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of

[SSSD] [sssd PR#5683][+Accepted] Fix log levels

2021-06-15 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5683 Title: #5683: Fix log levels Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct:

[SSSD] [sssd PR#5684][comment] src/conf_macros.m4: set default value /run for pidpath

2021-06-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5684 Title: #5684: src/conf_macros.m4: set default value /run for pidpath sumit-bose commented: """ > Where can I see the detailed failure logs, please? Hi, the failures happen during the integration tests and can be seen in the `ci-

[SSSD] [sssd PR#5683][comment] Fix log levels

2021-06-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5683 Title: #5683: Fix log levels sumit-bose commented: """ > > Not sure if we want to use IMPORTANT_INFO for unimplemented operation. That > > means its going to be always visible in the logs, we certainly don't want >

[SSSD] [sssd PR#5683][comment] Fix log levels

2021-06-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5683 Title: #5683: Fix log levels sumit-bose commented: """ Hi, I'm fine with minor failure, @pbrezina feel free to give the final ACK. bye, Sumit """ See the full comment at https://github.com/SSSD/ss

[SSSD] [sssd PR#5552][synchronized] files: split update into batches

2021-06-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Author: sumit-bose Title: #5552: files: split update into batches Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5552/head:pr5552 git checkout pr5552 From

[SSSD] [sssd PR#5552][comment] files: split update into batches

2021-06-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Title: #5552: files: split update into batches sumit-bose commented: """ Hi, in the latest version a copy-and-paste error which caused one test failure is fixed and the new `fallback_to_nss = False` option is added to more tests which

[SSSD] [sssd PR#5552][comment] files: split update into batches

2021-06-20 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Title: #5552: files: split update into batches sumit-bose commented: """ Hi, thanks for testing and reviewing, yes `batch_size` should be larger, I think `1000` would be ok. @elkoniu, do you, by chance, have a second domain in `sss

[SSSD] [sssd PR#5552][synchronized] files: split update into batches

2021-06-23 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Author: sumit-bose Title: #5552: files: split update into batches Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5552/head:pr5552 git checkout pr5552 From

[SSSD] [sssd PR#5552][comment] files: split update into batches

2021-06-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Title: #5552: files: split update into batches sumit-bose commented: """ Hi @elkoniu, thank you for the latest tests, what still makes me wonder is that if I run one of those tests I see: ``` # time for N in `seq 500`; do usera

[SSSD] [sssd PR#5552][synchronized] files: split update into batches

2021-06-25 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Author: sumit-bose Title: #5552: files: split update into batches Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5552/head:pr5552 git checkout pr5552 From

[SSSD] [sssd PR#5552][comment] files: split update into batches

2021-06-25 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Title: #5552: files: split update into batches sumit-bose commented: """ Hi, thanks for the logs, they made me realize that my test environment is so old that `useradd` does not call `sss_cache` and this is blocked because `ldb_tr

[SSSD] [sssd PR#5552][synchronized] files: split update into batches

2021-06-30 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Author: sumit-bose Title: #5552: files: split update into batches Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5552/head:pr5552 git checkout pr5552 From

[SSSD] [sssd PR#5552][comment] files: split update into batches

2021-06-30 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Title: #5552: files: split update into batches sumit-bose commented: """ > There are several minor covscan issues: > https://cov01.lab.eng.brq.redhat.com/covscanhub/task/223840/log/added.err > (sorry for the private link)

[SSSD] [sssd PR#5552][comment] files: split update into batches

2021-06-30 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Title: #5552: files: split update into batches sumit-bose commented: """ Hi, the latest version contains fixes for @alexey-tikhonov's review comments, I'll try to understand what is happening in @elkoniu latest test now.

[SSSD] [sssd PR#5552][synchronized] files: split update into batches

2021-07-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Author: sumit-bose Title: #5552: files: split update into batches Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5552/head:pr5552 git checkout pr5552 From

[SSSD] [sssd PR#5552][synchronized] files: split update into batches

2021-07-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Author: sumit-bose Title: #5552: files: split update into batches Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5552/head:pr5552 git checkout pr5552 From

[SSSD] [sssd PR#5552][comment] files: split update into batches

2021-07-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Title: #5552: files: split update into batches sumit-bose commented: """ > I have one strange observation but I am not sure if it is related to batching > process. > > Steeps: > > 1. Add 100 users calling use

[SSSD] [sssd PR#5552][comment] files: split update into batches

2021-07-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Title: #5552: files: split update into batches sumit-bose commented: """ Hi, I think the latest issues you've found are not strictly related to the patches. The reason is that if there are many users and groups in the cache

[SSSD] [sssd PR#5552][synchronized] files: split update into batches

2021-07-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Author: sumit-bose Title: #5552: files: split update into batches Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5552/head:pr5552 git checkout pr5552 From

[SSSD] [sssd PR#5552][comment] files: split update into batches

2021-07-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5552 Title: #5552: files: split update into batches sumit-bose commented: """ Hi, the latest version just adds the `:config:` tag for the new option. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5698][opened] man: clarify effects of sss_cache on the memory cache

2021-07-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5698 Author: sumit-bose Title: #5698: man: clarify effects of sss_cache on the memory cache Action: opened PR body: """ Resolves: https://github.com/SSSD/sssd/issues/5697 """ To pull the PR as Git branch: git remote add

[SSSD] [sssd PR#5698][comment] man: clarify effects of sss_cache on the memory cache

2021-07-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5698 Title: #5698: man: clarify effects of sss_cache on the memory cache sumit-bose commented: """ Hi, if you think something is missing feel free to close this PR and use it as the basis for a new one. bye, Sumit """

[SSSD] [sssd PR#5731][opened] simple: fix memory leak while reloading lists - 1.16

2021-08-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5731 Author: sumit-bose Title: #5731: simple: fix memory leak while reloading lists - 1.16 Action: opened PR body: """ The simple access provider will reload the access and deny lists at runtime to make sure that users and groups from do

[SSSD] [sssd PR#5732][opened] AD: do not override LDAP data during GC lookups - 1.16

2021-08-01 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5732 Author: sumit-bose Title: #5732: AD: do not override LDAP data during GC lookups - 1.16 Action: opened PR body: """ The Global Catalog contains user and group information of the whole forest and hence any Global Catalog server can be

[SSSD] [sssd PR#5705][comment] p11_child: do_card fix loop exit condition

2021-08-02 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5705 Title: #5705: p11_child: do_card fix loop exit condition sumit-bose commented: """ Hi, thanks for the patch, I agree with the change. I would like to ask you to update the commit message a bit. First, please says `partially fixes

[SSSD] [sssd PR#5705][comment] p11_child: do_card partially fix loop exit condition

2021-08-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5705 Title: #5705: p11_child: do_card partially fix loop exit condition sumit-bose commented: """ > @sumit-bose Unfortunately I accidentally made this PR an orphan, so I cannot > update the commit or push new commits. What do you wa

[SSSD] [sssd PR#5722][comment] NSS client: avoid using NETDB_INTERNAL if daemon is not available

2021-08-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5722 Title: #5722: NSS client: avoid using NETDB_INTERNAL if daemon is not available sumit-bose commented: """ Hi, thanks for the patch. According to the comment https://sourceware.org/git/?p=glibc.git;a=blob;f=resolv/nss_d

[SSSD] [sssd PR#844][comment] sssd-ad and gpo_child: GPO apply fixes during reading fails

2021-08-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/844 Title: #844: sssd-ad and gpo_child: GPO apply fixes during reading fails sumit-bose commented: """ Hi @mastersin, I wonder if you can consider to revive this pull-request or open a new one with your patches. They have very helpful

[SSSD] [sssd PR#5731][synchronized] simple: fix memory leak while reloading lists - 1.16

2021-08-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5731 Author: sumit-bose Title: #5731: simple: fix memory leak while reloading lists - 1.16 Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5731/head:pr5731 git checkout pr5731

[SSSD] [sssd PR#5731][comment] simple: fix memory leak while reloading lists - 1.16

2021-08-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5731 Title: #5731: simple: fix memory leak while reloading lists - 1.16 sumit-bose commented: """ Hi, sorry, looks like I picked it from my own branch and not from master, new version fixes it. bye, Sumit """ See the full

[SSSD] [sssd PR#5731][+Waiting for review] simple: fix memory leak while reloading lists - 1.16

2021-08-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5731 Title: #5731: simple: fix memory leak while reloading lists - 1.16 Label: +Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@

[SSSD] [sssd PR#5731][-Changes requested] simple: fix memory leak while reloading lists - 1.16

2021-08-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5731 Title: #5731: simple: fix memory leak while reloading lists - 1.16 Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@l

[SSSD] [sssd PR#5739][comment] backport cldap patches to 1.16

2021-08-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5739 Title: #5739: backport cldap patches to 1.16 sumit-bose commented: """ Hi, backport is looking good. @pbrezina, there is a a man page fix in the original patch set (a62a13ae61d4e08b21e706df6ca266c38891f430) as well, but I ass

[SSSD] [sssd PR#5739][comment] backport cldap patches to 1.16

2021-08-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5739 Title: #5739: backport cldap patches to 1.16 sumit-bose commented: """ > It isn't directly related to the issue and I didn't want to change strings. Thanks, ACK. """ See the full comment at https://

[SSSD] [sssd PR#5739][-Waiting for review] backport cldap patches to 1.16

2021-08-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5739 Title: #5739: backport cldap patches to 1.16 Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#5739][+Accepted] backport cldap patches to 1.16

2021-08-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5739 Title: #5739: backport cldap patches to 1.16 Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Co

[SSSD] [sssd PR#5739][comment] backport cldap patches to 1.16

2021-08-11 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5739 Title: #5739: backport cldap patches to 1.16 sumit-bose commented: """ > Do we need to backport #5743 as well? Hi, I think is this not needed for RHEL or Fedora since CLDAP is enabled in OpenLDAP on those platforms, but in g

[SSSD] [sssd PR#5745][opened] cache_req: cache_first fix for fully-qualified names

2021-08-12 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5745 Author: sumit-bose Title: #5745: cache_req: cache_first fix for fully-qualified names Action: opened PR body: """ With commit b572871236a7f9059d375a5ab1bff8cbfd519956 "cache_req: introduce cache_behavior enumeration" th

[SSSD] [sssd PR#5734][comment] MONITOR: Return success from genconf with no config

2021-08-12 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5734 Title: #5734: MONITOR: Return success from genconf with no config sumit-bose commented: """ > @sumit-bose Would you mind giving ack for this? Hi, I'm fine with the fix, so ACK from my side. But since I'm a bit biased it

[SSSD] [sssd PR#5746][comment] p11_child: do_card partially fix loop exit condition (redo of #5705)

2021-08-17 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5746 Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705) sumit-bose commented: """ Hi, thanks for the patch, the commit message is looking good now. ACK bye, Sumit """ See the full comment at

[SSSD] [sssd PR#5746][+Accepted] p11_child: do_card partially fix loop exit condition (redo of #5705)

2021-08-17 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5746 Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705) Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel

[SSSD] [sssd PR#5734][comment] MONITOR: Return success from genconf with no config

2021-08-18 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5734 Title: #5734: MONITOR: Return success from genconf with no config sumit-bose commented: """ Hi, since Alexey agrees with the patch and I'm fine with the now version as well, ACK. bye, Sumit """ See the full comme

[SSSD] [sssd PR#5734][+Accepted] MONITOR: Return success from genconf with no config

2021-08-18 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5734 Title: #5734: MONITOR: Return success from genconf with no config Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedor

[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility

2021-08-18 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility sumit-bose commented: """ Hi Scott, thanks for the latest updates. I think the log lines from `accept_fd_handler` e.g. 2021-08-18 10:36:3

[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility

2021-08-18 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility sumit-bose commented: """ Hi Justin, thanks for the latest updates. I think the log lines from `accept_fd_handler` e.g. 2021-08-18 10:36:3

[SSSD] [sssd PR#5746][comment] p11_child: do_card partially fix loop exit condition (redo of #5705)

2021-08-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5746 Title: #5746: p11_child: do_card partially fix loop exit condition (redo of #5705) sumit-bose commented: """ Hi, thanks for the hint, I have to admit that I didn't test the patch with `wait_for_card`. @assafmo, would you like

[SSSD] [sssd PR#5760][comment] p11_child: Fixes for init_p11_ctx() and do_card()

2021-08-27 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5760 Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() sumit-bose commented: """ Hi, thank you for the update, code-wise I'm fine with the patches, I'd like to run some tests during the weekend and will give my

[SSSD] [sssd PR#5771][opened] sdap: always create sdap object for a forest root

2021-09-02 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5771 Author: sumit-bose Title: #5771: sdap: always create sdap object for a forest root Action: opened PR body: """ Even if the forest root is disabled for user and group lookups a sdap object is needed to lookup trusted domains. This a

[SSSD] [sssd PR#5760][comment] p11_child: Fixes for init_p11_ctx() and do_card()

2021-09-02 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5760 Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() sumit-bose commented: """ Hi, my testing went well. Now wait_for_card is working with multiple empty readers again. As before p11_child can only wait on a single rea

[SSSD] [sssd PR#5760][comment] p11_child: Fixes for init_p11_ctx() and do_card()

2021-09-02 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5760 Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() sumit-bose commented: """ > > > As before p11_child can only wait on a single reader, in the old version > > > it was the first, now it is the last.

[SSSD] [sssd PR#5760][comment] p11_child: Fixes for init_p11_ctx() and do_card()

2021-09-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5760 Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() sumit-bose commented: """ Hi, thanks for the update, the CI failures are not related, ACK. bye, Sumit """ See the full comment at https://github.com/SS

[SSSD] [sssd PR#5760][-Waiting for review] p11_child: Fixes for init_p11_ctx() and do_card()

2021-09-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5760 Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lis

[SSSD] [sssd PR#5760][+Accepted] p11_child: Fixes for init_p11_ctx() and do_card()

2021-09-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5760 Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card() Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorah

[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility

2021-09-14 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility sumit-bose commented: """ Hi, thanks for the updates. I think from now on every enhancement should be done not in this PR but in a new one. What I still fin

[SSSD] [sssd PR#5787][opened] krb5: fix ccache ownership for offline Smartcard authentication

2021-09-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5787 Author: sumit-bose Title: #5787: krb5: fix ccache ownership for offline Smartcard authentication Action: opened PR body: """ During Smartcard authentication/PKINIT the krb5_child process is running as privileged user for some time to

[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility

2021-09-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility sumit-bose commented: """ Hi, thanks for checking the help message, as long as this is the default behavior of argparse I'm fine. I build and installe

[SSSD] [sssd PR#5712][-Waiting for review] Health and Support Analyzer - Add request log parsing utility

2021-09-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-dev

[SSSD] [sssd PR#5712][+Accepted] Health and Support Analyzer - Add request log parsing utility

2021-09-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@l

[SSSD] [sssd PR#5788][opened] debug: suppress backtrace if GetAccountDomain() is not supported

2021-09-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5788 Author: sumit-bose Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported Action: opened PR body: """ The return code ERR_GET_ACCT_DOM_NOT_SUPPORTED is an expected return code if the backend does

[SSSD] [sssd PR#5791][opened] sysdb: more specific mpg search filter

2021-09-17 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5791 Author: sumit-bose Title: #5791: sysdb: more specific mpg search filter Action: opened PR body: """ Originally all user of an mpg domain had an automatically created user-private group and as a result the ID space was unified in t

[SSSD] [sssd PR#5791][synchronized] sysdb: more specific mpg search filter

2021-09-21 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5791 Author: sumit-bose Title: #5791: sysdb: more specific mpg search filter Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5791/head:pr5791 git checkout pr5791 From

[SSSD] [sssd PR#5791][comment] sysdb: more specific mpg search filter

2021-09-21 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5791 Title: #5791: sysdb: more specific mpg search filter sumit-bose commented: """ Hi Pavel, thanks for the review, I've fixed the typo and added a `:fixes:`. bye, Sumit """ See the full comment at https://github.c

[SSSD] [sssd PR#5771][synchronized] sdap: always create sdap object for a forest root

2021-09-21 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5771 Author: sumit-bose Title: #5771: sdap: always create sdap object for a forest root Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5771/head:pr5771 git checkout pr5771 From

[SSSD] [sssd PR#5771][comment] sdap: always create sdap object for a forest root

2021-09-21 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5771 Title: #5771: sdap: always create sdap object for a forest root sumit-bose commented: """ Hi Pavel, thanks for the review, I added a `:fixes:`. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pu

[SSSD] [sssd PR#5788][synchronized] debug: suppress backtrace if GetAccountDomain() is not supported

2021-09-23 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5788 Author: sumit-bose Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5788/head:pr5788 git

[SSSD] [sssd PR#5788][synchronized] debug: suppress backtrace if GetAccountDomain() is not supported

2021-09-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5788 Author: sumit-bose Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5788/head:pr5788 git

[SSSD] [sssd PR#5788][comment] debug: suppress backtrace if GetAccountDomain() is not supported

2021-09-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5788 Title: #5788: debug: suppress backtrace if GetAccountDomain() is not supported sumit-bose commented: """ > Patches look good to me. > But strictly speaking commit message of a first patch isn't correct anymore: > ba

[SSSD] [sssd PR#5771][synchronized] sdap: always create sdap object for a forest root

2021-09-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5771 Author: sumit-bose Title: #5771: sdap: always create sdap object for a forest root Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5771/head:pr5771 git checkout pr5771 From

[SSSD] [sssd PR#5771][comment] sdap: always create sdap object for a forest root

2021-09-24 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5771 Title: #5771: sdap: always create sdap object for a forest root sumit-bose commented: """ > There is a typo in the commit message: `:fixes: Even is the forest` -> > `:fixes: Even IF the forest` sorry, fixed in latest v

[SSSD] [sssd PR#5722][comment] NSS client: avoid using NETDB_INTERNAL if daemon is not available

2021-10-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5722 Title: #5722: NSS client: avoid using NETDB_INTERNAL if daemon is not available sumit-bose commented: """ > Hi @sumit-bose , did you have a chance to take a look at this? Hi, thanks for the reminder. I'm fine with

[SSSD] [sssd PR#5722][+Accepted] NSS client: avoid using NETDB_INTERNAL if daemon is not available

2021-10-04 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/5722 Title: #5722: NSS client: avoid using NETDB_INTERNAL if daemon is not available Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le.

<    2   3   4   5   6   7   8   9   10   11   >