d-and-tested-by: Muri Nicanor
Tested-by: Martin Hauke
Cc:
Fixes: e7181d005e84 ("USB: qcserial: Add support for HP lt4112 LTE/HSPA+ Gobi
4G Modem")
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/qcserial.c | 53 +++
1 file changed, 33 in
d-and-tested-by: Muri Nicanor
Tested-by: Martin Hauke
Cc:
Fixes: e7181d005e84 ("USB: qcserial: Add support for HP lt4112 LTE/HSPA+ Gobi
4G Modem")
Signed-off-by: Bjørn Mork
---
v2:
- respin with new context in v4.4-rc1
- fix checkpatch long-line warning
drivers/usb/serial/
for at.
The device works well with qmi and ModemManager-NetworkManager.
"
Reported-by: Thomas Schäfer
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 68
Greg Kroah-Hartman writes:
> 4.1-stable review patch. If anyone has any objections, please let me know.
>
> --
>
> From: =?UTF-8?q?Bj=C3=B8rn=20Mork?=
>
> [ Upstream commit 0db65fcfcded76fe4f74e3ca9f4e2baf67b683ef ]
>
> New device IDs shamelessly lifted from the vendor driver.
>
elessly lifted from the vendor driver.
>
> Signed-off-by: Bjørn Mork
> Signed-off-by: David S. Miller
> Signed-off-by: Luis Henriques
> ---
> drivers/net/usb/qmi_wwan.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net
Driver=option
E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I:* If#= 6 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage
E: Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
Cc:
Signed-off-by: Bjørn Mork
omeone reports
it.
For the qmi_wwan part:
Acked-by: Bjørn Mork
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 558adfc..569caf6 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
Combining net and usb patches in the sam
Dan Williams writes:
> On Wed, 2013-05-01 at 20:33 +0200, Bjørn Mork wrote:
>> Dan Williams writes:
>>
>> > A rebranded Novatel E371 for AT&T's LTE bands.
>>
>> I don't think we're handling the Novatel branded E371 yet? I tried
>>
liams
> ---
> drivers/net/usb/cdc_ether.c | 7 +++
> drivers/net/usb/qmi_wwan.c | 7 +++
> 2 files changed, 14 insertions(+)
Acked-by: Bjørn Mork
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to major
an unknown number of
similar devices.
Cc: stable
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index f7d339d..0ee8b8d 100644
--- a/drivers/
Bjørn Mork writes:
> + * CDC ACM with vendor specific protocol may signify RNDIS or
> + * serial or something else. A number of Huawei devices use
> + * it for serial functions having only 2 endpoints,
Arrgh. Please drop this patch.
I thought I had verified this over
Another device using CDC ACM with vendor specific protocol to mark
serial functions.
Cc: stable
Signed-off-by: Bjørn Mork
---
This replaces the patch titled
'USB: option: use vendor match for Huawei "ACM" devices'
by adding a new device specific entry instead.
I s
king already working systems. The long term plan is to remove
the list, not to add to it. Ref:
http://permalink.gmane.org/gmane.linux.usb.general/28543
Cc:
Cc: stable
Signed-off-by: Bjørn Mork
---
I just realized that this already had gone into maintained stable
series', making the fix so much
Ben Hutchings writes:
> On Mon, 2013-03-04 at 14:19 +0100, Bjørn Mork wrote:
> [...]
>> In-kernel mode switching was deprecated years ago with the
>> development of the more user friendly userspace alternatives. The
>> existing list of devices in usb-storage was only kep
use the same method the netdev people use when they want
to remove stuff: Subtly break it and leave it like that for a few years
before finally deleting it, arguing that noone can be using the feature
because it's broken :)
Bjørn
> On Mon, Mar 4, 2013 at 8:47 AM, Bjørn Mork wrote:
>&g
"Fangxiaozhi (Franko)" writes:
> -- commit 200e0d99 and commit cd060956, only put the switch
> command into kernel, instead of userspace usb_modeswitch utility.
Yes. And that is the problem. It was agreed years ago that this
functionality belongs in userspace. Ref e.g
https://lkml.org/lkml
Oliver Neukum writes:
> On Monday 04 March 2013 23:28:47 Josua Dietze wrote:
>> > I guess the real problem will be verifying that all of the entries can
>> > go away. This type of hardware tends to get old very fast, but there is
>> > always someone having a really ancient device.
>>
>> I will ch
Oliver Neukum writes:
> On Tuesday 05 March 2013 11:07:05 Bjørn Mork wrote:
>> "Fangxiaozhi (Franko)" writes:
>>
>> > -- commit 200e0d99 and commit cd060956, only put the switch
>> > command into kernel, instead of userspace usb_modeswitch utilit
"Fangxiaozhi (Franko)" writes:
> As far as I know, except switching in kernel, there isn't any
> mode switch solution on Android now. Do you have any good ideas
> for the mode switch on Android system?
Josh, the usb_modeswitch maintainer, is also maintaining this Android app:
Greg Kroah-Hartman writes:
> On Fri, Feb 15, 2013 at 12:30:11PM +0100, Bjørn Mork wrote:
>> Oliver Neukum writes:
>> > On Friday 15 February 2013 08:53:28 Bjørn Mork wrote:
>> >> Oliver Neukum writes:
>> >
>> >> > We have to let
Sergio Callegari writes:
> This is just a short note to let you know that after installing 3.8.3,
> display port stopped working on my laptop. Going back to 3.8.2 brought
> it back to life.
> This has been tested with the ubuntu mainline kernels that should be
> vanilla stable kernels. Hope this
Gregs git-bot writes:
> commit: 3935e89505a1c3ab3f3b0c7ef0eae54124f48905
> From: =?UTF-8?q?Bj=C3=B8rn=20Mork?=
> Date: Wed, 19 Dec 2012 20:51:31 +0100
> Subject: watchdog: Fix disable/enable regression
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bi
Greg KH writes:
> Yes, I've already responded why it didn't make it, see the 3.7.2-rc1
> email message for details.
>
> Don't worry, it will make the next one.
Thanks. Sorry for making more email noise for you. And there I did it
again. I'll stop now.
Bjørn
--
To unsubscribe from this list:
00B7&MI_02
ATVID_1BBB&PID_00B7&MI_03
Modem VID_1BBB&PID_00B7&MI_04
wwan VID_1BBB&PID_00B7&MI_05
Updating the blacklist info for the X060S_X200 and X220_X500D,
reserving interfaces for a wwan driver, based on
wwan VID_1BBB&PID_&MI_04
wwan VID_1BB
New device with 3 serial interfaces:
If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend) Sub=ff Prot=ff
If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend) Sub=ff Prot=ff
If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend) Sub=ff Prot=ff
If#= 3 Alt= 0 #EPs= 2 Cls=08(stor) Sub=06 Prot=50
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial
64 Ivl=2ms
E: Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=4ms
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 868a57d..004f
Dan Williams writes:
> On Tue, 2013-02-12 at 13:42 +0100, Bjørn Mork wrote:
>> Interface layout:
>>
>> 00 CD-ROM
>> 01 debug COM port
>> 02 AP control port
>> 03 modem
>> 04 usb-ethernet
>
> Any idea what AT command set the thing uses?
"non RNDIS" by that driver.
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 004f5b0..f7d339d 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/
Dan Williams writes:
> On Wed, 2013-02-13 at 08:53 +0100, Bjørn Mork wrote:
>> Dan Williams writes:
>> > On Tue, 2013-02-12 at 13:42 +0100, Bjørn Mork wrote:
>> >> Interface layout:
>> >>
>> >> 00 CD-ROM
>> >> 01 debug COM por
Do not scribble past end of buffer. Check if the userspace buffer has
enough space available before attempting to move more data there. Throw
away all previously read data if the buffer is full.
Cc: stable
Signed-off-by: Bjørn Mork
---
Hello Oliver!
I hope I am missing something here...
This
Do not scribble past end of buffer. Check if the userspace buffer has
enough space available before attempting to move more data there. Drop
new data on overflow.
Cc: stable
Signed-off-by: Bjørn Mork
---
Oliver Neukum writes:
> I am afraid your diagnosis is correct. This is a buffer overf
Oliver Neukum writes:
> On Thursday 14 February 2013 18:10:43 Bjørn Mork wrote:
>> Do not scribble past end of buffer. Check if the userspace buffer has
>> enough space available before attempting to move more data there. Drop
>> new data on overflow.
>>
>> Cc
Oliver Neukum writes:
> On Friday 15 February 2013 08:53:28 Bjørn Mork wrote:
>> Oliver Neukum writes:
>
>> > We have to let user space recover. To do so we need to indicate when
>> > exactly we dropped data.
>>
>> The problem with that is that this
Ben Hutchings writes:
>> @@ -1077,8 +1077,8 @@ u8 rtl_is_special_data(struct ieee80211_hw *hw, struct
>> sk_buff *skb, u8 is_tx)
>>
>> ip = (struct iphdr *)((u8 *) skb->data + mac_hdr_len +
>>SNAP_SIZE + PROTOC_TYPE_SIZE);
>> -ether_type = *(u16 *) ((u8 *)
Cc:
Reported-by: Oliver Neukum
Signed-off-by: Bjørn Mork
---
drivers/usb/class/cdc-wdm.c |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c
index 4d387596f3f0..0b23a8639311 100644
--- a/drivers/usb/class/cdc
writes:
> From 2167e2399dc5e69c62db56d933e9c8cbe107620a Mon Sep 17 00:00:00 2001
> From: Bjørn Mork
> Date: Tue, 3 Dec 2013 12:14:32 +0100
> Subject: cpufreq: fix garbage kobjects on errors during suspend/resume
>
> From: Bjørn Mork
>
> commit 2167e2399dc5e69c62db56d93
oli...@neukum.org writes:
> From: Oliver Neukum
>
> Both could want to submit the same URB. Some checks of the flag
> intended to prevent that were missing.
>
> Signed-off-by: Oliver Neukum
> CC: stable@vger.kernel.org
Yes, this is definitely required for 3.11 and stable. Note that it is
not j
commit 98cb7e44 ([SCSI] megaraid_sas: Sanity check user
supplied length before passing it to dma_alloc_coherent())
introduced a memory leak. Memory allocated for entries
following zero length SGL entries will not be freed.
Reference: http://bugs.debian.org/688198
Cc:
Signed-off-by: Bjørn Mork
e.
Blacklisting the network interface to allow it to be picked up by
the network driver.
Cc:
Reported-by: Thomas Schäfer
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
i
Mauro Carvalho Chehab writes:
> It seems ok to send it to stable for the stable versions that got the
> HERM patches (e. g. EDAC core version updated to 3.0.0). Adding it
> to older ones would cause regressions.
>
> In other words, if the following patch exists at -stable, then
> I recommend back
Herton Ronaldo Krzesinski writes:
> There is a problem in stable kernels that included the commit cafbe85
> ("USB: cdc-wdm: better allocate a buffer that is at least as big as we
> tell the USB core")
>
> In that commit, the usb_alloc_coherent call was changed without also
> adjusting usb_free_co
VID_1BBB&PID_011E&MI_04
Reported-by: Thomas Schäfer
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index e6f87b7..6391647 100644
--- a/drivers/usb/serial/o
Hello,
Please apply mainline commit e1d45ae to any maintained stable kernel
prior to v3.7. I just hit this bug on a Debian 3.2.41-2+deb7u2 kernel:
May 19 06:52:54 canardo kernel: [ 49.013774] BUG: unable to handle kernel
NULL pointer dereference at 0308
May 19 06:52:54 canardo ke
Cc: stable@vger.kernel.org
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 5dd857d..a6bf404 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial
Sreekanth Reddy writes:
> Infinite loop can occur if IOCStatus is not equal to
> MPI2_IOCSTATUS_CONFIG_INVALID_PAGE value in the while loops in functions
> _scsih_search_responding_sas_devices,
> _scsih_search_responding_raid_devices and
> _scsih_search_responding_expanders
>
> So, Instead of ch
Bjørn Mork writes:
> commit 98cb7e44 ([SCSI] megaraid_sas: Sanity check user
> supplied length before passing it to dma_alloc_coherent())
> introduced a memory leak. Memory allocated for entries
> following zero length SGL entries will not be freed.
>
> Reference: http://bugs
Søren Holm writes:
> oh...
>
> I just noticed that qcserial.c also handles this exact same USB-id.
>
> Will that pose a problem or is this the way things should be?
The device should be handled by only one of the drivers. If it is going
to be handled by "sierra" driver then we should remove the
Søren Holm writes:
> Fredag den 11. juli 2014 10:47:50 skrev Bjørn Mork:
>> The device should be handled by only one of the drivers. If it is going
>> to be handled by "sierra" driver then we should remove the entry from
>> the "qcserial" driver.
>
Søren Holm writes:
> qcserial from master on top of v3.14 works.
Thanks for verifying. You did ensure that you can actually talk to the
serial ports?
> I applied this patch on 3.14.5
>
> $ git diff v3.14..ba2c0922f74a57d794c10646c3a70ee5a5e14668 --
> drivers/usb/serial/qcserial.c
>
> In tot
Søren Holm writes:
> Fredag den 11. juli 2014 11:57:30 skrev Bjørn Mork:
>> Søren Holm writes:
>> > qcserial from master on top of v3.14 works.
>>
>> Thanks for verifying. You did ensure that you can actually talk to the
>> serial ports?
>
>
Søren Holm writes:
> Oh dear it's friday
>
> # modinfo qcserial | grep 1199p68
> alias: usb:v1199p68A2d*dc*dsc*dp*ic*isc*ip*in03*
> alias: usb:v1199p68A2d*dc*dsc*dp*ic*isc*ip*in02*
> alias: usb:v1199p68A2d*dc*dsc*dp*ic*isc*ip*in00*
> alias: usb:v1199p68A9
Adding a couple of Olivetti modems and blacklisting the net
function on a couple which are already supported.
Reported-by: Lars Melin
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a
Dave Chiluk writes:
> Stable_kernel_rules should point submitters of network stable patches to the
> netdev_FAQ.txt as requests for stable network patches should go to netdev
> first.
>
> Signed-off-by: Dave Chiluk
> ---
> Documentation/stable_kernel_rules.txt | 3 +++
> 1 file changed, 3 inser
count becomes negative.
The bug can easily be triggered from userspace by not reading all
data in the read buffer, and then closing and reopening the chardev.
Fixes: 8dd5cd5395b9 ("usb: cdc-wdm: avoid hanging on zero length reads")
Cc:
Signed-off-by: Bjørn Mork
---
A fix for the fix.
Cc:
Signed-off-by: Bjørn Mork
---
Hello Greg!
I saw your post on Google+ :-) You'll probably want one of
these nice adapters to go with that toy. It's simply not worth
the job making the console cable yourself.
Bjørn
drivers/usb/serial/ftdi_sio.c | 1 +
drivers/
Greg Kroah-Hartman writes:
> On Tue, Jan 14, 2014 at 06:56:54PM +0100, Bjørn Mork wrote:
>> Cc:
>> Signed-off-by: Bjørn Mork
>> ---
>> Hello Greg!
>>
>> I saw your post on Google+ :-) You'll probably want one of
>> these nice adapters to
This device was mentioned in an OpenWRT forum. Seems to have a "standard"
Sierra Wireless ifnumber to function layout:
0: qcdm
2: nmea
3: modem
8: qmi
9: storage
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/qcserial.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
Johan Hovold writes:
> Today, only one device has the "NOT_A_MODEM" flag (*only* to prevent one
> message during probe), and most devices are simply matched on the
> interface class fields anyway. I'm not sure we want to start registering
> devices with broken bmCapabilities in the driver (rather
-by: Bjørn Mork
---
drivers/usb/serial/sierra.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 6f7f01eb556a..fa45d39619ca 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -282,14
This VID:PID is used for some Direct IP devices behaving
identical to the already supported 0F3D:68AA devices.
Cc:
Reported-by: Lars Melin
Signed-off-by: Bjørn Mork
---
This should be applied on top of my 'USB: sierra: avoid CDC class
functions on "68A3" devices' to avoid u
ported current charge level (39800) is higher than
reported maximum charge level (39800).
and wrong values being reported for 'capacity_now' and
'full_charge_capacity' after the warning has been triggered.
Fixes: 232de5143790 ("ACPI / battery: fix wrong value of capacit
ging is complete whenever 'full_charge_capacity'
needs to be increased.
Fixes: d719870b41e0 ("ACPI / battery: Fix warning message in
acpi_battery_get_state()")
Cc: Mariusz Ceier
Cc: Josef Gajdusek
Cc: 3.16+ # 3.16+
Signed-off-by: Bjørn Mork
---
drivers/acpi/battery.c | 2 +-
1
Hans de Goede writes:
> --- a/drivers/usb/storage/uas-detect.h
> +++ b/drivers/usb/storage/uas-detect.h
> @@ -73,8 +73,8 @@ static int uas_use_uas_driver(struct usb_interface *intf,
>* broken on the ASM1051, use the number of streams to differentiate.
>* New ASM1053-s also support
The include/uapi/linux/usb/cdc-wdm.h header defines cdc-wdm
userspace APIs and should be exported by make headers_install.
Cc: # 3.10, 3.12, 3.14
Fixes: 3edce1cf813a ("USB: cdc-wdm: implement IOCTL_WDM_MAX_COMMAND")
Signed-off-by: Bjørn Mork
---
Seems like I accidentally left thi
A number of older CMOTech modems are based on Qualcomm
chips. The blacklisted interfaces are QMI/wwan.
Reported-by: Lars Melin
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c | 74 ++---
1 file changed, 70 insertions(+), 4 deletions
>From Sierra Wireless' "USB Driver Developer's Guide"
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/qcserial.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index 662235240f3f..1d1bc9b41337 1
>From Lenovo Windows driver.
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/qcserial.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index 968a40201e5f..662235240f3f 100644
--- a/drivers/usb/serial/qcserial.c
++
>From https://bug726613.bugzilla-attachments.gnome.org/attachment.cgi?id=272246
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/qcserial.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index 1d1bc9b41337..7ed681a71
Device interface layout:
0: ff/ff/ff - serial
1: ff/ff/ff - serial AT+PPP
2: 08/06/50 - storage
3: ff/ff/ff - serial
4: ff/ff/ff - QMI/wwan
Cc:
Reported-by: Julio Araujo
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers
Device interface layout:
0: ff/ff/ff - serial
1: ff/00/00 - serial AT+PPP
2: ff/ff/ff - QMI/wwan
3: 08/06/50 - storage
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
From: Bjørn Mork
Dan writes:
"The Dell drivers use the same configuration for PIDs:
81A2: Dell Wireless 5806 Gobi(TM) 4G LTE Mobile Broadband Card
81A3: Dell Wireless 5570 HSPA+ (42Mbps) Mobile Broadband Card
81A4: Dell Wireless 5570e HSPA+ (42Mbps) Mobile Broadband Card
81A8: Dell Wir
d desktop, GEN4 and non-GEN4) seem
> to work fine. Based on this apply the workaround on all GEN4 Lenovo
> platforms.
> - add code comment about failing platforms (Ville)
>
> Reference:
> http://lists.freedesktop.org/archives/intel-gfx/2015-February/060633.html
> Reported-and-bise
Greg KH writes:
> On Mon, Mar 16, 2015 at 02:36:53PM +0100, Bjørn Mork wrote:
>> writes:
>>
>> > The patch below does not apply to the 3.19-stable tree.
>> > If someone wants it applied there, or to any other stable or longterm
>> > tree, then please
Willy Tarreau writes:
> On Wed, Jun 03, 2015 at 05:50:49PM +, Scott Branden wrote:
>> Hi Larry,
>>
>> There is no problem applying this patch to the stable tree.
>> I didn't know it was my responsibility to inform the stable mailing list
>> every time a patch is accepted
>> in the latest ker
New device IDs shamelessly lifted from the vendor driver.
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/qcserial.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index ebcec8cda858..f49d262e926b 100644
--- a/drivers
e was already in
place, with freeze_late pointing to the same function as suspend_late.
There is no need for any poweroff_late hook in this driver.
This reverts commit da2bc1b9db33.
Fixes: da2bc1b9db33 ("drm/i915: add poweroff_late handler")
Cc:
Cc: Imre Deak
Cc: Ville Syrjälä
Si
Imre Deak writes:
> The poweroff handlers undo the actions of the thaw handlers. As the
> original commit stated saving the registers is not needed there, but
> it's also not a big overhead and there should be no problem doing it. We
> are planning to optimize the hibernation sequence by for exam
Imre Deak writes:
>> That patch fixes the problem, with only pci_set_power_state commented
>> out. Do you still want me to try with pci_disable_device() commented
>> out as well?
>
> No, but it would help if you could still try the two attached patch
> separately, without any of the previous wor
Imre Deak writes:
> Attached is the proposed fix for this issue.
>
> --Imre
>
> From 5c23657bc168db12a1ba100ab65fabd305c89c8a Mon Sep 17 00:00:00 2001
> From: Imre Deak
> Date: Thu, 26 Feb 2015 18:38:53 +0200
> Subject: [PATCH] drm/i915: gm45: work around hang during hibernation
I can confirm t
Ville Syrjälä writes:
>> @@ -651,7 +651,14 @@ static int i915_drm_suspend_late(struct drm_device
>> *drm_dev)
>> }
>>
>> pci_disable_device(drm_dev->pdev);
>> -pci_set_power_state(drm_dev->pdev, PCI_D3hot);
>> +/*
>> + * During hibernation on some GM45 platforms the BIOS
Hello Sasha!
This backported mvebu fix seems to have slipped through the cracks by
accident. IIUC, the OpenWRT mvebu maintainer(s) are particularily
interested in having this bug fixed for 3.18-stable. See this thread
for the original patch submission and discussion:
http://permalink.gmane.org/g
Ben Hutchings writes:
> 3.2-stable review patch. If anyone has any objections, please let me know.
>
> --
>
> From: Bjørn Mork
>
> commit de102ef41f24a4c251c4a3838796bb27557d4d93 upstream.
>
> Tested-by: Thomas Schäfer
> Signed-off-by: Bjørn Mor
Ben Hutchings writes:
> 3.2-stable review patch. If anyone has any objections, please let me know.
>
> --
>
> From: Bjørn Mork
>
> commit fec67b45bf045582c3172101970090d640cd56d9 upstream.
>
This should be dropped for the same reason as patch #46
Bjør
But a crashing
device may cause both a read error and cancelling all
urbs. We must make sure that the flag is cleared by
wdm_read in this case.
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/class/cdc-wdm.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/class/cdc-w
Oliver Neukum writes:
> Am Montag, 2. Juli 2012, 01:08:59 schrieb Bjørn Mork:
>> The WDM_READ flag is normally cleared by wdm_int_callback
>> before resubmitting the interrupt urb. But a crashing
>> device may cause both a read error and cancelling all
>> urbs. We m
h should be processed. The flag will
instead be cleared on the next wdm_read call.
Cc:
Signed-off-by: Bjørn Mork
---
v2: unconditionally clearing the flag on errors may cause a
data leak. And it is redundant in any case, so dropping.
Pointed out by Oliver Neukum
drivers/usb/class/cdc-wdm.c |
Oliver Neukum writes:
> For mice with card readers the HID driver can deadlock
> as its post_reset() method allocates memory. GFP_NOIO
> must be used in a block layer error handler, which
> usbhid can be indirectly part of.
I am wondering a bit where this will eventually end. Given enough time,
Based on information from the ZTE Windows drivers.
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c | 68 ++-
1 file changed, 48 insertions(+), 20 deletions(-)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index
Cc:
Signed-off-by: Bjørn Mork
---
drivers/usb/serial/option.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 231a5c1..72b7961 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
Bjørn Mork writes:
> +static const struct option_blacklist_info net_intf6_blacklist = {
> + .reserved = BIT(5),
> +};
Yuck. Why do I see such stupid errors only *after* sending?
Forget this patch. I'll send a fixed version.
--
To unsubscribe from this list: send the lin
Based on information from the ZTE Windows drivers.
Cc:
Signed-off-by: Bjørn Mork
---
v2: fixed mindless typo on the net_intf6_blacklist
drivers/usb/serial/option.c | 68 ++-
1 file changed, 48 insertions(+), 20 deletions(-)
diff --git a/drivers/usb
Commit f79b2d0f (USB: keyspan: fix NULL-pointer dereferences and
memory leaks) had a small typo which made the driver use wrong
offsets when mapping serial port private data. This results in
in a GPF when the port is opened.
Reported-by: Richard
Cc:
Cc: Johan Hovold
Signed-off-by: Bjørn Mork
Richard writes:
> Bjørn:
>
> I patched keyspan.c using your below supplied diff in 3.6.6 (I'm not
> using git.) The patch WORKS for me. (I tested using minicom and the
> two programs that usually access the Keyspan serial device.)
Thanks for testing. Good to know that this really was the prob
. So we can reuse the
existing workaround.
Cc: Markus Kolb
Cc: Iker Salmón San Millán
Cc: Jonathan Nieder
Cc: Oliver Neukum
Cc: 655...@bugs.debian.org
Cc: stable@vger.kernel.org
Signed-off-by: Bjørn Mork
---
Something like this, then?
This has only been build tested by me as I don't have a
. So we can reuse the
existing workaround.
Cc: Markus Kolb
Cc: Iker Salmón San Millán
Cc: Jonathan Nieder
Cc: Oliver Neukum
Cc: 655...@bugs.debian.org
Cc: stable@vger.kernel.org
Signed-off-by: Bjørn Mork
---
v2: adding a test to verify that the resulting control interface is the
probed
Else the poll will be restarted indefinitely in a tight loop,
preventing final device cleanup.
Cc: Oliver Neukum
Cc: stable@vger.kernel.org
Signed-off-by: Bjørn Mork
---
drivers/usb/class/cdc-wdm.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/class/cdc
already been
called if WDM_DISCONNECTING is set. This does not
actually fix anything, but keeps the code more consistent.
Cc: Oliver Neukum
Cc: stable@vger.kernel.org
Signed-off-by: Bjørn Mork
---
drivers/usb/class/cdc-wdm.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff
ice
should not appear in the list unless probe() has succeeded
and disconnect() has not finished.
Cc: Oliver Neukum
Cc: stable@vger.kernel.org
Signed-off-by: Bjørn Mork
---
drivers/usb/class/cdc-wdm.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/cl
Adding device IDs for Aircard 320U and two other devices
found in the out-of-tree version of this driver.
Cc: li...@sierrawireless.com
Cc: Autif Khan
Cc: Tom Cassidy
Cc: stable@vger.kernel.org
Signed-off-by: Bjørn Mork
---
drivers/net/usb/sierra_net.c | 14 ++
1 file changed, 10
Greg KH writes:
> On Wed, Jun 06, 2012 at 09:18:10AM +0200, Bjørn Mork wrote:
>> Adding device IDs for Aircard 320U and two other devices
>> found in the out-of-tree version of this driver.
>>
>> Cc: li...@sierrawireless.com
>> Cc: Autif Khan
>> Cc: Tom
1 - 100 of 116 matches
Mail list logo
