Martin Sebor wrote:
I'd like us to start to think about and putting together a list
of widely implemented core C++ features whose absence we currently
work around with the help of configuration tests and macros and
that are contributing in a significant way to the maintenance and
development effo
Travis Vitek wrote:
Martin Sebor wrote:
Travis Vitek wrote:
If that is the case, then why would we possibly need this
same code in any of the other methods that are used to extend
the original string?
I don't think we do, really. I suspect the main reason why the
code is in all other (out-
Martin Sebor wrote:
I'd like to extend a belated welcome to Brad (AKA Eric) and Mark,
the newest stdcxx committers. The Incubator PMC voted and approved
them on 9/5. I've asked both Brad and Mark to sign and send/fax in
their CLA's. As soon as they have been processed we'll go ahead and
request t
Travis Vitek wrote:
Stupid outlook.
[21.3.5.2 p4] Effects: Determines the effective length rlen of the
string to append as the smaller of n and str.size() - pos. The function
then throws length_error if size() >= npos - rlen.
The append that I'm invoking is described to behave as if it had ca
Stupid outlook.
>
>[21.3.5.2 p4] Effects: Determines the effective length rlen of the
>string to append as the smaller of n and str.size() - pos. The function
>then throws length_error if size() >= npos - rlen.
>
>The append that I'm invoking is described to behave as if it had called
>that func
Martin Sebor wrote:
>
>Travis Vitek wrote:
>>
>> template
>> class Xallocator
>> {
>> public:
>> typedef unsigned char size_type;
>
>I suspect the problem might actually be here. Once you define
>size_type to a type with a more generous range the test case
>passes. I made this and a f
Travis Vitek wrote:
Martin Sebor wrote:
Travis Vitek wrote:
If that is the case, then why would we possibly need this
same code in any of the other methods that are used to extend
the original string?
I don't think we do, really. I suspect the main reason why the
code is in all other (out-
Martin Sebor wrote:
>
>Travis Vitek wrote:
>>
>> If that is the case, then why would we possibly need this
>> same code in any of the other methods that are used to extend
>> the original string?
>
>I don't think we do, really. I suspect the main reason why the
>code is in all other (out-of-li
Travis Vitek wrote:
Martin,
I think that you are right in the case of push_back, or when the string
to append is short. My last testcase didn't prove anything. This one
does. If you use the current trunk, this prints '4 ' to the console.
i.e. appending 20 characters to a buffer with 240 s
Travis Vitek wrote:
[...]
The change also seems unnecessary -- when size() equals capacity()
we check that it doesn't exceed max_size() before allocating more
memory in append(). Otherwise, when size() is less than capacity()
(or rather capacity() - 1), there should be no reason to check
against
Martin,
I think that you are right in the case of push_back, or when the string
to append is short. My last testcase didn't prove anything. This one
does. If you use the current trunk, this prints '4 ' to the console.
i.e. appending 20 characters to a buffer with 240 should not get you 4,
s
Martin Sebor wrote:
>
>Travis Vitek wrote:
>> It appears that recent changes to string have accidentally
>> removed some overflow checking that used to be in the
>> basic_string::append() and push_back() methods. The following
>> patch adds the checks back in.
>
>Does this fix a test failure? O
[
https://issues.apache.org/jira/browse/STDCXX-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Sebor closed STDCXX-567.
---
Resolution: Fixed
Fix Version/s: (was: trunk)
4.2
Fixed thus: http://sv
[
https://issues.apache.org/jira/browse/STDCXX-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Sebor updated STDCXX-567:
Priority: Blocker (was: Major)
Affects Version/s: (was: trunk)
[
https://issues.apache.org/jira/browse/STDCXX-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Sebor reassigned STDCXX-567:
---
Assignee: Martin Sebor
> [Sun C++/Linux/x86] assembler error on xchg in i86/atomic.s
> --
[Sun C++/Linux/x86] assembler error on xchg in i86/atomic.s
---
Key: STDCXX-567
URL: https://issues.apache.org/jira/browse/STDCXX-567
Project: C++ Standard Library
Issue Type: Bug
Travis Vitek wrote:
It appears that recent changes to string have accidentally removed some
overflow checking that used to be in the basic_string::append() and
push_back() methods. The following patch adds the checks back in.
Does this fix a test failure? Or some regression? (If the former,
whi
Travis Vitek wrote:
>
>It appears that recent changes to string have accidentally removed some
>overflow checking that used to be in the basic_string::append() and
>push_back() methods. The following patch adds the checks back in.
>
>Travis
>
Lets try that again. This one has the correct method
It appears that recent changes to string have accidentally removed some
overflow checking that used to be in the basic_string::append() and
push_back() methods. The following patch adds the checks back in.
Travis
2007-09-20 Travis Vitek <[EMAIL PROTECTED]>
* string (append): add inte
Travis Vitek wrote:
Martin Sebor wrote:
Travis Vitek wrote:
It appears that svn has a pre-commit hook that could be used
to require that the correct change format be used for all
submissions. That would avoid this problem in the future.
That'd be cool! Maybe we could even use it to reject
I'm planning to merge all of the trunk to branches/4.2.0 as soon
as the recently introduced build failures have cleared up in the
build results. This could be as early as tomorrow and hopefully
no later than early next week. Until then, I'd like to ask all
committers to be extra careful before che
Travis Vitek wrote:
Martin Sebor wrote:
I've asked Tim to get the compilers installed.
That appears to have done the trick. I've successfully built the library
and the test driver without trouble, and the tests are compiling now.
Great! There are a couple of successful Intel C++ 10.0 bui
I'd like to extend a belated welcome to Brad (AKA Eric) and Mark,
the newest stdcxx committers. The Incubator PMC voted and approved
them on 9/5. I've asked both Brad and Mark to sign and send/fax in
their CLA's. As soon as they have been processed we'll go ahead and
request that accounts be set u
> -Original Message-
> From: Farid Zaripov [mailto:[EMAIL PROTECTED]
> Sent: Thursday, September 20, 2007 8:19 PM
> To: stdcxx-dev@incubator.apache.org
> Subject: RE: svn commit: r576543 - in
> /incubator/stdcxx/trunk/etc/config/windows: msvc-7.0.config
> msvc-9.0-x64.config msvc-9.0.con
[
https://issues.apache.org/jira/browse/STDCXX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529158
]
Martin Sebor commented on STDCXX-566:
-
The source XML file should also be updated with the latest status report a
> -Original Message-
> From: Martin Sebor [mailto:[EMAIL PROTECTED]
> Sent: Thursday, September 20, 2007 8:01 PM
> To: stdcxx-dev@incubator.apache.org
> Subject: Re: svn commit: r576543 - in
> /incubator/stdcxx/trunk/etc/config/windows: msvc-7.0.config
> msvc-9.0-x64.config msvc-9.0.conf
[
https://issues.apache.org/jira/browse/STDCXX-561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Farid Zaripov resolved STDCXX-561.
--
Resolution: Fixed
> add ASL headers to all etc/nls files
>
Martin Sebor wrote:
>Travis Vitek wrote:
>>
>> It appears that svn has a pre-commit hook that could be used
>> to require that the correct change format be used for all
>> submissions. That would avoid this problem in the future.
>
>That'd be cool! Maybe we could even use it to reject badly fo
[EMAIL PROTECTED] wrote:
Author: faridz
Date: Mon Sep 17 10:45:33 2007
New Revision: 576543
URL: http://svn.apache.org/viewvc?rev=576543&view=rev
Log:
2007-09-17 Farid Zaripov <[EMAIL PROTECTED]>
* msvc-7.0.config: Comments extended with information on MSVC 9.0
(Orcas).
* msvc-
[
https://issues.apache.org/jira/browse/STDCXX-560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Farid Zaripov resolved STDCXX-560.
--
Resolution: Fixed
> add ASL headers to all config tests
> ---
>
Travis Vitek wrote:
Travis Vitek wrote:
Martin Sebor wrote:
This Change Log seems to have lost its leading asterisks. I'll be
generating ChangeLogs for stdcxx before the release so I could add
them then but I wonder if we could fix it in Subversion now?
That's my fault. I forgot to put the
Travis Vitek wrote:
>
>Martin Sebor wrote:
>>
>>This Change Log seems to have lost its leading asterisks. I'll be
>>generating ChangeLogs for stdcxx before the release so I could add
>>them then but I wonder if we could fix it in Subversion now?
>>
>
>That's my fault. I forgot to put them in the
[
https://issues.apache.org/jira/browse/STDCXX-560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Farid Zaripov reopened STDCXX-560:
--
etc/config/windows/*.config files should also have the ASL headers.
> add ASL headers to all confi
> -Original Message-
> From: Martin Sebor [mailto:[EMAIL PROTECTED] On Behalf Of Martin Sebor
> Sent: Thursday, September 20, 2007 6:28 PM
> To: stdcxx-dev@incubator.apache.org
> Subject: Re: svn commit: r58 [1/20] - in
> /incubator/stdcxx/trunk/etc/nls: charmaps/ posix/charmaps/
> po
Martin Sebor wrote:
>
>I've asked Tim to get the compilers installed.
>
That appears to have done the trick. I've successfully built the library
and the test driver without trouble, and the tests are compiling now.
Travis
Martin Sebor wrote:
>
>[EMAIL PROTECTED] wrote:
>> Author: faridz
>> Date: Thu Sep 20 07:50:22 2007
>> New Revision: 58
>>
>> URL: http://svn.apache.org/viewvc?rev=58&view=rev
>> Log:
>> 2007-09-20 Travis Vitek <[EMAIL PROTECTED]>
>>
>> STDCXX-561
>> ANSI_X3.110-1983: Add ASL
[EMAIL PROTECTED] wrote:
Author: faridz
Date: Thu Sep 20 07:50:22 2007
New Revision: 58
URL: http://svn.apache.org/viewvc?rev=58&view=rev
Log:
2007-09-20 Travis Vitek <[EMAIL PROTECTED]>
STDCXX-561
ANSI_X3.110-1983: Add ASL Header
ANSI_X3.4-1968: Same.
AS
[
https://issues.apache.org/jira/browse/STDCXX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Farid Zaripov reassigned STDCXX-566:
Assignee: Farid Zaripov
> update/generate incubation status file
>
[
https://issues.apache.org/jira/browse/STDCXX-560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Farid Zaripov resolved STDCXX-560.
--
Resolution: Fixed
Tested on Windows and no problems were found.
> add ASL headers to all confi
39 matches
Mail list logo
