Re: test binaries for Beta 5

2014-08-05 Thread Jef Driesen
On 2014-08-05 17:13, Miika Turkia wrote: On Tue, Aug 5, 2014 at 5:49 PM, Dirk Hohndel wrote: On Tue, Aug 05, 2014 at 05:33:24AM -0700, Richard DePas wrote: Unfortunately I am still getting a group of error messages when importing from my Petrel. The dives still show up. unlikely dive gas dat

[PATCH] Fix compile warning

2014-08-05 Thread Miika Turkia
warning: format not a string literal and no format arguments Signed-off-by: Miika Turkia --- planner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/planner.c b/planner.c index 3efa702..60751fc 100644 --- a/planner.c +++ b/planner.c @@ -534,7 +534,7 @@ static void add_plan_

Re: Planner SAC rate - imperial

2014-08-05 Thread Gaetan Bisson
[2014-08-05 20:55:00 -0700] Richard DePas: > On Tue, Aug 5, 2014 at 8:39 PM, Richard DePas > wrote: > > > Ran one of my deeper dives through the planner to see how different mixes > > would change deco. I know my normal SAC is about .40cuft/min so I assumed I > > would need to put in 40 for a SAC

Beta 5

2014-08-05 Thread Dirk Hohndel
Tag pushed, installers uploaded, announcement pushed, new version added to trac. Test away. I really hope that this fixes most of the critical bugs. I repeat, I want 4.2 out by the weekend :-) There are a handful new or slightly modified strings. If you are translating, please log in one more ti

Re: test binaries for Beta 5

2014-08-05 Thread Dirk Hohndel
On Tue, Aug 05, 2014 at 11:33:48PM +0200, Henrik Brautaset Aronsen wrote: > Dirk Hohndel wrote: > >On Tue, Aug 05, 2014 at 05:33:24AM -0700, Richard DePas wrote: > >>unlikely dive gas data from libdivecomputer: o2 = 0 he = 0 > > > >Well, arguably these ARE rather unlikely dive gases :-) > > > >Remi

Re: test binaries for Beta 5

2014-08-05 Thread Richard DePas
On Tue, Aug 5, 2014 at 2:33 PM, Henrik Brautaset Aronsen < subsurf...@henrik.synth.no> wrote: > Dirk Hohndel wrote: > > On Tue, Aug 05, 2014 at 05:33:24AM -0700, Richard DePas wrote: > > unlikely dive gas data from libdivecomputer: o2 = 0 he = 0 > > Well, arguably these ARE rather unlikely dive

fixes

2014-08-05 Thread Tomaz Canabrava
the 676 it's harder than I think to fix, but it's user error so nothing very urgent. From e962983873666e996c4c425c712a70d80eb1782e Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Tue, 5 Aug 2014 17:40:50 -0300 Subject: [PATCH 1/2] Hide Depth Column we were showing everything, always. fixes

Re: test binaries for Beta 5

2014-08-05 Thread Henrik Brautaset Aronsen
Dirk Hohndel wrote: On Tue, Aug 05, 2014 at 05:33:24AM -0700, Richard DePas wrote: unlikely dive gas data from libdivecomputer: o2 = 0 he = 0 Well, arguably these ARE rather unlikely dive gases :-) Remind me what our conclusion was last time we talked about this... o2 = 0? That's _obviousl

Re: test binaries for Beta 5

2014-08-05 Thread Rainer Mohr
Am 05.08.14 16:46, schrieb Dirk Hohndel: BTW: did you notice the cool new browser string that you get from Subsurface users? Ooooh, full of utter awesomeness, to say the least :-) "Subsurface 4.1.93 Operating System: OS X Mavericks (10.9) CPU Architecture: x86_64 Language: en" does give me qu

Re: test binaries for Beta 5

2014-08-05 Thread Robert C. Helling
On 05 Aug 2014, at 21:53, Dirk Hohndel wrote: > I'd always refuse to do single digit GFHigh until you leave the field. > Because that's what happens when you edit "70"->"7"->"75" and I think > that's 99% of the cases where we get <10. > > And if last stop is 6m, refuse anything below 35 Here i

Copying HTML templates seems to be broken.

2014-08-05 Thread Gehad Elrobey
Copying the HTML templates to install directory seems to be broken after some patches applied to master. The html files in theme directory aren't updated on running 'install' Regards, Gehad ___ subsurface mailing list subsurface@hohndel.org http://lists.

Re: test binaries for Beta 5

2014-08-05 Thread Dirk Hohndel
On Tue, Aug 05, 2014 at 08:48:15PM +0200, Robert C. Helling wrote: > > On 05 Aug 2014, at 16:17, Dirk Hohndel wrote: > > > void DivePlannerPointsModel::setGFHigh(const int gfhigh) > > { > > tempGFHigh = gfhigh; > > // GFHigh <= 34 can cause infinite deco at 6m - don't trigger a > > /

Re: test binaries for Beta 5

2014-08-05 Thread Robert C. Helling
On 05 Aug 2014, at 16:17, Dirk Hohndel wrote: > void DivePlannerPointsModel::setGFHigh(const int gfhigh) > { > tempGFHigh = gfhigh; > // GFHigh <= 34 can cause infinite deco at 6m - don't trigger a > // recalculation > // for smaller GFHigh unless the user explicitly leav

Re: test binaries for Beta 5

2014-08-05 Thread Lubomir I. Ivanov
On 5 August 2014 20:03, Dirk Hohndel wrote: > On Tue, Aug 05, 2014 at 06:35:44PM +0300, Lubomir I. Ivanov wrote: >> On 5 August 2014 18:28, Dirk Hohndel wrote: >> > So check if you get invalid page size and the abort >> > >> >> this might be the way to go. just compiled on linux and >> QPrinterIn

Re: [PATCH 1/3] Print: don't use QPrinterInfo::availablePrinters()

2014-08-05 Thread Lubomir I. Ivanov
On 5 August 2014 20:34, Lubomir I. Ivanov wrote: > From: "Lubomir I. Ivanov" > > QPrinterInfo::availablePrinters() seems unreliable on Linux. > It returns zero printers event if there are two printers listed > in the print dialog on a stock Ubuntu - PDF printer and PS printer. > > Not having a go

Re: test binaries for Beta 5

2014-08-05 Thread Lubomir I. Ivanov
On 5 August 2014 20:03, Dirk Hohndel wrote: > On Tue, Aug 05, 2014 at 06:35:44PM +0300, Lubomir I. Ivanov wrote: >> On 5 August 2014 18:28, Dirk Hohndel wrote: >> > So check if you get invalid page size and the abort >> > >> >> this might be the way to go. just compiled on linux and >> QPrinterIn

[PATCH 3/3] Print: rename the variable 'isHeading' to 'newHeading'

2014-08-05 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" This better describes what the variable (flag) does. It's used to inform the loop that the last row goes our of the page limit and that we need to place a new heading on a new page. In that context 'newHeading' is more meaningful. The name 'isHeading' is confusing for (i

[PATCH 2/3] Print: add a safe guard for row heights in the table print

2014-08-05 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" If a row height is more than the available height on a page (minus the height of a heading row) we have to skip this row (dive). The current profile print simply does not support that and it does not make much sense. For that to happen either the page will have to be tin

[PATCH 1/3] Print: don't use QPrinterInfo::availablePrinters()

2014-08-05 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" QPrinterInfo::availablePrinters() seems unreliable on Linux. It returns zero printers event if there are two printers listed in the print dialog on a stock Ubuntu - PDF printer and PS printer. Not having a good check for the installed printers, forces us to check if the

Re: test binaries for Beta 5

2014-08-05 Thread Joakim Bygdell
Beta 5, Mac Print preview: Unused gases are included in the gas list. /Jocke ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: test binaries for Beta 5

2014-08-05 Thread Dirk Hohndel
On Tue, Aug 05, 2014 at 06:35:44PM +0300, Lubomir I. Ivanov wrote: > On 5 August 2014 18:28, Dirk Hohndel wrote: > > So check if you get invalid page size and the abort > > > > this might be the way to go. just compiled on linux and > QPrinterInfo::availablePrinters() returns an empty list yet th

ignore more

2014-08-05 Thread Cristian Ionescu-Idbohrn
Now ignoring errors from pdf-generation and ignoring generated documentation files. Cheers, -- CristianFrom 43210ed22fe46b33c73ca5bb690789d55b8d1d4b Mon Sep 17 00:00:00 2001 From: Cristian Ionescu-Idbohrn Date: Tue, 5 Aug 2014 18:02:46 +0200 Subject: [PATCH 1/2] Ignore errors on pdf generation

Re: test binaries for Beta 5

2014-08-05 Thread Lubomir I. Ivanov
On 5 August 2014 18:28, Dirk Hohndel wrote: > So check if you get invalid page size and the abort > this might be the way to go. just compiled on linux and QPrinterInfo::availablePrinters() returns an empty list yet there are two "printers" (or drivers) by default: for PDF and PS. TODO a patch.

Re: test binaries for Beta 5

2014-08-05 Thread Dirk Hohndel
So check if you get invalid page size and the abort /D --- From my phone On August 5, 2014 8:16:12 AM "Lubomir I. Ivanov" wrote: On 5 August 2014 18:12, Dirk Hohndel wrote: > On Tue, Aug 05, 2014 at 06:06:04PM +0300, Lubomir I. Ivanov wrote: >> On 5 August 2014 16:52, Dirk Hohndel wrote

Re: test binaries for Beta 5

2014-08-05 Thread Richard DePas
> > >> > Unfortunately I am still getting a group of error messages when >> importing >> > from my Petrel. The dives still show up. >> > >> > unlikely dive gas data from libdivecomputer: o2 = 0 he = 0 >> > >> > unlikely dive gas data from libdivecomputer: o2 = 0 he = 0 >> > >> > unlikely dive gas d

Re: test binaries for Beta 5

2014-08-05 Thread Lubomir I. Ivanov
On 5 August 2014 18:12, Dirk Hohndel wrote: > On Tue, Aug 05, 2014 at 06:06:04PM +0300, Lubomir I. Ivanov wrote: >> On 5 August 2014 16:52, Dirk Hohndel wrote: >> > On Tue, Aug 05, 2014 at 09:10:11AM +0200, Joakim Bygdell wrote: >> > >> >> Print preview: >> >> Air is included in the gas list for

Re: test binaries for Beta 5

2014-08-05 Thread Miika Turkia
On Tue, Aug 5, 2014 at 5:49 PM, Dirk Hohndel wrote: > On Tue, Aug 05, 2014 at 05:33:24AM -0700, Richard DePas wrote: > > Export to divelogs.de is working great now! Win7 64 bit. > > Good. > > > Error messages look much better with the Close on the right hand side. > > :-) > > > Unfortunately I a

Re: test binaries for Beta 5

2014-08-05 Thread Dirk Hohndel
On Tue, Aug 05, 2014 at 06:06:04PM +0300, Lubomir I. Ivanov wrote: > On 5 August 2014 16:52, Dirk Hohndel wrote: > > On Tue, Aug 05, 2014 at 09:10:11AM +0200, Joakim Bygdell wrote: > > > >> Print preview: > >> Air is included in the gas list for dives done using other gasmixes. "AL80 > >> EAN32 /

Re: test binaries for Beta 5

2014-08-05 Thread Dirk Hohndel
On Tue, Aug 05, 2014 at 08:05:24AM -0700, Richard DePas wrote: > > > Unfortunately I am still getting a group of error messages when importing > > > from my Petrel. The dives still show up. > > > > > > unlikely dive gas data from libdivecomputer: o2 = 0 he = 0 > > > > > > unlikely dive gas data fro

Re: test binaries for Beta 5

2014-08-05 Thread Lubomir I. Ivanov
On 5 August 2014 16:52, Dirk Hohndel wrote: > On Tue, Aug 05, 2014 at 09:10:11AM +0200, Joakim Bygdell wrote: > >> Print preview: >> Air is included in the gas list for dives done using other gasmixes. "AL80 >> EAN32 / air" >> Also should the tanks used really show up in the printed gaslist? As "D

Re: test binaries for Beta 5

2014-08-05 Thread Richard DePas
> > Unfortunately I am still getting a group of error messages when importing > > from my Petrel. The dives still show up. > > > > unlikely dive gas data from libdivecomputer: o2 = 0 he = 0 > > > > unlikely dive gas data from libdivecomputer: o2 = 0 he = 0 > > > > unlikely dive gas data from libdiv

Re: test binaries for Beta 5

2014-08-05 Thread Dirk Hohndel
On Tue, Aug 05, 2014 at 05:33:24AM -0700, Richard DePas wrote: > Export to divelogs.de is working great now! Win7 64 bit. Good. > Error messages look much better with the Close on the right hand side. :-) > Unfortunately I am still getting a group of error messages when importing > from my Pet

Re: test binaries for Beta 5

2014-08-05 Thread Dirk Hohndel
On Tue, Aug 05, 2014 at 12:25:35PM +0200, Rainer Mohr wrote: > Ok, > > Mac binary: > looks good, > divelogs.de upload works fine BTW: did you notice the cool new browser string that you get from Subsurface users? :-) > printing also works apart from some ugly unregular borders in the table (see

[PATCH] Remove wrong unit from CNS in UDDF import

2014-08-05 Thread Miika Turkia
Signed-off-by: Miika Turkia --- xslt/uddf.xslt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xslt/uddf.xslt b/xslt/uddf.xslt index d8ea618..c4911c5 100644 --- a/xslt/uddf.xslt +++ b/xslt/uddf.xslt @@ -454,7 +454,7 @@ - +

Various minor matters

2014-08-05 Thread Davide DB
Maybe still in time for 4.2 if confirmed. http://trac.hohndel.org/ticket/687 http://trac.hohndel.org/ticket/688 http://trac.hohndel.org/ticket/689 I'm just in the middle of a liveaboard so I can just forward what I find on my 4.1 laptop between dives and when internet is available. Bye Davide

Re: test binaries for Beta 5

2014-08-05 Thread Dirk Hohndel
On Tue, Aug 05, 2014 at 02:46:56PM +0200, Robert Helling wrote: > > On 05.08.2014, at 13:55, Tomaz Canabrava wrote: > > Hi, > > Good catch. This is just a matter of changing the connect line for the gf > > high to editfinished instead of value changed, can somebody do that for me? > > Im on th

Re: test binaries for Beta 5

2014-08-05 Thread Dirk Hohndel
On Tue, Aug 05, 2014 at 08:55:26AM -0300, Tomaz Canabrava wrote: > Em 05/08/2014 08:34, "Joakim Bygdell" escreveu: > > > > Well in this case I think it is more correct to tell subsurface not to > update the profile until the user has committed the final value by pressing > enter or tab. > > Becaus

Re: test binaries for Beta 5

2014-08-05 Thread Lubomir I. Ivanov
On 5 August 2014 16:55, Dirk Hohndel wrote: > On Tue, Aug 05, 2014 at 12:18:20PM +0300, Lubomir I. Ivanov wrote: >> On 5 August 2014 09:09, Dirk Hohndel wrote: >> > >> > We know that the 32bit/Qt4 Windows installer has printing issues - so >> > that's not the main goal of testing :-) >> > >> >> a

Re: test binaries for Beta 5

2014-08-05 Thread Dirk Hohndel
On Tue, Aug 05, 2014 at 01:02:27PM +0200, Robert Helling wrote: > > here is a patch that implements option 5) above. Thanks. You're clearly not on latest master, but I manually applied it. /D ___ subsurface mailing list subsurface@hohndel.org http://li

Re: test binaries for Beta 5

2014-08-05 Thread Dirk Hohndel
On Tue, Aug 05, 2014 at 12:18:20PM +0300, Lubomir I. Ivanov wrote: > On 5 August 2014 09:09, Dirk Hohndel wrote: > > > > We know that the 32bit/Qt4 Windows installer has printing issues - so > > that's not the main goal of testing :-) > > > > actually it should all work the same way as the Qt5 bu

Re: test binaries for Beta 5

2014-08-05 Thread Dirk Hohndel
On Tue, Aug 05, 2014 at 09:10:11AM +0200, Joakim Bygdell wrote: > Beta 5, Windows 8 64bit. > > Globe map: > Location pins show up correctly but the globe map doesn't scale properly > see image. This is consistent to what we see when Marble cannot get new tiles. I just blew my tile data away and t

Re: test binaries for Beta 5

2014-08-05 Thread Lubomir I. Ivanov
On 5 August 2014 13:25, Rainer Mohr wrote: > Printing looks fine, although the table has the same ugly unregular borders > (same as the mac version) we may have to figure a way to style the tables consistently. perhaps for the next version. lubomir --

Re: [RFC PATCH] Add 'create new trip' option for downloading dives from the dive computer

2014-08-05 Thread Jef Driesen
On 2014-07-22 20:24, Linus Torvalds wrote: On Tue, Jul 22, 2014 at 11:11 AM, Dirk Hohndel wrote: I'd say that the "private trip" is better than the Suunto DM3 dialog that Paul-Erik described. The private trip ends up being a similar kind of "preview dialog" for the newly downloaded dives, *but*

Re: [RFC PATCH] Add 'create new trip' option for downloading dives from the dive computer

2014-08-05 Thread Jef Driesen
On 2014-07-22 02:36, Linus Torvalds wrote: Last time this happened, I mentioned to Dirk that maybe we should have a "download only last N days" in the dive computer download logic, but that ends up having its own set of problems, like the fact that some dive computers will only download things

Re: test binaries for Beta 5

2014-08-05 Thread Robert Helling
On 05.08.2014, at 13:55, Tomaz Canabrava wrote: Hi, > Good catch. This is just a matter of changing the connect line for the gf > high to editfinished instead of value changed, can somebody do that for me? > Im on the dive store trying to buy my wet suit now, só I dont have a > computer. >

Re: test binaries for Beta 5

2014-08-05 Thread Richard DePas
> I just put three new installers up: > > > http://subsurface.hohndel.org/downloads/daily/subsurface-4.1.93-103-gc477f5602909-32bit-Qt4.exe > > http://subsurface.hohndel.org/downloads/daily/subsurface-4.1.93-103-gc477f5602909.exe > > http://subsurface.hohndel.org/downloads/daily/Subsurface-4.1.93-1

Re: Beta 5 (103) Equipment add issue

2014-08-05 Thread Richard DePas
> Have faith. =D > > > No worries. Was just making a note in case I missed the note of a fix and mentioned it while I saw the Equipment add issue. ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurf

Re: Beta 5 (103) Equipment add issue

2014-08-05 Thread Tomaz Canabrava
Richard, The print issue will be fixed before release, I fixed several inconsiatencies on printing in the last week, but the pictures are being a pain to find the error. Have faith. =D Em 05/08/2014 09:07, "Richard DePas" escreveu: > > First time I add a piece of equipment, it does not remain af

Beta 5 (103) Equipment add issue

2014-08-05 Thread Richard DePas
First time I add a piece of equipment, it does not remain after clicking Save. Seems to only happen the first time after opening the program. If I go in and add it again, it will work. If I move to another dive and add, it will work. In my case, I was adding a weight belt. Still seeing the picture

Re: test binaries for Beta 5

2014-08-05 Thread Tomaz Canabrava
Em 05/08/2014 08:34, "Joakim Bygdell" escreveu: > > Well in this case I think it is more correct to tell subsurface not to update the profile until the user has committed the final value by pressing enter or tab. > Because with latest master it recalculates the profile as soon as I enter the first

Re: test binaries for Beta 5

2014-08-05 Thread Joakim Bygdell
Well in this case I think it is more correct to tell subsurface not to update the profile until the user has committed the final value by pressing enter or tab. Because with latest master it recalculates the profile as soon as I enter the first digit meaning that it tries to calculate a profile wit

Re: test binaries for Beta 5

2014-08-05 Thread Robert Helling
On 05.08.2014, at 12:10, Robert Helling wrote:Hi,What shall we do about this?1) Nothing. We consider it a user error.2) Not allow setting GFhigh to values below 35% if “last stop at 6m” is selected (GFhigh=1% still allows to surface with the saturation at 3m, so the problem is

Re: test binaries for Beta 5

2014-08-05 Thread Robert Helling
On 05.08.2014, at 09:10, Joakim Bygdell wrote: Hi, > Planner: > Changing GF values by typing in a new value hangs subsurface if "last stop at > 6m" is checked. I did not realize this before, but indeed you can choose combinations of settings that make deco impossible (i.e. take infinitely l

Re: GSoC Progress: Configuring Dive Computers via Subsurface

2014-08-05 Thread Jef Driesen
On 2014-07-29 18:17, Dirk Hohndel wrote: On Mon, Jul 28, 2014 at 01:09:46PM -0700, Thiago Macieira wrote: By the way, I also told Josh that I would count the code he developed for libdivecomputer as part of his GSoC project, though I haven't seen any yet. Yes, Jef and I had discussed that bri

Re: [PATCH] HTML export patches

2014-08-05 Thread Paul-Erik Törrönen
Subsurface v4.1.93-103-gc477f5602909, built with libdivecomputer v0.4.2 FF31.0 on Linux Fedora 20 64bit. The graph shown in 'show more details' (should this be 'Show more details', ie. capital S?) does not by default show the pressure scale on the secondary Y-axis (on the right side). If I r

Re: GSOC project updates

2014-08-05 Thread Jef Driesen
On 2014-07-28 16:31, Venkatesh Shukla wrote: On Mon, Jul 28, 2014 at 7:17 PM, Dirk Hohndel wrote: So I see regular updates from Gehad (HTML export) and Andrey (IOS Companion), but I feel like I don’t really know where we are regarding libdivecomputer on Android and dive computer configuratio

Re: GSOC project updates

2014-08-05 Thread Jef Driesen
On 2014-07-28 15:47, Dirk Hohndel wrote: So I see regular updates from Gehad (HTML export) and Andrey (IOS Companion), but I feel like I don’t really know where we are regarding libdivecomputer on Android and dive computer configuration from Subsurface. Venkatesh and Joseph, could you send your l

Re: test binaries for Beta 5

2014-08-05 Thread Lubomir I. Ivanov
On 5 August 2014 12:30, Miika Turkia wrote: > On Tue, Aug 5, 2014 at 12:20 PM, Lubomir I. Ivanov > wrote: >> >> On 5 August 2014 06:40, Miika Turkia wrote: >> > Can someone also test the divelogs.de upload/download on Windows? >> > >> >> download(import) from divelogs.de works, but i can't find

Re: test binaries for Beta 5

2014-08-05 Thread Miika Turkia
On Tue, Aug 5, 2014 at 12:20 PM, Lubomir I. Ivanov wrote: > On 5 August 2014 06:40, Miika Turkia wrote: > > Can someone also test the divelogs.de upload/download on Windows? > > > > download(import) from divelogs.de works, but i can't find where the > upload is. it used to be in the divelist con

Re: test binaries for Beta 5

2014-08-05 Thread Lubomir I. Ivanov
On 5 August 2014 06:40, Miika Turkia wrote: > Can someone also test the divelogs.de upload/download on Windows? > download(import) from divelogs.de works, but i can't find where the upload is. it used to be in the divelist context menu. lubomir -- ___

Re: test binaries for Beta 5

2014-08-05 Thread Lubomir I. Ivanov
On 5 August 2014 09:09, Dirk Hohndel wrote: > > We know that the 32bit/Qt4 Windows installer has printing issues - so > that's not the main goal of testing :-) > actually it should all work the same way as the Qt5 build, except the table print is in raster. re: tmpfile() i remember Miika wrote t

Re: test binaries for Beta 5

2014-08-05 Thread Lubomir I. Ivanov
On 5 August 2014 10:10, Joakim Bygdell wrote: > > Print preview: > > Notes are printed as one line even if they include line breaks. > > confirmed. but that's odd, i clearly remember it showed multiple lines a couple of days ago. has anyone done changes in that area? lubomir --