Re: [PATCH] Print nice names for nitrox mixes in the divelist

2014-08-16 Thread Davide DB
Davide@mobile Il 16/ago/2014 18:40 "Linus Torvalds" ha scritto: > > Side note: our worst offender is actually the date field. We print > date/time in a very verbose way, It's the same in the main screen divelist. ___ subsurface mailing list subsurface@h

Re: [PATCH] Print nice names for nitrox mixes in the divelist

2014-08-16 Thread Paul-Erik Törrönen
> I agree with linus. I don't understand why one would ever need the ean > prefix, it adds nothing. Indeed. BTW may I point out that there are already columns that have only the unit in the header. If you strife for consistency and clearness, then the most obvious fix would be to have (a two line

Re: [PATCH] Print nice names for nitrox mixes in the divelist

2014-08-16 Thread Geir Alstad
I agree with linus. I don't understand why one would ever need the ean prefix, it adds nothing. Besides, how are you going to tackle tmx? A tool tip or hover over menu with certain standard mixes would possibly fix the "issue". 16. aug. 2014 18:08 skrev "Linus Torvalds" følgende: > On Sat, Aug 16

Re: [PATCH] Print nice names for nitrox mixes in the divelist

2014-08-16 Thread Linus Torvalds
On Sat, Aug 16, 2014 at 10:28 AM, Robert C. Helling wrote: > > Let me suggest "32%" as a compromise. That should be clearer than a bare > number. And for trimix I would keep 18/50 without percent. For a range it > would be 28..35%. Yes, 32% certainly works fof me. It's no bigger than the headin

Re: [PATCH] Print nice names for nitrox mixes in the divelist

2014-08-16 Thread Robert C. Helling
> Am 16.08.2014 um 18:08 schrieb Linus Torvalds : > > THAT is much more confusing and subtle than "32" vs "EAN32". Let me suggest "32%" as a compromise. That should be clearer than a bare number. And for trimix I would keep 18/50 without percent. For a range it would be 28..35%. Best Robert

Re: [PATCH] Print nice names for nitrox mixes in the divelist

2014-08-16 Thread Linus Torvalds
On Sat, Aug 16, 2014 at 9:44 AM, Dirk Hohndel wrote: > > But to the average user, having the unit makes this more useful. Bah. It's not like it's all that confusing. If you have anything there at all, you're Nitrox certified, and you surely know about O2 percentages. A tool-tip (perhaps at just

Re: [PATCH] Print nice names for nitrox mixes in the divelist

2014-08-16 Thread Dirk Hohndel
On Sat, Aug 16, 2014 at 09:37:40AM -0600, Linus Torvalds wrote: > On Sat, Aug 16, 2014 at 9:33 AM, Dirk Hohndel wrote: > > > > How about EAN28...50 ? > > It's better, but quite frankly, what's the advantage of expanding that column? This all comes from the change of the column heading from "O₂"

Re: [PATCH] Print nice names for nitrox mixes in the divelist

2014-08-16 Thread Linus Torvalds
On Sat, Aug 16, 2014 at 9:33 AM, Dirk Hohndel wrote: > > How about EAN28...50 ? It's better, but quite frankly, what's the advantage of expanding that column? Quite frankly, we should *shrink* those things, not expand them. For example, putting the unit in the SAC rate column was exactly this sa

Re: [PATCH] Print nice names for nitrox mixes in the divelist

2014-08-16 Thread Joakim Bygdell
On 16 Aug 2014, at 17:33, Dirk Hohndel wrote: > On Sat, Aug 16, 2014 at 09:30:58AM -0600, Linus Torvalds wrote: >> On Sat, Aug 16, 2014 at 7:50 AM, Dirk Hohndel wrote: >>> >>> This does cost us more space (we always struggle with not wasting screen >>> space), but I think the value outweighs t

Re: [PATCH] Print nice names for nitrox mixes in the divelist

2014-08-16 Thread Dirk Hohndel
On Sat, Aug 16, 2014 at 09:30:58AM -0600, Linus Torvalds wrote: > On Sat, Aug 16, 2014 at 7:50 AM, Dirk Hohndel wrote: > > > > This does cost us more space (we always struggle with not wasting screen > > space), but I think the value outweighs the issue. > > I disagree. I disagree *violently* whe

Re: [PATCH] Print nice names for nitrox mixes in the divelist

2014-08-16 Thread Linus Torvalds
On Sat, Aug 16, 2014 at 7:50 AM, Dirk Hohndel wrote: > > This does cost us more space (we always struggle with not wasting screen > space), but I think the value outweighs the issue. I disagree. I disagree *violently* when it comes to the idiotic double EAN. The string "EAN28...EAN50" is a *hell

Re: [PATCH] Print nice names for nitrox mixes in the divelist

2014-08-16 Thread Dirk Hohndel
On Sat, Aug 16, 2014 at 03:47:05PM +0200, Anton Lundin wrote: > >@@ -453,9 +454,9 @@ char *get_dive_gas_string(struct dive *dive) > > snprintf(buffer, MAX_GAS_STRING, "%d/%d", o2, he); > > else if (o2) > > if (o2 == o2low) > >-

Re: [PATCH] Print nice names for nitrox mixes in the divelist

2014-08-16 Thread Dirk Hohndel
On Sat, Aug 16, 2014 at 03:08:38PM +0200, Joakim Bygdell wrote: > Since we changed the name of the O2 column to gas lets print common > names for nitrox mixes instead of just the %O2. This does cost us more space (we always struggle with not wasting screen space), but I think the value outweighs t

Re: [PATCH] Print nice names for nitrox mixes in the divelist

2014-08-16 Thread Anton Lundin
On 16 August, 2014 - Joakim Bygdell wrote: > Since we changed the name of the O2 column to gas lets print common names for > nitrox mixes instead of just the %O2. > >diff --git a/divelist.c b/divelist.c >index 75ad42f..10ce066 100644 >--- a/divelist.c >+++ b/divelist.c >@@ -1,3 +1,4 @@ >+ Stra

[PATCH] Print nice names for nitrox mixes in the divelist

2014-08-16 Thread Joakim Bygdell
Since we changed the name of the O2 column to gas lets print common names for nitrox mixes instead of just the %O2. 0001-Print-nice-names-for-nitrox-mixes-in-the-divelist-in.patch Description: Binary data /Jocke ___ subsurface mailing list subsurfa