Thanks. Maybe the time unit should be "min" instead of "m" as I associate
the latter to meters in this context. I just went ahead and changed this in
your patch before sending out.
miika
On Mon, Aug 18, 2014 at 1:08 AM, Gehad Elrobey
wrote:
> I re-attached the patch and sent two other fixes.
>
I re-attached the patch and sent two other fixes.
On Sun, Aug 17, 2014 at 6:59 PM, Miika Turkia
wrote:
> Following patch breaks the gas consumption graph:
>
> b06b0cd008a76b28f29f6f9fc649ed08e56e6207 HTML: Fix Fake precision
> value.
>
> miika
>
>
>
>
> On Sun, Aug 17, 2014 at 1:21 AM, Geha
Following patch breaks the gas consumption graph:
b06b0cd008a76b28f29f6f9fc649ed08e56e6207 HTML: Fix Fake precision value.
miika
On Sun, Aug 17, 2014 at 1:21 AM, Gehad Elrobey
wrote:
> I attached fixes to some minor bugs that Dirk has mentioned before.
>
> Regards,
> Gehad
>
>
> On Thu,
I attached fixes to some minor bugs that Dirk has mentioned before.
Regards,
Gehad
On Thu, Aug 14, 2014 at 8:10 AM, Gehad Elrobey
wrote:
> Hi miika,
>
> I attached patches for the mentioned bug and other random fixes.
> Now I think the exports are quite stable.
>
> There is one remaining known
Hi miika,
I attached patches for the mentioned bug and other random fixes.
Now I think the exports are quite stable.
There is one remaining known bug in the keyboard arrows navigation between
dives I will fix it and submit a patch later.
I ll also work on some style enhancement.
thanks.
On Sun
Thanks. I just fixed a few typos and will send versions with my SOB... I'd
be interested in testing the multilingual support, but to test it properly
requires the translations to be available.
The bug I mentioned earlier about the missing trips seems to occur when
exporting selected dives. Even if
Hi miika,
Here are another four patches on the top of the previously sent patches.
This is a try to make the HTML exports Multilingual I also fixed some bugs.
I still need to update the user-manual if you find that these patches are
good.
Thanks.
On Fri, Aug 8, 2014 at 6:22 PM, Miika Turkia wr
On Fri, Aug 8, 2014 at 5:32 PM, Gehad Elrobey
wrote:
> I have attached some patches that improves the statistics table view and
> fix the cells layout.
>
> Thanks, I'll take a look later.
>
>
> On Mon, Aug 4, 2014 at 6:40 PM, Miika Turkia
> wrote:
>
>> Looking good, but some more improvements n
I have attached some patches that improves the statistics table view and
fix the cells layout.
On Mon, Aug 4, 2014 at 6:40 PM, Miika Turkia wrote:
> Looking good, but some more improvements needed after a brief test:
>
> - When I export dives from one trip only, the trip mode sorting shows all
Looking good, but some more improvements needed after a brief test:
- When I export dives from one trip only, the trip mode sorting shows all
the exported dives under other.
- The yearly statistics layout needs some work, at least on my FF 30.0
- The table is too wide for my 1600 pix wide screen
Hi Miika,
Sorry for the delay, I had some family vacations this week.
I Implemented the yearly statistics into the HTML exports (Patches are
attached), also there are some patches not applied to current master yet..
I am waiting your feedback.
Regards,
Gehad
On Mon, Jul 28, 2014 at 5:14 PM, Mii
Thanks, you had one 'return' missing, which I added and did some rewording
on the commit messages.
The lines on the horizontal axis are a bit weird currently. Shown on the
attached screenshot. The depth and pressure units get misaligned due to the
static temperature fix (I guess).
miika
On Sun,
I Attached four patches that fix the mentioned bugs. I ll still work on
more improvements for the current javascript code.
Regards,
Gehad
On Fri, Jul 25, 2014 at 8:02 AM, Miika Turkia
wrote:
> On Thu, Jul 24, 2014 at 10:29 PM, Gehad Elrobey
> wrote:
>
>>
>> I attached a patch with two more fi
On Thu, Jul 24, 2014 at 10:29 PM, Gehad Elrobey
wrote:
>
> I attached a patch with two more fixes.
> Now most of the bugs list seems to be resolved.
>
It seems that the temperature graph is not drawn, if the temperature is
constant the whole dive.
The layout seems to change for me when I open a
I attached a patch with two more fixes.
Now most of the bugs list seems to be resolved.
what do you recommend to be added for now? and what things are missing or
need to be fixed as a priority?
On Mon, Jul 21, 2014 at 7:32 AM, Miika Turkia
wrote:
> On Mon, Jul 21, 2014 at 8:16 AM, Gehad Elrobey
Here is the latest set with my SOB and some typo fixes for the commit
messages.
Event value of 0 for the events that don't really have any value looks a
bit weird. would be a better choice, I suppose.
miika
On Mon, Jul 21, 2014 at 8:32 AM, Miika Turkia
wrote:
> On Mon, Jul 21, 2014 at 8:16
On Mon, Jul 21, 2014 at 8:16 AM, Gehad Elrobey
wrote:
>
> Hi miika,
>
> On Sun, Jul 20, 2014 at 8:02 AM, Miika Turkia
> wrote:
>
>> New bugs I spotted:
>>
>> - The tooltip on temperature graphs shows actually the time (concatenated
>> with temperature unit).
>>
>
> what is it supposed to show? I
Hi miika,
On Sun, Jul 20, 2014 at 8:02 AM, Miika Turkia
wrote:
> New bugs I spotted:
>
> - The tooltip on temperature graphs shows actually the time (concatenated
> with temperature unit).
>
what is it supposed to show? I think this is consistent will all the other
curves in the profile.
I Als
New bugs I spotted:
- The tooltip on temperature graphs shows actually the time (concatenated
with temperature unit).
- I am not sure about the search of location - e.g. if I write "Mexico
somethingthatdoesnotexist", I get all the locations in Mexico.
- Zooming in (ctrl++) and out (ctrl+-) and res
I Attached some bug fixes, Still working on the remaining bugs.
Regards,
Gehad.
On Tue, Jul 15, 2014 at 11:22 PM, Tomaz Canabrava
wrote:
> On Tue, Jul 15, 2014 at 4:31 PM, Anton Lundin wrote:
> > On 15 July, 2014 - Anton Lundin wrote:
> >
> >> On 15 July, 2014 - Miika Turkia wrote:
> >>
> >>
On Tue, Jul 15, 2014 at 4:31 PM, Anton Lundin wrote:
> On 15 July, 2014 - Anton Lundin wrote:
>
>> On 15 July, 2014 - Miika Turkia wrote:
>>
>> > A few more bugs:
>> > - Trimix dives are missing He content (use e.g. test20.xml for testing
>> > purposes) - Reported by Roberto, but mailing list was
On 15 July, 2014 - Anton Lundin wrote:
> On 15 July, 2014 - Miika Turkia wrote:
>
> > A few more bugs:
> > - Trimix dives are missing He content (use e.g. test20.xml for testing
> > purposes) - Reported by Roberto, but mailing list was not included
>
> Gaah. This is code that uses the event data
On 15 July, 2014 - Miika Turkia wrote:
> A few more bugs:
> - Trimix dives are missing He content (use e.g. test20.xml for testing
> purposes) - Reported by Roberto, but mailing list was not included
Gaah. This is code that uses the event data straight off. In the case of
SAMPLE_EVENT_GASCHANGE e
I'll not add other features until I send patches for the current bug list,
and leave the Worldmap integration for later development.
Thanks Miika and Poltsi for the testing.
Regards,
Gehad
On Tue, Jul 15, 2014 at 5:39 PM, Miika Turkia
wrote:
> A few more bugs:
> - Trimix dives are missing He c
A few more bugs:
- Trimix dives are missing He content (use e.g. test20.xml for testing
purposes) - Reported by Roberto, but mailing list was not included
- Gas change and heading events should have the value information shown;
mix and direction
- When there is no pressure samples, the y-axis on ri
On Tue, Jul 15, 2014 at 12:31 PM, "Paul-Erik Törrönen"
wrote:
> > If you have time and want to implement a worldmap integration to the
> > logbook export, it sure would be a nice to have feature. Of course it
> > would
> > be nice to know if other people are interested in using such feature with
> If you have time and want to implement a worldmap integration to the
> logbook export, it sure would be a nice to have feature. Of course it
> would
> be nice to know if other people are interested in using such feature with
> the HTML export.
Are you referring to 'the worldmap integration' whic
Here are the patches with my SOB along with some additional fixes.
should have a semi colon at the end ( ) - I fixed this along
with some other small errors that I noticed, some of them did sneak in in
earlier patches. Check out the attachments. Some other issues that I
spotted for you to fix:
Hi,
I did some progress in exporting photos, I attached two patches.
I am still working on improving the photos slider style and adding
additional dive data to the dive status.
Also do you think adding a Google map or some kind of maps to show the dive
location will be needed?
waiting for your f
Here are the latest patches with my SOB. This includes also the Rick's
patch that was missed.
On Fri, Jul 11, 2014 at 5:05 AM, Gehad Elrobey
wrote:
> I attached two patches with some fixes to the dive profile view.
>
> additionally, I am still can't view the thumbnails when I add photos to
> di
I attached two patches with some fixes to the dive profile view.
additionally, I am still can't view the thumbnails when I add photos to
dives, I think I am doing something wrong when adding photos.
does any type of export save Images?
Also there is a patch that Rick has sent 5 days ago which is
About the patches...
Why the commented lines below?
+for (var i = 0; i < items[dive_id].events.length; i++) {
+//var x = get_sample(items[dive_id].events[i].time);
+d3.push([
+items[dive_id].events[i].time / 60,
+0,
+//-1 * mm_to_meter(items
On Fri, Jul 4, 2014 at 1:59 AM, Gehad Elrobey
wrote:
> I attached some patches that
> -Fix the negative value of the depth axis.
> -Added temperature curve and events to profile.
> -Update user manual.
>
> About the (start and end pressures) null values bug, I found that these
> values are missin
Gehad,
On 4 Jul 2014 10:59, "Gehad Elrobey" wrote:
>
> I attached some patches that
> -Fix the negative value of the depth axis.
> -Added temperature curve and events to profile.
> -Update user manual.
>
> About the (start and end pressures) null values bug, I found that these
values are missing
I attached some patches that
-Fix the negative value of the depth axis.
-Added temperature curve and events to profile.
-Update user manual.
About the (start and end pressures) null values bug, I found that these
values are missing in the cylinder structure when the divecomputer
structure contains
This patches add the events to list to the detailed view.
This events will be rendered later to the profile.
Regards,
Gehad
On Wed, Jun 25, 2014 at 12:36 PM, Miika Turkia
wrote:
> Libdivecomputer.c has events structure that shows meaning of the events
> (function handle_event). Just check from
Libdivecomputer.c has events structure that shows meaning of the events
(function handle_event). Just check from a sample dive that I am correct.
Tablet is a poor tool to check code...
I believe the deleted means that user has deleted the event and does not
want to see it anymore.
miika
On Jun 24
I was lately working on exporting event list, I will send some patches for
that today.
I don't understand well the event structure in dive.h , I don't know what
is the 'deleted' flag, and the type what do these numbers mean ? is there a
look-up table for there meaning or some enums? some help in t
On Tue, Jun 24, 2014 at 04:01:40PM +0300, Miika Turkia wrote:
>
> I will send Gehad's patch-set from the 17th with my signed-off as a
> separate set of mail (using git e-mail), as poor Internet connection
> over here forces me to use HTML-only gmail and that does not seem to
> support attachments.
Hello,
I will send Gehad's patch-set from the 17th with my signed-off as a
separate set of mail (using git e-mail), as poor Internet connection
over here forces me to use HTML-only gmail and that does not seem to
support attachments. I will skip the one from 19th that switches to
Highchart as the
On Mon, Jun 23, 2014 at 02:33:26PM +0800, Miika Turkia wrote:
> >
> > Please Have a look on the licensing of this library
> > (http://www.highcharts.com/license) as Dirk has mentioned that it must be
> > GPL companionable and I am not sure about that.
>
> I guess this is up to Dirk. Looks to b
Sorry to be slow to respond to this... The last two hotels had no internet
so all I have is my phone.
I still need to review the license and figure this out. Hopefully tonight
I'll have real internet again. Right now I don't even have power...
/D
On June 24, 2014 2:34:36 AM Gehad Elrobey wro
On Mon, Jun 23, 2014 at 9:33 AM, Miika Turkia
wrote:
>
>
> On 22 Jun 2014, at 19:19, Gehad Elrobey wrote:
>
>
>
> On Sun, Jun 22, 2014 at 1:46 PM, Miika Turkia
> wrote:
>
>> Can you post sample screenshots of both versions? Compiling code will
>> have to wait a bit for me...
>>
>
> I Attached t
23. juni 2014 08:33 skrev "Miika Turkia" følgende:
>> Please Have a look on the licensing of this library (
http://www.highcharts.com/license) as Dirk has mentioned that it must be
GPL companionable and I am not sure about that.
>
>
> I guess this is up to Dirk. Looks to be free for non-commercia
> On 22 Jun 2014, at 19:19, Gehad Elrobey wrote:
>
>
>
>> On Sun, Jun 22, 2014 at 1:46 PM, Miika Turkia wrote:
>> Can you post sample screenshots of both versions? Compiling code will have
>> to wait a bit for me...
>>
>
> I Attached two screenshots one using native HTML5 and the other us
Can you post sample screenshots of both versions? Compiling code will have
to wait a bit for me...
Miika
Hi,
This is a patch on the top of the 4 patches I sent two days ago. This
mainly changes the profile to Highchart graph instead of the HTML5 canvas,
This patch still needs more working and for
On Thu, Jun 19, 2014 at 7:52 PM, Tomaz Canabrava wrote:
> veyr good gehad, I'm very much in love with the outcome of your patches. :)
>
>
Thanks Tomaz, Do you have any comments regarding the dive profile?
> On Thu, Jun 19, 2014 at 1:34 PM, Gehad Elrobey
> wrote:
> > Hi,
> >
> > This is a patc
veyr good gehad, I'm very much in love with the outcome of your patches. :)
On Thu, Jun 19, 2014 at 1:34 PM, Gehad Elrobey wrote:
> Hi,
>
> This is a patch on the top of the 4 patches I sent two days ago. This mainly
> changes the profile to Highchart graph instead of the HTML5 canvas, This
> pat
Hi,
This is a patch on the top of the 4 patches I sent two days ago. This
mainly changes the profile to Highchart graph instead of the HTML5 canvas,
This patch still needs more working and format and style fixing. Also I
need to add another Data to the JSON file.
But I send it now so you can comp
On Tue, Jun 17, 2014 at 1:12 AM, Gehad Elrobey
wrote:
>
>
>
> On Sun, Jun 15, 2014 at 7:55 AM, Miika Turkia
> wrote:
>
>> Here is the latest set of Gehad's patches with my singed-off included. I
>> have also some comments here.
>>
>> - You delete the theme.css but not the other template files wh
Here is the latest set of Gehad's patches with my singed-off included. I
have also some comments here.
- You delete the theme.css but not the other template files when copying?
If any other of the template files has changed in Subsurface, they are not
updated.
- The detailed view does not work for
Here is a list of updated patches.
I am also having good progress with Highcharts, I will send it as soon as I
finish so you can compare Highcharts work that requires JQuery with the
Native plots in this list of patches.
On Fri, Jun 13, 2014 at 7:06 PM, Dirk Hohndel wrote:
> On Fri, Jun 13, 20
On Fri, Jun 13, 2014 at 06:54:59PM +0300, Miika Turkia wrote:
> if the license allows us to bundle the stuff on our build and the needed
> stuff is reasonably sized, then that might be fine by me. Dirk, your
> opinion?
It has to be under a GPL compatible license. And can't be more than a few
hundr
On Fri, Jun 13, 2014 at 12:54 PM, Miika Turkia wrote:
> if the license allows us to bundle the stuff on our build and the needed
> stuff is reasonably sized, then that might be fine by me. Dirk, your
> opinion?
>
> I am not keen on adding too much of external stuff, but wasting time on
> something
if the license allows us to bundle the stuff on our build and the needed stuff
is reasonably sized, then that might be fine by me. Dirk, your opinion?
I am not keen on adding too much of external stuff, but wasting time on
something that others have already done (better?) does not make sense eit
just the one problem here. Out of tree build and contents of theme directory is
not updated on make.
miika
> On 12 Jun 2014, at 17:17, Dirk Hohndel wrote:
>
> On Thu, Jun 12, 2014 at 06:49:17AM +0300, Miika Turkia wrote:
>>> I'm not sure which files you mean.
>>> The js files get copied into t
On Fri, Jun 13, 2014 at 12:12 PM, Gehad Elrobey wrote:
>
> On Fri, Jun 13, 2014 at 5:05 PM, Tomaz Canabrava wrote:
>>
>> On Fri, Jun 13, 2014 at 11:15 AM, Gehad Elrobey
>> wrote:
>> > So I had a look about Highcharts which Poltsi has suggested,
>> > which looks much better and neater than the na
On Fri, Jun 13, 2014 at 5:05 PM, Tomaz Canabrava wrote:
> On Fri, Jun 13, 2014 at 11:15 AM, Gehad Elrobey
> wrote:
> > So I had a look about Highcharts which Poltsi has suggested,
> > which looks much better and neater than the native sketched curves.
> >
> > Anyway this will require us to add J
On Fri, Jun 13, 2014 at 11:15 AM, Gehad Elrobey wrote:
> So I had a look about Highcharts which Poltsi has suggested,
> which looks much better and neater than the native sketched curves.
>
> Anyway this will require us to add JQuery files plus the library files to
> the exports.
> I am not sure i
So I had a look about Highcharts which Poltsi has suggested,
which looks much better and neater than the native sketched curves.
Anyway this will require us to add JQuery files plus the library files to
the exports.
I am not sure if this will meet the requirements, I think it was required
not to u
On Thu, Jun 12, 2014 at 06:49:17AM +0300, Miika Turkia wrote:
> > I'm not sure which files you mean.
> > The js files get copied into their "official" place during make install.
> > But even when running from a build directory, they should be available to
> > copy into an export directory. If that
On Thu, Jun 12, 2014 at 6:41 AM, Dirk Hohndel wrote:
> On Thu, Jun 12, 2014 at 06:33:40AM +0300, Miika Turkia wrote:
> > On Wed, Jun 11, 2014 at 10:51 PM, Gehad Elrobey
> > wrote:
> >
> > >
> > >
> > >
> > > On Wed, Jun 11, 2014 at 9:41 PM, Miika Turkia
> > > wrote:
> > >
> > >> On Tue, Jun 10,
On Thu, Jun 12, 2014 at 06:33:40AM +0300, Miika Turkia wrote:
> On Wed, Jun 11, 2014 at 10:51 PM, Gehad Elrobey
> wrote:
>
> >
> >
> >
> > On Wed, Jun 11, 2014 at 9:41 PM, Miika Turkia
> > wrote:
> >
> >> On Tue, Jun 10, 2014 at 7:07 PM, Gehad wrote:
> >>
> >>> I attached my progress in the HTM
On Wed, Jun 11, 2014 at 10:51 PM, Gehad Elrobey
wrote:
>
>
>
> On Wed, Jun 11, 2014 at 9:41 PM, Miika Turkia
> wrote:
>
>> On Tue, Jun 10, 2014 at 7:07 PM, Gehad wrote:
>>
>>> I attached my progress in the HTML exporter,
>>> My work was basically adding a detailed dive view that shows more dive
On Wed, Jun 11, 2014 at 9:41 PM, Miika Turkia
wrote:
> On Tue, Jun 10, 2014 at 7:07 PM, Gehad wrote:
>
>> I attached my progress in the HTML exporter,
>> My work was basically adding a detailed dive view that shows more dive
>> info,and added a simple dive profile and dive equipments list to the
On Tue, Jun 10, 2014 at 7:07 PM, Gehad wrote:
> I attached my progress in the HTML exporter,
> My work was basically adding a detailed dive view that shows more dive
> info,and added a simple dive profile and dive equipments list to the
> detailed view.
>
Seems that this is not working on my Fir
>> This is why I thought we should only export the most important curves in
>> the view, and leave the least important ones as an options. This will help
>> us to have handy exports and easily portable.
Then my list of importance would be:
* Pressure (with gas switches if possible)
* Temperature
Actually this should have been sent to the mailing list, My phone client
doesn't reply all by default. Sorry for that.
-- Forwarded message --
From: "Gehad Elrobey"
Date: 11 Jun 2014 11:14
Subject: Re: My progress in HTML export.
To:
Cc:
>
> On 11 Jun
> I am not familiar with the dive profile anyway so I am willing to know
> your feedback and if you have any recommendations. I need to know what
> is the most important curves that we need to sketch in the profile.
Everything? Which is shown in the application graph (the information box
when hove
Em ter 10 jun 2014, às 19:07:28, Gehad escreveu:
> + QString json_dive_data = exportFiles + QDir::separator() +
> "file.json";
> + QString json_settings = exportFiles +
> QDir::separator() + "settings.json";
Note that you only need to use QDir::separator() if you're constructing a fil
I attached my progress in the HTML exporter,
My work was basically adding a detailed dive view that shows more dive
info,and added a simple dive profile and dive equipments list to the
detailed view.
I am not familiar with the dive profile anyway so I am willing to know
your feedback and if you ha
71 matches
Mail list logo
