On Wed, Apr 2, 2014 at 10:38 PM, Lubomir I. Ivanov wrote:
>
> >
>
> hello,
> parts of the patch uses spaces instead of tabs for indentation.
>
> lubomir
> --
>
Thanks for the correction, Lubomir. I forgot to reformat the source.
New patch attached.
From d9c248531c970af8afb32edd02f6624ea6965df5 Mo
On 2 April 2014 22:33, Joshua Joseph wrote:
> On Wed, Apr 2, 2014 at 8:54 PM, Dirk Hohndel wrote:
>>
>> I'm willing to take a version of the patch before you and Thiago figure
>> out the OS detection. But the current version still needs some work :-)
>>
> Hi Dirk,
>
> Attached is the updated pat
On Wed, Apr 2, 2014 at 8:54 PM, Dirk Hohndel wrote:
>
> I'm willing to take a version of the patch before you and Thiago figure
> out the OS detection. But the current version still needs some work :-)
>
> Hi Dirk,
Attached is the updated patch.
From 491b96a76b3e0eef413bd17a0c0ecd83e870eda9 Mon
On Wed, Apr 2, 2014 at 10:05 PM, Joshua Joseph wrote:
>
>
> See the attached updated patch.
>
> Here is the patch.
From 0a5b483c81fd5820bfc3263750c2a21083338559 Mon Sep 17 00:00:00 2001
From: "Joseph W. Joshua"
Date: Wed, 2 Apr 2014 21:59:36 +0300
Subject: [PATCH] Add "Check for updates" Feature
On Wed, Apr 2, 2014 at 8:54 PM, Dirk Hohndel wrote:
>
> I'm willing to take a version of the patch before you and Thiago figure
> out the OS detection. But the current version still needs some work :-)
>
> Hi,
See the attached updated patch.
--
Joshua W Joseph
___
Em qua 02 abr 2014, às 20:37:58, Joshua Joseph escreveu:
> I had used SubsurfaceWebServices::manager(). Are they different?
They're the same. I had missed this, sorry about it.
You're using the right solution now.
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software A
On Wed, 2014-04-02 at 09:56 +0300, Joshua Joseph wrote:
> On Thu, Mar 6, 2014 at 10:03 PM, Dirk Hohndel
> wrote:
> BTW: is there a QT function that gives us a nice "OS Version"?
> I looked at QSysInfo and that's not all that useful.
>
> I was thinking of something
>
> Hi Josh
>
> We'll work on the OS detection feature together. I need to finish the
> patches
> for Qt 5.4. Once that is done, we can backport the changes into subsurface.
>
> Ok
> On the patch itself, it looks good, except that it leaks memory: you never
> delete the UpdateManager object and yo
Em qua 02 abr 2014, às 09:56:08, Joshua Joseph escreveu:
> Hi Dirk,
>
> See the attached updated patch, I hope it is OK. I am still working on the
> OS detection feature.
Hi Josh
We'll work on the OS detection feature together. I need to finish the patches
for Qt 5.4. Once that is done, we can
On Thu, Mar 6, 2014 at 10:03 PM, Dirk Hohndel wrote:
>
> BTW: is there a QT function that gives us a nice "OS Version"?
> I looked at QSysInfo and that's not all that useful.
>
> I was thinking of something like a little more versatile :-)
>
Hi Dirk,
See the attached updated patch, I hope it is
On Fri, Mar 7, 2014 at 4:37 AM, Thiago Macieira wrote:
> Em qui 06 mar 2014, às 11:08:00, Thiago Macieira escreveu:
>> Em qui 06 mar 2014, às 11:03:17, Dirk Hohndel escreveu:
>> > BTW: is there a QT function that gives us a nice "OS Version"?
>> > I looked at QSysInfo and that's not all that usefu
Em qui 06 mar 2014, às 11:08:00, Thiago Macieira escreveu:
> Em qui 06 mar 2014, às 11:03:17, Dirk Hohndel escreveu:
> > BTW: is there a QT function that gives us a nice "OS Version"?
> > I looked at QSysInfo and that's not all that useful.
> >
> > I was thinking of something like a little more ve
On Thu, 2014-03-06 at 10:57 -0800, Thiago Macieira wrote:
> Em qua 05 mar 2014, às 16:50:20, Joshua Joseph escreveu:
> > Hi,
> >
> > The attached patch implements the check for updates feature for windows and
> > mac.
>
> Why are you translating the URL? Do you expect it to be localised?
Missed
On 3/6/14, Thiago Macieira wrote:
> This is what I meant in the other email: why are you requesting that the URL
>
> be translated?
>
I overlooked this. I will change it.
___
subsurface mailing list
subsurface@hohndel.org
http://lists.hohndel.org/cgi-bi
On 3/6/14, Dirk Hohndel wrote:
> On Wed, 2014-03-05 at 16:50 +0300, Joshua Joseph wrote:
> when presenting the link with the latest version - can this be made
> clickable so that it open that link in a browser (and therefore starts
> the download)?
I will check on this. The link is clickable on m
Em qui 06 mar 2014, às 11:03:17, Dirk Hohndel escreveu:
> BTW: is there a QT function that gives us a nice "OS Version"?
> I looked at QSysInfo and that's not all that useful.
>
> I was thinking of something like a little more versatile
There is QSysInfo::macVersion() and QSysInfo::windowsVersion
Em qua 05 mar 2014, às 16:50:20, Joshua Joseph escreveu:
> +UpdateManager::UpdateManager(QObject *parent) :
> + QObject(parent)
> +{
> + manager = new QNetworkAccessManager(this);
We have a global QNetworkAccessManager singleton already (see
WebServices::manager()). Please use it inst
Em qua 05 mar 2014, às 16:50:20, Joshua Joseph escreveu:
> Hi,
>
> The attached patch implements the check for updates feature for windows and
> mac.
Why are you translating the URL? Do you expect it to be localised?
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Softwa
On Wed, 2014-03-05 at 16:50 +0300, Joshua Joseph wrote:
> Hi,
>
> The attached patch implements the check for updates feature for windows and
> mac.
A few comments...
I would much rather like the app to figure out the OS it's running on at
runtime. It would be useful for us to know if people ru
Hi,
The attached patch implements the check for updates feature for windows and mac.
Joshua.
From 23b38aa9d9cce02f80fff8d7019033bf8b7bfe5c Mon Sep 17 00:00:00 2001
From: Joshua Wambua
Date: Wed, 5 Mar 2014 14:38:56 +0300
Subject: [PATCH 28/28] Add "Check For Updates" Feature
This patch adds a
20 matches
Mail list logo
