Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Gehad Elrobey
On Thu, Jun 4, 2015 at 7:52 PM, Lubomir I. Ivanov wrote: > On 4 June 2015 at 19:42, Dirk Hohndel wrote: > > On Thu, Jun 04, 2015 at 05:47:02PM +0200, Guillaume Gardet wrote: > >> Le 04/06/2015 17:43, Lubomir I. Ivanov a écrit : > >> >On 4 June 2015 at 18:27, Lubomir I. Ivanov > wrote: > >> >>-

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Lubomir I. Ivanov
On 4 June 2015 at 21:39, Dirk Hohndel wrote: > On Thu, Jun 04, 2015 at 09:13:34PM +0300, Lubomir I. Ivanov wrote: >> replies: >> >> https://github.com/torvalds/subsurface/commit/3f3937f908b5c0044aef1caa196511469103daa7#commitcomment-11525543 >> > Why is this hard coded to A4? This should simply us

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Dirk Hohndel
On Thu, Jun 04, 2015 at 09:13:34PM +0300, Lubomir I. Ivanov wrote: > replies: > > https://github.com/torvalds/subsurface/commit/3f3937f908b5c0044aef1caa196511469103daa7#commitcomment-11525543 > > Why is this hard coded to A4? This should simply use the printer's default > > page size > > intenti

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Gehad Elrobey
On Thu, Jun 4, 2015 at 8:13 PM, Lubomir I. Ivanov wrote: > On 4 June 2015 at 20:02, Dirk Hohndel wrote: > > On Thu, Jun 04, 2015 at 05:58:10PM +0300, Lubomir I. Ivanov wrote: > >> So this is the initial work from Gehad. I'm looking forward to getting > this in > >> master as he needs to continut

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Lubomir I. Ivanov
On 4 June 2015 at 20:02, Dirk Hohndel wrote: > On Thu, Jun 04, 2015 at 05:58:10PM +0300, Lubomir I. Ivanov wrote: >> So this is the initial work from Gehad. I'm looking forward to getting this >> in >> master as he needs to continute the work into the template specific logic. >> Rebasing all the

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Lubomir I. Ivanov
On 4 June 2015 at 20:20, Dirk Hohndel wrote: > On Thu, Jun 04, 2015 at 10:02:28AM -0700, Dirk Hohndel wrote: >> On Thu, Jun 04, 2015 at 05:58:10PM +0300, Lubomir I. Ivanov wrote: >> > So this is the initial work from Gehad. I'm looking forward to getting >> > this in >> > master as he needs to co

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Lubomir I. Ivanov
On 4 June 2015 at 19:42, Dirk Hohndel wrote: > On Thu, Jun 04, 2015 at 05:47:02PM +0200, Guillaume Gardet wrote: >> Le 04/06/2015 17:43, Lubomir I. Ivanov a écrit : >> >On 4 June 2015 at 18:27, Lubomir I. Ivanov wrote: >> >>- should we in the meantime add -DNO_PRINTING=1 to build.sh? >> >> >> >^

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Dirk Hohndel
On Thu, Jun 04, 2015 at 10:02:28AM -0700, Dirk Hohndel wrote: > On Thu, Jun 04, 2015 at 05:58:10PM +0300, Lubomir I. Ivanov wrote: > > So this is the initial work from Gehad. I'm looking forward to getting this > > in > > master as he needs to continute the work into the template specific logic. >

Re: build script problem

2015-06-04 Thread Dirk Hohndel
On Thu, Jun 04, 2015 at 07:06:22PM +0200, Willem Ferguson wrote: > On 04/06/2015 18:38, Cristian Ionescu-Idbohrn wrote: > >Now, really... Why do you state that? _That's_ silly. `man 1 bash': > > > >, > >| BUGS > >|It's too big and too slow. > >| > >|There are some subtle differences

Re: build script problem

2015-06-04 Thread Willem Ferguson
On 04/06/2015 18:38, Cristian Ionescu-Idbohrn wrote: Now, really... Why do you state that? _That's_ silly. `man 1 bash': , | BUGS | It's too big and too slow. | | There are some subtle differences between bash and traditional | versions of sh, mostly because of the POSIX

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Dirk Hohndel
On Thu, Jun 04, 2015 at 05:58:10PM +0300, Lubomir I. Ivanov wrote: > So this is the initial work from Gehad. I'm looking forward to getting this in > master as he needs to continute the work into the template specific logic. > Rebasing all the time while waiting on me for reviews must be a pain, so

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Dirk Hohndel
On Thu, Jun 04, 2015 at 05:47:02PM +0200, Guillaume Gardet wrote: > Le 04/06/2015 17:43, Lubomir I. Ivanov a écrit : > >On 4 June 2015 at 18:27, Lubomir I. Ivanov wrote: > >>- should we in the meantime add -DNO_PRINTING=1 to build.sh? > >> > >^ actually, that's pretty much the only thing i can saf

Re: build script problem

2015-06-04 Thread Cristian Ionescu-Idbohrn
On Thu, 4 Jun 2015, Dirk Hohndel wrote: > > On Jun 4, 2015, at 12:14 AM, Willem Ferguson > > wrote: > > > > I get this: > > > > src$ sh subsurface/scripts/build.sh > > exec 1> >(tee build.log) 2>&1 > > subsurface/scripts/build.sh: 21: subsurface/scripts/build.sh: Syntax error: > > redirection u

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Lubomir I. Ivanov
On 4 June 2015 at 18:47, Guillaume Gardet wrote: > Le 04/06/2015 17:43, Lubomir I. Ivanov a écrit : >> >> On 4 June 2015 at 18:27, Lubomir I. Ivanov wrote: >>> >>> - should we in the meantime add -DNO_PRINTING=1 to build.sh? >>> >> ^ actually, that's pretty much the only thing i can safely do ATM

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Guillaume Gardet
Le 04/06/2015 17:43, Lubomir I. Ivanov a écrit : On 4 June 2015 at 18:27, Lubomir I. Ivanov wrote: - should we in the meantime add -DNO_PRINTING=1 to build.sh? ^ actually, that's pretty much the only thing i can safely do ATM, as i can't test Linux and OSX. for instance, about the INSTALL in

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Lubomir I. Ivanov
On 4 June 2015 at 18:27, Lubomir I. Ivanov wrote: > - should we in the meantime add -DNO_PRINTING=1 to build.sh? > ^ actually, that's pretty much the only thing i can safely do ATM, as i can't test Linux and OSX. for instance, about the INSTALL instructions on Grantlee: Cross-building Subsurfac

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Lubomir I. Ivanov
On 4 June 2015 at 18:24, Dirk Hohndel wrote: > On Thu, Jun 04, 2015 at 05:18:51PM +0200, Anton Lundin wrote: >> On 04 June, 2015 - Benjamin wrote: >> >> > On 4 Jun 2015 18:02, "Lubomir I. Ivanov" wrote: >> > > >> > > On 4 June 2015 at 17:58, Lubomir I. Ivanov wrote: >> > > > "cmake -DNO_PRINTING

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Benjamin
Thank you On 4 Jun 2015 18:18, "Lubomir I. Ivanov" wrote: > On 4 June 2015 at 18:15, Benjamin wrote: > > > > How does one install Grantlee? From the repositories? From a tar.gz? > > building from source might be the preferred way: > https://www.gitorious.org/grantlee/pages/Home > > lubomir > --

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Dirk Hohndel
On Thu, Jun 04, 2015 at 05:18:51PM +0200, Anton Lundin wrote: > On 04 June, 2015 - Benjamin wrote: > > > On 4 Jun 2015 18:02, "Lubomir I. Ivanov" wrote: > > > > > > On 4 June 2015 at 17:58, Lubomir I. Ivanov wrote: > > > > "cmake -DNO_PRINTING" but mind that Grantlee will be a hard dependency >

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Anton Lundin
On 04 June, 2015 - Benjamin wrote: > On 4 Jun 2015 18:02, "Lubomir I. Ivanov" wrote: > > > > On 4 June 2015 at 17:58, Lubomir I. Ivanov wrote: > > > "cmake -DNO_PRINTING" but mind that Grantlee will be a hard dependency > if you > > > > cmake -DNO_PRINTING=1 > > > > lubomir > > -- > > __

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Lubomir I. Ivanov
On 4 June 2015 at 18:15, Benjamin wrote: > > How does one install Grantlee? From the repositories? From a tar.gz? building from source might be the preferred way: https://www.gitorious.org/grantlee/pages/Home lubomir -- ___ subsurface mailing list subs

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Benjamin
On 4 Jun 2015 18:02, "Lubomir I. Ivanov" wrote: > > On 4 June 2015 at 17:58, Lubomir I. Ivanov wrote: > > "cmake -DNO_PRINTING" but mind that Grantlee will be a hard dependency if you > > cmake -DNO_PRINTING=1 > > lubomir > -- > ___ > subsurface mailing

Re: GSoC - Customizable print formats

2015-06-04 Thread Lubomir I. Ivanov
On 2 June 2015 at 15:19, Gehad Elrobey wrote: > > I have removed the QObject inheritance from my Dive class and pushed to my > branch. > i've just sent a pull request; namely: [PULL REQUEST] GSoC Printing: initial batch of patches modified your commit messages at places. don't mind me skipping u

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Lubomir I. Ivanov
On 4 June 2015 at 17:58, Lubomir I. Ivanov wrote: > "cmake -DNO_PRINTING" but mind that Grantlee will be a hard dependency if you cmake -DNO_PRINTING=1 lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-div

[PULL REQUEST] GSoC Printing: initial batch of patches

2015-06-04 Thread Lubomir I. Ivanov
So this is the initial work from Gehad. I'm looking forward to getting this in master as he needs to continute the work into the template specific logic. Rebasing all the time while waiting on me for reviews must be a pain, so this is pending. As discussed this does break the current printing modu

[PATCH] GlobeGPS: add empty function for NO_MARBLE

2015-06-04 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" Signed-off-by: Lubomir I. Ivanov --- qt-ui/globe.cpp | 3 +++ qt-ui/globe.h | 1 + 2 files changed, 4 insertions(+) diff --git a/qt-ui/globe.cpp b/qt-ui/globe.cpp index 64f9caa..f8bf182 100644 --- a/qt-ui/globe.cpp +++ b/qt-ui/globe.cpp @@ -380,6 +380,9 @@ bool Glob

Re: build script problem

2015-06-04 Thread Dirk Hohndel
> On Jun 4, 2015, at 12:14 AM, Willem Ferguson > wrote: > > I get this: > > src$ sh subsurface/scripts/build.sh > exec 1> >(tee build.log) 2>&1 > subsurface/scripts/build.sh: 21: subsurface/scripts/build.sh: Syntax error: > redirection unexpected > > Am I only half awake again? (Arrived from

Dive Site Management - send the last patch that I forgot to include

2015-06-04 Thread Tomaz Canabrava
This makes the plus button work. sorry 0026-Make-the-plus-button-work.patch Description: Binary data ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: GSoC - Customizable print formats

2015-06-04 Thread Lubomir I. Ivanov
On 2 June 2015 at 15:19, Gehad Elrobey wrote: > > > On Sun, May 31, 2015 at 8:01 PM, Lubomir I. Ivanov > wrote: >> >> On 31 May 2015 at 08:59, Gehad Elrobey wrote: >> > >> > I think we can use standard c++ generic classes with grantlee as their >> > documentation says >> > http://www.grantlee.or

build script problem

2015-06-04 Thread Willem Ferguson
I get this: src$ sh subsurface/scripts/build.sh exec 1> >(tee build.log) 2>&1 subsurface/scripts/build.sh: 21: subsurface/scripts/build.sh: Syntax error: redirection unexpected Am I only half awake again? (Arrived from Tanzania at 3 am this morning, so only 2 brain cells firing) Kind regard