Re: [PATCH 2/3] Changes to bring pO2 representation in line with CodingStyle

Sorry for top posting, on my cell on the run, but I'd NAK this one because it changes the format of the settings xml, making it incompatible with older saves. The other parts of the patch I'm fine with. //Anton On September 5, 2015 12:25:34 AM GMT+02:00, Tim Wootton

Re: [Patch] String translation issues

On 5 September 2015 at 12:08, Salvador Cuñat wrote: > Good morning. > > There is a string in qt-ui/btdeviceselectiondialog.cpp which doesn't have a > good translation: > > >ui->dialogStatus->setText(tr("The local Bluetooth device was turned > %1.") >

[Patch] String translation issues

Good morning. There is a string in qt-ui/btdeviceselectiondialog.cpp which doesn't have a good translation: ui->dialogStatus->setText(tr("The local Bluetooth device was turned %1.") .arg(on? "ON" : "OFF")); as "turn on" translates to a word and "turn

Re: Problems building Subsurface on Ubuntu and Fedora

Easy to Fix, for some reason Grantlee is not being found. Go to your build directory and run ccmake .., go to the field saying Grantlee_dir - that should have the value not found, and put the correct one, wich should be install-root /lib/cmake/Grantlee5 Em sáb, 5 de set de 2015 13:36, Miika

Re: translations

On Sat, Sep 05, 2015 at 03:13:17PM +0200, Guillaume Gardet wrote: > Le 04/09/2015 18:53, Dirk Hohndel a écrit : > >Thanks for the reminder to deal with translations :-) > > > >I just pushed all the source string changes that have happened over the > >past six months to transifex. Once the bot over

Re: My first patch

Hi Guido, patches should go to the mailing list so more people can comment and review. I will try to comment on everything that I notice in here. The first comment, of course, is that this should NOT have been just one commit. There should have been many small commits that each do one thing.

Re: My first patch

OK, working on this some more... strlcpy isn't available on Windows (and appears not to be there by defauly on all Linux flavors that I have access to, either... some have it in bsd/string.h, some don't). So let's use the universally available strncpy instead. I removed all the "glerch" markings

Re: [PATCH 2/3] Changes to bring pO2 representation in line with CodingStyle

On 05/09/15 15:12, Dirk Hohndel wrote: > I took the other two, this one I'm not excited about. It basically changes > a) variable names (yeah, maybe not wrong, but too likely to break things > in subtle ways right now) true, not smart this close to release, sorry > b) as Anton pointed out, changes

Problems building Subsurface on Ubuntu and Fedora

Dirk, Miika, I cannot build the latest version (downloaded around 09h00 WCT, I assume it is SHA f9c32a58). I have identical symptoms on two independent machines (Fedora and Ubuntu). I could build Subsurface reliably on Ubuntu at least until SHA 2c4ae23ccc5d but it appears that something has

Re: [Patch] String translation issues

Le 05/09/2015 15:53, Dirk Hohndel a écrit : On Sat, Sep 05, 2015 at 12:25:57PM +0300, Lubomir I. Ivanov wrote: On 5 September 2015 at 12:08, Salvador Cuñat wrote: Good morning. There is a string in qt-ui/btdeviceselectiondialog.cpp which doesn't have a good

Re: Re[2]: Need help with GIT

On Sat, Sep 05, 2015 at 10:33:56AM -0300, Tomaz Canabrava wrote: > On Sat, Sep 5, 2015 at 10:17 AM, Guido Lerch wrote: > > > If shit can happen... it does, I followed your instructions but made a > > mistake, now my changes to the uemis-download.c > > are gone ... :-( HELP

Re: [Patch] String translation issues

On Sat, Sep 05, 2015 at 12:25:57PM +0300, Lubomir I. Ivanov wrote: > On 5 September 2015 at 12:08, Salvador Cuñat wrote: > > Good morning. > > > > There is a string in qt-ui/btdeviceselectiondialog.cpp which doesn't have a > > good translation: > > > > > >

Re: [Patch] String translation issues

2015-09-05 16:06 GMT+02:00 Dirk Hohndel : > > >>> > > >>hey salva, > > >>yes, ON/OFF should be added for translation as tr("ON"), tr("OFF"). > > >I wonder if it wouldn't be better to have > > > > > >ui->dialogStatus->setText(tr("The local Bluetooth device was %1.") > > >

Re: [Patch] String translation issues

2015-09-05 17:16 GMT+02:00 Salvador Cuñat : > > And looks like you applied the patch before the coffee. > > Do you want me to rework it ? > > Hmmm, you reworked it. So it was after the cofee. Thanks Dirk. Regards. Salva.

Re: Problems building Subsurface on Ubuntu and Fedora

On Sat, Sep 5, 2015 at 6:15 PM, Willem Ferguson wrote: > Dirk, Miika, > > I cannot build the latest version (downloaded around 09h00 WCT, I assume it > is SHA f9c32a58). I have identical symptoms on two independent machines > (Fedora and Ubuntu). > > I could build

Re: Re[2]: Need help with GIT

On Sat, Sep 5, 2015 at 10:17 AM, Guido Lerch wrote: > If shit can happen... it does, I followed your instructions but made a > mistake, now my changes to the uemis-download.c > are gone ... :-( HELP ! > Attached the terminal and what I did ... stupid me. I hope I can get

Re: [PATCH 2/3] Changes to bring pO2 representation in line with CodingStyle

I took the other two, this one I'm not excited about. It basically changes a) variable names (yeah, maybe not wrong, but too likely to break things in subtle ways right now) b) as Anton pointed out, changes file format So I'll skip this one entirely, not just the file format changes. /D On Fri,

Re: translations

Le 05/09/2015 16:22, Dirk Hohndel a écrit : On Sat, Sep 05, 2015 at 03:13:17PM +0200, Guillaume Gardet wrote: Le 04/09/2015 18:53, Dirk Hohndel a écrit : Thanks for the reminder to deal with translations :-) I just pushed all the source string changes that have happened over the past six

Re: Grantlee on Mac

On Sat, Sep 05, 2015 at 01:18:58AM +0300, Lubomir I. Ivanov wrote: > On 4 September 2015 at 23:28, Dirk Hohndel wrote: > > So I think I have figured it out. XCode 4.x miscompiles Grantlee. > > are only the plugins somehow bogus? > i wonder if all Qt plugin compiled with that

Re: CSV export no longer containing location name?

On Sun, Sep 6, 2015 at 2:11 AM, Lutz Vieweg wrote: > Hi, > > I used to print my dives from a spreadsheet software, using > CSV exports of my dives from Subsurface. > > But when I execute a CSV export from the current git master head, > the export does not contain one of the most