Re: Eclipse vs coding style

2015-10-05 Thread Dirk Hohndel
On Tue, Oct 06, 2015 at 06:26:44AM +, Giorgio Marzano wrote: > So which editors / ide are you guys using? Everybody with vi[m]? The CodingStyle document has settings for vim and emacs. I think quite a few people (including myself) use QtCreator which really makes it easier to write in Qt. I kn

Re: Eclipse vs coding style

2015-10-05 Thread Robert Helling
Giorgio, > On 06.10.2015, at 08:26, Giorgio Marzano > wrote: > > So which editors / ide are you guys using? Everybody with vi[m]? no. At heart, I am an EscapeMetaAltControlShift person. But I learned that Qt Creator can be really helpful when writing Qt stuff

Re: Eclipse vs coding style

2015-10-05 Thread Giorgio Marzano
So which editors / ide are you guys using? Everybody with vi[m]? Il giorno Mar 6 Ott 2015 08:19 Anton Lundin ha scritto: > On 06 October, 2015 - Giorgio Marzano wrote: > > > Could someone using eclipse please share the indentation and formatting > > options matching subsurface coding styles dire

Re: Eclipse vs coding style

2015-10-05 Thread Anton Lundin
On 06 October, 2015 - Giorgio Marzano wrote: > Could someone using eclipse please share the indentation and formatting > options matching subsurface coding styles directives? > > I don't think anyone else of the developers are using Eclipse. Once you have figured it out, write a patch for the

Eclipse vs coding style

2015-10-05 Thread Giorgio Marzano
Could someone using eclipse please share the indentation and formatting options matching subsurface coding styles directives? Thanks G ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/lis

Re: Issues building install with Marble

2015-10-05 Thread Dirk Hohndel
On Tue, Oct 06, 2015 at 08:54:34AM +1100, Rick Walsh wrote: > > Here is what I am usually doing > > $ git pull > > $ make -j4 > > $ make install > > > > make install complains about not finding /marbledata/maps > > > There is an issue with the cmake files not copying th

Re: Issues building install with Marble

2015-10-05 Thread Rick Walsh
Hi Guido, On 6 Oct 2015 08:45, "Guido Lerch" wrote: > > Sure > > 2015-10-05 23:44 GMT+02:00 Tomaz Canabrava : >> >> Then I'll ask you to wait a bit - I'll try to test this at home on the Mac. >> >> >> Em seg, 5 de out de 2015 18:43, Guido Lerch escreveu: >>> >>> 2015-10-05 23:41 GMT+02:00 Tomaz

Re: Issues building install with Marble

2015-10-05 Thread Guido Lerch
Sure 2015-10-05 23:44 GMT+02:00 Tomaz Canabrava : > Then I'll ask you to wait a bit - I'll try to test this at home on the > Mac. > > Em seg, 5 de out de 2015 18:43, Guido Lerch > escreveu: > >> 2015-10-05 23:41 GMT+02:00 Tomaz Canabrava : >> >>> >>> >>> On Mon, Oct 5, 2015 at 6:37 PM, Guido Ler

Re: Issues building install with Marble

2015-10-05 Thread Tomaz Canabrava
Then I'll ask you to wait a bit - I'll try to test this at home on the Mac. Em seg, 5 de out de 2015 18:43, Guido Lerch escreveu: > 2015-10-05 23:41 GMT+02:00 Tomaz Canabrava : > >> >> >> On Mon, Oct 5, 2015 at 6:37 PM, Guido Lerch >> wrote: >> >>> All, >>> >>> I would appreciate some help and

Re: Issues building install with Marble

2015-10-05 Thread Guido Lerch
2015-10-05 23:41 GMT+02:00 Tomaz Canabrava : > > > On Mon, Oct 5, 2015 at 6:37 PM, Guido Lerch wrote: > >> All, >> >> I would appreciate some help and some instructions on how to download >> the latest master and reproducibly make marble to work. >> >> Here is what I am usually doing >> $ git pul

Re: Issues building install with Marble

2015-10-05 Thread Tomaz Canabrava
On Mon, Oct 5, 2015 at 6:37 PM, Guido Lerch wrote: > All, > > I would appreciate some help and some instructions on how to download > the latest master and reproducibly make marble to work. > > Here is what I am usually doing > $ git pull > $ make -j4 > $ make install > > make install complains a

quick request for people with access to Windows Vista and 8 or newer

2015-10-05 Thread Dirk Hohndel
Could you download Beta 3, install it, run it and do the following - Click Log->Add dive - start typing in a Location When the completion drop down shows up, does it look like this White font on very very light blue gradient (i.e. unreadable - the screenshot is Windows 7) Or does it look li

Issues building install with Marble

2015-10-05 Thread Guido Lerch
All, I would appreciate some help and some instructions on how to download the latest master and reproducibly make marble to work. Here is what I am usually doing $ git pull $ make -j4 $ make install make install complains about not finding /marbledata/maps I am on MAC Yosemite looking at the

[PATCH] Try to fix the white font on Windows 7

2015-10-05 Thread Tomaz Canabrava
This should fix it. if not, it's a start and people that have windows should look at this patch to see how it can be fixed. From 1ad0a17232ff609887d0efb7d6f1294ef0a439d8 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Mon, 5 Oct 2015 18:20:19 -0300 Subject: [PATCH 2/2] Do not use White font o

Re: Testing beta 3

2015-10-05 Thread Dirk Hohndel
On Tue, Oct 06, 2015 at 12:08:54AM +0300, Lubomir I. Ivanov wrote: > > > > Faulting application name: subsurface.exe, version: 0.0.0.0, time stamp: > > 0x56114c6e > > Faulting module name: msvcrt.dll, version: 7.0.10240.16384, time stamp: > > 0x559f3e0e > > Exception code: 0xc005 > > Fault offs

[PATCH] do not incorrectly select UUID as dive site name

2015-10-05 Thread Tomaz Canabrava
<3 From 17906400364c08221a22afe3f3c62b133285b91b Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Mon, 5 Oct 2015 18:01:28 -0300 Subject: [PATCH] Do not incorrectly use the UUID as the dive name for some reason sometimes activating the dive via tab or enter gave us the wrong column, so simply

Re: Testing beta 3

2015-10-05 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 09:50:40PM +0100, Dirk Hohndel wrote: > On Mon, Oct 05, 2015 at 02:45:04PM +0300, Lubomir I. Ivanov wrote: > > On 5 October 2015 at 14:30, Steve wrote: > > > > > > And the same message box that states: > > > subsurface.exe has stopped working > > > > > > > could you please

Re: Testing beta 3

2015-10-05 Thread Lubomir I. Ivanov
On 5 October 2015 at 23:50, Dirk Hohndel wrote: > On Mon, Oct 05, 2015 at 02:45:04PM +0300, Lubomir I. Ivanov wrote: >> On 5 October 2015 at 14:30, Steve wrote: >> > >> > And the same message box that states: >> > subsurface.exe has stopped working >> > >> >> could you please: >> >> press the "Wi

Re: transalation - dive site geo lookup

2015-10-05 Thread Dirk Hohndel
On Tue, Oct 06, 2015 at 07:31:30AM +1100, Rick Walsh wrote: > On 6 Oct 2015 07:17, "Dirk Hohndel" wrote: > > > > On Mon, Oct 05, 2015 at 10:09:49PM +0200, Krzysztof Arentowicz wrote: > > > Hi, > > > > > > Could someone give me an explanation how dive site geo lookup options > work? > > > > > > "En

Re: Testing beta 3

2015-10-05 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 02:45:04PM +0300, Lubomir I. Ivanov wrote: > On 5 October 2015 at 14:30, Steve wrote: > > > > And the same message box that states: > > subsurface.exe has stopped working > > > > could you please: > > press the "Windows key" + R: > type: eventvwr > > goto WindowsLogs ->

[PATCH] Trip header format in dive list

2015-10-05 Thread Dirk Hohndel
this should have gone to the developer mailing list... Hi Giorgio, I continue to review this a little more strictly than I might normally do, simply to give you better ideas of what I prefer... On Mon, Oct 05, 2015 at 11:04:51AM +0200, Giorgio Marzano wrote: > From 29fde2898e04f839319e65d84092a

Re: [PATCH] Trip header format in dive list

2015-10-05 Thread Dirk Hohndel
Hi Giorgio, I continue to review this a little more strictly than I might normally do, simply to give you better ideas of what I prefer... On Mon, Oct 05, 2015 at 11:04:51AM +0200, Giorgio Marzano wrote: > From 29fde2898e04f839319e65d84092a6cb5e76a7f4 Mon Sep 17 00:00:00 2001 > From: Giorgio Marz

Re: transalation - dive site geo lookup

2015-10-05 Thread Rick Walsh
On 6 Oct 2015 07:17, "Dirk Hohndel" wrote: > > On Mon, Oct 05, 2015 at 10:09:49PM +0200, Krzysztof Arentowicz wrote: > > Hi, > > > > Could someone give me an explanation how dive site geo lookup options work? > > > > "Enable geocoding for dive site management" > > "Parse site without GPS data" > >

a gentle request to keep the list copied

2015-10-05 Thread Dirk Hohndel
I notice that a number of people have started to respond to me in personal email and not copy the list after a first answer to their email. I assume this is unintentional - some mailing lists have a default Reply-To to the list and so some people may be used to just hitting reply and expect that to

Re: transalation - dive site geo lookup

2015-10-05 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 10:09:49PM +0200, Krzysztof Arentowicz wrote: > Hi, > > Could someone give me an explanation how dive site geo lookup options work? > > "Enable geocoding for dive site management" > "Parse site without GPS data" > "Same format for existing dives" > > I have no idea what t

Re: [PATCH] qthelper.cpp: use the Roaming path on Win32

2015-10-05 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 08:36:11PM +0300, Lubomir I. Ivanov wrote: > On 5 October 2015 at 20:23, Lubomir I. Ivanov wrote: > > From: "Lubomir I. Ivanov" > > > > Dirk, please read the comments i've made and let see if this is > portable on the other OSes as i can't test on OSX and Linux (ATM). >

transalation - dive site geo lookup

2015-10-05 Thread Krzysztof Arentowicz
Hi, Could someone give me an explanation how dive site geo lookup options work? "Enable geocoding for dive site management" "Parse site without GPS data" "Same format for existing dives" I have no idea what they do and it makes translating somewhat difficult. These options are not covered in use

Re: [PATCH] Wrong maxdepth when splitting dives (WAS Re: 4.5 Beta 3)

2015-10-05 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 03:45:34PM +, Giorgio Marzano wrote: > I can see why it is important to have a well formatted code. Will pay more > attention to it > > Did you see the other one, about the trip headers? I did - but decided not to take it for 4.5. I'll send you feedback on it later ton

Re: [PATCH] qthelper.cpp: use the Roaming path on Win32

2015-10-05 Thread Lubomir I. Ivanov
On 5 October 2015 at 20:23, Lubomir I. Ivanov wrote: > From: "Lubomir I. Ivanov" > Dirk, please read the comments i've made and let see if this is portable on the other OSes as i can't test on OSX and Linux (ATM). with this patch the git cache files are now written exactly where the suggested u

[PATCH] qthelper.cpp: use the Roaming path on Win32

2015-10-05 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" On Win32 the Roaming path is recommended. The truth is every application picks either the Local or Roaming paths for no particular reason as the the difference is not that great and developers don't understand what Microsoft implied in the context of the paths. Roaming

Re: Beta 3 Testing

2015-10-05 Thread Lubomir I. Ivanov
On 5 October 2015 at 18:31, Dirk Hohndel wrote: > On Mon, Oct 05, 2015 at 03:13:17PM +0300, Lubomir I. Ivanov wrote: >> On 5 October 2015 at 06:02, Dirk Hohndel wrote: >> > On Mon, Oct 05, 2015 at 12:21:56AM +, John Smith wrote: >> > >> >> Added location. The first line (in location) is white

Re: [PATCH] Wrong maxdepth when splitting dives (WAS Re: 4.5 Beta 3)

2015-10-05 Thread Giorgio Marzano
I can see why it is important to have a well formatted code. Will pay more attention to it Did you see the other one, about the trip headers? Il giorno Lun 5 Ott 2015 17:41 Dirk Hohndel ha scritto: > On Mon, Oct 05, 2015 at 04:34:13PM +0100, Dirk Hohndel wrote: > > On Mon, Oct 05, 2015 at 05:19

Re: Beta 3 Testing

2015-10-05 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 02:14:40PM +0300, Lubomir I. Ivanov wrote: > i was able to figure out how to do that in NSIS... > > basically, what it does is before performing the uninstall the user > has a blank page with 2 checkboxes. one for removing the registry key > and one for removing the user di

Re: [PATCH] Wrong maxdepth when splitting dives (WAS Re: 4.5 Beta 3)

2015-10-05 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 04:34:13PM +0100, Dirk Hohndel wrote: > On Mon, Oct 05, 2015 at 05:19:35PM +0200, Giorgio Marzano wrote: > > Dirk, > > > > this patch should fix the wrong values in the max depth field for splitted > > dives. > > It does - I already have a more complete patch in my tree bu

Re: [PATCH] Wrong maxdepth when splitting dives (WAS Re: 4.5 Beta 3)

2015-10-05 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 05:19:35PM +0200, Giorgio Marzano wrote: > Dirk, > > this patch should fix the wrong values in the max depth field for splitted > dives. It does - I already have a more complete patch in my tree but haven't had a chance to push that out, yet. Sorry about that. I'll take y

Re: Beta 3 Testing

2015-10-05 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 03:13:17PM +0300, Lubomir I. Ivanov wrote: > On 5 October 2015 at 06:02, Dirk Hohndel wrote: > > On Mon, Oct 05, 2015 at 12:21:56AM +, John Smith wrote: > > > >> Added location. The first line (in location) is white text on light blue > >> background - its very difficu

[PATCH] Wrong maxdepth when splitting dives (WAS Re: 4.5 Beta 3)

2015-10-05 Thread Giorgio Marzano
Dirk, this patch should fix the wrong values in the max depth field for splitted dives. G 2015-10-04 20:05 GMT+02:00 Dirk Hohndel : > On Sun, Oct 04, 2015 at 07:30:39PM +0200, Giorgio Marzano wrote: > > Just noticed that split dives seems to have max depth (and i guess some > > other field) i

[PATCH] kmessagewidget: add a custom color scheme Information_Subsurface

2015-10-05 Thread Lubomir I. Ivanov
From: "Lubomir I. Ivanov" Information_Subsurface is now the default color scheme based on the Subsurface logo colors in KMessageWidget. Taking colors from the OS is a good practice and makes the app look consistent with how the user has customized the OS, but it becomes difficult to control the

Re: freedive mode

2015-10-05 Thread Giorgio Marzano
Jef, I just sent you a patch to embed temperature info in the dive profile so that when subsurface splits it each subdive has its own min and max temp. Please take a look at it G Il giorno Lun 5 Ott 2015 15:19 Jef Driesen ha scritto: > (moved the discussion to the developer mailinglist) > > O

Re: Beta 3 Testing

2015-10-05 Thread Miika Turkia
On Mon, Oct 5, 2015 at 12:52 PM, John Smith wrote: > > > >> > > My divecomputers seem to give the dives to me in the right order so I >> > > can't quite reproduce this here. So of you start with an empty dive >> > > file >> > > and load the 13 dives from your D4i they are not numbered in >> > > ch

Re: freedive mode

2015-10-05 Thread Jef Driesen
(moved the discussion to the developer mailinglist) On 2015-10-03 13:14, Dirk Hohndel wrote: On Sat, Oct 03, 2015 at 12:20:35AM -0700, Giorgio Marzano wrote: It could be another (and IMO better) way to handle freedive sessions. Libdivecomputer could return a list of single dives instead of me

Re: Beta 3 Testing

2015-10-05 Thread Lubomir I. Ivanov
On 5 October 2015 at 06:02, Dirk Hohndel wrote: > On Mon, Oct 05, 2015 at 12:21:56AM +, John Smith wrote: > >> Added location. The first line (in location) is white text on light blue >> background - its very difficult to read. > > Very easy to read here on Linux. Tried it in the Windows 10 V

Re: Testing beta 3

2015-10-05 Thread Lubomir I. Ivanov
On 5 October 2015 at 14:30, Steve wrote: > > And the same message box that states: > subsurface.exe has stopped working > could you please: press the "Windows key" + R: type: eventvwr goto WindowsLogs -> Applications. there should be an Error about Subsurface crashing recently. copy / paste t

RE: Testing beta 3

2015-10-05 Thread Steve
On Mon, Oct 05, 2015 at 09:11:15PM +1030, Steve wrote: > Tested 4.5 beta 3 and most things are working well. Good. > The patch from Salva regarding the XML element has fixed the dive site > notes line ending problems that I had reported earlier. Thanks. Excellent. I'm glad he figured this out

Re: Beta 3 Testing

2015-10-05 Thread Lubomir I. Ivanov
On 5 October 2015 at 13:19, Lubomir I. Ivanov wrote: > On 5 October 2015 at 13:10, Dirk Hohndel wrote: >> On Mon, Oct 05, 2015 at 12:18:08PM +0300, Lubomir I. Ivanov wrote: >>> On 5 October 2015 at 10:16, John Smith wrote: >>> > >>> >> > I had done an uninstall prior to installing but some of th

Re: Testing beta 3

2015-10-05 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 09:11:15PM +1030, Steve wrote: > Tested 4.5 beta 3 and most things are working well. Good. > The patch from Salva regarding the XML element has fixed the dive site notes > line ending problems that I had reported earlier. Thanks. Excellent. I'm glad he figured this out.

RE: Beta 3 Testing

2015-10-05 Thread John Smith
> > > My divecomputers seem to give the dives to me in the right order so I > > > can't quite reproduce this here. So of you start with an empty dive file > > > and load the 13 dives from your D4i they are not numbered in chronological > > > order? Or is this an issue because you first imported

Re: Translations

2015-10-05 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 11:47:58AM +0300, Lubomir I. Ivanov wrote: > > > > The string 584 is a pluralized string and its statement should be like > > the following: > > > > > > > > , %n dive(s) here) > > , %n > > dive(s) > > here) > > > > > > So in order to solve the issue, you could downlo

Testing beta 3

2015-10-05 Thread Steve
Tested 4.5 beta 3 and most things are working well. The patch from Salva regarding the XML element has fixed the dive site notes line ending problems that I had reported earlier. Thanks. Bluetooth from both modes and both OSTC and Shearwater computers now works well. Microsoft has also now

Re: Translation question

2015-10-05 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 11:06:37AM +0200, Davide DB wrote: > On Mon, Oct 5, 2015 at 10:54 AM, Lubomir I. Ivanov > wrote: > > > > i didn't translate them and i think either the UI needs to change so > > that these are mixed case (i.e. user-readable) or remove them from > > translation. > > > Me

Re: Beta 3 Testing

2015-10-05 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 07:16:39AM +, John Smith wrote: > > > > Deleted the logs and used the reset all settings button in preferences. > > > Most of the settings went back to default except - > > > > > > 1. Web Server Service ID was kept > > > > The userid can also be saved in your data f

Re: Beta 3 Testing

2015-10-05 Thread Lubomir I. Ivanov
On 5 October 2015 at 13:10, Dirk Hohndel wrote: > On Mon, Oct 05, 2015 at 12:18:08PM +0300, Lubomir I. Ivanov wrote: >> On 5 October 2015 at 10:16, John Smith wrote: >> > >> >> > I had done an uninstall prior to installing but some of the logs were >> >> > kept from the last installation and load

Re: Beta 3 Testing

2015-10-05 Thread Dirk Hohndel
On Mon, Oct 05, 2015 at 12:18:08PM +0300, Lubomir I. Ivanov wrote: > On 5 October 2015 at 10:16, John Smith wrote: > > > >> > I had done an uninstall prior to installing but some of the logs were > >> > kept from the last installation and loaded at startup. > >> > >> Yes, we intentionally keep set

Re: Lost most of my divesites

2015-10-05 Thread Dirk Hohndel
> On Oct 5, 2015, at 11:00 AM, Guido Lerch wrote: > > All, > > I downloaded the new master today, built it and ran SubSurface, after that I > loaded > a new dive from the Uemis and saved the log. Please don't CamelCase Subsurface. > After this most of my dive sites are gone showing the dive

Lost most of my divesites

2015-10-05 Thread Guido Lerch
All, I downloaded the new master today, built it and ran SubSurface, after that I loaded a new dive from the Uemis and saved the log. After this most of my dive sites are gone showing the dive site name as "from Uemis". I havent had this issue during my stay in Egypt where I loaded 15 dives from

Re: Beta 3 Testing

2015-10-05 Thread Lubomir I. Ivanov
On 5 October 2015 at 10:16, John Smith wrote: > >> > I had done an uninstall prior to installing but some of the logs were >> > kept from the last installation and loaded at startup. >> >> Yes, we intentionally keep settings and data files. Do you think that's a >> mistake? >> > Ater a uninstall I

Re: Translation question

2015-10-05 Thread Davide DB
On Mon, Oct 5, 2015 at 10:54 AM, Lubomir I. Ivanov wrote: > > i didn't translate them and i think either the UI needs to change so > that these are mixed case (i.e. user-readable) or remove them from > translation. Me too. I just copied as is. I thought they were some constant defines :) -- D

[PATCH] Trip header format in dive list

2015-10-05 Thread Giorgio Marzano
Ok, this is my second try :) I should have fixed coding style issues and I used QString to have the right localization of the trip header. G 2015-10-05 7:50 GMT+02:00 Giorgio Marzano : > Agree (I am from Italy). > > Do localization tools provide info on the date format? > > Otherwise " mm d

Re: Translation question

2015-10-05 Thread Lubomir I. Ivanov
On 22 September 2015 at 15:41, Guillaume Gardet wrote: > In Bluetooth related translations, we have : > UNPAIRED > PAIRED > AUTHORIZED_PAIRED > the source file comments them as "status labels". i see them as something border line user-readable and programmer-readable, leaning more tow

Re: Translations

2015-10-05 Thread Lubomir I. Ivanov
On 5 October 2015 at 08:11, Tim Wootton wrote: > On 04/10/15 22:43, Lubomir I. Ivanov wrote: >> On 5 October 2015 at 00:05, Tim Wootton wrote: >>> Transifex support reckon string 584 is the offending item, but I'm not >>> sure exactly what needs to be done to fix it. >>> >> quite odd as there is

Re: Translation question

2015-10-05 Thread Guillaume Gardet
Ping... Guillaume Le 22/09/2015 14:41, Guillaume Gardet a écrit : In Bluetooth related translations, we have : UNPAIRED PAIRED AUTHORIZED_PAIRED Should we translate it? If yes, is it ok to use spaces and special chars (such as 'é')? Guillaume __

RE: Beta 3 Testing

2015-10-05 Thread John Smith
> > I had done an uninstall prior to installing but some of the logs were > > kept from the last installation and loaded at startup. > > Yes, we intentionally keep settings and data files. Do you think that's a > mistake? > Ater a uninstall I would have expected a clean installation with no prev