Re: AppImage & BT with OSTC Sport

On 01 November, 2015 - Miika Turkia wrote: > Good news and bad news :D > > Bluetooth connection works when using the latest AppImage (4.5.1.6). > Downloading dives worked fine from OSTC Sport, reading the device > settings seemed to work ok and I was able to change the settings. > > However, the

Building from scratch on a MAC (El Captain)

Hi All, I am getting several warnings around libdivecomputer. WARNING: Target "Subsurface" requests linking to directory "/Users/glerch/src/libdivecomputer/include". Targets may link only to libraries. CMake is dropping the item. this is what ccmake looks like [image: Inline-Bild 1] I do

Website Fedora build instructions are missing libcurl-devel and libssh2-devel

Hi, The subject says it all. I just made a clean install of Fedora 23, and being lazy, copied the install instructions from https://subsurface-divelog.org/documentation/building/ into the terminal. The install instructions on the website do not include installing libcurl-devel and libssh2-devel.

double free or corruption error

Hi, double free or corruption error occurs when exitting Subsurface (with current clean build). To reproduce the error start Subsurface and hit Ctrl+q (or File->Quit). mermar@kaarya:~/ss$ ~/ss/subsurface/build/subsurface Plugins Directory: QDir( "/home/mermar/ss/subsurface/build" , nameFilters =

[PATCH] Fix M_PI with -std=c++11 on Mingw

From: "Lubomir I. Ivanov" The introduction of -std=c++11 breaks usage of M_PI in Mingw, but technically M_PI is not standard C or C++. Defining M_PI in units.h solves the issue. Signed-off-by: Lubomir I. Ivanov --- the Mingw math.h header does have the _USE_MATH_DEFINES macro check and it's on

Re: Start-up parameters locations

On 3 November 2015 at 13:39, John Smith wrote: > > > > On Mon, Nov 02, 2015 at 10:22:18AM +, John Smith wrote: >> I've been seeing a problem with cylinder data that I am trying to replicate >> so I decided to start again with a completely new installation on my W10 PC. >> > > It looks like W

Re: WARNING ! Read before you pull / build master !!

On 3 November 2015 at 06:18, Dirk Hohndel wrote: > > OK, now that I have ensured that no one will read this email but everyone > will instead pull master and build it to see what breaks... > > I just merged Tomaz' work on restructuring the sources and the cmake > infrastructure. This makes things

[PATCH 2/2] subsurfacestartup.c: don't double free 'default_filename'

From: "Lubomir I. Ivanov" 'default_filename' is obtained from system_default_filename() but system_default_filename() returns a static pointer the HEAP memory of which is handled in main(). Remove the free() for 'default_filename' free_prefs() to prevent a double free(). Signed-off-by: Lubomir

Re: double free or corruption error

On 3 November 2015 at 13:32, Martin Měřinský wrote: > #6 0x0072a8d7 in free_prefs () > at /home/mermar/ss/subsurface/subsurface > -core/subsurfacestartup.c:314 > #7 0x005429f8 in main (argc=1, argv=0x7ffccb1eaa48) > at /home/mermar/ss/subsurface/subsurface-desktop-main.cp

Re: WARNING ! Read before you pull / build master !!

On 03-11-2015 04:18, Dirk Hohndel wrote: I'm sure this will break a few things here and there. To increase the likelihood of that I added a few patches of my own that allow individual preferences for time and date format. Dirk: I've just built subsurface on my machine without any issues, aft

Re: UDDF crash

On 3 November 2015 at 06:24, Miika Turkia wrote: > > I would not be surprised, if there was still something more lurking around... > yours and Linus' patches make the file work. i'm sure everyone has noticed that the parsing of this file slow as heck, though...and it locks the UI, which could mak

Re: Building from scratch on a MAC (El Captain)

Hi All, It seems the build script doesn't work on El Captain. Here is what I did to make subsurface build. - ran build.shh - brew libssh2 - I found errors about libssh2 in the build Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the system variable OPENSSL_ROOT_DIR (missing

Re: WARNING ! Read before you pull / build master !!

Hey all. I'm aware of some of the issues and I'm fixing g them now. Tomaz Em 3 de nov de 2015 10:30, "Pedro Neves" escreveu: > On 03-11-2015 04:18, Dirk Hohndel wrote: > >> >> I'm sure this will break a few things here and there. To increase the >> likelihood of that I added a few patches of my

Re: Building from scratch on a MAC (El Captain)

Can you verify if you have a file named CMakeCache.txt in your sources directory? If you do, something happened that made you run cmake in the wrong folder, and you need to remove this. Em 3 de nov de 2015 11:46, "Guido Lerch" escreveu: > Hi All, > > It seems the build script doesn't work on El

Re: Start-up parameters locations

> > but the user folder can > contain the default dive log file and any modified printing templates, > which if lost will make the user mildly annoyed. > > if voted upon, i can send a patch. > > lubomir > -- I realise that, but if you recall you suggested having tick boxes allowing a basic un

Re: [PATCH] Fix M_PI with -std=c++11 on Mingw

On Tue, Nov 03, 2015 at 01:47:28PM +0200, Lubomir I. Ivanov wrote: > From: "Lubomir I. Ivanov" > > The introduction of -std=c++11 breaks usage of M_PI in Mingw, > but technically M_PI is not standard C or C++. > > Defining M_PI in units.h solves the issue. This is one of those things that just

Re: Start-up parameters locations

On Tue, Nov 03, 2015 at 02:47:23PM +, John Smith wrote: > > > > but the user folder can > > contain the default dive log file and any modified printing templates, > > which if lost will make the user mildly annoyed. > > > > if voted upon, i can send a patch. > > I realise that, but if you r

Re: UDDF crash

On Tue, Nov 03, 2015 at 02:43:50PM +0200, Lubomir I. Ivanov wrote: > On 3 November 2015 at 06:24, Miika Turkia wrote: > > > > I would not be surprised, if there was still something more lurking > > around... > > yours and Linus' patches make the file work. > i'm sure everyone has noticed that th

Re: Website Fedora build instructions are missing libcurl-devel and libssh2-devel

On Tue, Nov 03, 2015 at 09:10:26PM +1100, Rick Walsh wrote: > Hi, > > The subject says it all. I just made a clean install of Fedora 23, and > being lazy, copied the install instructions from > https://subsurface-divelog.org/documentation/building/ into the terminal. > > The install instructions

Re: Start-up parameters locations

On 3 November 2015 at 17:24, Dirk Hohndel wrote: > On Tue, Nov 03, 2015 at 02:47:23PM +, John Smith wrote: >> > >> > but the user folder can >> > contain the default dive log file and any modified printing templates, >> > which if lost will make the user mildly annoyed. >> > >> > if voted upo

Re: WARNING ! Read before you pull / build master !!

2015-11-03 5:18 GMT+01:00 Dirk Hohndel : > > OK, now that I have ensured that no one will read this email but everyone > will instead pull master and build it to see what breaks... Currently the AppImage generation fails, could this build error be related to the above? Note the non-standard charac

Re: Start-up parameters locations

On Tue, Nov 03, 2015 at 05:41:59PM +0200, Lubomir I. Ivanov wrote: > On 3 November 2015 at 17:24, Dirk Hohndel wrote: > > On Tue, Nov 03, 2015 at 02:47:23PM +, John Smith wrote: > >> > > >> > but the user folder can > >> > contain the default dive log file and any modified printing templates,

Re: [PATCH] Drag and Drop images

On Tue, Nov 03, 2015 at 11:31:32AM +0100, Robert Helling wrote: > Hi, > > > On 21.09.2015, at 09:30, Robert C. Helling > > wrote: > > > > <0001-Drag-and-Drop-images.txt> > > Hi, > > > > Dirk I don’t know if you want to take this at this point or wait till after > > t

Re: Start-up parameters locations

On 3 November 2015 at 17:46, Dirk Hohndel wrote: > On Tue, Nov 03, 2015 at 05:41:59PM +0200, Lubomir I. Ivanov wrote: >> On 3 November 2015 at 17:24, Dirk Hohndel wrote: >> > On Tue, Nov 03, 2015 at 02:47:23PM +, John Smith wrote: >> >> > >> >> > but the user folder can >> >> > contain the d

Re: Start-up parameters locations

On Tue, Nov 3, 2015 at 1:46 PM, Dirk Hohndel wrote: > On Tue, Nov 03, 2015 at 05:41:59PM +0200, Lubomir I. Ivanov wrote: > > On 3 November 2015 at 17:24, Dirk Hohndel wrote: > > > On Tue, Nov 03, 2015 at 02:47:23PM +, John Smith wrote: > > >> > > > >> > but the user folder can > > >> > cont

Re: WARNING ! Read before you pull / build master !!

On Tue, Nov 03, 2015 at 04:45:00PM +0100, probono wrote: > 2015-11-03 5:18 GMT+01:00 Dirk Hohndel : > > > > OK, now that I have ensured that no one will read this email but everyone > > will instead pull master and build it to see what breaks... > > Currently the AppImage generation fails, could t

Re: [PATCH] Drag and Drop images

Sorrry for the breakage. On Tue, Nov 3, 2015 at 1:48 PM, Dirk Hohndel wrote: > On Tue, Nov 03, 2015 at 11:31:32AM +0100, Robert Helling wrote: > > Hi, > > > > > On 21.09.2015, at 09:30, Robert C. Helling > wrote: > > > > > > <0001-Drag-and-Drop-images.txt> > > > Hi, >

Re: Start-up parameters locations

On Tue, Nov 03, 2015 at 05:49:35PM +0200, Lubomir I. Ivanov wrote: > to clarify - in which cpp file? Ah. > we don't need the default directory stored in the QSettings on Android > for now, so i was thinking of just adding it in the desktop > MainWindow() constructor. We only need this on Windows

Re: Start-up parameters locations

On Tue, Nov 3, 2015 at 1:52 PM, Dirk Hohndel wrote: > On Tue, Nov 03, 2015 at 05:49:35PM +0200, Lubomir I. Ivanov wrote: > > to clarify - in which cpp file? > > Ah. > > > we don't need the default directory stored in the QSettings on Android > > for now, so i was thinking of just adding it in the

Re: UDDF crash

On Tue, Nov 3, 2015 at 5:27 PM, Dirk Hohndel wrote: > On Tue, Nov 03, 2015 at 02:43:50PM +0200, Lubomir I. Ivanov wrote: >> On 3 November 2015 at 06:24, Miika Turkia wrote: >> > >> > I would not be surprised, if there was still something more lurking >> > around... >> >> yours and Linus' patches

Patches to add Context Menu to Images

Hi All, Re-submitting. This set of patches enables users to use the mouse and a context menu to: 1. Add images from files/web 2. Delete selected images 3. Delete all images If there is no objection, I am going to work on a local file based management of images again that can be selected via the

Re: [PATCH] Drag and Drop images

Hi Dirk, Just saw this, hope my context menu does fit with this ... 2015-11-03 16:48 GMT+01:00 Dirk Hohndel : > On Tue, Nov 03, 2015 at 11:31:32AM +0100, Robert Helling wrote: > > Hi, > > > > > On 21.09.2015, at 09:30, Robert C. Helling > wrote: > > > > > > <0001-Drag

Re: UDDF crash

On Tue, Nov 03, 2015 at 06:16:32PM +0200, Miika Turkia wrote: > Two patches, so you actually see the real change and don't get flooded > with indentation changes. THANK YOU. Extra credit for Miika. That made it so much easier to see what you did there. Perfect use of multiple commits. /D ___

[PATCH 3/4] PreferencesDialog.cpp: store 'default_directory' in QSettings

From: "Lubomir I. Ivanov" This is needed only on Windows, so that the uninstaller knows which directory to delete. Signed-off-by: Lubomir I. Ivanov --- desktop-widgets/preferences/preferencesdialog.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/desktop-widgets/preferences/prefer

[PATCH 4/4] NSIS: add a couple of uninstaller checkboxes

From: "Lubomir I. Ivanov" Add a new dialog/page which is shown right before the final "uninstall" click. The dialog may contains two checkboxes - for registry entries and for the user path. These checkboxes will not be created if the user has not run the application yet, as no registry keys will

Re: [PATCH 3/4] PreferencesDialog.cpp: store 'default_directory' in QSettings

On 3 November 2015 at 19:03, Lubomir I. Ivanov wrote: > From: "Lubomir I. Ivanov" > > [PATCH 3/4] please, ignore the patch indexing: [PATCH 3/4] PreferencesDialog.cpp: store 'default_directory' in QSettings > [1/2] [PATCH 4/4] NSIS: add a couple of uninstaller checkboxes > [2/2] lubomir

Re: WARNING ! Read before you pull / build master !!

I have finger trouble in building the new master (Ubuntu 15.04). Please give me a pointer or two? Kind regards, willem willem~/src$ cmake subsurface -- The C compiler identification is GNU 4.9.2 -- The CXX compiler identification is GNU 4.9.2 -- Check for working C compiler: /usr/bin/cc -- Check

Re: WARNING ! Read before you pull / build master !!

On Tue, Nov 3, 2015 at 4:26 PM, Willem Ferguson < willemfergu...@zoology.up.ac.za> wrote: > I have finger trouble in building the new master (Ubuntu 15.04). > Please give me a pointer or two? > Kind regards, > willem > > willem~/src$ cmake subsurface > -- The C compiler identification is GNU 4.9.2

Building Subsurface on MAC

All, The blues is over ... Here are the steps to get the new master loaded and build on a MAC OS 10.11 1. remove the entire subsurface folder 2. launch XCode to complete the XCode installation if you have not done already 3. xcode-select --install 4. brew install libssh2 5. brew install libgcrypt

Re: [PATCH] Drag and Drop images

Dirk,On 03 Nov 2015, at 16:48, Dirk Hohndel wrote:Well, it didn't include the patch. I went back to the old patch and thatof course doesn't apply any more. I can manually make it work or I can askyou to resend a working patch :-)From e00d8b6fca596e194ee16e571bba2f55a04a820d Mon S

Re: Patches to add Context Menu to Images

Hi Guido, > On 03 Nov 2015, at 17:21, Guido Lerch wrote: > > This set of patches enables users to use the mouse and a context menu to: I think the interference between these and my Drag and Drop patch should be very small, so yes, of course, go ahead, let’s sort this out together! For me the

Re: WARNING ! Read before you pull / build master !!

2015-11-03 16:50 GMT+01:00 Dirk Hohndel : > > Is your compiler new enough to support -std=gnu11 ? I think it's more > likely that that is the issue. Thanks. Sure enough that was the issue. Fixed. Subsurface_4.5.1.78_x86_64.AppImage seems to have been built just fine. _

Re: Nightly Subsurface AppImage for most Linux distributions

On Tue, Nov 03, 2015 at 02:54:57AM +0100, probono wrote: > 2015-11-02 18:50 GMT+01:00 Dirk Hohndel : > > > > So I cannot build a working AppImage on either 14.04 or a schroot 12.04. > > I successfully built an AppImage on my local machine using proot 12.04.4 > https://gist.github.com/probonopd/71f

Re: Nightly Subsurface AppImage for most Linux distributions

2015-11-03 23:01 GMT+01:00 Dirk Hohndel : > > So here's my latest image, built just a few minutes ago from the latest > master in a 12.04 chroot on a 14.04 server. > > http://subsurface-divelog.org/downloads/daily/Subsurface_4.5.1.78_x86_64.AppImage usr/bin/subsurface is missing inside the AppImag

Re: Nightly Subsurface AppImage for most Linux distributions

The question is... why? Built with your script. Oh well, more digging necessary. -- Sent from my phone > On Nov 3, 2015, at 14:12, probono wrote: > > 2015-11-03 23:01 GMT+01:00 Dirk Hohndel : >> >> So here's my latest image, built just a few minutes ago from the latest >> master in a 12.04 c

Re: Patches to add Context Menu to Images

Hi Robert 2015-11-03 21:34 GMT+01:00 Robert C. Helling : > Hi Guido, > > On 03 Nov 2015, at 17:21, Guido Lerch wrote: > > This set of patches enables users to use the mouse and a context menu to: > > > I think the interference between these and my Drag and Drop patch should > be very small, so y

RE: Start-up parameters locations

On Mon, Nov 02, 2015 at 10:22:18AM +, John Smith wrote: > I've been seeing a problem with cylinder data that I am trying to replicate so I decided to start again with a completely new installation on my W10 PC. > It looks like W10 wierdness with regards the DC settings. Even after clearin