Re: Accidental file delete on mobile.

2021-01-18 Thread Chirana Gheorghita Eugeniu Theodor via subsurface
still the same but seems to crash the app faster :). log attached On Mon, Jan 18, 2021, 23:40 Dirk Hohndel wrote: > > > On Jan 18, 2021, at 12:40 PM, Dirk Hohndel via subsurface < > subsurface@subsurface-divelog.org> wrote: > > OK, I have a crazy idea. If I implement a transition that slowly

Re: Accidental file delete on mobile.

2021-01-18 Thread Dirk Hohndel via subsurface
> On Jan 18, 2021, at 12:40 PM, Dirk Hohndel via subsurface > wrote: > > OK, I have a crazy idea. If I implement a transition that slowly hides the > item instead of > just turning it off. Yeah, kinda silly, but... what if that's enough to keep > the object around > long enough that the

Re: mobile version testing

2021-01-18 Thread Dirk Hohndel via subsurface
As you can tell from the picture, it still isn't perfect. The '>' in the title between 'Dive list' and 'Martin Luther King Boulevard' is the wrong font size which pushes the dive location text down somewhat. But I should be able to track that one down... Thanks for the update! Which island

Re: mobile version testing

2021-01-18 Thread Attilla de Groot via subsurface
> On 18 Jan 2021, at 14:02, Dirk Hohndel wrote: > > Responding to myself... :-) > >> On Jan 18, 2021, at 9:21 AM, Dirk Hohndel via subsurface >> wrote: >> >> I'm disappointed that you do see that issue with the title bar, but at least >> now I have that confirmation and can try to dig

Re: Accidental file delete on mobile.

2021-01-18 Thread Dirk Hohndel via subsurface
> On Jan 18, 2021, at 12:11 PM, Chirana Gheorghita Eugeniu Theodor > wrote: > > Ps. I just create a new dive and save, no fields completed. all blank... > maibe this is let me test > > So > > new dive > save > long press or using 3 dots to delete crashes app > > 2. new dive >

Re: Accidental file delete on mobile.

2021-01-18 Thread Chirana Gheorghita Eugeniu Theodor via subsurface
Ps. I just create a new dive and save, no fields completed. all blank... maibe this is let me test So new dive > save > long press or using 3 dots to delete crashes app 2. new dive > complete dive location > save > long press or context to delete does not crash app anymore :) So I guess

Re: Accidental file delete on mobile.

2021-01-18 Thread Chirana Gheorghita Eugeniu Theodor via subsurface
Hmmm. I will try reproducing and detail each step. By the way I am using dark theme :) On Mon, Jan 18, 2021, 20:47 Dirk Hohndel wrote: > > > On Jan 18, 2021, at 12:00 AM, Chirana Gheorghita Eugeniu Theodor < > off...@adaptcom.ro> wrote: > > Hello. OK. > > Discovered something: > - I add a new

Re: Accidental file delete on mobile.

2021-01-18 Thread Dirk Hohndel via subsurface
> On Jan 18, 2021, at 12:00 AM, Chirana Gheorghita Eugeniu Theodor > wrote: > > Hello. OK. > > Discovered something: > - I add a new dive > -Save and exit to Dive list > - Enter that dive again > - delete it >> all ok. > > - Add a new dive > - Save and exit to Dive list > - select another

Re: mobile version testing

2021-01-18 Thread Dirk Hohndel via subsurface
Responding to myself... :-) > On Jan 18, 2021, at 9:21 AM, Dirk Hohndel via subsurface > wrote: > > I'm disappointed that you do see that issue with the title bar, but at least > now I have that confirmation and can try to dig some more to figure out what > I missed in all this. Maybe it's a

Re: mobile version testing

2021-01-18 Thread Dirk Hohndel via subsurface
> On Jan 18, 2021, at 8:45 AM, Attilla de Groot wrote: > > Just updated. The colors of the statistics don’t match the dark mode, but I > don’t mind that. The font-size in the statistics menu seem to be correct now. Yeah, the statistics itself is drawn in C++ code that currently isn't dark

Re: Accidental file delete on mobile.

2021-01-18 Thread Martin de Weger via subsurface
I was just about to send a mail: first test looks great. The bars are shown when rotating back and forth. Met vriendelijke groet, Martin de Weger > Op 18 jan. 2021 om 17:25 heeft Dirk Hohndel het volgende > geschreven: > > Ok, so Apple was unexpectedly swift and .364 should just have

Re: Accidental file delete on mobile.

2021-01-18 Thread Dirk Hohndel via subsurface
Ok, so Apple was unexpectedly swift and .364 should just have been pushed out to you via TestFlight. This contains a cruel hack to try and force a redraw of the statistics after rotation. Would you mind testing that as I can't reproduce the issue, as I mentioned :-) Thanks /D > On Jan 18,

Re: mobile version testing

2021-01-18 Thread Dirk Hohndel via subsurface
> On Jan 18, 2021, at 7:38 AM, Attilla de Groot wrote: > > Hi Dirk, > > No problem as long as it’s known. Seems I’m the only dark theme user. :-) No, there are more - I know how many requests I got when it was broken. And I also see more people send dark mode screen shots. Also, can you

Re: Accidental file delete on mobile.

2021-01-18 Thread Dirk Hohndel via subsurface
OK, I do have a friend here locally (not a diver, not a Subsurface user) who has an iPhone 12 Pro XL mega wizzytop or whatever it’s called. So at least someone in this time zone who can test my experiments... and I can ask my wife to try it on her 11 Pro. > On Jan 18, 2021, at 07:27, Martin de

Re: Accidental file delete on mobile.

2021-01-18 Thread Martin de Weger via subsurface
I’m using an iPhone 12 Pro with the latest stable release from iOS. Fixing an issue that you cannot reproduce is a pain, I know... Thanks for all the work you guys are putting into this. Met vriendelijke groet, Martin de Weger > Op 18 jan. 2021 om 16:21 heeft Dirk Hohndel via subsurface >

Re: Accidental file delete on mobile.

2021-01-18 Thread Dirk Hohndel via subsurface
Thanks for testing. What did you think about the notification after changes, with the button that opens the context menu... is that helpful? Is that a reasonable user experience? /D > On Jan 18, 2021, at 06:19, Willem Ferguson > wrote: > I tested this on a Galaxy A20 running Android 10.

Re: mobile version testing

2021-01-18 Thread Dirk Hohndel via subsurface
I’ve been battling this behavior from the very start. Right now (with .363) with the devices I have (half a dozen Android phones, two older iPhones and an iPad pro) this seems to work correctly on all of them, all the time. But I have seen that effect that you describe many times during my

Re: mobile version testing

2021-01-18 Thread Dirk Hohndel via subsurface
Did you test this with .361 or .363? The latter has a fix for this issue that appears to work on my devices... /D On January 18, 2021 1:01:41 AM PST, Paul Buxton wrote: >Statistics look pretty awesome. >I do notice if you change to the dark theme (your favorite) that there >is >some issue

Re: Accidental file delete on mobile.

2021-01-18 Thread Willem Ferguson via subsurface
On 2021/01/18 00:05, Dirk Hohndel wrote: To me this flow is informative, relatively unobtrusive, and makes sense. Best of all, even if you miss the time window to press the button in the notification, you still can just open the context menu and trigger the undo (or redo) action. Please,

Re: mobile version testing

2021-01-18 Thread Martin de Weger via subsurface
Thanks for the answer. When testing this, I found something else. If I turn my iPhone to landscape, the statistics area is empty. Only when I reselect the data I want to see, the bars are shown again (and stay visible when switching from landscape to portrait v.v.) Met vriendelijke groet,

Re: mobile version testing

2021-01-18 Thread Willem Ferguson via subsurface
On 2021/01/18 11:13, Martin de Weger via subsurface wrote: I had a quick look on the statistics. They look great. I found one weird thing: When looking at the minimum depth per year, the minimum depth is shown in the column. When doing the same thing for maximum dept, the maximum depth isn’t

Re: mobile version testing

2021-01-18 Thread Paul Buxton via subsurface
Statistics look pretty awesome. I do notice if you change to the dark theme (your favorite) that there is some issue with the size of the titles for the combo boxes. All looks pretty good otherwise. Paul On Sun, Jan 17, 2021 at 3:14 AM Dirk Hohndel via subsurface <

Re: Accidental file delete on mobile.

2021-01-18 Thread Chirana Gheorghita Eugeniu Theodor via subsurface
PS: Android 11 OS on N20 On Mon, Jan 18, 2021 at 10:00 AM Chirana Gheorghita Eugeniu Theodor < off...@adaptcom.ro> wrote: > Hello. OK. > > Discovered something: > - I add a new dive > -Save and exit to Dive list > - Enter that dive again > - delete it >> all ok. > > - Add a new dive > - Save and

Re: Accidental file delete on mobile.

2021-01-18 Thread Chirana Gheorghita Eugeniu Theodor via subsurface
Hello. OK. Discovered something: - I add a new dive -Save and exit to Dive list - Enter that dive again - delete it >> all ok. - Add a new dive - Save and exit to Dive list - select another dive and back to dive list - Select the newly added dive and back to dive list and tha new dive remains