Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-24 Thread Stefan Seyfried
On Mon, Jul 23, 2007 at 10:14:02PM +0200, Pavel Machek wrote: > Hi! > > > >> If you ask me... I think lzo will be better for most users... But I > > > > > >If you can argue lzo is significantly better, we can switch, but we do > > >not want both. > > > > Well... So let's switch. :) > > So, what

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Alon Bar-Lev
On 7/24/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > On Monday, 23 July 2007 22:34, Alon Bar-Lev wrote: > > On 7/23/07, Arkadiusz Miskiewicz <[EMAIL PROTECTED]> wrote: > > > ... and there are two versions of lzo 8-) Which to support? We (at PLD) > > > "like" > > > 2.x for example. > > > > My

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Rafael J. Wysocki
On Monday, 23 July 2007 22:34, Alon Bar-Lev wrote: > On 7/23/07, Arkadiusz Miskiewicz <[EMAIL PROTECTED]> wrote: > > ... and there are two versions of lzo 8-) Which to support? We (at PLD) > > "like" > > 2.x for example. > > My patch is for lzo1x_1 it is available in llzo-1 and lzo-2. > I checked

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Alon Bar-Lev
On 7/23/07, Arkadiusz Miskiewicz <[EMAIL PROTECTED]> wrote: > ... and there are two versions of lzo 8-) Which to support? We (at PLD) "like" > 2.x for example. My patch is for lzo1x_1 it is available in llzo-1 and lzo-2. I checked the lzo2* but it is much slower. Alon ---

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Arkadiusz Miskiewicz
On Monday 23 of July 2007, Rafael J. Wysocki wrote: > On Monday, 23 July 2007 22:04, Pavel Machek wrote: > > On Mon 2007-07-23 20:12:21, Alon Bar-Lev wrote: > > > On 7/23/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > > > >I guess it is easiest way for gentoo, but... I'd prefer not to switch > > > >

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Alon Bar-Lev
On 7/23/07, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > OTOH, if the user builds s2disk and resume himself, he probably won't care > which compression library they are linked with anyway. True. Next patch I was about to send is a version string to the suspend header and addition of compression

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Rafael J. Wysocki
On Monday, 23 July 2007 22:04, Pavel Machek wrote: > On Mon 2007-07-23 20:12:21, Alon Bar-Lev wrote: > > On 7/23/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > > >I guess it is easiest way for gentoo, but... I'd prefer not to switch > > >compression algorithms too often, unless there's good reason t

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Pavel Machek
Hi! > >> If you ask me... I think lzo will be better for most users... But I > > > >If you can argue lzo is significantly better, we can switch, but we do > >not want both. > > Well... So let's switch. :) So, what are advantages of lzo? Is it significantly faster? Better compression ratio? Stef

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Alon Bar-Lev
On 7/23/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > That's even worse. I do not want to maintain two compression > algorithms :-). Why? You don't maintain the algorithm... You just provide the interface. BTW: suspend2 can use any module to do the job... It would have been great to use a shared

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Pavel Machek
On Mon 2007-07-23 20:12:21, Alon Bar-Lev wrote: > On 7/23/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > >I guess it is easiest way for gentoo, but... I'd prefer not to switch > >compression algorithms too often, unless there's good reason to. > > Support is a good reason :) > Tried to talk to

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Alon Bar-Lev
On 7/23/07, Pavel Machek <[EMAIL PROTECTED]> wrote: > I guess it is easiest way for gentoo, but... I'd prefer not to switch > compression algorithms too often, unless there's good reason to. Support is a good reason :) Tried to talk to lzf developer, I don't want to quote the rude responses I

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-23 Thread Pavel Machek
Hi! > I am the maintainer of gentoo hibernate-script, tuxonice (suspend2). > I wish to add uswsup/suspend into portage. > > We do not currently maintain liblzf, as it seems upstream is not cooperative. > I've created a patch so that the user may select to use liblzf or lzo-2 > during compilation.

Re: [Suspend-devel] [PATCH] Add lzo compression support

2007-07-18 Thread Rafael J. Wysocki
Hi, On Wednesday, 18 July 2007 19:25, Alon Bar-Lev wrote: > Hello, Rafael > > I am the maintainer of gentoo hibernate-script, tuxonice (suspend2). > I wish to add uswsup/suspend into portage. > > We do not currently maintain liblzf, as it seems upstream is not cooperative. > I've created a patch

[Suspend-devel] [PATCH] Add lzo compression support

2007-07-18 Thread Alon Bar-Lev
Hello, Rafael I am the maintainer of gentoo hibernate-script, tuxonice (suspend2). I wish to add uswsup/suspend into portage. We do not currently maintain liblzf, as it seems upstream is not cooperative. I've created a patch so that the user may select to use liblzf or lzo-2 during compilation.