Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-06 Thread Rafael J. Wysocki
On Monday, 6 November 2006 08:14, Stefan Seyfried wrote: > On Sun, Nov 05, 2006 at 12:46:37PM +0100, Rafael J. Wysocki wrote: > > > As far as the interruptible freeing is concerned, is it _really_ that > > important? Currently the shrinking of memory is common code and I don't > > think > > the

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-06 Thread Pavel Machek
Hi! > > Could memory freeing be separated into separate ioctl()? That would > > allow us to do interruptible freeing (in small hunks), and allow > > timing done from userland... > > Well, I prefer the timing being done by the kernel, because it's easliy > grepable in the dmesg output and it can b

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-06 Thread Stefan Seyfried
On Sun, Nov 05, 2006 at 12:46:37PM +0100, Rafael J. Wysocki wrote: > As far as the interruptible freeing is concerned, is it _really_ that > important? Currently the shrinking of memory is common code and I don't think > the interruptibility is a good enough reason to make things more complicated

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-06 Thread Stefan Seyfried
On Sun, Nov 05, 2006 at 12:21:37PM +0100, Pavel Machek wrote: > Hi! > > Bootsplash only drops to verbose mode on escape and F2 as far as I can > > see. At least the kernel has something like this: > > > > --- > > #ifdef CONFIG_BOOTSPLASH > > /* This code has to be redone for some non-x86 plat

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-05 Thread Rafael J. Wysocki
Hi, On Sunday, 5 November 2006 12:25, Pavel Machek wrote: > Hi! > > > > > > Ok, maybe this is something we should look into later, since i really > > > > > often > > > > > see machine freeing memory for 30 seconds, snapshotting for another > > > > > 20 seconds > > > > > and then writing for 10

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-05 Thread Pavel Machek
Hi! > > > > Ok, maybe this is something we should look into later, since i really > > > > often > > > > see machine freeing memory for 30 seconds, snapshotting for another 20 > > > > seconds > > > > and then writing for 10 seconds (or at least it feels like that :-). > > > > > > The freeing of

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-05 Thread Pavel Machek
Hi! > > > Which key do you prefer? > > > > I don't know. Escape sounds pretty logical :-) > > Go ahead, i don't even know if this is an issue (Holger could probably test > > what happens to the escape that sends bootsplash into verbose mode, i'm not > > sure if this one is even propagated to user

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-04 Thread Rafael J. Wysocki
On Saturday, 4 November 2006 10:03, Stefan Seyfried wrote: > On Fri, Nov 03, 2006 at 09:07:08PM +0100, Rafael J. Wysocki wrote: > > > > Ok, maybe this is something we should look into later, since i really > > > often > > > see machine freeing memory for 30 seconds, snapshotting for another 20 >

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-04 Thread Stefan Seyfried
On Fri, Nov 03, 2006 at 09:07:08PM +0100, Rafael J. Wysocki wrote: > > Ok, maybe this is something we should look into later, since i really often > > see machine freeing memory for 30 seconds, snapshotting for another 20 > > seconds > > and then writing for 10 seconds (or at least it feels like

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-03 Thread Rafael J. Wysocki
On Friday, 3 November 2006 14:57, Stefan Seyfried wrote: > On Thu, Nov 02, 2006 at 04:08:20PM +0100, Rafael J. Wysocki wrote: > > On Thursday, 2 November 2006 13:13, Stefan Seyfried wrote: > > > On Thu, Nov 02, 2006 at 11:29:47AM +0100, Rafael J. Wysocki wrote: > > > > On Thursday, 2 November 2006

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-03 Thread Stefan Seyfried
On Fri, Nov 03, 2006 at 04:12:22PM +0100, Holger Macht wrote: > Bootsplash only drops to verbose mode on escape and F2 as far as I can > see. At least the kernel has something like this: > > --- > #ifdef CONFIG_BOOTSPLASH > /* This code has to be redone for some non-x86 platforms */ >

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-03 Thread Holger Macht
On Fri 03. Nov - 14:57:10, Stefan Seyfried wrote: > On Thu, Nov 02, 2006 at 04:08:20PM +0100, Rafael J. Wysocki wrote: > > On Thursday, 2 November 2006 13:13, Stefan Seyfried wrote: > > > On Thu, Nov 02, 2006 at 11:29:47AM +0100, Rafael J. Wysocki wrote: > > > > On Thursday, 2 November 2006 11:24,

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-03 Thread Stefan Seyfried
On Thu, Nov 02, 2006 at 04:08:20PM +0100, Rafael J. Wysocki wrote: > On Thursday, 2 November 2006 13:13, Stefan Seyfried wrote: > > On Thu, Nov 02, 2006 at 11:29:47AM +0100, Rafael J. Wysocki wrote: > > > On Thursday, 2 November 2006 11:24, Pavel Machek wrote: > > > > Hi! > > > > > > > > > The app

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 23:51, Pavel Machek wrote: > On Thu 2006-11-02 23:07:32, Rafael J. Wysocki wrote: > > On Thursday, 2 November 2006 22:42, Pavel Machek wrote: > > > Hi! > > > > > > > > > > The appended patch allows the users of suspend to abort the image > > > > > > > saving by > > >

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Pavel Machek
On Thu 2006-11-02 23:07:32, Rafael J. Wysocki wrote: > On Thursday, 2 November 2006 22:42, Pavel Machek wrote: > > Hi! > > > > > > > > The appended patch allows the users of suspend to abort the image > > > > > > saving by > > > > > > pressing Ctrl+c. > > > > > > > > > > It would be nice to abor

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 22:43, Pavel Machek wrote: > Hi! > > > > > Sounds good, but generally we have two options now: We can apply the > > > > patch > > > > as is and then add the libsplashy function or we can wait with applying > > > > the > > > > patch until the libsplashy function is re

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 22:42, Pavel Machek wrote: > Hi! > > > > > > The appended patch allows the users of suspend to abort the image > > > > > saving by > > > > > pressing Ctrl+c. > > > > > > > > It would be nice to abort with escape or something... ctrl+c is going > > > > to be "interest

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Pavel Machek
Hi! > > > Sounds good, but generally we have two options now: We can apply the patch > > > as is and then add the libsplashy function or we can wait with applying > > > the > > > patch until the libsplashy function is ready. > > > > > > So, if the patch doesn't break splashy, I'd like to apply

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Pavel Machek
Hi! > > > > The appended patch allows the users of suspend to abort the image > > > > saving by > > > > pressing Ctrl+c. > > > > > > It would be nice to abort with escape or something... ctrl+c is going > > > to be "interesting" for users using splashscreen. > > > > OK > > Escape (and f2) swit

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 20:47, Tim Dijkstra wrote: > On Thu, 2 Nov 2006 17:20:39 +0100 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > On Thursday, 2 November 2006 16:55, Tim Dijkstra wrote: > > > Op Thu, 2 Nov 2006 16:10:04 +0100 > > > schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>:

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Tim Dijkstra
On Thu, 2 Nov 2006 17:20:39 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > On Thursday, 2 November 2006 16:55, Tim Dijkstra wrote: > > Op Thu, 2 Nov 2006 16:10:04 +0100 > > schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>: > > > > > On Thursday, 2 November 2006 14:49, Tim Dijkstra wrote: >

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 16:55, Tim Dijkstra wrote: > Op Thu, 2 Nov 2006 16:10:04 +0100 > schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>: > > > On Thursday, 2 November 2006 14:49, Tim Dijkstra wrote: > > > Op Thu, 2 Nov 2006 08:07:36 +0100 > > > schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Tim Dijkstra
Op Thu, 2 Nov 2006 16:10:04 +0100 schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>: > On Thursday, 2 November 2006 14:49, Tim Dijkstra wrote: > > Op Thu, 2 Nov 2006 08:07:36 +0100 > > schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>: > > > > > Hi, > > > > > > The appended patch allows the users of

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 14:49, Tim Dijkstra wrote: > Op Thu, 2 Nov 2006 08:07:36 +0100 > schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>: > > > Hi, > > > > The appended patch allows the users of suspend to abort the image > > saving by pressing Ctrl+c. > > > > Comments welcome. > > This is

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 13:13, Stefan Seyfried wrote: > On Thu, Nov 02, 2006 at 11:29:47AM +0100, Rafael J. Wysocki wrote: > > On Thursday, 2 November 2006 11:24, Pavel Machek wrote: > > > Hi! > > > > > > > The appended patch allows the users of suspend to abort the image > > > > saving by >

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Tim Dijkstra
Op Thu, 2 Nov 2006 08:07:36 +0100 schreef "Rafael J. Wysocki" <[EMAIL PROTECTED]>: > Hi, > > The appended patch allows the users of suspend to abort the image > saving by pressing Ctrl+c. > > Comments welcome. This is not going to work for splashy. We will need wrap the call to 'read' in the sp

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Stefan Seyfried
On Thu, Nov 02, 2006 at 11:29:47AM +0100, Rafael J. Wysocki wrote: > On Thursday, 2 November 2006 11:24, Pavel Machek wrote: > > Hi! > > > > > The appended patch allows the users of suspend to abort the image saving > > > by > > > pressing Ctrl+c. > > > > It would be nice to abort with escape or

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Pavel Machek
Hi! > > > > @@ -451,20 +476,34 @@ static int save_image(struct swap_map_ha > > > > error = swap_write_page(handle); > > > > if (error) > > > > break; > > > > + > > > > if (!(nr_pages % m)) { > >

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 11:29, Rafael J. Wysocki wrote: > On Thursday, 2 November 2006 11:24, Pavel Machek wrote: > > Hi! > > > > > The appended patch allows the users of suspend to abort the image saving > > > by > > > pressing Ctrl+c. > > > > It would be nice to abort with escape or somet

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Rafael J. Wysocki
On Thursday, 2 November 2006 11:24, Pavel Machek wrote: > Hi! > > > The appended patch allows the users of suspend to abort the image saving by > > pressing Ctrl+c. > > It would be nice to abort with escape or something... ctrl+c is going > to be "interesting" for users using splashscreen. OK >

Re: [Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-02 Thread Pavel Machek
Hi! > The appended patch allows the users of suspend to abort the image saving by > pressing Ctrl+c. It would be nice to abort with escape or something... ctrl+c is going to be "interesting" for users using splashscreen. > - printf("suspend: Saving image data pages (%u pages) ... ", > n

[Suspend-devel] [PATCH] Allow users to abort image saving

2006-11-01 Thread Rafael J. Wysocki
Hi, The appended patch allows the users of suspend to abort the image saving by pressing Ctrl+c. Comments welcome. Greetings, Rafael --- suspend.c | 48 +--- 1 file changed, 45 insertions(+), 3 deletions(-) Index: suspend/suspend.c ==