Re: [Suspend-devel] pci save state patch

2007-01-10 Thread Pavel Machek
Hi! > > > here it is (some small changes to Frank's patch are: do not initialize > > > *pacc, > > > static vga_pci_state, a comment on why we fail suspend, whitespace > > > cleanups): > > > > ACK, please commit. > > Done. BTW, when backporting it to an older distro, i removed the dependency > t

Re: [Suspend-devel] pci save state patch

2007-01-10 Thread Stefan Seyfried
On Wed, Jan 10, 2007 at 10:08:14PM +0100, Pavel Machek wrote: > On Wed 2007-01-10 13:09:57, Stefan Seyfried wrote: > > here it is (some small changes to Frank's patch are: do not initialize > > *pacc, > > static vga_pci_state, a comment on why we fail suspend, whitespace > > cleanups): > > ACK, p

Re: [Suspend-devel] pci save state patch

2007-01-10 Thread Pavel Machek
On Wed 2007-01-10 13:09:57, Stefan Seyfried wrote: > On Wed, Jan 10, 2007 at 12:26:07PM +0100, Pavel Machek wrote: > > Hi! > > > > > > Well, Frank was wrong here for subtle reason, and I did not like it: > > > > > > > > If malloc failed (basically can not happen, but...) he'd suspend, > > > > anyw

Re: [Suspend-devel] pci save state patch

2007-01-10 Thread Stefan Seyfried
On Wed, Jan 10, 2007 at 12:26:07PM +0100, Pavel Machek wrote: > Hi! > > > > Well, Frank was wrong here for subtle reason, and I did not like it: > > > > > > If malloc failed (basically can not happen, but...) he'd suspend, > > > anyway, failing to restore PCI config at the exit, and bringing video

Re: [Suspend-devel] pci save state patch

2007-01-10 Thread Pavel Machek
Hi! > > Well, Frank was wrong here for subtle reason, and I did not like it: > > > > If malloc failed (basically can not happen, but...) he'd suspend, > > anyway, failing to restore PCI config at the exit, and bringing video > > corruption back to us... Without knowing that pci save state failed.

Re: [Suspend-devel] pci save state patch

2007-01-10 Thread Frank Seidel
Hi! On Wednesday 10 January 2007 10:39, Pavel Machek wrote: > Well, Frank was wrong here for subtle reason, and I did not like it: > > If malloc failed (basically can not happen, but...) he'd suspend, > anyway, failing to restore PCI config at the exit, and bringing video > corruption back to us..

Re: [Suspend-devel] pci save state patch

2007-01-10 Thread Pavel Machek
Hi! > > I'm going to commit this: ...it is slightly cleaned up version of > > patch by Frank Seidel suse.de>; and it should allow > > s2ram to work on thinkpad R50 or so. It needs rather new libpci so > > update it if you see compile problem. > > Yes, everybody with video problems, please test t

Re: [Suspend-devel] pci save state patch

2007-01-10 Thread Stefan Seyfried
On Wed, Jan 10, 2007 at 09:01:12AM +0100, Pavel Machek wrote: > Hi! > > I'm going to commit this: ...it is slightly cleaned up version of > patch by Frank Seidel suse.de>; and it should allow > s2ram to work on thinkpad R50 or so. It needs rather new libpci so > update it if you see compile probl

[Suspend-devel] pci save state patch

2007-01-10 Thread Pavel Machek
Hi! I'm going to commit this: ...it is slightly cleaned up version of patch by Frank Seidel suse.de>; and it should allow s2ram to work on thinkpad R50 or so. It needs rather new libpci so update it if you see compile problem. Pavel