Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Hi Sergey, If fFileList refers to a soft linked empty folder, we will will not need to apply orientation to it’s sub-components. With Regards, Avik Niyogi > On 12-Jan-2016, at 7:19 pm, Sergey Bylokhov > wrote: > > Hi, Avik. > Is it possible that fFileList can be

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hi All, Please find changes as provided with incorporation of inputs: http://cr.openjdk.java.net/~aniyogi/8015748/webrev.03/ With Regards, Avik Niyogi > On 12-Jan-2016, at 11:49 pm, Alexander Scherbatiy >

Re: Review request for 8041894: Test javax/swing/JSpinner/8008657/bug8008657.java failed on Mac

Hi All, Thank you for the reviews. Kindly request to commit the changes for the same. With Regards, Avik Niyogi > On 12-Jan-2016, at 11:23 pm, Alexander Scherbatiy > wrote: > > The fix looks good to me. > > Thanks, > Alexandr. > > On 12/01/16 17:53, Sergey

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Hi All, The comment in the mail trail is regarding different bug 8015748. Since, No inputs remain for code review related to this fix, please provide +1 for the fixes. Thank you in advance. With Regards, Avik Niyogi > On 12-Jan-2016, at 2:52 pm, Avik Niyogi wrote: > >

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Hi Alexander, Due to animation effects on Aqua look and feel, the color checks can not be used as seen in the image below: The Blue color is not homogeneously distributed and varies continuously. Since this is a fix for Aqua look and feel mainly, we need to perform a visual confirmation

Re: Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

Hi All, Please find the code changes in fix as with the inputs received for the same. http://cr.openjdk.java.net/~aniyogi/8015748/webrev.02/ With Regards, Avik Niyogi > On 11-Jan-2016, at 3:55 pm, Semyon Sadetsky

Re: Review request for 8041894: Test javax/swing/JSpinner/8008657/bug8008657.java failed on Mac

Hi All, Gentle reminder: Please provide review and provide +1 for the review in case it is acceptable. Thank you in advance. With Regards, Avik Niyogi > On 04-Jan-2016, at 3:11 pm, Avik Niyogi wrote: > > Hi All, > Please review the following incorporated with inputs

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

Hi, Avik. Is it possible that fFileList can be null? I see that in other places we do not check it to null? On 04/01/16 11:52, Avik Niyogi wrote: Hi All, Please review the webrev.01 : http://cr.openjdk.java.net/~aniyogi/8016665/webrev.01/ incorporated with the inputs received. With Regards,

Re: Review request for 8041894: Test javax/swing/JSpinner/8008657/bug8008657.java failed on Mac

Looks fine. On 04/01/16 12:41, Avik Niyogi wrote: Hi All, Please review the following incorporated with inputs provided http://cr.openjdk.java.net/~aniyogi/8041894/webrev.01/ With Regards, Avik Niyogi On 28-Dec-2015, at 7:05 pm, Sergey Bylokhov

Re: Review request for JDK-8075084 JOptionPane.showMessageDialog causes JScrollBar to move

Hello All, Gentle reminder to review the fix. http://cr.openjdk.java.net/~rchamyal/8075084/webrev.02/ Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 27 December 2015 20:32 To: Sergey Bylokhov Cc: swing-dev@openjdk.java.net Subject: Re: Review request for

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

@since needs to be just "9" as of the updated verona versioning scheme. -phil. On 1/12/16, 4:25 AM, Semyon Sadetsky wrote: Hi Alexander, I see that you've added the next clarifications to the methods specs: > draws string/returns width ... using text properties and anti-aliasing hints from

Re: Review request for 8041894: Test javax/swing/JSpinner/8008657/bug8008657.java failed on Mac

The fix looks good to me. Thanks, Alexandr. On 12/01/16 17:53, Sergey Bylokhov wrote: Looks fine. On 04/01/16 12:41, Avik Niyogi wrote: Hi All, Please review the following incorporated with inputs provided http://cr.openjdk.java.net/~aniyogi/8041894/webrev.01/ With Regards, Avik Niyogi On

Re: RfR JDK-8145735, Tests api/javax_swing/JTabbedPane/AccessibleJTabbedPane/* are failing

It seems that there still is the case when tab titles are empty string, tab components are null, components are not null and the correct index should be returned for the given page. May be it is better to replace searching the page index by tab component to by component? We already do this

Re: RfR JDK-8145735, Tests api/javax_swing/JTabbedPane/AccessibleJTabbedPane/* are failing

Hi Alexandr, On 1/12/16 1:03 PM, Alexander Scherbatiy wrote: > > It seems that there still is the case when tab titles are empty > string, tab components are null, components are not null and the > correct index should be returned for the given page. In the code of the current webrev (webrev.00)

Re: [9] Review request for 8132119 Provide public API for text related methods in SwingUtilities2

Hi Alexander, I see that you've added the next clarifications to the methods specs: > draws string/returns width ... using text properties and anti-aliasing hints from the provided component It still seems too brief and even incorrect for getStringWidth(). For drawString(): For

Re: Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

I am sorry. The comment really was about the issue 8015748. The fix looks good for me. Thanks, Alexandr. On 1/12/2016 1:44 AM, Avik Niyogi wrote: Hi All, The comment in the mail trail is regarding different bug 8015748. Since, No inputs remain for code review related to this fix, please