Re: [9] Review Request: 8155785 Add @Deprecated annotations to the Applet API classes

2016-05-12 Thread Sergey Bylokhov
cc swing-dev. Looks fine. On 13.05.16 4:41, Daniil Titov wrote: Hello, Please review the fix for JDK 9. The fix adds @Deprecated annotations to the Applet API classes as per JEP 289 “Deprecate the Applet API” ( http://openjdk.java.net/jeps/289 ). @SuppressWarnings("deprecation")

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-12 Thread Sergey Bylokhov
So there was no performance difference if you used char[] or String.charAt()? On 12.05.16 15:33, mikhail cherkasov wrote: and one more small update: http://cr.openjdk.java.net/~mcherkas/8078268/webrev.04/ I removed START_COMMENT_CHARS and END_COMMENT_CHARS variables and instead of them use

Re: [9] Review request for 8041694: JFileChooser removes trailing spaces in the selected directory name

2016-05-12 Thread Semyon Sadetsky
Hi, On 5/12/2016 7:50 PM, Alexander Potochkin wrote: Hello > You use Thread.sleep and critical sections in the test. Why not to use AWT robot's waitForIdle() ? waitForIdle() never really worked back in JDK7. I just checked the code in JDK9 and found that it still syncs only with the EDT

Re: [OpenJDK 2D-Dev] [9] Review request for 8151303 [macosx] [hidpi] JButton's low-res. icon is visible when clicking on it

2016-05-12 Thread Alexander Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8151303/webrev.01 There was a suggestion to postpone the fix for the issue 8152309 Seamless way of using image filters with multi-resolution images and continue with the current one:

Re: [9] Review request for 8041694: JFileChooser removes trailing spaces in the selected directory name

2016-05-12 Thread Alexander Potochkin
Hello > You use Thread.sleep and critical sections in the test. Why not to use AWT robot's waitForIdle() ? waitForIdle() never really worked back in JDK7. I just checked the code in JDK9 and found that it still syncs only with the EDT and completely ignores the toolkit thread. So I don't

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-12 Thread Alexander Potochkin
Hello Mikhail Looks great! Thanks alexp On 5/12/2016 5:53 PM, Alexey Ivanov wrote: 56 while (!parsingDone && System.currentTimeMillis() - s < 5_000) { Check for exception was added: http://cr.openjdk.java.net/~mcherkas/8078268/webrev.05/

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-12 Thread mikhail cherkasov
On 5/12/2016 5:53 PM, Alexey Ivanov wrote: 56 while (!parsingDone && System.currentTimeMillis() - s < 5_000) { Check for exception was added: http://cr.openjdk.java.net/~mcherkas/8078268/webrev.05/

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-12 Thread Alexey Ivanov
Hi Mikhail, On 12.05.2016 12:47, mikhail cherkasov wrote: On 5/12/2016 12:18 PM, Alexey Ivanov wrote: HTMLEditorKit htmlKit = new HTMLEditorKit(); Document doc = htmlKit.createDefaultDocument(); htmlKit.read(new FileReader(...), doc, 0); Thank you for advice, this works fine:

Re: [9] Review request for 8136998: JComboBox prevents wheel mouse scrolling of JScrollPane

2016-05-12 Thread Sergey Bylokhov
Looks fine. On 11.05.16 17:29, Alexey Ivanov wrote: Hello Swing team, Could you please review the fix for jdk9: bug: https://bugs.openjdk.java.net/browse/JDK-8136998 webrev: http://cr.openjdk.java.net/~aivanov/8136998/jdk9/webrev.00/ Problem description: When JComboBox is added into

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

2016-05-12 Thread Alexander Scherbatiy
The fix looks good to me. Thanks, Alexandr. On 12/05/16 15:26, Sergey Bylokhov wrote: Looks fine to me. On 12.05.16 14:07, Rajeev Chamyal wrote: Hello All, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8147521/webrev.06/ Changes: Updated the documentation.

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

2016-05-12 Thread Sergey Bylokhov
Looks fine to me. On 12.05.16 14:07, Rajeev Chamyal wrote: Hello All, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8147521/webrev.06/ Changes: Updated the documentation. Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 12 May 2016 13:32

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

2016-05-12 Thread Rajeev Chamyal
Hello All, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8147521/webrev.06/ Changes: Updated the documentation. Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 12 May 2016 13:32 To: Sergey Bylokhov; Alexander Scherbatiy;

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-12 Thread mikhail cherkasov
On 5/12/2016 12:18 PM, Alexey Ivanov wrote: HTMLEditorKit htmlKit = new HTMLEditorKit(); Document doc = htmlKit.createDefaultDocument(); htmlKit.read(new FileReader(...), doc, 0); Thank you for advice, this works fine: http://cr.openjdk.java.net/~mcherkas/8078268/webrev.03/

Re: [9] Review request for 8078268: javax.swing.text.html.parser.Parser parseScript incorrectly optimized

2016-05-12 Thread Alexey Ivanov
Hi Mikhail, Source code changes look good now. Please also see my comments below. On 11.05.2016 23:11, mikhail cherkasov wrote: Please see update version: http://cr.openjdk.java.net/~mcherkas/8078268/webrev.02 >You don't need to create JEditorPane, you can instantiate HTMLDocument directly

Re: [9] Review request for JDK-8147521 [macosx] Internal API Usage: setPopupType used to force creation of heavyweight popup

2016-05-12 Thread Rajeev Chamyal
Hello Sergey, Please review the updated webrev as per review comments. http://cr.openjdk.java.net/~rchamyal/8147521/webrev.05/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 11 May 2016 18:16 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net;