Re: [9] Review request for 8136998: JComboBox prevents wheel mouse scrolling of JScrollPane

2016-05-17 Thread Alexander Potochkin
Hello Alexey The scrollerMouseWheelListener field is only initialized in the installScrollerListeners() method which is called from the protected configureScroller(). So if a customer UI delegate overrides configureScroller() method, the scrollerMouseWheelListener may not be initialized.

Re: [9] Review request for 6882559: new JEditorPane("text/plain", "") fails for null context class loader

2016-05-17 Thread Sergey Bylokhov
On 17.05.16 19:20, mikhail cherkasov wrote: On 5/17/2016 7:04 PM, Sergey Bylokhov wrote: Can you please clarify on what thread we got null TCCL? EDT, I haven't seen it, but a customer faced with it, however they can't provide reproducer, My first thought was that they execute the code on

Re: [9] Review request for 8136366 Add a public API to create a L without installation

2016-05-17 Thread Sergey Bylokhov
On 17.05.16 19:18, Phil Race wrote: I do not really think this new API is a good candidate to be public. The method which gets some unspecified name, then change it to some other, and at the end support only bundled L The user was not able to get the list of built-in L And at the same time the

Re: [9] Review request for 8136366 Add a public API to create a L without installation

2016-05-17 Thread Phil Race
On 05/17/2016 09:21 AM, Sergey Bylokhov wrote: I do not really think this new API is a good candidate to be public. The method which gets some unspecified name, then change it to some other, and at the end support only bundled L The user was not able to get the list of built-in L And at the

Re: [9] Review request for 8136366 Add a public API to create a L without installation

2016-05-17 Thread Sergey Bylokhov
I do not really think this new API is a good candidate to be public. The method which gets some unspecified name, then change it to some other, and at the end support only bundled L The user was not able to get the list of built-in L And at the same time the method iterates over the list of

Re: [9] Review request for 8136366 Add a public API to create a L without installation

2016-05-17 Thread Phil Race
+1 -phil. On 05/17/2016 08:13 AM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8136366/webrev.04 The proposed UIManager.createLookAndFeel(name) method allows to create only Java built-in L by the given L name.

Re: [9] Review request for 6882559: new JEditorPane("text/plain", "") fails for null context class loader

2016-05-17 Thread Sergey Bylokhov
On 17.05.16 18:02, mikhail cherkasov wrote: The problem is that JTextPane during initialization saves Thread.contextClassloader which is null, but class loader is a null and Hashtable, which is used to store class loader, doesn't support a null value as result we get an exception. However

Re: [9] Review request for 8136366 Add a public API to create a L without installation

2016-05-17 Thread Alexander Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8136366/webrev.04 The proposed UIManager.createLookAndFeel(name) method allows to create only Java built-in L by the given L name. Thanks, Alexandr. On 4/4/2016 11:17 PM, Phil Race wrote: +1 -phil.

[9] Review request for 6882559: new JEditorPane("text/plain", "") fails for null context class loader

2016-05-17 Thread mikhail cherkasov
Hello all, Could you please review a fix for: https://bugs.openjdk.java.net/browse/JDK-6882559 webrev: http://cr.openjdk.java.net/~mcherkas/6882559/webrev.00/ The problem is that JTextPane during initialization saves Thread.contextClassloader which is null, but class loader is a null and

Re: [9] Fix for JDK-7172750 : Nimbus ScrollBar:ScrollBarThumb[Pressed].backgroundPainter is never invoked

2016-05-17 Thread Ajit Ghaisas
Thanks for the review. I have updated the test case to include suggested corrections. Please review : http://cr.openjdk.java.net/~aghaisas/7172750/webrev.01/ Regards, Ajit -Original Message- From: Rajeev Chamyal Sent: Tuesday, May 17, 2016 2:27 PM To: Ajit Ghaisas; Alexander

Re: [9] Fix for JDK-7172750 : Nimbus ScrollBar:ScrollBarThumb[Pressed].backgroundPainter is never invoked

2016-05-17 Thread Rajeev Chamyal
Hello Ajit, Fix looks fine to me. Few comments about test case. 1) @run main is missing in test. 2) JFrame dispose should be done in swing thread. Regards, Rajeev Chamyal -Original Message- From: Ajit Ghaisas Sent: 06 May 2016 12:52 To: Alexander Scherbatiy; Sergey Bylokhov;