Re: [9] Review request for 8058742: Text size is twice bigger under GTK L on Gnome with HiDPI enabled

On 21.07.16 20:30, Semyon Sadetsky wrote: Then why PangoFonts.nativeScale is double? or it is a way to apply a generic solution in case some system will have double scales? In this case I suggest to request DefaultTransform.scaleY from the gc. In this case it will not be necessary to use

Re: [9] Review request for 8058742: Text size is twice bigger under GTK L on Gnome with HiDPI enabled

On 21.07.2016 14:02, Sergey Bylokhov wrote: On 21.07.16 13:40, Semyon Sadetsky wrote: If it is unsupported then why it is validated in the pango fonts and not in X11GraphicsDevice? I am not sure how scale less than 1 prevent us from usage of 1.5 for example. getNativeScale() returns int. int

Re: [9] Review request for 8058742: Text size is twice bigger under GTK L on Gnome with HiDPI enabled

On 21.07.2016 18:33, Alexandr Scherbatiy wrote: On 7/21/2016 1:40 PM, Semyon Sadetsky wrote: On 7/21/2016 1:24 PM, Sergey Bylokhov wrote: On 21.07.16 13:18, Semyon Sadetsky wrote: We do not support non-integer scale on Linux. If it is unsupported then why it is validated in the pango

Re: [9] Review request for 8058742: Text size is twice bigger under GTK L on Gnome with HiDPI enabled

On 7/21/2016 1:40 PM, Semyon Sadetsky wrote: On 7/21/2016 1:24 PM, Sergey Bylokhov wrote: On 21.07.16 13:18, Semyon Sadetsky wrote: We do not support non-integer scale on Linux. If it is unsupported then why it is validated in the pango fonts and not in X11GraphicsDevice? I am not sure how

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

On 7/21/2016 5:25 PM, Rajeev Chamyal wrote: Hello Semyon, The resolution variant image returned is based on the implementation of BaseMultiResolutionImage::getResolutionVariant API. Current implementation of BaseMultiResolutionImage::getResolutionVariant returns a resolution variant image

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

Hello Semyon, The resolution variant image returned is based on the implementation of BaseMultiResolutionImage::getResolutionVariant API. Current implementation of BaseMultiResolutionImage::getResolutionVariant returns a resolution variant image which has width and height greater than or

Re: [9] Review request for 8160087: Change IOOBE to warning in the scenarios when it had not being thrown before the JDK-8078514

On 7/20/2016 4:46 PM, Semyon Sadetsky wrote: On 7/20/2016 2:29 PM, Alexandr Scherbatiy wrote: On 7/20/2016 10:18 AM, Semyon Sadetsky wrote: On 7/19/2016 4:06 PM, Alexandr Scherbatiy wrote: On 7/19/2016 2:56 PM, Semyon Sadetsky wrote: On 19.07.2016 14:20, Alexandr Scherbatiy wrote: The

Re: Swing Dev>[9] Review Request JDK-8158918 setExtendedState(1) for maximized Frame results in state==7

On 7/21/2016 1:51 PM, Rajeev Chamyal wrote: Hello Semyon, Following is the new bug. https://bugs.openjdk.java.net/browse/JDK-8161995 Thank you. Please link it to 8037575 and 8158918. The fix looks good. --Semyon Regards, Rajeev Chamyal *From:*Semyon Sadetsky *Sent:* 21 July 2016 16:14

Re: [9] Review request for 8058742: Text size is twice bigger under GTK L on Gnome with HiDPI enabled

On 21.07.16 13:40, Semyon Sadetsky wrote: If it is unsupported then why it is validated in the pango fonts and not in X11GraphicsDevice? I am not sure how scale less than 1 prevent us from usage of 1.5 for example. getNativeScale() returns int. int cannot be 1.5. Then why

Re: Swing Dev>[9] Review Request JDK-8158918 setExtendedState(1) for maximized Frame results in state==7

Hello Semyon, Following is the new bug. https://bugs.openjdk.java.net/browse/JDK-8161995 Regards, Rajeev Chamyal From: Semyon Sadetsky Sent: 21 July 2016 16:14 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: Swing Dev>[9] Review Request JDK-8158918

Re: Swing Dev>[9] Review Request JDK-8158918 setExtendedState(1) for maximized Frame results in state==7

On 7/21/2016 1:30 PM, Rajeev Chamyal wrote: Hello Semyon, I will be creating a new bug for the old issue. Could you, please, add the JBS link here. --Semyon Regards, Rajeev Chamyal *From:*Semyon Sadetsky *Sent:* 21 July 2016 15:59 *To:* Rajeev Chamyal; Alexander Scherbatiy;

Re: [9] Review request for 8058742: Text size is twice bigger under GTK L on Gnome with HiDPI enabled

On 7/21/2016 1:24 PM, Sergey Bylokhov wrote: On 21.07.16 13:18, Semyon Sadetsky wrote: We do not support non-integer scale on Linux. If it is unsupported then why it is validated in the pango fonts and not in X11GraphicsDevice? I am not sure how scale less than 1 prevent us from usage of

Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time

The fix looks good to me. Thanks, Alexandr. On 7/21/2016 1:34 PM, Rajeev Chamyal wrote: Looks good to me. Regards, Rajeev Chamyal -Original Message- From: Ajit Ghaisas Sent: 21 July 2016 15:13 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: RE: [9] Fix

Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time

Looks good to me. Regards, Rajeev Chamyal -Original Message- From: Ajit Ghaisas Sent: 21 July 2016 15:13 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: RE: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time Fixed a typo

Re: Swing Dev>[9] Review Request JDK-8158918 setExtendedState(1) for maximized Frame results in state==7

Hello Semyon, I will be creating a new bug for the old issue. Regards, Rajeev Chamyal From: Semyon Sadetsky Sent: 21 July 2016 15:59 To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: Swing Dev>[9] Review Request JDK-8158918 setExtendedState(1) for

Re: Swing Dev>[9] Review Request JDK-8158918 setExtendedState(1) for maximized Frame results in state==7

Hi Rajeev, As I understand you have reverted 8037575 fix. How the 8037575 will be addressed now? --Semyon On 7/18/2016 9:03 AM, Rajeev Chamyal wrote: Hello Alexandr, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8158918/webrev.01/

Re: [9] Review request for 8058742: Text size is twice bigger under GTK L on Gnome with HiDPI enabled

On 21.07.16 13:18, Semyon Sadetsky wrote: We do not support non-integer scale on Linux. If it is unsupported then why it is validated in the pango fonts and not in X11GraphicsDevice? I am not sure how scale less than 1 prevent us from usage of 1.5 for example. On 21.07.2016 13:13, Sergey

Re: [9] Review request for 8058742: Text size is twice bigger under GTK L on Gnome with HiDPI enabled

We do not support non-integer scale on Linux. --Semyon On 21.07.2016 13:13, Sergey Bylokhov wrote: Is it intended to skip scales less than 1? On 07.07.16 10:01, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/6/2016 10:03 PM, Semyon Sadetsky wrote: On

Re: Swing Dev>[9] Review Request JDK-8158918 setExtendedState(1) for maximized Frame results in state==7

The fix looks good to me. Thanks, Alexandr. On 7/18/2016 9:03 AM, Rajeev Chamyal wrote: Hello Alexandr, Please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8158918/webrev.01/ Regards, Rajeev Chamyal

Re: [9] Review request for 8058742: Text size is twice bigger under GTK L on Gnome with HiDPI enabled

Is it intended to skip scales less than 1? On 07.07.16 10:01, Alexandr Scherbatiy wrote: The fix looks good to me. Thanks, Alexandr. On 7/6/2016 10:03 PM, Semyon Sadetsky wrote: On 7/6/2016 6:03 PM, Alexandr Scherbatiy wrote: On 7/6/2016 4:13 PM, Semyon Sadetsky wrote: Hello, Please

Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time

Fixed a typo in comment (from lable to label) http://cr.openjdk.java.net/~aghaisas/7096375/webrev.04/ Regards, Ajit -Original Message- From: Ajit Ghaisas Sent: Thursday, July 21, 2016 11:41 AM To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: [9] Fix

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

On 7/21/2016 11:49 AM, Semyon Sadetsky wrote: Hello Rajeev, The taskbar icon is ok now. I change the resolution variants from the test a bit: final BaseMultiResolutionImage IMG = new BaseMultiResolutionImage( new BufferedImage[]{generateImage(4,

Re: [9] Review Request JDK-8147648 [hidpi] multiresolution image: wrong resolution variant is used as icon in the Unity panel

Hello Rajeev, The taskbar icon is ok now. I change the resolution variants from the test a bit: final BaseMultiResolutionImage IMG = new BaseMultiResolutionImage( new BufferedImage[]{generateImage(4, Color.RED), generateImage(10, Color.BLUE)}); And

Re: [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time

Good catch. I have corrected the test case. Please review. http://cr.openjdk.java.net/~aghaisas/7096375/webrev.03/ Regards, Ajit -Original Message- From: Rajeev Chamyal Sent: Thursday, July 21, 2016 11:16 AM To: Ajit Ghaisas; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: RE: