I am unable to test this since I don't have access to suitable systems,
but it does look like it should be OK as it reverts the function's behaviour
to what it was before 8214253 except for tooltips.
-phil.
On 3/8/19, 7:20 PM, Pankaj Bansal wrote:
Hi All,
Please review the following fix.
Bu
Hi, Pankaj.
Is it possible at runtime in the test check that the color of the selected node
is the same as background?
On 08/03/2019 05:50, Pankaj Bansal wrote:
Hi All,
Please review the following fix.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8220349
webrev
http://cr.openjdk.java.ne
Prasanta,
You should double check this file:
http://cr.openjdk.java.net/~psadhukhan/8220250/webrev.1/src/java.desktop/share/classes/javax/print/attribute/package-info.java.udiff.html
Previously, it was a mixture of and , suggesting that the
were subheadings of the enclosing logical section.
Hi Prasanta,
You mentioned the tool I was using to find the issues with headings...
It's a bit of a hack -- it's an annotation processor that can be run by
javac --
but while it is reasonably good at _detecting, it is not good at
checking that
you have fixed them _correctly_. This is because
Hi Phil,
On 08-Mar-19 9:17 AM, Philip Race wrote:
Apart from making sure all the files are fixed there are two things to
look for :
1) If by moving a heading up from H3 to H2 you've now created a
similar error
because there is now no H3 before an H4. To be sure of this I think you'd
need to
Hi All,
Please review the following fix.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8220349
webrev
http://cr.openjdk.java.net/~pbansal/8220349/webrev00/
Issue:
The fix done for JDK-8214253 have caused issues in JTree behaviour. If the
JTree node is selected, its background and
Hello,
I strongly recommend using
String.strip
rather than
String.trim
as Strim.trim uses a idosyncratic definition of whitespace whereas the
new-in-11 String.strip uses a conventional definition of white space.
Likewise, I recommend linking "white space" to the definition of white
