+1,
Thanks
Vivi
On 1/14/2016 4:02 AM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 1/14/2016 12:06 AM, Pete Brunet wrote:
How does this look?
http://cr.openjdk.java.net/~ptbrunet/JDK-8145735/webrev.01/
Pete
On 1/13/16 7:16 AM, Alexander Scherbatiy wrot
Hi Pete, looks good to me.
Thanks
Vivi
On 12/9/2015 2:59 PM, Pete Brunet wrote:
Please review this simple patch:
http://cr.openjdk.java.net/~ptbrunet/JDK-8071334/webrev.00/
There was some old "if JDK 1.4" code that was removed via this patch.
There was no version string change impact; the JA
Looks good to me.
Thanks
Vivi
On 11/20/2015 9:24 AM, Pete Brunet wrote:
Please review:
http://cr.openjdk.java.net/~ptbrunet/JDK-8056925/webrev.00/
Hello, anyone can help to get this item reviewed?
Thanks again!
Vivi
On 4/29/2015 3:21 PM, Vivi An wrote:
Hello,
Could you please review below bug fix?
Change made using focusCycleRoot to get root container of the
component's focus traversal cycle, instead of using getWindowAncesto
Hello,
Could you please review below bug fix?
Change made using focusCycleRoot to get root container of the
component's focus traversal cycle, instead of using getWindowAncestor to
find root window, since the focus root is not always a window. Test case
provided too.
Bug: https://bugs.openj
Hello,
Could you please approve straight backport the bug fix in JDK8 to JDK9?
Bug Description:
In Component/Container/JComponent's AccessibleContext inner classes, a
private variable propertyListenersCount is used to make sure a specific
listener is only added once through addPropertyChangeLi
Thanks Alexander for the review.
The "the" problem has been fixed in new version.
http://cr.openjdk.java.net/~van/8068518/webrev.01/
Regards,
Vivi
On 2/10/2015 8:00 AM, Alexander Scherbatiy wrote:
On 2/3/2015 11:27 PM, Vivi An wrote:
Hello,
Please review a fix for JDK 9.
D
Hello,
Please review a fix for JDK 9.
Description:
Since TreePath(Object[] path) throws /IllegalArgumentException /in case
the passed in "path" is null or last element of the array is null. We
need to make sure the result of TreeModel.getRoot() is not null before
using it to create TreePath.
Group = new HashSet();
Otherwise the fix looks good to me.
Thanks,
Alexander.
On 10/09/2014 09:53 AM, Vivi An wrote:
Thank you Alexander,
New patch with fix:
http://cr.openjdk.java.net/~van/8033699/webrev.08/
Regards,
Vivi
On 10/8/2014 11:36 AM, Alexander Zvegintsev wrote:
Hello
;
}
}
return focusBaseComp;
}
Small typo in test: Seperate - > Separate (2 times)
--
Thanks,
Alexander.
On 10/08/2014 09:45 AM, Vivi An wrote:
Hello Alexander,
Latest patched is ready for review, test case is updated too:
http://cr.openjdk.java.
Hello Alexander,
Latest patched is ready for review, test case is updated too:
http://cr.openjdk.java.net/~van/8033699/webrev.07/
Thanks
Vivi
On 10/2/2014 2:46 PM, Vivi An wrote:
Thanks Alexander. Will look into it.
Regards,
~ Vivi
On 10/2/2014 12:20 AM, Alexander Zvegintsev wrote:
Sorry
mean that after this fix this user can't
navigate to the "MIDDLE" button via keyboard
(or to the btnEnd after ButtonGroup reordering).
--
Thanks,
Alexander.
02.10.2014 0:40, Vivi An wrote:
Thanks Alexander.
I have some questions, please see comments inline.
Regards,
~ Vivi
O
d and all
following components(Shift+Tab can help in that case).
I think that these cases deserves some attention.
--
Thanks,
Alexander.
On 10/01/2014 01:15 AM, Vivi An wrote:
Hello Alexander,
Thanks for the review.
New patch is available under
http://cr.openjdk.java.net/~van/8033699
ion.
http://docs.oracle.com/javase/specs/jls/se7/html/jls-15.html#jls-15.20.2
Test is updated, non-grouped radio button test is added, test passed on
Oracle Linux 5 u6 32 bits and Windows 7.
--
Thanks,
Alexander.
On 09/18/2014 09:23 PM, Vivi An wrote:
Thank you Alexandr.
Need one more revi
AM, Vivi An wrote:
Hello Alex,
On 9/17/2014 12:44 AM, Alexander Scherbatiy wrote:
On 9/17/2014 9:17 AM, Vivi An wrote:
You are right. Fixed now.
http://cr.openjdk.java.net/~van/8033699/webrev.04/
528 if (e.isShiftDown()) {
529 if (e.getKeyCode
Hello Alex,
On 9/17/2014 12:44 AM, Alexander Scherbatiy wrote:
On 9/17/2014 9:17 AM, Vivi An wrote:
You are right. Fixed now.
http://cr.openjdk.java.net/~van/8033699/webrev.04/
528 if (e.isShiftDown()) {
529 if (e.getKeyCode() == KeyEvent.VK_TAB) {
537
hen both
jumpToNextComponent(true) and jumpToNextComponent(false) methods can
be called.
Thanks,
Alexandr.
On 9/16/2014 7:38 AM, Vivi An wrote:
Fixed. New Webrev: http://cr.openjdk.java.net/~van/8033699/webrev.03/
Thanks Alex.
Regards,
~ Vivi
On 9/15/2014 2:59 AM, Alexander Scherbatiy wrote:
Fixed. New Webrev: http://cr.openjdk.java.net/~van/8033699/webrev.03/
Thanks Alex.
Regards,
~ Vivi
On 9/15/2014 2:59 AM, Alexander Scherbatiy wrote:
On 9/12/2014 8:56 PM, Vivi An wrote:
Thanks Alexander.
All items addressed except last one, please see comments inline.
New Webrev: http
Thanks Alexander.
All items addressed except last one, please see comments inline.
New Webrev: http://cr.openjdk.java.net/~van/8033699/webrev.02/
Regards,
Vivi
On 9/11/2014 3:21 AM, Alexander Scherbatiy wrote:
On 9/11/2014 2:56 AM, Vivi An wrote:
Hello Alexander,
Thanks for nice review
Hello Alexander,
Thanks for nice review, new patch is available as below:
webrev: http://cr.openjdk.java.net/~van/8033699/webrev.01/
Regards,
~ Vivi
On 9/8/2014 5:43 AM, Alexander Scherbatiy wrote:
On 9/4/2014 10:56 PM, Vivi An wrote:
Hello,
Please review fix for JDK-8033699. Changes
Hello,
Please review fix for JDK-8033699. Changes made:
1) When tab or shift-tab key pressed, focus moved to next/previous
component outside of the radio button group
2) Using up/down or left/right arrow key to change selection inside
radio button group
Bug:https://bugs.openjdk.java.net/browse
Hello,
Could you please review the fix for JDK 9?
This bug is JAB related. Mnemonics not read for textbox. Fix made uses
the available (linked) JLabel in JComponent to get available accessible
key binding info.
Bug: https://bugs.openjdk.java.net/browse/JDK-8036819
Webrev: http://cr.openjdk.
Updated Webrev:
http://cr.openjdk.java.net/~dmarkov/8036983/jdk9/webrev.02/
Thanks
~ VIvi
On 4/15/2014 4:36 AM, Alexander Scherbatiy wrote:
On 4/15/2014 10:44 AM, Vivi An wrote:
Hi Alex,
On 4/14/2014 5:59 AM, Alexander Scherbatiy wrote:
On 4/11/2014 10:30 PM, Vivi An wrote:
Hello Alex
Hi Alex,
On 4/14/2014 5:59 AM, Alexander Scherbatiy wrote:
On 4/11/2014 10:30 PM, Vivi An wrote:
Hello Alex,
On 4/11/2014 6:21 AM, Alexander Scherbatiy wrote:
src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java
208 * The lead path is set to the last unique path.
This
eport attached to the bug
Thanks,
Alexandr.
On 4/11/2014 3:24 AM, Vivi An wrote:
Thanks Petr
Please see comments inline. Plus, one more question, does new package
private function requires CCC approval?
~ Vivi
On 4/10/2014 7:25 AM, Petr Pchelko wrote:
Hello, Vivi.
Is it possible t
good point since I will have more of such fix coming up.
10 апр. 2014 г., в 6:04 после полудня, Vivi An написал(а):
Updated webrev:
http://cr.openjdk.java.net/~dmarkov/8036983/jdk9/webrev.01/
Comments as below
Thanks
Vivi
On 4/9/2014 8:08 AM, Alexander Scherbatiy wrote:
On 4/8/2014 9:19 P
Updated webrev:
http://cr.openjdk.java.net/~dmarkov/8036983/jdk9/webrev.01/
Comments as below
Thanks
Vivi
On 4/9/2014 8:08 AM, Alexander Scherbatiy wrote:
On 4/8/2014 9:19 PM, Vivi An wrote:
Hello,
Could you please review the fix for JDK 9?
This bug is JAB related
Hello,
Could you please review the fix for JDK 9?
This bug is JAB related. ActivateDescenderPropertyChanged event for
JTree and JTable were not sent properly in case SHIFT+CursorDown or
Ctrl+CursorUp/Down are used. Fix made mainly uses lead path (acctive
child path) instead of selection path
Hello,
Could you please review the fix for JDK 9?
This bug is JAB related. ActivateDescenderPropertyChanged event for
JTree and JTable were not sent properly in case SHIFT+CursorDown or
Ctrl+CursorUp/Down are used. Fix made mainly uses lead path (active
child path) instead of selection path
29 matches
Mail list logo
