I have not changed any build files. I only modified CompileJavaModules
to see if it builds fine as was asked for.
Regards
Prasanta
On 21-Mar-19 8:33 PM, Jonathan Gibbons wrote:
Sounds good; note you should cc: build-dev@ojn for changes to build
files.
-- Jon
On 3/21/19 3:23 AM, Prasanta
Sounds good; note you should cc: build-dev@ojn for changes to build files.
-- Jon
On 3/21/19 3:23 AM, Prasanta Sadhukhan wrote:
FYI...it does build fine with this build change.
Regards
Prasanta
On 19-Mar-19 10:58 PM, Jonathan Gibbons wrote:
Prasanta,
Note that if you believe you have fixed
FYI...it does build fine with this build change.
Regards
Prasanta
On 19-Mar-19 10:58 PM, Jonathan Gibbons wrote:
Prasanta,
Note that if you believe you have fixed all the heading issues in the
java.desktop module,
you can re-enable the doclint checks for the module by removing
Hi Prasanta,
Looks fine.
Regards,
Alexey
On 19/03/2019 10:41, Prasanta Sadhukhan wrote:
Hi Alexey,
Your points are valid so I modified those in this webrev, please have
a look
http://cr.openjdk.java.net/~psadhukhan/8220250/webrev.3/
Regards
Prasanta
On 15-Mar-19 10:28 PM, Alexey Ivanov
Prasanta,
Note that if you believe you have fixed all the heading issues in the
java.desktop module,
you can re-enable the doclint checks for the module by removing
"-accessibility" from
the java.desktop line in make/CompileJavaModules.gmk
Hi Alexey,
Your points are valid so I modified those in this webrev, please have a look
http://cr.openjdk.java.net/~psadhukhan/8220250/webrev.3/
Regards
Prasanta
On 15-Mar-19 10:28 PM, Alexey Ivanov wrote:
Hi Prasanta,
On 15/03/2019 05:15, Prasanta Sadhukhan wrote:
Hi Alexey,
On 13-Mar-19
Hi Prasanta,
On 15/03/2019 05:15, Prasanta Sadhukhan wrote:
Hi Alexey,
On 13-Mar-19 6:10 PM, Alexey Ivanov wrote:
Hi guys,
This is more of a general comment rather than targeted at this
particular change. Sorry if I missed any previous discussion on that
matter.
I think it's good to
Hi Alexey,
On 13-Mar-19 6:10 PM, Alexey Ivanov wrote:
Hi guys,
This is more of a general comment rather than targeted at this
particular change. Sorry if I missed any previous discussion on that
matter.
I think it's good to have consistent headings without skipping levels.
Yet in the
Hi guys,
This is more of a general comment rather than targeted at this
particular change. Sorry if I missed any previous discussion on that matter.
I think it's good to have consistent headings without skipping levels.
Yet in the Javadoc comments does not seem right. Let's take a look
at
Any more comments on this
http://cr.openjdk.java.net/~psadhukhan/8220250/webrev.2/
Regards
Prasanta
On 11-Mar-19 2:16 PM, Prasanta Sadhukhan wrote:
The 2nd URL is based on webrev.1. I have placed new docs for webrev.2
here
On 11/03/2019 17:42, Philip Race wrote:
What can I say ? It is clear enough to me ..
"What is an Attribute" is the intro/preamble/overview and the two subsections
get into the specifics of how an attribute is used by the API.
After that we move on to the next topic of Attribute Sets ..
And
What can I say ? It is clear enough to me ..
"What is an Attribute" is the intro/preamble/overview and the two
subsections
get into the specifics of how an attribute is used by the API.
After that we move on to the next topic of Attribute Sets ..
-phil.
On 3/12/19, 5:46 AM, Sergey Bylokhov
On 09/03/2019 22:59, Philip Race wrote:
What was H3 is in italics and what follows in regular style is intended
to be a sub-section.
It is unclear why "Attribute Categories and Values" and "Attribute Roles" is a
sub-section of "What is an Attribute?", while all other stuff is not.
--
Best
If it helps, I have a utility to extract headers from an API bundle,
that can generate a new bundle showing just the headers for each page,
and their metadata. I'll run that on the two bundles you list below, and
post the new URLs here.
-- Jon
On 3/9/19 10:59 PM, Philip Race wrote:
It might
It might have been intentional but I think it is wrong.
It is useful to look at the old :
https://docs.oracle.com/en/java/javase/11/docs/api/java.desktop/module-summary.html
and the new :
http://cr.openjdk.java.net/~psadhukhan/8220250/docs/api/java.desktop/module-summary.html
to compare.
What
When I check the first version, I thought it was intentional change.
https://docs.oracle.com/en/java/javase/11/docs/api/java.desktop/javax/print/attribute/package-summary.html
All of them looks similar headers described something about attributes:
1. Attribute Roles
2. Attribute Sets
Why
Thanks Jon for the pointer. I have modified that file
http://cr.openjdk.java.net/~psadhukhan/8220250/webrev.2/
Any more comments?
Regards
Prasanta
On 09-Mar-19 2:24 AM, Jonathan Gibbons wrote:
Prasanta,
You should double check this file:
Hi Prasanta,
You mentioned the tool I was using to find the issues with headings...
It's a bit of a hack -- it's an annotation processor that can be run by
javac --
but while it is reasonably good at _detecting, it is not good at
checking that
you have fixed them _correctly_. This is because
Apart from making sure all the files are fixed there are two things to
look for :
1) If by moving a heading up from H3 to H2 you've now created a similar
error
because there is now no H3 before an H4. To be sure of this I think you'd
need to run Jon's tool - how did you verify it ?
2) If in
Looks fine.
On 07/03/2019 03:37, Prasanta Sadhukhan wrote:
Hi All,
Bug: https://bugs.openjdk.java.net/browse/JDK-8220250
webrev: http://cr.openjdk.java.net/~psadhukhan/8220250/webrev.0/
Please review a doc fix to fix heading style to improve the accessibility JDK
API documentation of
Hi All,
Bug: https://bugs.openjdk.java.net/browse/JDK-8220250
webrev: http://cr.openjdk.java.net/~psadhukhan/8220250/webrev.0/
Please review a doc fix to fix heading style to improve the
accessibility JDK API documentation of java.desktop module.
Main approach taken for fixing heading style
21 matches
Mail list logo
