Re: [jdk16] RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v2]

On Thu, 24 Dec 2020 18:36:12 GMT, Prasanta Sadhukhan wrote: >> Please review a fix for jdk16. >> On macOS 11 (bigsur), using the Swing Aqua Look and Feel, the text of the >> selected JTabbedPane tab title text is just a light gray outline of white >> text on a white background. The macOS 11 de

Re: [jdk16] RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v2]

On Thu, 24 Dec 2020 18:36:12 GMT, Prasanta Sadhukhan wrote: >> Please review a fix for jdk16. >> On macOS 11 (bigsur), using the Swing Aqua Look and Feel, the text of the >> selected JTabbedPane tab title text is just a light gray outline of white >> text on a white background. The macOS 11 de

Re: [jdk16] RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v2]

On Thu, 24 Dec 2020 17:35:56 GMT, Phil Race wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Check for BigSur and above > > src/java.desktop/macosx/classes/com/apple/laf/AquaLookAndFeel.java line 873: > >> 87

Re: [jdk16] RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Thu, 24 Dec 2020 18:08:57 GMT, Phil Race wrote: >> Please review a fix for jdk16. >> On macOS 11 (bigsur), using the Swing Aqua Look and Feel, the text of the >> selected JTabbedPane tab title text is just a light gray outline of white >> text on a white background. The macOS 11 design inver

Re: [jdk16] RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v2]

> Please review a fix for jdk16. > On macOS 11 (bigsur), using the Swing Aqua Look and Feel, the text of the > selected JTabbedPane tab title text is just a light gray outline of white > text on a white background. The macOS 11 design inverted from dark background > / light text to light backgro

Re: [jdk16] RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Wed, 23 Dec 2020 10:41:04 GMT, Prasanta Sadhukhan wrote: > Please review a fix for jdk16. > On macOS 11 (bigsur), using the Swing Aqua Look and Feel, the text of the > selected JTabbedPane tab title text is just a light gray outline of white > text on a white background. The macOS 11 design

Re: [jdk16] RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

What alternative are you proposing? I don’t believe there is any option that is guaranteed not to require changing for some future release of macOS without some new API from Apple, e.g. “selectedTabTextColor”. > On Dec 24, 2020, at 9:39 AM, Phil Race wrote: > > On Wed, 23 Dec 2020 10:41:04 G

Re: [jdk16] RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Wed, 23 Dec 2020 10:41:04 GMT, Prasanta Sadhukhan wrote: > Please review a fix for jdk16. > On macOS 11 (bigsur), using the Swing Aqua Look and Feel, the text of the > selected JTabbedPane tab title text is just a light gray outline of white > text on a white background. The macOS 11 design

[jdk16] RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

Please review a fix for jdk16. On macOS 11 (bigsur), using the Swing Aqua Look and Feel, the text of the selected JTabbedPane tab title text is just a light gray outline of white text on a white background. The macOS 11 design inverted from dark background / light text to light background / dark

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

On Fri, 18 Dec 2020 23:36:27 GMT, Phil Race wrote: >>> So why would this API return the wrong colour ? >> >> That method used in the last version returns the color which is not the >> color of the tabpane. It is a similar color in some cases, but not always. > > So I think we need to hard code

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

On Fri, 18 Dec 2020 22:41:18 GMT, Sergey Bylokhov wrote: >> So why would this API return the wrong colour ? >> Sounds like we need to re-cap the alternatives and the pros and cons along >> with some explanation >> And do it before opening the 16 PR. > >> So why would this API return the wrong co

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

Just to be clear, there is no Apple API whose purpose is to reveal the color that AppKit uses to paint the text in a tab. Any color choice you make, literal or symbolic, will either be wrong now or sometime in the future, or both. Trying to deduce the color by analyzing an actual native view mig

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

On Fri, 18 Dec 2020 22:23:24 GMT, Phil Race wrote: > So why would this API return the wrong colour ? That method used in the last version returns the color which is not the color of the tabpane. It is a similar color in some cases, but not always. - PR: https://git.openjdk.java.ne

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

On Fri, 18 Dec 2020 22:14:48 GMT, Sergey Bylokhov wrote: >>>It does not cached it is a mutable SystemColor which is updated on the color >>>theme switch, >>> it works in a similar way as text selection color which might be configured >>> in the macOS settings. >> >> Looked in the code as if it

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

On Fri, 18 Dec 2020 21:48:04 GMT, Phil Race wrote: > > It does not cached it is a mutable SystemColor which is updated on the > > color theme switch, > > it works in a similar way as text selection color which might be configured > > in the macOS settings. > > Looked in the code as if it was c

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

On Fri, 18 Dec 2020 21:38:59 GMT, Sergey Bylokhov wrote: >It does not cached it is a mutable SystemColor which is updated on the color >theme switch, > it works in a similar way as text selection color which might be configured > in the macOS settings. Looked in the code as if it was cached by

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

On Fri, 18 Dec 2020 13:00:35 GMT, Kevin Rushforth wrote: >> The current version has the issue of text color obtained through >> [selectedControlColor] being changed through "Preferences->General->Accent >> Color", which is not in our control, which was already discussed. So, I >> thought the 1

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

On Fri, 18 Dec 2020 03:35:03 GMT, Prasanta Sadhukhan wrote: >> I wouldn't know how to approve an earlier version. SFAIK I approved the >> current version. >> One thing here though is that I think you should WITHDRAW this PR and >> re-submit for JDK 16. >> I don't think we want to have to wait

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

On Thu, 17 Dec 2020 18:03:04 GMT, Phil Race wrote: >>> If 1st, is there any way to integrate the 1st version without updating the >>> PR? >> >> No, this is not possible. If you need to integrate an earlier version, you >> will need to revert those changes in your local branch and push them. >

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

On Thu, 17 Dec 2020 13:02:12 GMT, Kevin Rushforth wrote: >> @prrace Did you approve the 1st version of the fix >> [https://openjdk.github.io/cr/?repo=jdk&pr=1182&range=00] >> or the current (4th) version? >> If 1st, is there any way to integrate the 1st version without updating the >> PR? > >>

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

On Thu, 17 Dec 2020 04:23:42 GMT, Prasanta Sadhukhan wrote: > If 1st, is there any way to integrate the 1st version without updating the > PR? No, this is not possible. If you need to integrate an earlier version, you will need to revert those changes in your local branch and push them. ---

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

On Tue, 15 Dec 2020 20:46:03 GMT, Phil Race wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> name correction > > Marked as reviewed by prr (Reviewer). @prrace Did you approve the 1st version of the fix [http

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Mon, 14 Dec 2020 04:55:02 GMT, Prasanta Sadhukhan wrote: > The forumpost is here https://discussions.apple.com/thread/252067605 > The hardcoded being referred was in this 1st iteration of the fix > https://openjdk.github.io/cr/?repo=jdk&pr=1182&range=00 OK. So I guess this could work for eit

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

On Thu, 19 Nov 2020 03:37:16 GMT, Prasanta Sadhukhan wrote: >> On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of >> the selected JTabbedPane tab title text is just a light gray outline of >> white text on a white background. The macOS 11 design inverted from dark >> b

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Sat, 12 Dec 2020 23:32:59 GMT, Phil Race wrote: >>> Since the apple forum post is still unanswered and if we want it to be >>> fixed for JDK16, I dont see any other alternative than to fix by what I did >>> in the 1st iteration of this by hardcoding. I dont think we are going to >>> enable

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Tue, 1 Dec 2020 18:18:21 GMT, Sergey Bylokhov wrote: >> Since the apple forum post is still unanswered and if we want it to be fixed >> for JDK16, I dont see any other alternative than to fix by what I did in the >> 1st iteration of this by hardcoding. I dont think we are going to enable >>

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Mon, 30 Nov 2020 04:49:25 GMT, Prasanta Sadhukhan wrote: > Since the apple forum post is still unanswered and if we want it to be fixed > for JDK16, I dont see any other alternative than to fix by what I did in the > 1st iteration of this by hardcoding. I dont think we are going to enable d

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Tue, 24 Nov 2020 21:23:38 GMT, Sergey Bylokhov wrote: >> Tried to find and change tabpane background color for "selected" tab but >> unable to do so. >> Tried changing AquaLookAndFeel.tabBackgroundColor, TabbedPane.background >> color to no avail. Tried to set background by calling >> tabP

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Mon, 30 Nov 2020 08:54:20 GMT, Prasanta Sadhukhan wrote: >> Since the apple forum post is still unanswered and if we want it to be fixed >> for JDK16, I dont see any other alternative than to fix by what I did in the >> 1st iteration of this by hardcoding. I dont think we are going to enabl

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

Isn’t that what -Dapple.awt.application.appearance=system does? > On Nov 30, 2020, at 12:56 AM, Prasanta Sadhukhan > wrote: > > On Mon, 30 Nov 2020 04:49:25 GMT, Prasanta Sadhukhan > wrote: > >>> Since color of tabpane is controlled by Apple, Can you point me to the code >>> where we call A

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Mon, 30 Nov 2020 04:49:25 GMT, Prasanta Sadhukhan wrote: >> Since color of tabpane is controlled by Apple, Can you point me to the code >> where we call Apple api to draw the color of tabpane? > > Since the apple forum post is still unanswered and if we want it to be fixed > for JDK16, I do

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Wed, 25 Nov 2020 03:19:32 GMT, Prasanta Sadhukhan wrote: >>> When inactive, I use 0 0 0 192. As far as I can tell, this does not >>> correspond to a named color. >>> It would be wrong to assume that Apple only uses named colors in their UIs. >>> The named colors are for application developer

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

> On Nov 24, 2020, at 1:26 PM, Sergey Bylokhov wrote: > > The problem here is that we do not control the color of the tab pane, it is > controlled by Apple, and if we hardcore some color on our side we will get > the same bugs again and again. I am sure that a similar bug will come in the > d

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Nov 24, 2020, at 7:21 PM, Prasanta Sadhukhan wrote: > > On Tue, 24 Nov 2020 21:23:38 GMT, Sergey Bylokhov > wrote: > >>> Tried to find and change tabpane background color for "selected" tab but >>> unable to do so. >>> Tried changing AquaLookAndFeel.tabBackgroundC

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Tue, 24 Nov 2020 21:23:38 GMT, Sergey Bylokhov wrote: >> Tried to find and change tabpane background color for "selected" tab but >> unable to do so. >> Tried changing AquaLookAndFeel.tabBackgroundColor, TabbedPane.background >> color to no avail. Tried to set background by calling >> tabP

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Tue, 24 Nov 2020 08:48:36 GMT, Prasanta Sadhukhan wrote: >> Then try to dig into it a little bit, probably a good reason to ask about >> the current font color in the tab at the Apple forum. > > Tried to find and change tabpane background color for "selected" tab but > unable to do so. > T

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Thu, 19 Nov 2020 18:56:43 GMT, Sergey Bylokhov wrote: >> In Mohave, native System Preferences->Display tabs has >> white-text-on-blue-background when windows is focused >> black-text-on-lightgray-background when window is unfocused >> >> In macos11, it is always black-text-on-white-backgroun

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

When inactive, I use 0 0 0 192. As far as I can tell, this does not correspond to a named color. It would be wrong to assume that Apple only uses named colors in their UIs. The named colors are for application developers, not for Apple itself. Alan > On Nov 19, 2020, at 4:05 PM, Alan Snyder

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

VAqua uses controlTextColor which has the value 255 255 255 217. If you are seeing opaque white, then the alpha channel is getting lost somewhere. Alan > On Nov 19, 2020, at 10:59 AM, Sergey Bylokhov wrote: > > On Thu, 19 Nov 2020 10:51:55 GMT, Prasanta Sadhukhan

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Thu, 19 Nov 2020 10:51:55 GMT, Prasanta Sadhukhan wrote: >> I have tried to test this change on macOS 10.15 and found some differences >> from the old behavior. >> Before the fix: >> - The color was white for the selected tab while the window was focused, >> the same as in the native app(I

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Thu, 19 Nov 2020 08:29:11 GMT, Sergey Bylokhov wrote: >> On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of >> the selected JTabbedPane tab title text is just a light gray outline of >> white text on a white background. The macOS 11 design inverted from dark >> backg

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Thu, 12 Nov 2020 09:58:36 GMT, Prasanta Sadhukhan wrote: > On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of > the selected JTabbedPane tab title text is just a light gray outline of white > text on a white background. The macOS 11 design inverted from dark backgrou

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v4]

> On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of > the selected JTabbedPane tab title text is just a light gray outline of white > text on a white background. The macOS 11 design inverted from dark background > / light text to light background / dark text, > Proposed

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v3]

On Wed, 18 Nov 2020 07:33:15 GMT, Prasanta Sadhukhan wrote: >> On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of >> the selected JTabbedPane tab title text is just a light gray outline of >> white text on a white background. The macOS 11 design inverted from dark >> b

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v3]

> On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of > the selected JTabbedPane tab title text is just a light gray outline of white > text on a white background. The macOS 11 design inverted from dark background > / light text to light background / dark text, > Proposed

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v2]

On Tue, 17 Nov 2020 20:27:11 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use apple UI Element color > > src/java.desktop/macosx/classes/sun/lwawt/macosx/LWCToolkit.java line 216: > >

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v2]

On Tue, 17 Nov 2020 10:00:20 GMT, Prasanta Sadhukhan wrote: >> On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of >> the selected JTabbedPane tab title text is just a light gray outline of >> white text on a white background. The macOS 11 design inverted from dark >> b

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible [v2]

> On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of > the selected JTabbedPane tab title text is just a light gray outline of white > text on a white background. The macOS 11 design inverted from dark background > / light text to light background / dark text, > Proposed

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Fri, 13 Nov 2020 23:17:30 GMT, Sergey Bylokhov wrote: > SystemColors/LWCToolkit#loadNativeColors are for sure works on macOS it is > responsible for the text selection color for example. I could not find how loadNativeColors() is used/works because only place I see it is called in macos is i

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Fri, 13 Nov 2020 10:07:57 GMT, Prasanta Sadhukhan wrote: >> Well, even "white" was hardcoded till now...so I am not sure how can we read >> the color from native...do you have any idea? >> Even CsystemColors.m has all the color hardcoded >> sColors[java_awt_SystemColor_ACTIVE_CAPTION_TEXT]

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Fri, 13 Nov 2020 09:29:38 GMT, Prasanta Sadhukhan wrote: >> The color instead of hardcoded "Color.lightGray" > > Well, even "white" was hardcoded till now...so I am not sure how can we read > the color from native...do you have any idea? > Even CsystemColors.m has all the color hardcoded >

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Fri, 13 Nov 2020 07:18:45 GMT, Sergey Bylokhov wrote: >> What "information" you want to be read from native? > > The color instead of hardcoded "Color.lightGray" Well, even "white" was hardcoded till now...so I am not sure how can we read the color from native...do you have any idea? Even Cs

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Fri, 13 Nov 2020 02:39:29 GMT, Prasanta Sadhukhan wrote: >> src/java.desktop/macosx/classes/com/apple/laf/AquaLookAndFeel.java line 332: >> >>> 330: final ColorUIResource selectedTabTitleNormalColor = >>> 331: >>> System.getProperty("os.version").contains("10

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Fri, 13 Nov 2020 00:24:00 GMT, Sergey Bylokhov wrote: >> On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of >> the selected JTabbedPane tab title text is just a light gray outline of >> white text on a white background. The macOS 11 design inverted from dark >> backg

Re: RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On Thu, 12 Nov 2020 09:58:36 GMT, Prasanta Sadhukhan wrote: > On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of > the selected JTabbedPane tab title text is just a light gray outline of white > text on a white background. The macOS 11 design inverted from dark backgrou

RFR: 8251377: [macos11] JTabbedPane selected tab text is barely legible

On macOS 11 (bigsur) beta, using the Swing Aqua Look and Feel, the text of the selected JTabbedPane tab title text is just a light gray outline of white text on a white background. The macOS 11 design inverted from dark background / light text to light background / dark text, Proposed fix is to