On Thu, 1 Apr 2021 16:19:48 GMT, Prasanta Sadhukhan
wrote:
>> A public overriding method
>> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
>> has no spec.
>> Added spec for the method.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit
On Thu, 8 Apr 2021 04:59:13 GMT, Sergey Bylokhov wrote:
>
>
> > In many places, we use {@inheritdoc} [ex.
> > https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthToolTipUI.java#L68]
> > for same usecase!!!
>
> All of them are in the SynthXX c
On Thu, 8 Apr 2021 04:27:16 GMT, Prasanta Sadhukhan
wrote:
>>> The behavior is not a javadoc bug. If a method is overridden with no
>>> specified change in behavior, the method will be documented in the "Methods
>>> Declared In ..." list at the end of the main summary table.
>>
>> If it is no
On Thu, 8 Apr 2021 00:37:57 GMT, Sergey Bylokhov wrote:
>> The behavior is not a javadoc bug.
>>
>> If a method is overridden with no specified change in behavior, the
>> method will be documented in the "Methods Declared In ..." list at the
>> end of the main summary table.
>>
>> -- Jon
>>
On Thu, 8 Apr 2021 00:16:29 GMT, Jonathan Gibbons wrote:
> The behavior is not a javadoc bug. If a method is overridden with no
> specified change in behavior, the method will be documented in the "Methods
> Declared In ..." list at the end of the main summary table.
If it is not a bug it is n
On Wed, 7 Apr 2021 20:34:22 GMT, Alexey Ivanov wrote:
>>> I dont see any update in JDK-8264217. Is this then considered to be a
>>> javadoc bug?
>>
>> It does not matter is it a JavaDoc bug or feature. If it is a bug it will be
>> fixed and spec will be returned for the current method. If it
On Wed, 7 Apr 2021 20:06:46 GMT, Sergey Bylokhov wrote:
> > I dont see any update in JDK-8264217. Is this then considered to be a
> > javadoc bug?
>
> It does not matter is it a JavaDoc bug or feature. If it is a bug it will be
> fixed and spec will be returned for the current method. If it is
On Wed, 7 Apr 2021 03:32:35 GMT, Prasanta Sadhukhan
wrote:
> I dont see any update in JDK-8264217. Is this then considered to be a javadoc
> bug?
It does not matter is it a JavaDoc bug or feature. If it is a bug it will be
fixed and spec will be returned for the current method. If it is an i
On Thu, 1 Apr 2021 17:00:15 GMT, Sergey Bylokhov wrote:
>> Marked as reviewed by aivanov (Reviewer).
>
>> This might have been overlooked. The overridden method changes the
>> behaviour. I'm for documenting the updated behaviour.
>
> It does not, the spec of the parent is still applicable to th
On Thu, 1 Apr 2021 16:14:14 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> javadoc change
>
> Marked as reviewed by aivanov (Reviewer).
> This might have been overlooked. The overridden m
On Thu, 1 Apr 2021 16:16:07 GMT, Prasanta Sadhukhan
wrote:
>> A public overriding method
>> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
>> has no spec.
>> Added spec for the method.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit
> A public overriding method
> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
> has no spec.
> Added spec for the method.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
javadoc change
-
Changes:
-
On Thu, 1 Apr 2021 16:08:48 GMT, Prasanta Sadhukhan
wrote:
>> A public overriding method
>> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
>> has no spec.
>> Added spec for the method.
>
> Prasanta Sadhukhan has updated the pull request incrementally with two
> additional commits
On Thu, 1 Apr 2021 15:50:28 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> javadoc change
>
> src/java.desktop/share/classes/javax/swing/JMenu.java line 1260:
>
>> 1258: /**
>> 1259:
On Thu, 1 Apr 2021 15:52:49 GMT, Sergey Bylokhov wrote:
> The method was overridden to change the implementation without changing of
> specification.
This might have been overlooked. The overridden method changes the behaviour.
I'm for documenting the updated behaviour.
> This is exactly the
> A public overriding method
> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
> has no spec.
> Added spec for the method.
Prasanta Sadhukhan has updated the pull request incrementally with two
additional commits since the last revision:
- javadoc change
- javadoc change
---
On Thu, 1 Apr 2021 15:29:34 GMT, Jonathan Gibbons wrote:
>>>
>>> Starting in JDK 10, the default behavior of the standard doclet was changed
>>> so that if a method is just being overridden for implementation reasons,
>>> and there is no change in the public spec or signature, then the method
On Thu, 1 Apr 2021 15:48:53 GMT, Prasanta Sadhukhan
wrote:
>> A public overriding method
>> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
>> has no spec.
>> Added spec for the method.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit
> A public overriding method
> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
> has no spec.
> Added spec for the method.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
javadoc change
-
Changes:
-
On Thu, 1 Apr 2021 15:25:44 GMT, Prasanta Sadhukhan
wrote:
>> Starting in JDK 10, the default behavior of the standard doclet was
>> changed so that if a method is just being overridden for implementation
>> reasons, and there is no change in the public spec or signature, then
>> the method w
On Thu, 1 Apr 2021 14:10:08 GMT, Jonathan Gibbons wrote:
>> @prsadhuk You could always add `@inheritDoc` like this:
>>
>> /**
>> * {@inheritDoc}
>> */
>
> Starting in JDK 10, the default behavior of the standard doclet was
> changed so that if a method is just being overridden for implementat
On Thu, 1 Apr 2021 12:45:52 GMT, Kevin Rushforth wrote:
>> I guess openjdk shows file history from 7u23 onwards IIRC so not sure why it
>> is showing "Initial load" and not who/what removed it. Maybe the spec
>> wordings actually was not there but some javadoc trickery was adding the
>> javado
On Thu, 1 Apr 2021 12:49:06 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/JMenu.java line 1269:
>>
>>> 1267: *
>>> 1268: * @see java.awt.ComponentOrientation
>>> 1269: */
>>
>> Shall it just use `{@inheritDoc}`?
>> The javadoc generated in 7 and 8
> A public overriding method
> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
> has no spec.
> Added spec for the method.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Add @inheritDoc
-
Changes:
On Thu, 1 Apr 2021 12:42:19 GMT, Alexey Ivanov wrote:
>> A public overriding method
>> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
>> has no spec.
>> Added spec for the method.
>
> src/java.desktop/share/classes/javax/swing/JMenu.java line 1269:
>
>> 1267: *
>> 1268:
On Thu, 1 Apr 2021 12:41:14 GMT, Prasanta Sadhukhan
wrote:
>> The method is also present in the Java 8:
>> https://docs.oracle.com/javase/8/docs/api/javax/swing/JMenu.html#setComponentOrientation-java.awt.ComponentOrientation-
>
> I guess openjdk shows file history from 7u23 onwards IIRC so not
On Fri, 26 Mar 2021 11:30:35 GMT, Prasanta Sadhukhan
wrote:
> A public overriding method
> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
> has no spec.
> Added spec for the method.
src/java.desktop/share/classes/javax/swing/JMenu.java line 1269:
> 1267: *
> 1268: * @
On Thu, 1 Apr 2021 12:35:21 GMT, Alexey Ivanov wrote:
>> I could not see the spec in the last 14 years openjdk history of this file.
>> Shouldn't we need to add the spec even if it's javadoc bug?
>> Instead of blindly copying JComponent setComponentOrientation spec as was
>> done in jdk7 in abo
On Thu, 1 Apr 2021 11:26:55 GMT, Prasanta Sadhukhan
wrote:
>> Looks like the JavaDoc bug, the spec was there in jdk7:
>> https://docs.oracle.com/javase/7/docs/api/javax/swing/JMenu.html#setComponentOrientation(java.awt.ComponentOrientation)
>
> I could not see the spec in the last 14 years openj
On Sat, 27 Mar 2021 01:20:45 GMT, Sergey Bylokhov wrote:
>> A public overriding method
>> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
>> has no spec.
>> Added spec for the method.
>
> Looks like the JavaDoc bug, the spec was there in jdk7:
> https://docs.oracle.com/javase/7/docs
On Fri, 26 Mar 2021 11:30:35 GMT, Prasanta Sadhukhan
wrote:
> A public overriding method
> JMenu.setComponentOrientation(java.awt.ComponentOrientation)
> has no spec.
> Added spec for the method.
Looks like the JavaDoc bug, the spec was there in jdk7:
https://docs.oracle.com/javase/7/docs/api/
A public overriding method
JMenu.setComponentOrientation(java.awt.ComponentOrientation)
has no spec.
Added spec for the method.
-
Commit messages:
- 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no
spec
Changes: https://git.openjdk.java.net/jdk/pull/3213/f
32 matches
Mail list logo
