:15
To: Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: Review request for JDK-4769772
JInternalFrame.setIcon(true) before JDesktopPane.add(JIF) causes wrong state
Hi Rajeev,
The updated version looks good to me.
Regards,
Alexey
On 28.12.2015 16:25, Rajeev Chamyal wrote:
Hello Alexey
to questions inline.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexey Ivanov
Sent: 25 December 2015 18:14
To: Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: Review request for JDK-4769772
JInternalFrame.setIcon(true) before JDesktopPane.add(JIF) causes wrong state
Hi Rajeev
Chamyal; swing-dev@openjdk.java.net
Subject: Re: Review request for JDK-4769772
JInternalFrame.setIcon(true) before JDesktopPane.add(JIF) causes wrong state
Hi Rajeev,
Thank you for updating the code and the test.
Please see my comments inline.
On 28.12.2015 10:37, Rajeev Chamyal wrote:
Hello
: Alexey Ivanov
Sent: 28 December 2015 16:53
To: Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: Review request for JDK-4769772
JInternalFrame.setIcon(true) before JDesktopPane.add(JIF) causes wrong state
Hi Rajeev,
Thank you for updating the code and the test.
Please see my comments
; swing-dev@openjdk.java.net
Subject: Re: Review request for JDK-4769772
JInternalFrame.setIcon(true) before JDesktopPane.add(JIF) causes wrong state
Hi Rajeev,
Thank you for updating the code.
I have a couple more questions though.
1. SynthDesktopPaneUI
What is the purpose of this line
updated webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/4769772/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexey Ivanov
Sent: 23 December 2015 19:27
To: swing-dev@openjdk.java.net
Subject: Re: Review request for JDK-4769772
JInternalFrame.setIcon(true
Hi Rajeev,
There's a potential NullPointerException in this line of
BasicInternalFrameUI.java:
if(value.equals(Boolean.FALSE))
I suggest eliminating it using this construct:
if (Boolean.FALSE.equals(value))
This way the code is safer.
Can the test be simplified? Is it really
Hi Rajeev,
One more comment:
You should call dispose() in finally block in main so that the frame is
closed automatically if the test fails.
Regards,
Alexey
On 23.12.2015 16:46, Alexey Ivanov wrote:
Hi Rajeev,
There's a potential NullPointerException in this line of
request for JDK-4769772
JInternalFrame.setIcon(true) before JDesktopPane.add(JIF) causes wrong state
Hi Rajeev,
One more comment:
You should call dispose() in finally block in main so that the frame is closed
automatically if the test fails.
Regards,
Alexey
On 23.12.2015 16:46, Alexey Ivanov
Subject: Re: Review request for JDK-4769772 JInternalFrame.setIcon(true) before
JDesktopPane.add(JIF) causes wrong state
Hi, Rajeev.
I still review the code, But I would like to clarify: should we do the similar
fix for the maximize property as well, or it works?
On 18/12/15 11:44, Rajeev
Hello All,
Please review the following fix for Jdk9:
Bug: https://bugs.openjdk.java.net/browse/JDK-4769772
Webrev: http://cr.openjdk.java.net/~rchamyal/4769772/webrev.00/
Issue: Iconifying a frame before adding it to desktop pane is not working.
Cause: Setting setIcon property of a
Hi, Rajeev.
I still review the code, But I would like to clarify: should we do the
similar fix for the maximize property as well, or it works?
On 18/12/15 11:44, Rajeev Chamyal wrote:
Hello All,
Please review the following fix for Jdk9:
Bug: https://bugs.openjdk.java.net/browse/JDK-4769772
12 matches
Mail list logo
