[symfony-devs] Re: About the Controller refactoring

2007-07-27 Thread Matthias N.
Hi, today I commited the recent changed of my controller stuff: http://trac.symfony-project.com/trac/changeset/4734 Key changes compared to trunk are: - Moved sfFrontWebController->dispatch() to sfWebController and separated the actual dispatching into an own execute() method to make it possibl

[symfony-devs] Re: About the Controller refactoring

2007-07-18 Thread Matthias N.
On 18 Jul., 15:12, Fabien POTENCIER <[EMAIL PROTECTED] project.com> wrote: > Matthias, > > Some random thoughts and questions about your recent changes to the > Controller (http://trac.symfony-project.com/trac/changeset/4650): > > - I'm not very comfortable with the usage of a sfParameterHolder ob

[symfony-devs] Re: About the Controller refactoring

2007-07-18 Thread Matthias N.
On 18 Jul., 15:12, Fabien POTENCIER <[EMAIL PROTECTED] project.com> wrote: > Matthias, > > Some random thoughts and questions about your recent changes to the > Controller (http://trac.symfony-project.com/trac/changeset/4650): Hm.. it seems that Google has some problems.. I already posted an answ

[symfony-devs] Re: About the Controller refactoring

2007-07-18 Thread Matthias N.
On 18 Jul., 15:12, Fabien POTENCIER <[EMAIL PROTECTED] project.com> wrote: > By the way, try to keep your commits atomics as it makes reviewing the > code easier. I have problems with merging changes from trunk to my branch. I'm working on a KDE desktop using kdesvn. Trying to get it work using