On 18 Jul., 15:12, Fabien POTENCIER <[EMAIL PROTECTED] project.com> wrote: > Matthias, > > Some random thoughts and questions about your recent changes to the > Controller (http://trac.symfony-project.com/trac/changeset/4650): > > - I'm not very comfortable with the usage of a sfParameterHolder object > for the action stack. I think you can migrate all this code into a > sfActionStack object (or whatever you want to call it). It will cleanup > the Controller and separate the controller logic and the stack logic.
Yes, I also don't like this but I wanted to commit the stuff yesterday to get some feedback. I like the idea of moving the methods into get() and set() methods to make it more flexible for the page controller I'll contribute soon. I'm still wondering how I can remove the stack. But on the other hand it makes sense to control forwards. > - If I understand correctly, you moved the dispatch() method from the > sfFrontWebController to the sfWebController. Why? The dispatch notion > belongs to the front controller design pattern. The reason is I want to add sfPageWebController (either in a separate plugin or directly to symfony) extending sfWebController. This way I can reuse the dispatch() implementation and only have to change execute(). I thought it is useful for this approach. > - The new "scope" filters.yml parameter is yet to be used? No. Currently my idea is to drop the idea of separate request & action filters and implement a sfPageExecutionFilter that is able to execute an arbitrary number of actions without going through the execution chain again. This should solve the main "page controller problem". > - Why do you use a $throwExceptions argument in the makeAction() method? > Why don't you throw exceptions and catch them when needed in the > sfExcutionFilter. The interface will be much cleaner, a makeAction() > method always returns an action instance. Alright.. I will change that. I also wonder if this new forward() is ok/enough. The idea is to move the actual forwarding to the execution filter to make it possible to change the module/action by a filter. > By the way, try to keep your commits atomics as it makes reviewing the > code easier. I'll try my best. Thanks for your feedback. Regards, Matthias --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
