On 18 Jul., 15:12, Fabien POTENCIER <[EMAIL PROTECTED] project.com> wrote: > Matthias, > > Some random thoughts and questions about your recent changes to the > Controller (http://trac.symfony-project.com/trac/changeset/4650):
Hm.. it seems that Google has some problems.. I already posted an answer.. Ok, one more try. > - I'm not very comfortable with the usage of a sfParameterHolder object > for the action stack. I think you can migrate all this code into a > sfActionStack object (or whatever you want to call it). It will cleanup > the Controller and separate the controller logic and the stack logic. Me too.. this push/pop implementation is not that nice.. I think we should keep a stack but I would like to move it to the controller. Maybe as sfControllerStack? But I have to think about that some more time and come back with a better solution. :-) > - If I understand correctly, you moved the dispatch() method from the > sfFrontWebController to the sfWebController. Why? The dispatch notion > belongs to the front controller design pattern. The idea is to avoid code repetition. The reason is that I would like to reuse the dispatch() implementation with sfPageWebController. By this approach I just have to change the execute() implementation. > - The new "scope" filters.yml parameter is yet to be used? No.. Actually I think that we do not really need this separation of request and action filters. Currently I'm about to write a sfPageExecutionFilter for executing an arbitrary number of actions without going through the filter chain again. And I need the stack to be able to store what to execute there. > - Why do you use a $throwExceptions argument in the makeAction() method? > Why don't you throw exceptions and catch them when needed in the > sfExcutionFilter. The interface will be much cleaner, a makeAction() > method always returns an action instance. Hm.. alright, I will change it. > By the way, try to keep your commits atomics as it makes reviewing the > code easier. I will do so. Sorry, I'm still learning. :-) Regards, Matthias --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
