[sympy] Re: turning complex exponential into trigonometric functions

2010-04-15 Thread Colin
OK, I have a version that this works for now. Something I noticed is that there could be simplifications applied inside some of the cos and sin functions - because of the factor of I. How do you simplify inside a cos or sin? Alternatively, how do I get the expression with common factors of I in the

[sympy] Re: turning complex exponential into trigonometric functions

2010-04-15 Thread Colin
On 15 Apr, 16:27, Colin wrote: > OK, I have a version that this works for now. Something I noticed is > that there could be simplifications applied inside some of the cos and > sin functions - because of the factor of I. How do you simplify inside > a cos or sin? Alternatively, how do I get the ex

[sympy] Prime Field Implementation

2010-04-15 Thread Kasun Samarasinghe
Hi, I tried to implement Prime Fields which is the first part of my GSOC project. I attached the patch with this. Please review it and comment. Thnak you, kasun -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sy.

[sympy] failing doctest in current master

2010-04-15 Thread Toon Verstraelen
Hi, I get this failing doctest: ** File "/mnt/data/toon/unief/research/code/work/sympy/doc/src/modules/polynomials.txt", line 216, in polynomials.txt Failed example: solve_poly_system([y**2 - x**3 + 1, y*x], x, y) Expecte

Re: [sympy] failing doctest in current master

2010-04-15 Thread Aaron S. Meurer
This is known. Please see http://groups.google.com/group/sympy-patches/browse_thread/thread/f62c954c3fc948d8 There is a simple patch to fix it there (it's trivial), and Mateusz's latest polysn branch fixes it too I think. Aaron Meurer On Apr 15, 2010, at 1:42 PM, Toon Verstraelen wrote: > Hi,

Re: [sympy] Prime Field Implementation

2010-04-15 Thread Aaron S. Meurer
Hi. Some things: - Use lower case for file names. - I get some test failures: File "/users/aaronmeurer/documents/python/sympy/sympy/sympy/abstractalgebra/test/test_primefield.py", line 1, in from sympy.abstractalgebra.FiniteField import PrimeField ImportError: No module named abstractal

Re: [sympy] Prime Field Implementation

2010-04-15 Thread Kasun Samarasinghe
hi, this is just the prime field implementation, which just provides the prime field arithmetic and operations. There is no relationship to polynomials unless we define galois polynomials using this prime field. In my proposal I suggested a separate finite field implementation and this is the firs

Re: [sympy] failing doctest in current master

2010-04-15 Thread Ondrej Certik
On Thu, Apr 15, 2010 at 12:45 PM, Aaron S. Meurer wrote: > This is known.  Please see > http://groups.google.com/group/sympy-patches/browse_thread/thread/f62c954c3fc948d8 > > There is a simple patch to fix it there (it's trivial), and Mateusz's latest > polysn branch fixes it too I think. I just

Re: [sympy] Prime Field Implementation

2010-04-15 Thread Kasun Samarasinghe
I changed according to the comments. Please have a look, kasun On Thu, Apr 15, 2010 at 9:55 PM, Kasun Samarasinghe < kwsamarasin...@gmail.com> wrote: > hi, > > this is just the prime field implementation, which just provides the prime > field arithmetic and operations. There is no relationship t

Re: [sympy] Prime Field Implementation

2010-04-15 Thread David Joyner
Does it need __repr__ and __str__ methods? On Thu, Apr 15, 2010 at 4:39 PM, Kasun Samarasinghe wrote: > I changed according to the comments. Please have a look, > kasun > > On Thu, Apr 15, 2010 at 9:55 PM, Kasun Samarasinghe > wrote: >> >> hi, >> this is just the prime field implementation, whi

Re: [sympy] Prime Field Implementation

2010-04-15 Thread Aaron S. Meurer
OK. - You need to fix the commit message. It now reads "changed patch" instead of "Adding Implementation of Finite Fields (Prime Fields)". It also wouldn't hurt to add more information to it. - You misunderstood what I meant for docstrings. You want """ Summary of function (one line). More i

Re: [sympy] Prime Field Implementation

2010-04-15 Thread Kasun Samarasinghe
hi aaron yes this is only the first part as a starting point. GF(p**n) will be implemented later. On sub classing, I think this is a standalone module, since its a different algebraic structure. David might have a better idea on this? in init.py, do I need to have anything there for the time bein

Re: [sympy] Prime Field Implementation

2010-04-15 Thread Kasun Samarasinghe
i m having a problem with tests. When I run the test I get the intended results from another python file. but when i run bin/test it fails? what can be the possible reason. Also I get the error import failed even though i have the sympy.abstractalgebra.finitefield module? thanks kasun On Thu, Apr

Re: [sympy] Prime Field Implementation

2010-04-15 Thread Aaron S. Meurer
I am pretty sure that it is because you need to add your things to an abstractalgebra/__init__.py file. Aaron Meurer On Apr 15, 2010, at 4:10 PM, Kasun Samarasinghe wrote: > i m having a problem with tests. When I run the test I get the intended > results from another python file. but when i

Re: [sympy] Prime Field Implementation

2010-04-15 Thread Kasun Samarasinghe
I added from finitefield import PrimeField to __init.py__ file at sympy/abstractalgebra/ but i still get the test failed? On Fri, Apr 16, 2010 at 12:13 AM, Aaron S. Meurer wrote: > I am pretty sure that it is because you need to add your things to an > abstractalgebra/__init__.py file. > > Aaro

Re: [sympy] Prime Field Implementation

2010-04-15 Thread David Joyner
On Thu, Apr 15, 2010 at 5:29 PM, Kasun Samarasinghe wrote: > hi aaron > yes this is only the first part as a starting point. GF(p**n) will be > implemented later. > On sub classing, I think this is a standalone module, since its a different > algebraic structure. David might have a better idea on

Re: [sympy] Prime Field Implementation

2010-04-15 Thread Ronan Lamy
Le jeudi 15 avril 2010 à 13:46 -0600, Aaron S. Meurer a écrit : > - I think PrimeField should subclass from Expr or Basic (though I could be > wrong on this one). > No, it should not. Instances of PrimeField are equivalent to classes like Integer or Rational. I think sympy is not quite ready for

Re: [sympy] Prime Field Implementation

2010-04-15 Thread Kasun Samarasinghe
hi aaron, I managed to make it passed test, please give me the comment. attached the patch with this thank you kasun On Fri, Apr 16, 2010 at 12:31 AM, Ronan Lamy wrote: > Le jeudi 15 avril 2010 à 13:46 -0600, Aaron S. Meurer a écrit : > > - I think PrimeField should subclass from Expr or Basic

[sympy] Action Verbs Patch

2010-04-15 Thread Addison Cugini
Per the issue here: http://groups.google.com/group/sympy/browse_thread/thread/59e5dfb987963204/eca6fd634?pli=1 I have created methods which allows 'action verbs' to be called both as global functions and as methods. Any suggestions you have would be appreciated! --Addison Cugini -- You receive

Re: [sympy] Action Verbs Patch

2010-04-15 Thread Brian Granger
Addison, Thanks for tackling this one. I will have a look. Cheers, Brian On Thu, Apr 15, 2010 at 7:35 PM, Addison Cugini wrote: > Per the issue here: > > http://groups.google.com/group/sympy/browse_thread/thread/59e5dfb987963204/eca6fd634?pli=1 > > I have created methods which allows 'action