Re: [sympy] Review help request: commutative algebra

2012-04-08 Thread Joachim Durchholz
Am 05.04.2012 20:46, schrieb Tom Bachmann: A start: https://github.com/sympy/sympy/wiki/Commutative-Algebra-Module What's the alternative to a constructed algebra? Would having that, while outside of the scope of your work, be relevant to / useful in SymPy? The motive behind that question is

Re: [sympy] Review help request: commutative algebra

2012-04-08 Thread Tom Bachmann
On 08.04.2012 10:26, Joachim Durchholz wrote: Am 05.04.2012 20:46, schrieb Tom Bachmann: A start: https://github.com/sympy/sympy/wiki/Commutative-Algebra-Module What's the alternative to a constructed algebra? Would having that, while outside of the scope of your work, be relevant to / useful

Re: [sympy] Review help request: commutative algebra

2012-04-08 Thread Joachim Durchholz
I see you have considered future extensibility to the best of available knowledge, which is more than my available knowledge, so that's going to be good as it gets. Plus, if it should turn out there are better ways to structure the code, we can always reorganize. Trying to guess a better

Re: [sympy] Review help request: commutative algebra

2012-04-06 Thread Alexey U. Gudchenko
Thank you! -- Alexey Gudchenko On 05.04.2012 22:46, Tom Bachmann wrote: A start: https://github.com/sympy/sympy/wiki/Commutative-Algebra-Module -- You received this message because you are subscribed to the Google Groups sympy group. To post to this group, send email to

[sympy] Review help request: commutative algebra

2012-04-05 Thread Tom Bachmann
Dear all, I'm currently on holidays and have started or writing a commutative algebra / algebraic geometry module, something I have been wanting to do for quite a long time. This will be quite a body of code, and I'm afraid I don't know the proper etiquette in getting so much code into sympy,

Re: [sympy] Review help request: commutative algebra

2012-04-05 Thread Aaron Meurer
This is great. I'll try to help review the non-trivial stuff, as much as I can. How long are you on holiday? Aaron Meurer On Thu, Apr 5, 2012 at 10:02 AM, Tom Bachmann e_mc...@web.de wrote: Dear all, I'm currently on holidays and have started or writing a commutative algebra / algebraic

Re: [sympy] Review help request: commutative algebra

2012-04-05 Thread Tom Bachmann
On 05.04.2012 17:25, Aaron Meurer wrote: This is great. I'll try to help review the non-trivial stuff, as much as I can. How long are you on holiday? Thank you. My term begins April 24. But then I really my only duty is to prepare for exams for another five weeks or so, during which I can

Re: [sympy] Review help request: commutative algebra

2012-04-05 Thread Alexey U. Gudchenko
Greetings, Tom. Can you write down (shortly, may be in wiki) an introduction of some vision for those modules set: that is, main use-cases for the users and use-cases for the developers (they be able do that and that and that). May be some examples exist now in the docstring examples, but the

Re: [sympy] Review help request: commutative algebra

2012-04-05 Thread Tom Bachmann
Will do. On 05.04.2012 19:14, Alexey U. Gudchenko wrote: Greetings, Tom. Can you write down (shortly, may be in wiki) an introduction of some vision for those modules set: that is, main use-cases for the users and use-cases for the developers (they be able do that and that and that). May be

Re: [sympy] Review help request: commutative algebra

2012-04-05 Thread Tom Bachmann
A start: https://github.com/sympy/sympy/wiki/Commutative-Algebra-Module On 05.04.2012 19:14, Alexey U. Gudchenko wrote: Greetings, Tom. Can you write down (shortly, may be in wiki) an introduction of some vision for those modules set: that is, main use-cases for the users and use-cases for the

Re: [sympy] review help request

2012-03-02 Thread Aaron Meurer
On Wed, Jan 25, 2012 at 6:24 AM, Chris Smith smi...@gmail.com wrote: On Tue, Jan 24, 2012 at 12:15 AM, Aaron Meurer asmeu...@gmail.com wrote: Are you on Windows? I just merged a branch that should hopefully make sympy-bot work on Windows.  Please do a git pull in the sympy bot directory and

Re: [sympy] review help request

2012-03-02 Thread Chris Smith
It might be nice to add a not to the sympy-bot readme.rst: `` Getting Started === In a directory other than the sympy directory (e.g. in the same directory that sympy is contained in) do git clone g...@github.com:sympy/sympy-bot.git cd sympy-bot ``` I tried the following and got an

Re: [sympy] review help request

2012-02-22 Thread Joachim Durchholz
Am 22.02.2012 04:25, schrieb smichr: You could help me and that list of people if you would check the pull request page ( https://github.com/sympy/sympy/pulls ) occasionally to see if there are any pull requests that you could review and move along in becoming part of SymPy. I've been meaning

Re: [sympy] review help request

2012-02-22 Thread Aaron Meurer
On Wed, Feb 22, 2012 at 1:59 AM, Joachim Durchholz j...@durchholz.org wrote: Am 22.02.2012 04:25, schrieb smichr: You could help me and that list of people if you would check the pull request page ( https://github.com/sympy/sympy/pulls ) occasionally to see if there are any pull requests that

[sympy] review help request

2012-02-21 Thread smichr
When I submit a pull request, I believe it only goes to a small list of people invovled with SymPy. You could help me and that list of people if you would check the pull request page ( https://github.com/sympy/sympy/pulls ) occasionally to see if there are any pull requests that you could review

Re: [sympy] review help request

2012-01-25 Thread Chris Smith
On Tue, Jan 24, 2012 at 12:15 AM, Aaron Meurer asmeu...@gmail.com wrote: Are you on Windows? I just merged a branch that should hopefully make sympy-bot work on Windows.  Please do a git pull in the sympy bot directory and try again. If it still doesn't work, please let us know specifically

Re: [sympy] review help request

2012-01-23 Thread Aaron Meurer
Are you on Windows? I just merged a branch that should hopefully make sympy-bot work on Windows. Please do a git pull in the sympy bot directory and try again. If it still doesn't work, please let us know specifically what your problem is so we can fix it. Aaron Meurer On Wed, Jan 11, 2012 at

Re: [sympy] review help request

2011-12-05 Thread Ondřej Čertík
Hi Chris, On Mon, Dec 5, 2011 at 4:42 AM, smichr smi...@gmail.com wrote: If a GCI review is too time consuming, perhaps you would consider one of the following pretty targeted reviews. I'll start closing some of the other larger requests, but these fix deficiencies and really should be

Re: [sympy] review help request

2011-12-05 Thread Chris Smith
813 (left a comment there) You concern has been addressed. 787 (needs rebase, but otherwise ok) Ronan's concern has been addressed. 720 (running tests on it currently) All tests passed...I'll commit in a few hours if there is no objection unless you do first. Thanks very much for helping