Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Updates: Status: Fixed Mergedinto: Comment #29 on issue 1263 by smi...@gmail.com: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 I removed the duplicate status since this has been fixed. sqrt(1/z) sqrt(1/z) z = Symbol('z', r

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Updates: Status: Duplicate Mergedinto: 1725 Comment #28 on issue 1263 by Vinzent.Steinberg: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 (No comment was entered for this change.) -- You received this message because you are s

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #27 on issue 1263 by smichr: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 I can see now that as_base_exp was only dealing with the case where the argument was a Rational (not a rational) so I really didn't fix anything there. I wi

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Updates: Labels: -NeedsBetterPatch NeedsReview Comment #26 on issue 1263 by smichr: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 The test has been changed to simplify(sqrt(1/n)) != 1/sqrt(n). -- You received this message because you

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Updates: Labels: -NeedsReview NeedsBetterPatch Comment #25 on issue 1263 by Vinzent.Steinberg: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 Looks good to me. However, the test you add seems not to fail in master. -- You received this

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Updates: Cc: asmeurer Vinzent.Steinberg Ronan.Lamy ondrej.certik Labels: -WrongResult NeedsReview Comment #24 on issue 1263 by smichr: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 commit 1263 in smichr's 1766 branch at github

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #23 on issue 1263 by smichr: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 The problem in 1766 existed in the coeff_resid routine. 1766 should now be clean and will be pushed as soon as tests are done running. -- You received this

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #22 on issue 1263 by smichr: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 ...but this isn't ok (in master and 1766): from sympy import * n=symbols('n',negative=1) sqrt(-n) (-n)**(1/2) simplify(_) I*n**(1/2) -- You received this

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #21 on issue 1263 by smichr: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 make that one problem--only the one in as_base_exp()! The Mul behavior is fine. sqrt(z)/z is 1/sqrt(z): sqrt(-1)/-1 = 1/sqsrt(-1) i/-1 = 1/i -i = i/-1 -i =

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #20 on issue 1263 by smichr: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 re 18: I must have put the test in from XFAIL wrong. Thanks for catching that. This issue is so ironic. I was just looking at Mul the other day trying to

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #19 on issue 1263 by asmeurer: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 Yes, z = symbols('z', complex=True, negative=False) is definitely wrong. I think it is a separate issue, though. And most likely, the actual issue is in

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #18 on issue 1263 by robert.kern: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 Using smichr/1766, I still get the wrong behavior: In [4]: z = Symbol('z', real=True, negative=True) In [5]: simplify(sqrt(1/z) + 1/sqrt(z)) Out[5]: 2/z

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #17 on issue 1263 by smichr: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 I don't think the problem is in cancel since all the above work in 1766 and I didn't fix anything in polys8. I did a lot of work in expand, extract_multipli

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #16 on issue 1263 by mattpap: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 Also, it looks like the problem is in cancel: In [1]: z = Symbol('z', real=True, negative=True) In [2]: sqrt(1/z) Out[2]: ___ / 1 / - \/ z In

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Updates: Status: Accepted Cc: smichr Labels: -NeedsReview Comment #15 on issue 1263 by asmeurer: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 I bisected, and this is the bad commit (between 0.6.5 and 0.6.6): 3a1aa58ed

Re: Issue 1263 in sympy: Invalid movement of roots across fractions

Updates: Status: New Labels: -Milestone-Release0.6.5 Milestone-Release0.7.0 Comment #14 on issue 1263 by robert.kern: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 The bug seems to be back: In [2]: z = Symbol('z', real=True,

Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #13 on issue 1263 by ondrej.certik: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 Oops, this is in already. Sorry for the noise. -- You received this message because you are listed in the owner or CC fields of this issue, or because yo

Issue 1263 in sympy: Invalid movement of roots across fractions

Updates: Labels: -Priority-Medium -Milestone-Release0.6.4 Priority-High Milestone-Release0.6.5 Comment #12 on issue 1263 by ondrej.certik: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 I'll look into it before a release. -- You recei

Issue 1263 in sympy: Invalid movement of roots across fractions

Updates: Status: Fixed Comment #11 on issue 1263 by ondrej.certik: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 This is in. Sorry for the delay. -- You received this message because you are listed in the owner or CC fields of this iss

Issue 1263 in sympy: Invalid movement of roots across fractions

Updates: Labels: -Milestone-Release0.6.5 Milestone-Release0.6.4 NeedsReview Comment #10 on issue 1263 by ondrej.certik: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 Ah ok, I thought you said it doesn't work. I'll look at it tonight and

Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #9 on issue 1263 by robert.kern: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 See comment #3. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adju

Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #8 on issue 1263 by robert.kern: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 I think it does work. Why do you think it doesn't? -- You received this message because you are listed in the owner or CC fields of this issue, or because y

Issue 1263 in sympy: Invalid movement of roots across fractions

Updates: Labels: -NeedsReview Comment #7 on issue 1263 by ondrej.certik: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 This patch needs investigating why it doesn't work. When it's done, it could be merged. -- You received this messa

Issue 1263 in sympy: Invalid movement of roots across fractions

Updates: Labels: Milestone-Release0.6.5 Comment #6 on issue 1263 by ondrej.certik: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 (No comment was entered for this change.) -- You received this message because you are listed in the owner

Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #5 on issue 1263 by robert.kern: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 See issue #1264 for the problem. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this is

Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #4 on issue 1263 by ondrej.certik: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 Let us know where the problem was, I am really interested in this. Also if we should regularly test on Mac as well, in addition to what we test now. --

Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #3 on issue 1263 by robert.kern: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 I think I've isolated the problem elsewhere. Removing that other problem makes this patch work. -- You received this message because you are listed in the

Issue 1263 in sympy: Invalid movement of roots across fractions

Comment #2 on issue 1263 by ondrej.certik: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 The patch is +1. All tests pass on my laptop, both using py.test or bin/test. Are you using Mac OS X? Do all tests pass without your patch and fail with

Issue 1263 in sympy: Invalid movement of roots across fractions

Updates: Labels: NeedsReview Comment #1 on issue 1263 by robert.kern: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 The problem is in Pow.as_numer_denom(). It does not take the negative denominator special case into account when it op

Issue 1263 in sympy: Invalid movement of roots across fractions

Status: Accepted Owner: robert.kern Labels: Type-Defect Priority-Medium WrongResult New issue 1263 by robert.kern: Invalid movement of roots across fractions http://code.google.com/p/sympy/issues/detail?id=1263 These came up while implementing the Wester tests. Basically, sqrt(1/z) is being trea