Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Issue 1725: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 This issue is now blocking issue sympy:1844. See http://code.google.com/p/sympy/issues/detail?id=1844 -- You received this message because you are listed in the owner or CC

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Issue 1725: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 This issue is now blocking issue sympy:1844. See http://code.google.com/p/sympy/issues/detail?id=1844 -- You received this message because you are listed in the owner or CC

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Updates: Labels: -NeedsReview -smichr Comment #32 on issue 1725 by smi...@gmail.com: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 (No comment was entered for this change.) -- You received this message because you are

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #29 on issue 1725 by smichr: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 I tried to rebase this and too much has changed to cherry pick this. There *is* a separate branch, but it hasn't been rebased on current

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Updates: Cc: smichr Comment #27 on issue 1725 by Vinzent.Steinberg: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 Issue 1263 has been merged into this issue. -- You received this message because you are subscribed to

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Issue 1725: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 This issue is now blocking issue 1936. See http://code.google.com/p/sympy/issues/detail?id=1936 -- You received this message because you are listed in the owner or CC

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #25 on issue 1725 by smichr: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 This has been difficult to separate from my other work, but it is done...please see commits 1725a-c at smichr's 1766 branch at github:

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #26 on issue 1725 by smichr: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 Note: I believe there are test failures in a or b, but c runs error-free here and I intend to squash all three together. -- You received

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Updates: Cc: Ronan.Lamy ondrej.certik Labels: -NeedsBetterPatch NeedsReview Comment #23 on issue 1725 by smichr: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 Before I start separating this from the general 1766

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #24 on issue 1725 by ronan.l...@gmail.com: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 Profiles look good. I attach the results of python -m cProfile --sort=cumulative bin/test sympy/series for master

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #21 on issue 1725 by smichr: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 commit 1725e in branch 1766 addresses comment 9: any flag that is turned on shuts all others off so you get a wysiwyg behavior whenever there

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #22 on issue 1725 by smichr: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 this is blocked by commit 1766b. -- You received this message because you are listed in the owner or CC fields of this issue, or because you

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Issue 1725: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 This issue is now blocking issue 1831. See http://code.google.com/p/sympy/issues/detail?id=1831 -- You received this message because you are listed in the owner or CC

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #20 on issue 1725 by smichr: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 The condition expr == 'hints' needs to be quialified as if type(expr) is str and expr == 'hints' because if some _eq_ test starts with testing

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #19 on issue 1725 by Vinzent.Steinberg: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 I've profiled the latest version of branch 1766[...] So he did test the whole branch. -- You received this message because you

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #15 on issue 1725 by ronan.l...@gmail.com: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 I've profiled the latest version of branch 1766 and there's a severe performance regression: expand() seems to be about twice

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #16 on issue 1725 by smichr: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 reply is in Issue 1766. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #17 on issue 1725 by smichr: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 This could be because separate() is now calling expand()'s power with the power_* expansions rather than running its own code (which largely

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #18 on issue 1725 by ronan.l...@gmail.com: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 I tested both, the results are similar (in 15, it's the results for the whole branch). The changes to separate() make little

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Updates: Labels: -NeedsReview NeedsBetterPatch Comment #14 on issue 1725 by asmeurer: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 I have several comments for this commit, so I posted them as comments on your github

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Updates: Labels: NeedsReview Comment #13 on issue 1725 by smichr: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 With the new hint manager, this will be easy to change. Should we do this in two steps? First the manager

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Updates: Cc: asmeurer Vinzent.Steinberg Comment #8 on issue 1725 by smichr: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 In Issue 1724 there has been some discussion about implementing this. I can give this a go this

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #9 on issue 1725 by Vinzent.Steinberg: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 I think this is too complex and too much magic. I'd just set a reasonable default, if there is any '...=True' kwarg, I'd disable all

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #7 on issue 1725 by Vinzent.Steinberg: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 I think we could add private low-level functions (like e.g. _expand_complex()), but they should not be exposed to the standard user

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #1 on issue 1725 by Vinzent.Steinberg: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 + pi/pi I prefer this much over expand_log() and friends. -- You received this message because you are listed in the owner or CC

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #2 on issue 1725 by ronan.l...@gmail.com: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 -1 for removing expand_* functions I see your point but .expand() adds a lot of overhead, and therefore should be called less

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #3 on issue 1725 by asmeurer: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 There is also the expand() function (not the method). I am not seeing how the overhead is different. expand_* are just wrappers around the

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #5 on issue 1725 by ronan.l...@gmail.com: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 Here's an excerpt of the result of python -m cProfile --sort=cumulative bin/test sympy/series: 19577742 function calls (17918448

Re: Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Comment #6 on issue 1725 by asmeurer: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 If the switch manager is used as it should, it would greatly reduce recursive calls. I am willing to bet that most of these calls to expand

Issue 1725 in sympy: Implement switch manager for expand() and possibly others

Status: Accepted Owner: smichr Labels: Type-Defect Priority-Medium New issue 1725 by asmeurer: Implement switch manager for expand() and possibly others http://code.google.com/p/sympy/issues/detail?id=1725 See this thread: