Comment #41 on issue 1923 by nicolas@gmail.com: count_ops doesn't
return a count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
Chris, trying to implement issue 2011, I found the following bug today:
In [6]: from sympy.physics.secondquant import BKet
In [7]:
Comment #42 on issue 1923 by nicolas@gmail.com: count_ops doesn't
return a count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
I opened new issue for this (issue 2237).
--
You received this message because you are subscribed to the Google Groups
sympy-issues group.
Updates:
Status: Fixed
Comment #40 on issue 1923 by smi...@gmail.com: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
This is in.
--
You received this message because you are subscribed to the Google Groups
sympy-issues group.
To
Updates:
Cc: nicolas.pourcelot
Comment #39 on issue 1923 by smi...@gmail.com: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
The quick option is not longer a flag. It is simply invoked by default with
visual=None; if visual=True,
Updates:
Labels: -PassedReview NeedsBetterPatch
Comment #37 on issue 1923 by smi...@gmail.com: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
(No comment was entered for this change.)
--
You received this message because you are
Comment #36 on issue 1923 by smi...@gmail.com: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
If this could get a final review of the last commit this is ready to go.
The 3 commits in the pull request could be squashed if you want:
[
Comment #32 on issue 1923 by candleband: count_ops doesn't return a count
(by default)
http://code.google.com/p/sympy/issues/detail?id=1923
Nocolas, can you figure out how to modify 1923 so that And(x, y) gives back
a count of 1 (like it did in master) instead of 2. In master (AFAICT) it
Comment #33 on issue 1923 by nicolas.pourcelot: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
Sorry, I don't understand what you mean. Add(x, y).count_ops() still
returns 1:
$ git checkout smichr/1923
$ ./bin/isympy
In [1]:
Updates:
Cc: Ronan.Lamy
Comment #34 on issue 1923 by smichr: count_ops doesn't return a count (by
default)
http://code.google.com/p/sympy/issues/detail?id=1923
I am really having a bad day with sessions...yes, I (now) get the same
result.
Should count_ops() have these lines:
Comment #35 on issue 1923 by nicolas.pourcelot: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
Well, I personally don't mind.
Concerning style, however, I would write it as following :
elif isinstance(expr, Expr):
return
Issue 1923: count_ops doesn't return a count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
This issue is now blocking issue 2011.
See http://code.google.com/p/sympy/issues/detail?id=2011
--
You received this message because you are listed in the owner
or CC fields of this
Updates:
Labels: -NeedsReview NeedsBetterPatch
Comment #27 on issue 1923 by nicolas.pourcelot: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
There are some issues concerning docstrings.
I've made corresponding comments directly in
Comment #28 on issue 1923 by nicolas.pourcelot: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
However, I don't understand why ./setup.py test does not report failing
docstrings in this case ?!
--
You received this message because you
Comment #29 on issue 1923 by asmeurer: count_ops doesn't return a count (by
default)
http://code.google.com/p/sympy/issues/detail?id=1923
Does it work with just ./bin/doctest? Perhaps there is a bug in the
doctest runner (there already is a problem with things not being doctested
when
Comment #30 on issue 1923 by nicolas.pourcelot: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
Using ./bin/doctest doesn't change anything.
However, I discovered this is linked to extra-indentation in count_ops()
docstring:
def
Issue 1923: count_ops doesn't return a count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
This issue is now blocking issue 1694.
See http://code.google.com/p/sympy/issues/detail?id=1694
--
You received this message because you are listed in the owner
or CC fields of this
Comment #25 on issue 1923 by smichr: count_ops doesn't return a count (by
default)
http://code.google.com/p/sympy/issues/detail?id=1923
A pull request for the 1923 (not 1694) portion of this issue has been made.
--
You received this message because you are subscribed to the Google Groups
Comment #26 on issue 1923 by asmeurer: count_ops doesn't return a count (by
default)
http://code.google.com/p/sympy/issues/detail?id=1923
It's https://github.com/sympy/sympy/pull/23, by the way.
--
You received this message because you are subscribed to the Google Groups
sympy-issues
Comment #19 on issue 1923 by nicolas.pourcelot: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
As for submitting this as my own branch, I'm not so easy with git, but I
may merge this with 1694 and propose a global patch.
Maybe I'll also
Comment #20 on issue 1923 by nicolas.pourcelot: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
I proposed a global patch in my last comment for issue 1694.
Have you some time to review it ?
--
You received this message because you are
Comment #21 on issue 1923 by smichr: count_ops doesn't return a count (by
default)
http://code.google.com/p/sympy/issues/detail?id=1923
I'd be happy to put the pieces together under branch 1694. Having looked
back at comment 11 (after seeing your other work) I now understand what you
Comment #22 on issue 1923 by smichr: count_ops doesn't return a count (by
default)
http://code.google.com/p/sympy/issues/detail?id=1923
I can review it.
--
You received this message because you are subscribed to the Google Groups
sympy-issues group.
To post to this group, send email to
Comment #23 on issue 1923 by nicolas.pourcelot: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
Thanks a lot Chris.
--
You received this message because you are subscribed to the Google Groups
sympy-issues group.
To post to this group,
Comment #16 on issue 1923 by smichr: count_ops doesn't return a count (by
default)
http://code.google.com/p/sympy/issues/detail?id=1923
Nicolas, thanks for the comments. How do the changes in 1923, last two
commits look now? In the 2nd to last commit I make the modifications to
Comment #17 on issue 1923 by nicolas.pourcelot: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
Hi Chris, two further comments:
1. In fact, I would put all Mul, Pow and Add code inside a
custom .count_ops() method, without adding a new
Comment #18 on issue 1923 by smichr: count_ops doesn't return a count (by
default)
http://code.google.com/p/sympy/issues/detail?id=1923
Very nice, Nicolas. I added the patch and repushed. As there is only a
kernel of my own work left, why don't you just take the branch and merge it
with
Comment #14 on issue 1923 by nicolas.pourcelot: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
Sorry, I forgot to do git fetch.
Ok, I can see your last version now.
Here's my first comments:
1. Some minor comment first:
In
Comment #15 on issue 1923 by nicolas.pourcelot: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
I just realize that previous code will return 0 (and not S.Zero) if expr is
an empty list/set/tuple or dict, even if visual=True.
If this
Comment #12 on issue 1923 by nicolas.pourcelot: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
(visual=True is missing in last comment suggestion)
--
You received this message because you are subscribed to the Google Groups
sympy-issues
Comment #7 on issue 1923 by mattpap: count_ops doesn't return a count (by
default)
http://code.google.com/p/sympy/issues/detail?id=1923
The issue is, should count_ops return a sympy Integer or python
integer? There
is precedence for leaving some integers alone (like in polys exponents).
Comment #8 on issue 1923 by smichr: count_ops doesn't return a count (by
default)
http://code.google.com/p/sympy/issues/detail?id=1923
I streamlined everything. There's one wrapper and one function. As per
Mateusz's comment, I have now made it return ints. This should make it a
very
Comment #9 on issue 1923 by smichr: count_ops doesn't return a count (by
default)
http://code.google.com/p/sympy/issues/detail?id=1923
The updated version (which requires a utility function) has been pushed to
1923. I put the utility function as a separate commit.
--
You received this
Updates:
Labels: -NeedsBetterPatch
Comment #6 on issue 1923 by smichr: count_ops doesn't return a count (by
default)
http://code.google.com/p/sympy/issues/detail?id=1923
This is in final review, branch 1923 if you have any final comments.
--
You received this message because you are
Issue 1923: count_ops doesn't return a count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
This issue is now blocking issue 1694.
See http://code.google.com/p/sympy/issues/detail?id=1694
--
You received this message because you are listed in the owner
or CC fields of this
Comment #3 on issue 1923 by Vinzent.Steinberg: count_ops doesn't return a
count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
I don't like the TODO in the docstring, but the rest looks fine.
--
You received this message because you are subscribed to the Google Groups
Updates:
Cc: -asmeurer
Comment #2 on issue 1923 by smichr: count_ops doesn't return a count (by
default)
http://code.google.com/p/sympy/issues/detail?id=1923
rebased on master and ready for review at smichr's branch 1923 at github.
--
You received this message because you are
Status: Accepted
Owner: smichr
CC: Vinzent.Steinberg, asmeurer, ondrej.certik
Labels: Type-Defect Priority-Medium NeedsReview
New issue 1923 by smichr: count_ops doesn't return a count (by default)
http://code.google.com/p/sympy/issues/detail?id=1923
This function has good utility for
Comment #1 on issue 1923 by smichr: count_ops doesn't return a count (by
default)
http://code.google.com/p/sympy/issues/detail?id=1923
(commit number 1923 in smichr's 1766 branch at github.)
--
You received this message because you are listed in the owner
or CC fields of this issue, or
38 matches
Mail list logo
