Status: Accepted
Owner: smichr
Labels: Type-Defect Priority-Medium
New issue 2127 by smichr: don't allow 0 or 1-arg AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
It is possible to create a 0 or 1-arg Add and Mul using the evaluate flag
of False. This seems like a bad idea. If th
Issue 2127: don't allow 0 or 1-arg AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
This issue is now blocking issue 1917.
See http://code.google.com/p/sympy/issues/detail?id=1917
--
You received this message because you are listed in the owner
or CC fields of this issue, or because
Updates:
Labels: NeedsReview
Comment #1 on issue 2127 by smichr: don't allow 0 or 1-arg AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
This is part of the branch under review, a commit with the number 2127:
https://github.com/sympy/sympy/pull/50
--
You received this messa
Updates:
Labels: -NeedsReview NeedsBetterPatch smichr
Comment #2 on issue 2127 by asmeurer: don't allow 0 or 1-arg AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
The change is good, but this needs a test.
--
You received this message because you are subscribed to the Googl
Issue 2127: don't allow 0 or 1-arg AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
This issue is now blocking issue 1694.
See http://code.google.com/p/sympy/issues/detail?id=1694
--
You received this message because you are listed in the owner
or CC fields of this issue, or because
Updates:
Labels: -NeedsBetterPatch NeedsReview
Comment #3 on issue 2127 by smi...@gmail.com: don't allow 0 or 1-arg AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
I added a few tests for this. If you can take a look, Aaron, it will take
just a moment to look at the tests
Updates:
Status: Fixed
Labels: -NeedsReview PassedReview
Comment #4 on issue 2127 by asmeurer: don't allow 0 or 1-arg AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
I cherry-picked the commit into master, and all the tests passed, so I
pushed it in.
--
You recei
Comment #5 on issue 2127 by smi...@gmail.com: don't allow 0 or 1-arg AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
OK, I'll check that the issue is closed later today.
Though I closed the request and merged them elsewhere, the 2018 branch is
still active and has several items t
Comment #6 on issue 2127 by asmeurer: don't allow 0 or 1-arg AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
In your big branches it is hard to keep track of which commits have already
passed review and which still need review.
--
You received this message because you are subscr
Comment #7 on issue 2127 by Vinzent.Steinberg: don't allow 0 or 1-arg
AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
In your big branches it is hard to keep track of which commits have
already passed review and which still need review.
This is basically an argument for pushi
Comment #8 on issue 2127 by asmeurer: don't allow 0 or 1-arg AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
I think it would be easier if Chris pushed in his own patches that are
passed review. The problem is really that if I review a patch that is tied
up in other patches tha
Comment #9 on issue 2127 by smi...@gmail.com: don't allow 0 or 1-arg AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
The TODO box is, I believe, the answer. In multi-commit issues I've put a
TODO box there and am removing commits as they are reviewed.
I don't have push access, b
Comment #10 on issue 2127 by Vinzent.Steinberg: don't allow 0 or 1-arg
AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
I don't have push access.
That surprises me, you are probably the most active sympy developer. So now
you have. :)
Really, when pushing it is enough to ma
Comment #11 on issue 2127 by asmeurer: don't allow 0 or 1-arg AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
Just follow that guide at
https://github.com/sympy/sympy/wiki/Pushing-Patches. The most important
thing to remember is to NEVER do a -f push to master. Once something
Comment #12 on issue 2127 by Vinzent.Steinberg: don't allow 0 or 1-arg
AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
A forced push is not *that* bad, it just can screw things up, because it
rewrites history. It should not happen, but if it happens, it is manageable.
We had
Comment #13 on issue 2127 by asmeurer: don't allow 0 or 1-arg AssocOp
http://code.google.com/p/sympy/issues/detail?id=2127
Yes, it is fixable. I believe a fix would be to merge the two non-fast
forward HEADs together to make them both fast forward. But of course, it's
still something that
16 matches
Mail list logo
