Re: review of Chris' 1766

2010-05-03 Thread Vinzent Steinberg
I just fixed py.test, the results are attached. They should be more useful that bin/test's results. Note that there are some failures related to py.test. Vinzent 2010/4/30 Aaron S. Meurer asmeu...@gmail.com: The failures are 64-bit only: 32-bit:

Re: review of Chris' 1766

2010-04-29 Thread Aaron S. Meurer
The failures are 64-bit only: 32-bit: ___ sympy/utilities/tests/test_code_quality.py:test_implicit_imports ___ File

Re: review of Chris' 1766

2010-03-27 Thread smichr
On Mar 26, 8:38 pm, Vinzent Steinberg vinzent.steinb...@googlemail.com wrote: I just tried to review the commits before the 'quartz' commit, I hope this is to be reviewed, if not, please create a new branch with only the commits to be reviewed. The 1766s and the 1766_s branch need to be

Re: review of Chris' 1766

2010-03-27 Thread Ondrej Certik
On Sat, Mar 27, 2010 at 12:54 AM, smichr smi...@gmail.com wrote: On Mar 26, 8:38 pm, Vinzent Steinberg vinzent.steinb...@googlemail.com wrote: I just tried to review the commits before the 'quartz' commit, I hope this is to be reviewed, if not, please create a new branch with only the

Re: review of Chris' 1766

2010-03-26 Thread Vinzent Steinberg
I just tried to review the commits before the 'quartz' commit, I hope this is to be reviewed, if not, please create a new branch with only the commits to be reviewed. The 1766s and the 1766_s branch need to be rebased on master. So I'm getting these failures:

Re: review of Chris' 1766

2010-03-11 Thread Aaron S. Meurer
I think that minor test failures are not too big of a deal for intermediate commits. It is important that isympy works in each intermediate commit, in case you need to bisect, and that there are no whitespace issues, because git complains about them while rebasing and if you have the

Re: review of Chris' 1766

2010-03-11 Thread Ondrej Certik
On Thu, Mar 11, 2010 at 9:56 AM, Aaron S. Meurer asmeu...@gmail.com wrote: I think that minor test failures are not too big of a deal for intermediate commits. It is important that isympy works in each intermediate commit, in case you need to bisect, and that there are no whitespace issues,

Re: review of Chris' 1766

2010-03-08 Thread smichr
why did  you remove the following tests (sympy/core/tests/test_arit.py): -    assert list((I*pi).atoms(NumberSymbol)) == [pi] -    assert sorted((I*pi).atoms(NumberSymbol, I)) == \ -           sorted((I*pi).atoms(I,NumberSymbol)) == [pi, I] There must be a better way to find this...sorry, I

Re: review of Chris' 1766

2010-03-08 Thread smichr
I'll reply to the initial questions in a bit. -- You received this message because you are subscribed to the Google Groups sympy-patches group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to

Re: review of Chris' 1766

2010-03-05 Thread smichr
On Mar 5, 12:04 pm, smichr smi...@gmail.com wrote: This is False for reasons I am trying to track down. The problem doesn't exist in master Correction: the problem exists in master. (The original raising- expression wasn't causing a problem in master but was in 1766, but the underlying

Re: review of Chris' 1766

2010-03-05 Thread smichr
ok, all issues have been resolved (except perhaps for an error that showed up for asmeurer but not for me which I tried to fix but it will take someone else to test it--a test in test_ode triggered it). All doctests and tests of the current 1766 branch pass for me. -- You received this message

Re: review of Chris' 1766

2010-03-04 Thread Vinzent Steinberg
2010/3/4 Ondrej Certik ond...@certik.cz: $ ./setup.py test Traceback (most recent call last):  File ./setup.py, line 33, in module    import sympy  File /home/ondrej/repos/sympy/sympy/__init__.py, line 29, in module    from concrete import *  File

Re: review of Chris' 1766

2010-03-04 Thread smichr
OK, let's try again...it's repushed and no failures show here. I am, however, trying to track down something that showed up in the polynomial decomposition question that I posed recently. ### t = -sqrt(2)*(1-sqrt(2)) print sqrt(t).is_real == sqrt(t.expand()).is_real ### This is False for reasons