Re: [Synfig-devl] Diego Barrios Romero : Unused variable commented out

2012-03-20 Thread Carlos Lopez Gonzalez
2012 23:18 Asunto: Re: [Synfig-devl] Diego Barrios Romero : Unused variable commented out 2012/3/16 Denis Washington : > > Again, why not move all commented-out code into a separate branch? This > gives us the best of both worlds. > > Regards, > Denis As Diego said, cross-me

Re: [Synfig-devl] Diego Barrios Romero : Unused variable commented out

2012-03-16 Thread Nikita Kitaev
2012/3/16 Denis Washington : > > Again, why not move all commented-out code into a separate branch? This > gives us the best of both worlds. > > Regards, > Denis As Diego said, cross-merges wouldn't work. Depending on how we set it up, either merging master into this separate branch will delete all

Re: [Synfig-devl] Diego Barrios Romero : Unused variable commented out

2012-03-16 Thread Denis Washington
Am 16.03.2012 08:48, schrieb Zelgadis: 16 марта 2012 г. 1:20 пользователь Diego Barrios Romero написал: Actually going through the comments and analyzing them takes a lot of effort. I tried doing that in synfig-studio but eventually lost momentum. Perhaps it's worth it to just delete all of t

Re: [Synfig-devl] Diego Barrios Romero : Unused variable commented out

2012-03-16 Thread Zelgadis
16 марта 2012 г. 1:20 пользователь Diego Barrios Romero написал: >>> >>> Actually going through the comments and analyzing them takes a lot of >>> effort. I tried doing that in synfig-studio but eventually lost >>> momentum. Perhaps it's worth it to just delete all of the stale code >>> in one pas

[Synfig-devl] Diego Barrios Romero : Unused variable commented out

2012-03-15 Thread root
Author: Diego Barrios Romero Date: Wed Mar 14 20:06:18 2012 +0100 Unused variable commented out --- synfig-core/src/synfig/valuenode_range.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/synfig-core/src/synfig/valuenode_range.cpp b/synfig-core/src/synfig/valuen

Re: [Synfig-devl] Diego Barrios Romero : Unused variable commented out

2012-03-15 Thread Diego Barrios Romero
Hi, 2012/3/15 Denis Washington > Am 15.03.2012 08:09, schrieb Nikita Kitaev: > > On Wed, Mar 14, 2012 at 4:29 PM, Denis Washington >> wrote: >> >>> Why commenting out? Aren't version control systems there exactly so that >>> you >>> don't need to keep such cruft in the current code? I am reall

Re: [Synfig-devl] Diego Barrios Romero : Unused variable commented out

2012-03-15 Thread Denis Washington
Am 15.03.2012 08:09, schrieb Nikita Kitaev: On Wed, Mar 14, 2012 at 4:29 PM, Denis Washington wrote: Why commenting out? Aren't version control systems there exactly so that you don't need to keep such cruft in the current code? I am really wondering about the huge amount of commented-out lines

Re: [Synfig-devl] Diego Barrios Romero : Unused variable commented out

2012-03-15 Thread Nikita Kitaev
On Wed, Mar 14, 2012 at 4:29 PM, Denis Washington wrote: > Why commenting out? Aren't version control systems there exactly so that you > don't need to keep such cruft in the current code? I am really wondering > about the huge amount of commented-out lines in the codebase. Many of the comments a

Re: [Synfig-devl] Diego Barrios Romero : Unused variable commented out

2012-03-14 Thread Denis Washington
Am 14.03.2012 20:16, schrieb r...@synfig.org: Author: Diego Barrios Romero Date: Wed Mar 14 20:06:18 2012 +0100 Unused variable commented out Why commenting out? Aren't version control systems there exactly so that you don't need to keep such cruft in the current code? I am really wonderin

[Synfig-devl] Diego Barrios Romero : Unused variable commented out

2012-03-14 Thread root
Author: Diego Barrios Romero Date: Wed Mar 14 20:06:18 2012 +0100 Unused variable commented out --- synfig-core/src/synfig/valuenode_range.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/synfig-core/src/synfig/valuenode_range.cpp b/synfig-core/src/synfig/valuen