Re: [systemd-devel] [PATCH V4] service: Support environment variable substition for PIDFile=

2013-04-17 Thread Harald Hoyer
Am 18.04.2013 02:40, schrieb Lennart Poettering: > On Wed, 10.04.13 16:53, har...@redhat.com (har...@redhat.com) wrote: > >> From: Harald Hoyer >> >> This patch adds environment variable substition for PIDFile=. To read >> the environment files only once, ExecContext holds a copy of the >> enviro

Re: [systemd-devel] [PATCH] RFC: stack_size_guess() and LINE_MAX limitation for MESSAGE

2013-04-17 Thread Harald Hoyer
Am 17.04.2013 19:48, schrieb Lennart Poettering: > On Mon, 15.04.13 16:12, har...@redhat.com (har...@redhat.com) wrote: > >> From: Harald Hoyer >> >> Introduce stack_size_guess() and alloca_maybe_safe() and get rid of >> the LINE_MAX limitation for MESSAGE in sd_journal_printv*() > > tbh I don't

Re: [systemd-devel] [PATCH 1/2] Report about syntax error in extended format

2013-04-17 Thread Oleksii Shevchuk
Zbigniew Jędrzejewski-Szmek writes: > I have now pushed a change that adds UNIT= or USER_UNIT= to most > syntax error messages. This patch mostly follows Oleksii's approach, > but extends it to all syntax parsing functions. > For the last time I tried to use next approach: I added reporting call

Re: [systemd-devel] [PATCH] Move bus_error to dbus-common and remove bus_error_message_or_strerror

2013-04-17 Thread Lennart Poettering
On Thu, 11.04.13 00:39, Simon Peeters (peeters.si...@gmail.com) wrote: > bus_error and bus_error_message_or_strerror dit almost exactly the same, > so use only one of them and place it in dbus-common. Looks good! Fixed a compilation issue and commited! Thanks, Lennart -- Lennart Poettering -

Re: [systemd-devel] [PATCH V2] cryptsetup-generator: add support for rd.luks.key=

2013-04-17 Thread Lennart Poettering
On Thu, 11.04.13 15:44, har...@redhat.com (har...@redhat.com) wrote: > From: Harald Hoyer > > Also clarify rd.luks.uuid and luks.uuid in the manual. > > https://bugzilla.redhat.com/show_bug.cgi?id=905683 Sounds good. Applied! Lennart -- Lennart Poettering - Red Hat, Inc. ___

Re: [systemd-devel] [PATCH V4] service: Support environment variable substition for PIDFile=

2013-04-17 Thread Lennart Poettering
On Wed, 10.04.13 16:53, har...@redhat.com (har...@redhat.com) wrote: > From: Harald Hoyer > > This patch adds environment variable substition for PIDFile=. To read > the environment files only once, ExecContext holds a copy of the > environment gathered. > > RFE: https://bugzilla.redhat.com/sho

Re: [systemd-devel] Per-instance override with foobar.service.d

2013-04-17 Thread Lennart Poettering
On Mon, 08.04.13 20:08, John Lane (syst...@jelmail.com) wrote: > I'm trying out the new foobar.service.d way of overriding unit files. > > I thought that I'd be able to have a number of service instances > that were overridden differently but that does not seem to be the > case (or, at least, I c

Re: [systemd-devel] [PATCH] cryptsetup: set the timeout to 0 by default

2013-04-17 Thread Lennart Poettering
On Fri, 12.04.13 09:45, har...@redhat.com (har...@redhat.com) wrote: > From: Harald Hoyer > > cryptsetup itself has no timeout as default from the beginning. So the > default timeout has been "0" from the beginning. Makes sense I guess. Applied. Also added a comment to crypttab(5) to mention t

Re: [systemd-devel] [PATCH] systemctl: clarify usage of "--all" versus list-unit-files

2013-04-17 Thread Lennart Poettering
On Wed, 10.04.13 12:34, har...@redhat.com (har...@redhat.com) wrote: > From: Harald Hoyer > > Novice users might think, that > $ systemctl --all > is equal to > $ systemctl list-unit-files Note that "systemctl" will already clarify this this in the quick summary it shows at the end of the lis

Re: [systemd-devel] [PATCH] TODO: add various journal enhancements

2013-04-17 Thread Kay Sievers
On Thu, Apr 18, 2013 at 12:28 AM, Josh Triplett wrote: > On Thu, Apr 18, 2013 at 12:12:38AM +0200, Kay Sievers wrote: >> On Wed, Apr 17, 2013 at 11:49 PM, Josh Triplett >> wrote: >> >> > + - Replace utmp, wtmp, btmp, and lastlog completely with journal >> >> We should definitely add the data ne

Re: [systemd-devel] [PATCH] TODO: timer unit generation

2013-04-17 Thread Kay Sievers
On Thu, Apr 18, 2013 at 12:30 AM, Josh Triplett wrote: > On Thu, Apr 18, 2013 at 12:15:22AM +0200, Kay Sievers wrote: >> On Thu, Apr 18, 2013 at 12:11 AM, Josh Triplett >> wrote: >> > On Thu, Apr 18, 2013 at 12:04:24AM +0200, Kay Sievers wrote: >> >> On Wed, Apr 17, 2013 at 11:50 PM, Josh Triple

Re: [systemd-devel] [PATCH] TODO: timer unit generation

2013-04-17 Thread Josh Triplett
On Thu, Apr 18, 2013 at 12:15:22AM +0200, Kay Sievers wrote: > On Thu, Apr 18, 2013 at 12:11 AM, Josh Triplett wrote: > > On Thu, Apr 18, 2013 at 12:04:24AM +0200, Kay Sievers wrote: > >> On Wed, Apr 17, 2013 at 11:50 PM, Josh Triplett > >> wrote: > >> > >> > + - unit generator for compatibilit

Re: [systemd-devel] [PATCH] TODO: add various journal enhancements

2013-04-17 Thread Josh Triplett
On Thu, Apr 18, 2013 at 12:12:38AM +0200, Kay Sievers wrote: > On Wed, Apr 17, 2013 at 11:49 PM, Josh Triplett wrote: > > > + - Replace utmp, wtmp, btmp, and lastlog completely with journal > > We should definitely add the data needed to constuct this information, > if they are not already ther

Re: [systemd-devel] [PATCH] TODO: passwd.d, group.d

2013-04-17 Thread Kay Sievers
On Wed, Apr 17, 2013 at 11:50 PM, Josh Triplett wrote: > --- > TODO |5 + > 1 file changed, 5 insertions(+) > > diff --git a/TODO b/TODO > index eb482d0..6cf632a 100644 > --- a/TODO > +++ b/TODO > @@ -679,6 +679,11 @@ External: > - put bootcharts in the journal > - kernel cmdline

Re: [systemd-devel] [PATCH] TODO: timer unit generation

2013-04-17 Thread Kay Sievers
On Thu, Apr 18, 2013 at 12:11 AM, Josh Triplett wrote: > On Thu, Apr 18, 2013 at 12:04:24AM +0200, Kay Sievers wrote: >> On Wed, Apr 17, 2013 at 11:50 PM, Josh Triplett >> wrote: >> >> > + - unit generator for compatibility with crontab and cron.d >> >> We kind of decided to port the 40-60 thin

Re: [systemd-devel] [PATCH] TODO: add various journal enhancements

2013-04-17 Thread Kay Sievers
On Wed, Apr 17, 2013 at 11:49 PM, Josh Triplett wrote: > + - Replace utmp, wtmp, btmp, and lastlog completely with journal We should definitely add the data needed to constuct this information, if they are not already there. The tools could just use the journal directly, but there is the glibc

Re: [systemd-devel] [PATCH] TODO: timer unit generation

2013-04-17 Thread Josh Triplett
On Thu, Apr 18, 2013 at 12:04:24AM +0200, Kay Sievers wrote: > On Wed, Apr 17, 2013 at 11:50 PM, Josh Triplett wrote: > > > + - unit generator for compatibility with crontab and cron.d > > We kind of decided to port the 40-60 things that use the .d/ dirs to > native units right away, and leave

Re: [systemd-devel] [PATCH] TODO: timer unit generation

2013-04-17 Thread Kay Sievers
On Wed, Apr 17, 2013 at 11:50 PM, Josh Triplett wrote: > + - unit generator for compatibility with crontab and cron.d We kind of decided to port the 40-60 things that use the .d/ dirs to native units right away, and leave cron as it is, and not parse its config files from systemd. If people wa

[systemd-devel] [PATCH] TODO: passwd.d, group.d

2013-04-17 Thread Josh Triplett
--- TODO |5 + 1 file changed, 5 insertions(+) diff --git a/TODO b/TODO index eb482d0..6cf632a 100644 --- a/TODO +++ b/TODO @@ -679,6 +679,11 @@ External: - put bootcharts in the journal - kernel cmdline "bootchart" option for simplicity? +* Support passwd.d and group.d; accumul

[systemd-devel] [PATCH] TODO: add various journal enhancements

2013-04-17 Thread Josh Triplett
--- TODO |7 +++ 1 file changed, 7 insertions(+) diff --git a/TODO b/TODO index 88be72d..48e5d2e 100644 --- a/TODO +++ b/TODO @@ -272,6 +272,13 @@ Features: - journal: store euid in journal if it differs from uid - journal: sanely deal with entries which are larger than the individu

[systemd-devel] [PATCH] TODO: timer unit generation

2013-04-17 Thread Josh Triplett
--- TODO |1 + 1 file changed, 1 insertion(+) diff --git a/TODO b/TODO index 48e5d2e..eb482d0 100644 --- a/TODO +++ b/TODO @@ -320,6 +320,7 @@ Features: o CLOCK_REALTIME makes jumps (TFD_TIMER_CANCEL_ON_SET) o DST changes - Support 2012-02~4 as syntax for specifying the fourth to

Re: [systemd-devel] [PATCH] cryptsetup: ask for password, if key file cannot be accessed

2013-04-17 Thread Lennart Poettering
On Thu, 11.04.13 13:08, har...@redhat.com (har...@redhat.com) wrote: > From: Harald Hoyer > > If the key file cannot be accessed, we can at least ask for the > password. I like the general idea, but not the patch. This code is racy. We shouldn't even start with things like this. We should try

Re: [systemd-devel] Reason for su command to be ignored in target?

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 22:16, Lennart Poettering (lenn...@poettering.net) wrote: > On Wed, 17.04.13 16:08, Mark Hounschell (ma...@compro.net) wrote: > > > >That looks OK. Can you try the logger thing I suggested? That should > > >tell us if the transition works at all... > > > > Sorry, I had a dentist

Re: [systemd-devel] Reason for su command to be ignored in target?

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 16:08, Mark Hounschell (ma...@compro.net) wrote: > >That looks OK. Can you try the logger thing I suggested? That should > >tell us if the transition works at all... > > Sorry, I had a dentist Apt. > > Uh, I put this as the first command in the /lcrs/sh.lcrs script: > > /bin/su

Re: [systemd-devel] Reason for su command to be ignored in target?

2013-04-17 Thread Mark Hounschell
On 04/17/2013 01:32 PM, Lennart Poettering wrote: On Wed, 17.04.13 13:21, Mark Hounschell (ma...@compro.net) wrote: The only thing I see in /var/log/messages is: 2013-04-17T11:36:51.667308-04:00 utils-linux su: (to lcrs) root on /dev/ttyS0 Bu that's run on ttyS0? Is that really script? How d

Re: [systemd-devel] systemd-readahead and often used applications

2013-04-17 Thread Lennart Poettering
On Sat, 13.04.13 13:27, Reindl Harald (h.rei...@thelounge.net) wrote: > Hi > > as far as i understand "systemd-readahead" is catching what is > loaded directly due boot and 10 seconds after, well that's fine I changed this to 30 now, btw, since 10s turned out to be too short on many systems. >

Re: [systemd-devel] Socket is dying, how to automatically restart it?

2013-04-17 Thread Lennart Poettering
On Wed, 10.04.13 19:03, Koen Kooi (k...@dominion.thruhere.net) wrote: > Hi, > > I have a bit of a heisenbug where dropbear.socket will just die and > needs a systemctl restart dropbear.socket. I can't tell why it's > dying, just that it does within 3 days of uptime. After restarting it > it seems

Re: [systemd-devel] [PATCH v3] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
Zbigniew Jędrzejewski-Szmek writes: > On Wed, Apr 17, 2013 at 07:36:47PM +0200, Henrik Grindal Bakken wrote: >> This patch adds --disable-tests to configure. It is based on a patch >> posted by Thierry Reding in 2010. The motivation for adding it is that >> some tests fail link-time when cross-

Re: [systemd-devel] Add ARCH parameter to /etc/os-release

2013-04-17 Thread Lennart Poettering
On Mon, 08.04.13 22:09, Askar Safin (safinas...@mail.ru) wrote: > > >I'm not sure what problem the proposal is trying to solve. Maybe it'd > >be clearer if that was provided. > I want to know what is the arches of the systems on my computer. I. e. I want > to do the following: > > for DISK in

Re: [systemd-devel] [PATCH 0/2] RFC for avoid dynamic allocation in?journald

2013-04-17 Thread Lennart Poettering
On Mon, 08.04.13 19:53, Holger Hans Peter Freyther (hol...@freyther.de) wrote: > > On Mon, Apr 08, 2013 at 07:06:44PM +0200, Lennart Poettering wrote: > > > > Is it really needed to determine the cgroup of /proc/1 on every message? > > > Couldn't journald keep the variables for its identity arou

Re: [systemd-devel] [PATCH v3] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 17, 2013 at 07:36:47PM +0200, Henrik Grindal Bakken wrote: > This patch adds --disable-tests to configure. It is based on a patch > posted by Thierry Reding in 2010. The motivation for adding it is that > some tests fail link-time when cross-compiling. > > The patch adds a new Makefi

Re: [systemd-devel] [PATCH] RFC: stack_size_guess() and LINE_MAX limitation for MESSAGE

2013-04-17 Thread Lennart Poettering
On Mon, 15.04.13 16:12, har...@redhat.com (har...@redhat.com) wrote: > From: Harald Hoyer > > Introduce stack_size_guess() and alloca_maybe_safe() and get rid of > the LINE_MAX limitation for MESSAGE in sd_journal_printv*() tbh I don't really see the benefit of this. This is about logging, you

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
Lennart Poettering writes: > Hmm, why do you bother with the tests only appearing on > noinst_PROGRAMS= anyway? Those are never run automatically, so they > shouldn't matter to you? Well, at the moment, one of them (test-bus-marshal) fails to link due to (seemingly) a problem with glib linking.

[systemd-devel] [PATCH v3] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
This patch adds --disable-tests to configure. It is based on a patch posted by Thierry Reding in 2010. The motivation for adding it is that some tests fail link-time when cross-compiling. The patch adds a new Makefile variable -- noinst_test_programs -- and uses that instead of noinst_PROGRAMS.

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 19:25, Henrik Grindal Bakken (h...@ifi.uio.no) wrote: > > Lennart Poettering writes: > > > On Wed, 17.04.13 18:48, Henrik Grindal Bakken (h...@ifi.uio.no) wrote: > > > >> @@ -125,8 +125,13 @@ dist_dbussystemservice_DATA = > >> check_PROGRAMS = > >> check_DATA = > >> noinst_t

Re: [systemd-devel] Reason for su command to be ignored in target?

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 13:21, Mark Hounschell (ma...@compro.net) wrote: > >>The only thing I see in /var/log/messages is: > >> > >>2013-04-17T11:36:51.667308-04:00 utils-linux su: (to lcrs) root on > >>/dev/ttyS0 > > > >Bu that's run on ttyS0? Is that really script? How do spawn that script? > > > > Fr

Re: [systemd-devel] typo? path-util: unify code for detecting OS trees

2013-04-17 Thread Peeters Simon
>> while reading random patches in cgit I saw >> (in commit 6606089752df90f3eeb4924af109046f1c73554c) >> >> ... >> > diff --git a/src/shared/util.h b/src/shared/util.h >> > index 3aac165..cfb5493 100644 >> > --- a/src/shared/util.h >> > +++ b/src/shared/util.h >> > @@ -684,3 +684,15 @@ int unlink_n

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
Lennart Poettering writes: > On Wed, 17.04.13 18:48, Henrik Grindal Bakken (h...@ifi.uio.no) wrote: > >> @@ -125,8 +125,13 @@ dist_dbussystemservice_DATA = >> check_PROGRAMS = >> check_DATA = >> noinst_tests= >> +if ENABLE_TESTS >> noinst_PROGRAMS = $(noinst_tests) >> TESTS = $(noinst_tests)

Re: [systemd-devel] Reason for su command to be ignored in target?

2013-04-17 Thread Mark Hounschell
On 04/17/2013 01:12 PM, Lennart Poettering wrote: On Wed, 17.04.13 12:22, Mark Hounschell (ma...@compro.net) wrote: On 04/17/2013 10:27 AM, Lennart Poettering wrote: On Wed, 17.04.13 09:46, Mark Hounschell (ma...@compro.net) wrote: I have been using systemd to boot into a very basic target.

Re: [systemd-devel] How to run *ctl command using systemd-nspawn

2013-04-17 Thread Koen Kooi
Op 17 apr. 2013, om 17:20 heeft Lennart Poettering het volgende geschreven: > On Wed, 17.04.13 17:09, Lennart Poettering (lenn...@poettering.net) wrote: > >> >> On Tue, 16.04.13 09:11, Koen Kooi (k...@dominion.thruhere.net) wrote: >> >>> Hi, >>> >>> To help with flashing the onboard eMMC of

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 18:48, Henrik Grindal Bakken (h...@ifi.uio.no) wrote: > @@ -125,8 +125,13 @@ dist_dbussystemservice_DATA = > check_PROGRAMS = > check_DATA = > noinst_tests= > +if ENABLE_TESTS > noinst_PROGRAMS = $(noinst_tests) > TESTS = $(noinst_tests) > +else > +noinst_PROGRAMS = > +TESTS

Re: [systemd-devel] Reason for su command to be ignored in target?

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 12:22, Mark Hounschell (ma...@compro.net) wrote: > > On 04/17/2013 10:27 AM, Lennart Poettering wrote: > >On Wed, 17.04.13 09:46, Mark Hounschell (ma...@compro.net) wrote: > > > >>I have been using systemd to boot into a very basic target. That > >>target basically executes a scr

Re: [systemd-devel] [PATCH] bus: Use memalign() if aligned_alloc() isn't available

2013-04-17 Thread Henrik Grindal Bakken
Kay Sievers writes: > On Wed, Apr 17, 2013 at 5:49 PM, Henrik Grindal Bakken > wrote: >> Use and _GNU_SOURCE to determine if _ISOC11_SOURCE is >> available, and with that, aligned_alloc(). > > Can't you just define the missing function in missing.h to the one we > use, instead of directly blow

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
Lennart Poettering writes: > noinst_PROGRAMS is for tests that cannot really be run > automatically during "make check", since they need some kind of > interaction, priviliges and so on. These tests are much less useful, but > for some low level stuff we need this. > > noinst_tests otoh is for te

Re: [systemd-devel] Lid close event delivered delayed

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 21:01, Andrey Borzenkov (arvidj...@gmail.com) wrote: > > В Wed, 17 Apr 2013 17:31:14 +0200 > Lennart Poettering пишет: > > > On Wed, 17.04.13 17:20, Jan Engelhardt (jeng...@inai.de) wrote: > > > > > > > > > > > On Wednesday 2013-04-17 16:42, Lennart Poettering wrote: > > > >

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 18:38, Henrik Grindal Bakken (h...@ifi.uio.no) wrote: > > Kay Sievers writes: > > > On Wed, Apr 17, 2013 at 5:49 PM, Henrik Grindal Bakken > > wrote: > >> This patch adds --disable-tests to configure. It is based on a patch > >> posted by Thierry Reding in 2010. The motivat

Re: [systemd-devel] How to run *ctl command using systemd-nspawn

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 17:36, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > we could add a generator to systemd which looks for "systemd.run=" or so > > on the kernel cmdline and simply generates throw-away unit files from > > that, that runs the specified command(s) and triggers a shutdown

Re: [systemd-devel] Lid close event delivered delayed

2013-04-17 Thread Andrey Borzenkov
В Wed, 17 Apr 2013 17:31:14 +0200 Lennart Poettering пишет: > On Wed, 17.04.13 17:20, Jan Engelhardt (jeng...@inai.de) wrote: > > > > > > > On Wednesday 2013-04-17 16:42, Lennart Poettering wrote: > > >On Wed, 17.04.13 06:58, Jan Engelhardt (jeng...@inai.de) wrote: > > > > > >Well, the current

[systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
This patch adds --disable-tests to configure. It is based on a patch posted by Thierry Reding in 2010. The motivation for adding it is that some tests fail link-time when cross-compiling. --- Makefile.am | 21 +++-- configure.ac |5 + 2 files changed, 16 insertions(+),

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
Henrik Grindal Bakken writes: > This patch adds --disable-tests to configure. It is based on a patch > posted by Thierry Reding in 2010. The motivation for adding it is that > some tests fail link-time when cross-compiling. This is the alternative approach. I'm not sure what the distinction b

Re: [systemd-devel] Lid close event delivered delayed

2013-04-17 Thread Andrey Borzenkov
В Wed, 17 Apr 2013 06:58:20 +0200 (CEST) Jan Engelhardt пишет: > Hi, > > > something I observed with systemd-195 is that the LidClose event is > delivered when switching from X to console while the lid is closed. This > is unexpected, and what I expected is instead that nothing occurs. > Appr

Re: [systemd-devel] [PATCH] bus: Use memalign() if aligned_alloc() isn't available

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 18:38, Lennart Poettering (lenn...@poettering.net) wrote: > > Yeah, the idea of missing.h is to make stuff look like it is there. We > > usually just decide on one option, and cover older stuff from there. > > :) > > Well, our current usage of aligned_alloc() is not even calling

Re: [systemd-devel] [PATCH] core: Remove unnecessary typedef

2013-04-17 Thread Simon McVittie
On 17/04/13 17:25, Kay Sievers wrote: > On Wed, Apr 17, 2013 at 6:08 PM, Henrik Grindal Bakken > wrote: >> ExecContext isn't used in this header file, and everything seems to >> build just fine without this typedef. The typedef doesn't really belong >> here, and at least my gcc-4.4.6 gives an er

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
Kay Sievers writes: > On Wed, Apr 17, 2013 at 5:49 PM, Henrik Grindal Bakken > wrote: >> This patch adds --disable-tests to configure. It is based on a patch >> posted by Thierry Reding in 2010. The motivation for adding it is >> that some tests fail link-time when cross-compiling. > > Can't

Re: [systemd-devel] [PATCH] bus: Use memalign() if aligned_alloc() isn't available

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 18:12, Kay Sievers (k...@vrfy.org) wrote: > > On Wed, Apr 17, 2013 at 6:09 PM, Henrik Grindal Bakken > wrote: > > Kay Sievers writes: > > > >> On Wed, Apr 17, 2013 at 5:49 PM, Henrik Grindal Bakken > >> wrote: > >>> Use and _GNU_SOURCE to determine if _ISOC11_SOURCE is > >>

Re: [systemd-devel] [PATCH] bus: Use memalign() if aligned_alloc() isn't available

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 17:49, Henrik Grindal Bakken (h...@ifi.uio.no) wrote: > Use and _GNU_SOURCE to determine if _ISOC11_SOURCE is > available, and with that, aligned_alloc(). Hmm, we probably should just use memalign() everywhere. It's available on all GNU systems and Solaris, which is more than en

Re: [systemd-devel] [PATCH] core: Remove unnecessary typedef

2013-04-17 Thread Henrik Grindal Bakken
Kay Sievers writes: > On Wed, Apr 17, 2013 at 6:08 PM, Henrik Grindal Bakken > wrote: >> ExecContext isn't used in this header file, and everything seems to >> build just fine without this typedef. The typedef doesn't really belong >> here, and at least my gcc-4.4.6 gives an error on type rede

Re: [systemd-devel] systemd-nspawn

2013-04-17 Thread Lennart Poettering
On Mon, 15.04.13 14:31, Chir0n (io.chi...@gmail.com) wrote: Please do not send HTML mails to this mailing list, thank you. > I'm trying to execute the Example 1 of the following tutorial and I can't > log with any user. I get an authentication > error. This is probably fixed with this recent com

Re: [systemd-devel] [PATCH] core: Remove unnecessary typedef

2013-04-17 Thread Kay Sievers
On Wed, Apr 17, 2013 at 6:08 PM, Henrik Grindal Bakken wrote: > ExecContext isn't used in this header file, and everything seems to > build just fine without this typedef. The typedef doesn't really belong > here, and at least my gcc-4.4.6 gives an error on type redefined. Weird, this type of fo

Re: [systemd-devel] systemd-nspawn

2013-04-17 Thread Simon McVittie
On 17/04/13 16:57, Lennart Poettering wrote: > Hmm, or maybe like this: enter the container, allocate a pty, > instantiate getty@.service for that pty, pass pty fd back to host, exit > in namespace, and process pty on the host as long as we don't get EOF. This is probably a good idea for interacti

Re: [systemd-devel] Reason for su command to be ignored in target?

2013-04-17 Thread Mark Hounschell
On 04/17/2013 10:27 AM, Lennart Poettering wrote: On Wed, 17.04.13 09:46, Mark Hounschell (ma...@compro.net) wrote: I have been using systemd to boot into a very basic target. That target basically executes a script. In that script we execute an "su -m -c command user". The last version of syst

[systemd-devel] [PATCH 2/2] bus: Include missing.h to get redefinition of aligned_access if necessary

2013-04-17 Thread Henrik Grindal Bakken
--- src/libsystemd-bus/bus-kernel.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/libsystemd-bus/bus-kernel.c b/src/libsystemd-bus/bus-kernel.c index 086877e..c144f69 100644 --- a/src/libsystemd-bus/bus-kernel.c +++ b/src/libsystemd-bus/bus-kernel.c @@ -26,6 +26,7 @@ #include #in

[systemd-devel] [PATCH 1/2] missing: Redefine aligned_alloc() to memalign() if we don't have C11

2013-04-17 Thread Henrik Grindal Bakken
--- src/shared/missing.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/shared/missing.h b/src/shared/missing.h index d4ba0d3..7f49a6d 100644 --- a/src/shared/missing.h +++ b/src/shared/missing.h @@ -23,6 +23,11 @@ /* Missing glibc definitions to access certain kernel API

Re: [systemd-devel] Reason for su command to be ignored in target?

2013-04-17 Thread Mark Hounschell
On 04/17/2013 10:09 AM, Andrey Borzenkov wrote: On Wed, Apr 17, 2013 at 5:46 PM, Mark Hounschell wrote: I have been using systemd to boot into a very basic target. That target basically executes a script. In that script we execute an "su -m -c command user". The last version of systemd I have w

Re: [systemd-devel] [PATCH] bus: Use memalign() if aligned_alloc() isn't available

2013-04-17 Thread Kay Sievers
On Wed, Apr 17, 2013 at 6:09 PM, Henrik Grindal Bakken wrote: > Kay Sievers writes: > >> On Wed, Apr 17, 2013 at 5:49 PM, Henrik Grindal Bakken >> wrote: >>> Use and _GNU_SOURCE to determine if _ISOC11_SOURCE is >>> available, and with that, aligned_alloc(). >> >> Can't you just define the mis

Re: [systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Kay Sievers
On Wed, Apr 17, 2013 at 5:49 PM, Henrik Grindal Bakken wrote: > This patch adds --disable-tests to configure. It is based on a patch > posted by Thierry Reding in 2010. The motivation for adding it is that > some tests fail link-time when cross-compiling. Can't the tests get its own variables,

[systemd-devel] [PATCH] core: Remove unnecessary typedef

2013-04-17 Thread Henrik Grindal Bakken
ExecContext isn't used in this header file, and everything seems to build just fine without this typedef. The typedef doesn't really belong here, and at least my gcc-4.4.6 gives an error on type redefined. --- src/core/namespace.h |2 -- 1 file changed, 2 deletions(-) diff --git a/src/core/n

Re: [systemd-devel] [PATCH] bus: Use memalign() if aligned_alloc() isn't available

2013-04-17 Thread Kay Sievers
On Wed, Apr 17, 2013 at 5:49 PM, Henrik Grindal Bakken wrote: > Use and _GNU_SOURCE to determine if _ISOC11_SOURCE is > available, and with that, aligned_alloc(). Can't you just define the missing function in missing.h to the one we use, instead of directly blowing up the code with compat stuff

[systemd-devel] [PATCH] bus: Use memalign() if aligned_alloc() isn't available

2013-04-17 Thread Henrik Grindal Bakken
Use and _GNU_SOURCE to determine if _ISOC11_SOURCE is available, and with that, aligned_alloc(). --- src/libsystemd-bus/bus-kernel.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/libsystemd-bus/bus-kernel.c b/src/libsystemd-bus/bus-kernel.c index 0

[systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

2013-04-17 Thread Henrik Grindal Bakken
This patch adds --disable-tests to configure. It is based on a patch posted by Thierry Reding in 2010. The motivation for adding it is that some tests fail link-time when cross-compiling. --- Makefile.am | 13 + configure.ac |5 + 2 files changed, 18 insertions(+) diff --

Re: [systemd-devel] systemd-nspawn

2013-04-17 Thread Lennart Poettering
On Mon, 15.04.13 20:48, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > On Mon, Apr 15, 2013 at 08:36:33PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > > On Mon, Apr 15, 2013 at 02:31:56PM -0300, Chir0n wrote: > > > # yum -y --releasever=19 --nogpg --installroot=/srv/mycontainer > > > --di

Re: [systemd-devel] How to run *ctl command using systemd-nspawn

2013-04-17 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 17, 2013 at 05:20:52PM +0200, Lennart Poettering wrote: > On Wed, 17.04.13 17:09, Lennart Poettering (lenn...@poettering.net) wrote: > > > > > On Tue, 16.04.13 09:11, Koen Kooi (k...@dominion.thruhere.net) wrote: > > > > > Hi, > > > > > > To help with flashing the onboard eMMC of a

Re: [systemd-devel] Lid close event delivered delayed

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 17:20, Jan Engelhardt (jeng...@inai.de) wrote: > > > On Wednesday 2013-04-17 16:42, Lennart Poettering wrote: > >On Wed, 17.04.13 06:58, Jan Engelhardt (jeng...@inai.de) wrote: > > > >Well, the current logic is that we suspend when the lid is > >closed,[...] Lid switch inhibitor

Re: [systemd-devel] systemd release agent

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 18:17, Kevin Wilson (wkev...@gmail.com) wrote: > > Hello, > Thanks a lot for your answer and micahl schmidt. > I made several more tests and I wonder whether there are at all > any such tasks with which systemd uses the release agents. Well, many many services fork of porcesses.

Re: [systemd-devel] [PATCH] login/sd-login.c: make use of _cleanup_free_ and friends

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 16:30, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > On Wed, Apr 17, 2013 at 04:25:40PM +0200, Lennart Poettering wrote: > > On Wed, 17.04.13 16:12, har...@redhat.com (har...@redhat.com) wrote: > > > > > -char *root, *cgroup, *p, *cc; > > > +char _cl

Re: [systemd-devel] How to run *ctl command using systemd-nspawn

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 17:09, Lennart Poettering (lenn...@poettering.net) wrote: > > On Tue, 16.04.13 09:11, Koen Kooi (k...@dominion.thruhere.net) wrote: > > > Hi, > > > > To help with flashing the onboard eMMC of a 10 boards I'm using > > systemd-nspawn to run package postinstall scripts that

Re: [systemd-devel] Lid close event delivered delayed

2013-04-17 Thread Jan Engelhardt
On Wednesday 2013-04-17 16:42, Lennart Poettering wrote: >On Wed, 17.04.13 06:58, Jan Engelhardt (jeng...@inai.de) wrote: > >Well, the current logic is that we suspend when the lid is >closed,[...] Lid switch inhibitor locks are currently per-VT, i.e. a >lock taken by GNOME is considered irrelevan

Re: [systemd-devel] systemd release agent

2013-04-17 Thread Kevin Wilson
Hello, Thanks a lot for your answer and micahl schmidt. I made several more tests and I wonder whether there are at all any such tasks with which systemd uses the release agents. Most of the services uses one process (this is at least what I see when running "cat task" from most systemd service fo

Re: [systemd-devel] How to run *ctl command using systemd-nspawn

2013-04-17 Thread Lennart Poettering
On Tue, 16.04.13 20:59, Koen Kooi (k...@dominion.thruhere.net) wrote: > > Op 16 apr. 2013, om 20:14 heeft Zbigniew Jędrzejewski-Szmek > het volgende geschreven: > > > On Tue, Apr 16, 2013 at 09:11:51AM +0200, Koen Kooi wrote: > >> Hi, > >> > >> To help with flashing the onboard eMMC of a 1000

Re: [systemd-devel] How to run *ctl command using systemd-nspawn

2013-04-17 Thread Lennart Poettering
On Tue, 16.04.13 11:00, Kok, Auke-jan H (auke-jan.h@intel.com) wrote: > > On Tue, Apr 16, 2013 at 12:11 AM, Koen Kooi > wrote: > > Hi, > > > > To help with flashing the onboard eMMC of a 10 boards I'm using > > systemd-nspawn to run package postinstall scripts that generate UUIDs and

Re: [systemd-devel] How to run *ctl command using systemd-nspawn

2013-04-17 Thread Lennart Poettering
On Tue, 16.04.13 09:11, Koen Kooi (k...@dominion.thruhere.net) wrote: > Hi, > > To help with flashing the onboard eMMC of a 10 boards I'm using > systemd-nspawn to run package postinstall scripts that generate UUIDs and > some other things and it's working great for that! Every board now ha

Re: [systemd-devel] system shutdown: what unit is taking so long?

2013-04-17 Thread Kay Sievers
On Wed, Apr 17, 2013 at 4:55 PM, Michal Schmidt wrote: > On 04/17/2013 04:33 PM, Lennart Poettering wrote: >> >> It's so pretty in fact, that it almost makes me want to >> add sleep(30) or so to all my daemons' startup and shutdown code just to >> see it. It's like KITT, but in ASCII! > > > No, no

Re: [systemd-devel] system shutdown: what unit is taking so long?

2013-04-17 Thread Michal Schmidt
On 04/17/2013 04:33 PM, Lennart Poettering wrote: It's so pretty in fact, that it almost makes me want to add sleep(30) or so to all my daemons' startup and shutdown code just to see it. It's like KITT, but in ASCII! No, no, you're not supposed to like it. You should tremble in fear! It's not a

Re: [systemd-devel] [PATCH] bash-completion: --property support

2013-04-17 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 17, 2013 at 04:50:19PM +0200, Lennart Poettering wrote: > On Tue, 16.04.13 13:48, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > > +__systemd_properties() { > > +local mode=$1; shift 1 > > +{ __systemctl $mode show; > > You probaly want to add "-a" here, si

Re: [systemd-devel] [PATCH] bash-completion: --property support

2013-04-17 Thread Lennart Poettering
On Tue, 16.04.13 13:48, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > +__systemd_properties() { > +local mode=$1; shift 1 > +{ __systemctl $mode show; You probaly want to add "-a" here, since "systemctl show" normally suppresses 'empty' properties. Lennart -- Lennart

Re: [systemd-devel] systemd release agent

2013-04-17 Thread Lennart Poettering
On Tue, 16.04.13 20:45, Kevin Wilson (wkev...@gmail.com) wrote: > cat /sys/fs/cgroup/systemd/system/bluetooth.service/tasks > 671 > > Apr 16 20:40:05 localhost systemd[1]: bluetooth.service: main process > exited, code=killed, status=9/KILL > Apr 16 20:40:05 localhost systemd[1]: Unit bluetooth.

Re: [systemd-devel] systemd release agent

2013-04-17 Thread Michal Schmidt
On 04/16/2013 07:45 PM, Kevin Wilson wrote: No I moved /usr/lib/systemd/systemd-cgroups-agent to some backup. and made sure that: ls /usr/lib/systemd/systemd-cgroups-agent ls: cannot access /usr/lib/systemd/systemd-cgroups-agent: No such file or directory Now I tried killing two services that I

Re: [systemd-devel] [PATCH 1/2] Report about syntax error in extended format

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 06:47, Zbigniew Jędrzejewski-Szmek (zbys...@in.waw.pl) wrote: > > If we do this, I am not entirely sure about the name "issue" though. If > > we do this I'd like a good name that expresses that this requires > > resolving by the admin, and sufficiently makes clear that this is not

Re: [systemd-devel] Lid close event delivered delayed

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 06:58, Jan Engelhardt (jeng...@inai.de) wrote: > Hi, > > > something I observed with systemd-195 is that the LidClose event is > delivered when switching from X to console while the lid is closed. This > is unexpected, and what I expected is instead that nothing occurs. > Appr

Re: [systemd-devel] system shutdown: what unit is taking so long?

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 10:37, Andrey Borzenkov (arvidj...@gmail.com) wrote: > > On Wed, Apr 17, 2013 at 9:17 AM, Jan Engelhardt wrote: > > > > I think systemd should print some status message -- like "Shutdown of > > xendomains.service still running" every 5sec, maybe? -- when shutting > > down some s

Re: [systemd-devel] [PATCH] login/sd-login.c: make use of _cleanup_free_ and friends

2013-04-17 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 17, 2013 at 04:25:40PM +0200, Lennart Poettering wrote: > On Wed, 17.04.13 16:12, har...@redhat.com (har...@redhat.com) wrote: > > > -char *root, *cgroup, *p, *cc; > > +char _cleanup_free_ *root = NULL, *cgroup = NULL, *p = NULL, *cc = > > NULL; > > Hmm, can we agree

Re: [systemd-devel] typo? path-util: unify code for detecting OS trees

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 09:33, Peeters Simon (peeters.si...@gmail.com) wrote: > while reading random patches in cgit I saw > (in commit 6606089752df90f3eeb4924af109046f1c73554c) > > ... > > diff --git a/src/shared/util.h b/src/shared/util.h > > index 3aac165..cfb5493 100644 > > --- a/src/shared/util.h >

Re: [systemd-devel] Reason for su command to be ignored in target?

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 09:46, Mark Hounschell (ma...@compro.net) wrote: > I have been using systemd to boot into a very basic target. That > target basically executes a script. In that script we execute an "su > -m -c command user". The last version of systemd I have where this > worked is version 37. I

Re: [systemd-devel] [PATCH] login/sd-login.c: make use of _cleanup_free_ and friends

2013-04-17 Thread Lennart Poettering
On Wed, 17.04.13 16:12, har...@redhat.com (har...@redhat.com) wrote: > -char *root, *cgroup, *p, *cc; > +char _cleanup_free_ *root = NULL, *cgroup = NULL, *p = NULL, *cc = > NULL; Hmm, can we agree on a common syntax for this? I tend to put the "_cleanup_free_" before the type,

[systemd-devel] [PATCH] login/sd-login.c: make use of _cleanup_free_ and friends

2013-04-17 Thread harald
From: Harald Hoyer --- Due to the heavy modification, I send this to the list for review. src/login/sd-login.c | 200 --- 1 file changed, 61 insertions(+), 139 deletions(-) diff --git a/src/login/sd-login.c b/src/login/sd-login.c index c97d75c.

Re: [systemd-devel] Reason for su command to be ignored in target?

2013-04-17 Thread Andrey Borzenkov
On Wed, Apr 17, 2013 at 5:46 PM, Mark Hounschell wrote: > I have been using systemd to boot into a very basic target. That target > basically executes a script. In that script we execute an "su -m -c command > user". The last version of systemd I have where this worked is version 37. > I'm using o

[systemd-devel] Reason for su command to be ignored in target?

2013-04-17 Thread Mark Hounschell
I have been using systemd to boot into a very basic target. That target basically executes a script. In that script we execute an "su -m -c command user". The last version of systemd I have where this worked is version 37. I'm using opensuse dist and that was in version 12.2 from about a year a

Re: [systemd-devel] typo? path-util: unify code for detecting OS trees

2013-04-17 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Apr 17, 2013 at 09:33:35AM +0200, Peeters Simon wrote: > while reading random patches in cgit I saw > (in commit 6606089752df90f3eeb4924af109046f1c73554c) > > ... > > diff --git a/src/shared/util.h b/src/shared/util.h > > index 3aac165..cfb5493 100644 > > --- a/src/shared/util.h > > +++ b/

Re: [systemd-devel] [PATCH V4] core/execute.c: debug log final execve() with argv[]

2013-04-17 Thread Harald Hoyer
Am 10.04.2013 11:51, schrieb har...@redhat.com: > From: Harald Hoyer > > https://bugzilla.redhat.com/show_bug.cgi?id=772073 > --- > src/core/execute.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/src/core/execute.c b/src/core/execute.c > index 5083af9..fabd38e 100644 >

[systemd-devel] typo? path-util: unify code for detecting OS trees

2013-04-17 Thread Peeters Simon
while reading random patches in cgit I saw (in commit 6606089752df90f3eeb4924af109046f1c73554c) ... > diff --git a/src/shared/util.h b/src/shared/util.h > index 3aac165..cfb5493 100644 > --- a/src/shared/util.h > +++ b/src/shared/util.h > @@ -684,3 +684,15 @@ int unlink_noerrno(const char *path);

  1   2   >